298782 2012-04-25 06:59:38 +0000 When deleting the current item, the new current item is not underlined in the view 2012-04-25 07:22:11 +0000 1 1 2 Applications dolphin view-engine: general 16.12.2 Compiled Sources Linux RESOLVED FIXED NOR normal --- 1 frank78ac peter.penz19 http://commits.kde.org/kde-baseapps/68ce395a192362969783615e50a8004d3029eb7e 4.8.3 0 oldest_to_newest 1249402 0 frank78ac 2012-04-25 06:59:38 +0000 When the current item is deleted in the view (e.g, by pressing Delete while only this item is selected), the next item takes its position in the view and becomes the new current item, but it is not underlined. A fix is coming in a minute. Reproducible: Always 1249405 1 frank78ac 2012-04-25 07:09:33 +0000 Git commit 68ce395a192362969783615e50a8004d3029eb7e by Frank Reininghaus. Committed on 25/04/2012 at 09:01. Pushed by freininghaus into branch 'KDE/4.8'. When the current item is removed, make -1 the current index temporarily This fixes two problems: 1. KItemListKeyboardSearchManger can cancel the current search when a new folder is opened (note that this action removes the current item from the view). 2. The view can underline the new current item (which is the item that used to be below the removed item). Note that this did not work before because the view did not receive a currentChanged() signal in this case and therefore did not update the "current item" status of the new current item. Related: bug 297488 FIXED-IN: 4.8.3 REVIEW: 104709 M +2 -0 dolphin/src/kitemviews/kitemlistcontroller.cpp M +10 -0 dolphin/src/kitemviews/kitemlistkeyboardsearchmanager.cpp M +4 -0 dolphin/src/kitemviews/kitemlistkeyboardsearchmanager_p.h M +6 -3 dolphin/src/kitemviews/kitemlistselectionmanager.cpp http://commits.kde.org/kde-baseapps/68ce395a192362969783615e50a8004d3029eb7e 1249415 2 frank78ac 2012-04-25 07:22:11 +0000 Git commit 922742762f2b1655ba55756b590e327acb00ce77 by Frank Reininghaus. Committed on 25/04/2012 at 09:20. Pushed by freininghaus into branch 'master'. When the current item is removed, make -1 the current index temporarily This fixes two problems: 1. KItemListKeyboardSearchManger can cancel the current search when a new folder is opened (note that this action removes the current item from the view). 2. The view can underline the new current item (which is the item that used to be below the removed item). Note that this did not work before because the view did not receive a currentChanged() signal in this case and therefore did not update the "current item" status of the new current item. Related: bug 297488 REVIEW: 104709 (cherry picked from commit 68ce395a192362969783615e50a8004d3029eb7e) M +2 -0 dolphin/src/kitemviews/kitemlistcontroller.cpp M +6 -3 dolphin/src/kitemviews/kitemlistselectionmanager.cpp M +10 -0 dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp M +4 -0 dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h http://commits.kde.org/kde-baseapps/922742762f2b1655ba55756b590e327acb00ce77