297488 2012-04-04 18:53:29 +0000 Keyboard searches do not reset when entering directory 2012-05-05 09:38:51 +0000 1 1 2 Applications dolphin view-engine: general 2.0 unspecified Linux RESOLVED FIXED NOR normal --- 1 leszek.lesner peter.penz19 christian finex frank78ac matt.ruffalo nitro ondrej.machulda stuffcorpse http://commits.kde.org/kde-baseapps/68ce395a192362969783615e50a8004d3029eb7e 4.8.3 0 oldest_to_newest 1242923 0 leszek.lesner 2012-04-04 18:53:29 +0000 Together with the change of 4.8.2 keyboard search delay a new bug appeared. When entering a directory with the help of keyboard search i.e. I have one folder called downloads and a subfolder in downloads called work. I open dolphin type "down" (Downloads folder gets hightlighted) hit enter and then immediately start typing "wo" nothing happens. I wait for 5 seconds type in "wo" and my work directory gets highlighted. The keyboard search should be cleared when entering new directories to prevent this problem. 1243133 1 frank78ac 2012-04-05 10:25:29 +0000 Thanks for the bug report! Sorry for that stupid regression (well, technically, it's not a regression because the bug has been there before, it was just not easy to see it because the timeout was so short). I'll try to figure out a clean solution for this before KDE 4.8.3 is released. 1243142 2 finex 2012-04-05 11:37:54 +0000 @Frank: I've just experienced this bug... I want to add that there is something with the case of file names either. When you will work on this bug please try on a directory wih files with both lowercase and uppercase names like "Folder one, folder two, example, Exams..."... I didn't understand a pattern in order to reproduce this bug. 1243143 3 finex 2012-04-05 11:39:11 +0000 P.S: This bug looks not related to bug #297458 1243167 4 frank78ac 2012-04-05 12:53:33 +0000 @FiNeX: I just tried keyboard searching in a folder with uppercase and lowercase names and noticed nothing unusual. Could you be a bit more specific about what kind of strange behaviour you noticed (preferably not here because this is off-topic for this bug report)? Thanks! 1243383 5 frank78ac 2012-04-06 09:31:05 +0000 Git commit d8732a59d3b1f2d0bebf43f294df7e9f333abde4 by Frank Reininghaus. Committed on 05/04/2012 at 18:59. Pushed by freininghaus into branch 'KDE/4.8'. Reduce the timeout in KItemListKeyboardSearchManager to 1 second It turned out that the longer timeout, introduced recently in 02eab49b2de51c31fe46a0d9501327b579b3648e, not only made multi-letter keyboard searches easier, but also had some unwanted side effects. I hope that 1 second, which is between the previous value of 5 seconds and the pre-KDE 4.8.2 value of 0.4 seconds, is a compromise which will fit most users' needs. We will try to improve the situation further in future releases by providing visual feedback about the keyboard search, but such a change would not be suitable for a bug-fix release. Related: bug 297458 M +1 -1 dolphin/src/kitemviews/kitemlistkeyboardsearchmanager.cpp http://commits.kde.org/kde-baseapps/d8732a59d3b1f2d0bebf43f294df7e9f333abde4 1243445 6 christian 2012-04-06 13:45:40 +0000 Regardless of the actual timeout, IMHO the search should be cleared when: * the location changes / a new folder is opened * any action is done that's unrelated to keyboard search, e.g. mouseclicks, hotkeys etc * the window loses focus * the user starts navigating with the cursor keys * the user hits escape The last one is important when you misspell a search and wish to retry without waiting for the timeout to happen. Clearing on cursor keys, enter and esc would cover the most common cases (for me) without touching too many areas of the code. 1243690 7 70206 leszek.lesner 2012-04-07 11:03:30 +0000 Created attachment 70206 Keyboardsearch fix As we were not satisfied with setting the keyboardsearch timeout to 1 second. I decided to write another patch which is now included in Neptune. It will delete the keyboard search item whenever enter key is pressed and if you accidently typed in something wrong you can also delete the search by pressing escape. Sorry Christian but I did not see your comment before writing the patch so I only implemented the first and last point of your lrequest list. But I guess with the way its implemented now(with this patch) it should be no problem to adapt the patch to your request. 1244045 8 frank78ac 2012-04-08 18:48:15 +0000 Thanks for the patch! It's definitely a step into the right direction :-) However, as Christian wrote, one would also expect the search to be cancelled in a couple more situations. Doing that (and providing some visual feedback about the search string) would require quite a few code changes, Nevertheless, I think that it might make sense to use your patch at least in the 4.8 branch to improve the current situation, in particular because it's a very small change that looks unlikely to break anything (although I've learned now that you can never be sure about that). Let's wait for feedback from Peter about this. 1244417 9 matt.ruffalo 2012-04-09 18:19:45 +0000 Thank you very much for fixing this. I can confirm that a timeout of 1 second is *way* too high -- I know my folder structure pretty well and before 4.8.2 I could navigate to a specific directory 4 or 5 levels deep in under 3 seconds (Doc <enter> res <enter> pap <enter> map <enter> fig <enter>). I can't quite time myself since I'm using 4.8.2 everywhere though :) I'm looking forward to 4.8.3 mostly to get this patch; thanks again. 1244433 10 peter.penz19 2012-04-09 19:09:31 +0000 @Leszek: Thanks for the patch, but if Frank's patch to decrease the timeout to 1 second is still not sufficient I'd prefer going back to 0.4 seconds for 4.8.x instead of applying the patch. Although the patch resolves the problem for the keyboard navigation, I don't like the approach to hardcode this as part of the controller. I'd say the correct fix would be to reset the keyboard-timeout whenever the items of the model have been cleared and to let the keyboard-manager internally handle this situation. But this is more a 4.9 thing from my point of view. 1249407 11 frank78ac 2012-04-25 07:09:33 +0000 Git commit 68ce395a192362969783615e50a8004d3029eb7e by Frank Reininghaus. Committed on 25/04/2012 at 09:01. Pushed by freininghaus into branch 'KDE/4.8'. When the current item is removed, make -1 the current index temporarily This fixes two problems: 1. KItemListKeyboardSearchManger can cancel the current search when a new folder is opened (note that this action removes the current item from the view). 2. The view can underline the new current item (which is the item that used to be below the removed item). Note that this did not work before because the view did not receive a currentChanged() signal in this case and therefore did not update the "current item" status of the new current item. Related: bug 298782 FIXED-IN: 4.8.3 REVIEW: 104709 M +2 -0 dolphin/src/kitemviews/kitemlistcontroller.cpp M +10 -0 dolphin/src/kitemviews/kitemlistkeyboardsearchmanager.cpp M +4 -0 dolphin/src/kitemviews/kitemlistkeyboardsearchmanager_p.h M +6 -3 dolphin/src/kitemviews/kitemlistselectionmanager.cpp http://commits.kde.org/kde-baseapps/68ce395a192362969783615e50a8004d3029eb7e 1249416 12 frank78ac 2012-04-25 07:22:11 +0000 Git commit 922742762f2b1655ba55756b590e327acb00ce77 by Frank Reininghaus. Committed on 25/04/2012 at 09:20. Pushed by freininghaus into branch 'master'. When the current item is removed, make -1 the current index temporarily This fixes two problems: 1. KItemListKeyboardSearchManger can cancel the current search when a new folder is opened (note that this action removes the current item from the view). 2. The view can underline the new current item (which is the item that used to be below the removed item). Note that this did not work before because the view did not receive a currentChanged() signal in this case and therefore did not update the "current item" status of the new current item. Related: bug 298782 REVIEW: 104709 (cherry picked from commit 68ce395a192362969783615e50a8004d3029eb7e) M +2 -0 dolphin/src/kitemviews/kitemlistcontroller.cpp M +6 -3 dolphin/src/kitemviews/kitemlistselectionmanager.cpp M +10 -0 dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp M +4 -0 dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h http://commits.kde.org/kde-baseapps/922742762f2b1655ba55756b590e327acb00ce77 1252225 13 frank78ac 2012-05-05 09:38:51 +0000 *** Bug 299196 has been marked as a duplicate of this bug. *** 70206 2012-04-07 11:03:30 +0000 2012-04-07 11:03:30 +0000 Keyboardsearch fix keyboardsearch-fix.patch text/plain 2322 leszek.lesner RGVzY3JpcHRpb246IEZpeGVzIGtleWJvYXJkc2VhcmNoIHVwc3RyZWFtIGJ1ZyAjMjk3NDg4CiBE ZWxldGUga2V5Ym9hcmRzZWFyY2ggaWYgZW50ZXJpbmcgZGlyZWN0b3J5IHdpdGggdGhlIEVudGVy IGtleSBvcgogaWYgRXNjYXBlIGlzIHByZXNzZWQKIC4KIGtkZS1iYXNlYXBwcyAoNDo0LjguMi1u ZXB0dW5lMikgdW5zdGFibGU7IHVyZ2VuY3k9bG93CiAuCiAgICogRml4ZWQgZG9scGhpbnMga2l0 ZW1saXN0a2V5Ym9hcmRzZWFyY2htYW5hZ2VyIHRvIGRlbGV0ZSBzZWFyY2hlcyB3aGVuCiAgICAg ZW50ZXJpbmcgYSBuZXcgZm9sZGVyCiAgICogQWRkZWQgc3VwcG9ydCBmb3IgZGVsZXRpbmcga2V5 Ym9hcmRzZWFyY2hlcyB3aXRoIHRoZSBFc2NhcGUga2V5CkF1dGhvcjogTGVzemVrIExlc25lciA8 bGVzemVrQHpldmVub3MuY29tPgoKLS0tClRoZSBpbmZvcm1hdGlvbiBhYm92ZSBzaG91bGQgZm9s bG93IHRoZSBQYXRjaCBUYWdnaW5nIEd1aWRlbGluZXMsIHBsZWFzZQpjaGVja291dCBodHRwOi8v ZGVwLmRlYmlhbi5uZXQvZGVwcy9kZXAzLyB0byBsZWFybiBhYm91dCB0aGUgZm9ybWF0LiBIZXJl CmFyZSB0ZW1wbGF0ZXMgZm9yIHN1cHBsZW1lbnRhcnkgZmllbGRzIHRoYXQgeW91IG1pZ2h0IHdh bnQgdG8gYWRkOgoKT3JpZ2luOiBvdGhlcgpCdWc6IGh0dHBzOi8vYnVncy5rZGUub3JnL3Nob3df YnVnLmNnaT9pZD0yOTc0ODgKCi0tLSBrZGUtYmFzZWFwcHMtNC44LjIub3JpZy9kb2xwaGluL3Ny Yy9raXRlbXZpZXdzL2tpdGVtbGlzdGNvbnRyb2xsZXIuY3BwCisrKyBrZGUtYmFzZWFwcHMtNC44 LjIvZG9scGhpbi9zcmMva2l0ZW12aWV3cy9raXRlbWxpc3Rjb250cm9sbGVyLmNwcApAQCAtMzEx LDYgKzMxMSw3IEBAIGJvb2wgS0l0ZW1MaXN0Q29udHJvbGxlcjo6a2V5UHJlc3NFdmVudCgKIAog ICAgIGNhc2UgUXQ6OktleV9FbnRlcjoKICAgICBjYXNlIFF0OjpLZXlfUmV0dXJuOiB7CisgICAg ICAgIG1fa2V5Ym9hcmRNYW5hZ2VyLT5jbGVhcktleXMoKTsKICAgICAgICAgY29uc3QgUVNldDxp bnQ+IHNlbGVjdGVkSXRlbXMgPSBtX3NlbGVjdGlvbk1hbmFnZXItPnNlbGVjdGVkSXRlbXMoKTsK ICAgICAgICAgaWYgKHNlbGVjdGVkSXRlbXMuY291bnQoKSA+PSAyKSB7CiAgICAgICAgICAgICBl bWl0IGl0ZW1zQWN0aXZhdGVkKHNlbGVjdGVkSXRlbXMpOwpAQCAtMzIyLDYgKzMyMywxMCBAQCBi b29sIEtJdGVtTGlzdENvbnRyb2xsZXI6OmtleVByZXNzRXZlbnQoCiAgICAgICAgIGJyZWFrOwog ICAgIH0KIAorICAgIGNhc2UgUXQ6OktleV9Fc2NhcGU6IHsKKyAgICAgICAgbV9rZXlib2FyZE1h bmFnZXItPmNsZWFyS2V5cygpOworICAgIH0KKwogICAgIGNhc2UgUXQ6OktleV9TcGFjZToKICAg ICAgICAgaWYgKG1fc2VsZWN0aW9uQmVoYXZpb3IgPT0gTXVsdGlTZWxlY3Rpb24pIHsKICAgICAg ICAgICAgIGlmIChjb250cm9sUHJlc3NlZCkgewotLS0ga2RlLWJhc2VhcHBzLTQuOC4yLm9yaWcv ZG9scGhpbi9zcmMva2l0ZW12aWV3cy9raXRlbWxpc3RrZXlib2FyZHNlYXJjaG1hbmFnZXJfcC5o CisrKyBrZGUtYmFzZWFwcHMtNC44LjIvZG9scGhpbi9zcmMva2l0ZW12aWV3cy9raXRlbWxpc3Rr ZXlib2FyZHNlYXJjaG1hbmFnZXJfcC5oCkBAIC00OCw2ICs0OCwxMSBAQCBwdWJsaWM6CiAgICAg ICogQWRkIFxhIGtleXMgdG8gdGhlIHRleHQgYnVmZmVyIHVzZWQgZm9yIHNlYXJjaGluZy4KICAg ICAgKi8KICAgICB2b2lkIGFkZEtleXMoY29uc3QgUVN0cmluZyYga2V5cyk7CisgICAgCisgICAg LyoqCisgICAgICogQ2xlYXJzIGtleXMgZnJvbSB0aGUgdGV4dCBidWZmZXIKKyAgICAgKi8KKyAg ICB2b2lkIGNsZWFyS2V5cygpOwogCiAgICAgLyoqCiAgICAgICogU2V0cyB0aGUgZGVsYXkgYWZ0 ZXIgd2hpY2ggdGhlIHNlYXJjaCBpcyBjYW5jZWxsZWQgdG8gXGEgbWlsbGlzZWNvbmRzLgotLS0g a2RlLWJhc2VhcHBzLTQuOC4yLm9yaWcvZG9scGhpbi9zcmMva2l0ZW12aWV3cy9raXRlbWxpc3Rr ZXlib2FyZHNlYXJjaG1hbmFnZXIuY3BwCisrKyBrZGUtYmFzZWFwcHMtNC44LjIvZG9scGhpbi9z cmMva2l0ZW12aWV3cy9raXRlbWxpc3RrZXlib2FyZHNlYXJjaG1hbmFnZXIuY3BwCkBAIC03Niwz ICs3Niw5IEBAIHFpbnQ2NCBLSXRlbUxpc3RLZXlib2FyZFNlYXJjaE1hbmFnZXI6OnQKICAgICBy ZXR1cm4gbV90aW1lb3V0OwogfQogCit2b2lkIEtJdGVtTGlzdEtleWJvYXJkU2VhcmNoTWFuYWdl cjo6Y2xlYXJLZXlzKCkKK3sKKyAgaWYgKG1fc2VhcmNoZWRTdHJpbmcubGVuZ3RoKCkgPiAwKSB7 CisgICAgICBtX3NlYXJjaGVkU3RyaW5nLmNsZWFyKCk7CisgIH0KK30K