293926 2012-02-12 18:46:17 +0000 Polling of solid and mtab for dynamic collections horribly broken 2012-09-28 07:53:11 +0000 1 1 2 Applications amarok Collections/Local 2.5.0 openSUSE Linux RESOLVED FIXED NOR normal 2.6 0 stefan.bruens amarok-bugs-null bart.cerneels eljefedelito florian ian.monroe nicholas pndiku ralf-engels rudd-o http://commits.kde.org/amarok/92fe9ac171b9920ba65adf244c7dbe23d694d209 2.7 0 oldest_to_newest 1226119 0 stefan.bruens 2012-02-12 18:46:17 +0000 +++ This bug was initially created as a clone of Bug #249760 +++ Currently, amarok polls for changes every second. This polling involves: 1. Reading and parsing mtab (via KMountpoint) 2. Reading and parsing fstab (via KMountpoint) 3. Querying solid for a list of all StorageAccess devices. Especially the last point is problematic, as this involves querying UDisks, creating a huge number of DBus roundtrips. A fix for solid s mtab monitoring is in reviewboard. After this is applied, the changes in MediaCache should be reverted. 1226818 1 myriam 2012-02-14 11:34:30 +0000 Could you please provide a link to that fix in reviewboard? 1226835 2 pndiku 2012-02-14 12:04:04 +0000 I see these 3: https://git.reviewboard.kde.org/r/103956/ https://git.reviewboard.kde.org/r/103954/ https://git.reviewboard.kde.org/r/103957/ Could they be the ones? 1227069 3 stefan.bruens 2012-02-15 00:30:54 +0000 https://git.reviewboard.kde.org/r/103954/ is the relevant request 1231272 4 mbensi 2012-02-28 15:24:50 +0000 Git commit b16cfec44104ded4a8959af4e790fe2f7d6d2745 by Mario Bensi. Committed on 28/02/2012 at 16:22. Pushed by bensi into branch 'KDE/4.8'. Fix for mtab monitoring on Linux Add a QSocketNotifier pointing to the mtab fd. REVIEW: 103954 Related: bug 293914 M +15 -1 solid/solid/backends/fstab/fstabwatcher.cpp M +4 -0 solid/solid/backends/fstab/fstabwatcher.h http://commits.kde.org/kdelibs/b16cfec44104ded4a8959af4e790fe2f7d6d2745 1301017 5 stefan.bruens 2012-09-27 10:23:12 +0000 Fixed in 2.7 http://commits.kde.org/amarok/92fe9ac171b9920ba65adf244c7dbe23d694d209