<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>293265</bug_id>
          
          <creation_ts>2012-02-04 05:31:24 +0000</creation_ts>
          <short_desc>When two Konsole windows are set as fullscreen mode, one of then tends to behave as if &quot;Keep Above Others&quot; has been enabled.</short_desc>
          <delta_ts>2012-03-22 19:47:04 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>4</classification_id>
          <classification>Plasma</classification>
          <product>kwin</product>
          <component>general</component>
          <version>git master</version>
          <rep_platform>Gentoo Packages</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jekyll Wu">adaptee</reporter>
          <assigned_to name="KWin default assignee">kwin-bugs-null</assigned_to>
          
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1222772</commentid>
    <comment_count>0</comment_count>
    <who name="Jekyll Wu">adaptee</who>
    <bug_when>2012-02-04 05:31:24 +0000</bug_when>
    <thetext>Version:           git master (using Devel) 
OS:                Linux

This might be the same problem as bug 261799, but this is reproducible when using single monitor.

0. make sure all Konsole windows are closed
1. switch to an empty virtual desktop
3. launch Konsole through krunner( let&apos;s call that Konsole window as Konsole #1)
4. (optionally)change the tab title format of the only tab in Konsole #1 to &quot;#1&quot;, so that its title bar becomes &quot;#1&quot; for better recognition.
5. use &quot;File -&gt; New Window&quot; to get another Konsole window( call it Konsole #2)
6. launch dolphin
7. set Konsole #1 as fullscreen mode
8. use Alt+Tab to switch between Konsole #1, #2 and dolphin. No problem at the moment.
9. set Konsole #2 as fullscreen mode, too
10. use Alt+Tab to switch between Konsole #1, #2 and dolphin.


Reproducible: Always

Steps to Reproduce:
0. make sure all Konsole windows are closed
1. switch to an empty virtual desktop
3. launch Konsole through krunner( let&apos;s call that Konsole window as Konsole #1)
4. (optionally)change the tab title format of the only tab in Konsole #1 to &quot;#1&quot;, so that its title bar becomes #1 for better recognition.
5. use &quot;File -&gt; New Window&quot; to get another Konsole window( call it Konsole #2)
6. launch dolphin
7. set Konsole #1 as fullscreen mode
8. use Alt+Tab to switch between Konsole #1, #2 and dolphin. No problem at the moment.
9. set Konsole #2 as fullscreen mode, too
10. use Alt+Tab to switch between Konsole #1, #2 and dolphin.


Actual Results:  
In step 10, quite often, when I want to switch the current window from konsole #2(or #1) to dolphin, Konsole #2(or #1) is still shown in the front in fullscreen mode as if &quot;Keep Above Others&quot; has been enabled.


Expected Results:  
same result as in step 8


This is reproducible using a clean account, so it is not related with kwin rules

And the problem does not exist when using konsole in GNOME and XFCE

The code within Konsole directly related with fullscreen mode is only this:

void MainWindow::viewFullScreen(bool fullScreen)
{
    if (fullScreen)
        setWindowState(windowState() | Qt::WindowFullScreen);
    else
        setWindowState(windowState() &amp; ~Qt::WindowFullScreen);
}

I failed to see how that might possibly lead to the reported problem, so I report it as a kwin bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1222911</commentid>
    <comment_count>1</comment_count>
    <who name="Thomas Lübking">thomas.luebking</who>
    <bug_when>2012-02-04 15:01:46 +0000</bug_when>
    <thetext>layers.cpp:841


bool Client::isActiveFullScreen() const
{
...
-         &amp;&amp; (top == this || this-&gt;group() == top-&gt;group()));
+         &amp;&amp; (top == this ));
}

It&apos;s however not *that* easy because it should cover at least transients.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1222928</commentid>
    <comment_count>2</comment_count>
    <who name="Thomas Lübking">thomas.luebking</who>
    <bug_when>2012-02-04 15:57:16 +0000</bug_when>
    <thetext>https://git.reviewboard.kde.org/r/103866/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1223383</commentid>
    <comment_count>3</comment_count>
    <who name="Jekyll Wu">adaptee</who>
    <bug_when>2012-02-05 19:27:43 +0000</bug_when>
    <thetext>The patch in the review request seems working fine.

Er, is bug 261799 also caused by the same defect? Should it be marked as a duplicate of this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1223390</commentid>
    <comment_count>4</comment_count>
    <who name="Thomas Lübking">thomas.luebking</who>
    <bug_when>2012-02-05 19:51:30 +0000</bug_when>
    <thetext>yes, very likely. i&apos;ll test it later but should be the same (+ there&apos;s afair a similar kwin bug)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1223434</commentid>
    <comment_count>5</comment_count>
    <who name="Thomas Lübking">thomas.luebking</who>
    <bug_when>2012-02-05 21:40:35 +0000</bug_when>
    <thetext>No, it&apos;s not.

I can raise windows above the non fullscreen konsole after activating the fullscreen konsole (on the other screen) but no more after activating the non-fullscreen konsole (until i activate the fullscreen konsole again)

Gonna check why this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1224649</commentid>
    <comment_count>6</comment_count>
    <who name="Thomas Lübking">thomas.luebking</who>
    <bug_when>2012-02-08 19:52:39 +0000</bug_when>
    <thetext>Git commit 10cd4faa8a0cb0619ebcfd462ee0104b1db58171 by Thomas Lübking.
Committed on 04/02/2012 at 16:45.
Pushed by luebking into branch &apos;master&apos;.

Only keep fullscreen for transients on top - not random group members
REVIEW: 103866

M  +26   -4    kwin/layers.cpp

http://commits.kde.org/kde-workspace/10cd4faa8a0cb0619ebcfd462ee0104b1db58171</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1239073</commentid>
    <comment_count>7</comment_count>
    <who name="Thomas Lübking">thomas.luebking</who>
    <bug_when>2012-03-22 19:47:04 +0000</bug_when>
    <thetext>Git commit 8634d94682800ad0d62b2c6f0c9877b8ba745009 by Thomas Lübking.
Committed on 04/02/2012 at 16:45.
Pushed by luebking into branch &apos;KDE/4.8&apos;.

Only keep fullscreen for transients on top - not random group members
REVIEW: 103866

M  +26   -4    kwin/layers.cpp

http://commits.kde.org/kde-workspace/8634d94682800ad0d62b2c6f0c9877b8ba745009</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>