<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>291711</bug_id>
          
          <creation_ts>2012-01-16 22:24:44 +0000</creation_ts>
          <short_desc>Redesign dialog for joining group chats</short_desc>
          <delta_ts>2012-07-26 14:52:40 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>10</classification_id>
          <classification>Unmaintained</classification>
          <product>telepathy</product>
          <component>contactlist</component>
          <version>git-latest</version>
          <rep_platform>Gentoo Packages</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>wishlist</bug_severity>
          <target_milestone>Future</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Elias Probst">mail</reporter>
          <assigned_to name="Telepathy Bugs">kde-telepathy-bugs-null</assigned_to>
          <cc>d.cermak</cc>
    
    <cc>flyser42</cc>
    
    <cc>kde</cc>
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1215289</commentid>
    <comment_count>0</comment_count>
    <who name="Elias Probst">mail</who>
    <bug_when>2012-01-16 22:24:44 +0000</bug_when>
    <thetext>Version:           git-latest (using Devel) 
OS:                Linux

Currently the dialog for joining group chats lacks several features.

- The name of the group chat needs to be entered every time (no completion list based on previous entered group chat names)

- There&apos;s no listing of available group chats on the server which provides the selected account (default limit to ~25 items as some servers may have thousands of group chats. A &quot;Show more&quot; button or an input field which starts listing a filtered list after entering 3 or more characters would be helpful for advanced queries of the list)

- It is not possible to query a specific server for its groupchats (one can also join a groupchat on a remote server like having an @googlemail.com account and joining groupchats on @conference.jabber.org).

- It is not possible keeping a list of favorite group chats. It probably makes sense to keep such a list in the group chat dialog. I can&apos;t imagine how group chats would fit into the contact list itself next to regular contacts. I have never used IRC via Telepathy, but maybe there&apos;s already something similar for favorite IRC rooms.

Reproducible: Always



Expected Results:  
See initial description</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1215290</commentid>
    <comment_count>1</comment_count>
    <who name="David Edmundson">kde</who>
    <bug_when>2012-01-16 22:25:49 +0000</bug_when>
    <thetext>Worth looking at Empathy for inspiration (but not necessarily copying )</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1215492</commentid>
    <comment_count>2</comment_count>
    <who name="Elias Probst">mail</who>
    <bug_when>2012-01-17 11:40:28 +0000</bug_when>
    <thetext>Also: I&apos;d love to be able to auto-connect to selected group chats when going &quot;Online&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1218525</commentid>
    <comment_count>3</comment_count>
    <who name="Dominik Cermak">d.cermak</who>
    <bug_when>2012-01-25 21:14:02 +0000</bug_when>
    <thetext>Just a short note to avoid unnecessary work: I&apos;m working on it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1221167</commentid>
    <comment_count>4</comment_count>
    <who name="Dominik Cermak">d.cermak</who>
    <bug_when>2012-01-31 11:20:18 +0000</bug_when>
    <thetext>Git commit 149412ffb8e5aac8a4deaebce57f5b33a1eb86fa by Dominik Cermak.
Committed on 31/01/2012 at 12:15.
Pushed by cermak into branch &apos;master&apos;.

Add support for showing available rooms in join chat room dialog

This adds support for showing available rooms. You can query the default
server of the selected account or specify a server yourself.
The list shows if the room is password protected, how many persons are
there, the name and the description.
REVIEW: 103825

M  +1    -0    CMakeLists.txt
M  +145  -1    dialogs/join-chat-room-dialog.cpp
M  +16   -0    dialogs/join-chat-room-dialog.h
M  +87   -2    dialogs/join-chat-room-dialog.ui
A  +146  -0    rooms-model.cpp     [License: LGPL (v2.1+)]
A  +65   -0    rooms-model.h     [License: LGPL (v2.1+)]

http://commits.kde.org/telepathy-contact-list/149412ffb8e5aac8a4deaebce57f5b33a1eb86fa</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1221207</commentid>
    <comment_count>5</comment_count>
    <who name="Elias Probst">mail</who>
    <bug_when>2012-01-31 13:28:37 +0000</bug_when>
    <thetext>The new dialog shows for an XMPP room with currently 7 participants a member count of 0.

Server:
OpenFire

Installed Telepathy packages:
KTP latest git (contact-list 149412ff)
dev-python/telepathy-python (0.15.19@07/30/2011):
net-im/kde-telepathy-meta (9999(4)[1]@01/30/2012):
net-im/telepathy-connection-managers (1@10/07/2011):
net-im/telepathy-logger (0.2.12@01/30/2012):
net-im/telepathy-mission-control (5.10.1@12/31/2011):
net-libs/telepathy-glib (0.16.3@12/30/2011):
net-libs/telepathy-qt (0.9.0@01/25/2012):
net-voip/telepathy-butterfly (0.5.15-r1@07/25/2011):
net-voip/telepathy-gabble (0.14.1@12/30/2011):
net-voip/telepathy-haze (0.5.0@12/06/2011):
net-voip/telepathy-salut (0.6.0@12/30/2011):
net-voip/telepathy-sofiasip (0.6.8@10/18/2011):</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1222041</commentid>
    <comment_count>6</comment_count>
    <who name="Dominik Cermak">d.cermak</who>
    <bug_when>2012-02-02 09:40:08 +0000</bug_when>
    <thetext>(In reply to comment #5)
&gt; The new dialog shows for an XMPP room with currently 7 participants a member
&gt; count of 0.
&gt; 
&gt; Server:
&gt; OpenFire

As I just take the value telepathy reports I think it&apos;s either a bug in telepathy-qt/telepathy-gabble or the server doesn&apos;t report the member count (not sure if one could configure it).

Does any other client show the right value for this room?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1229782</commentid>
    <comment_count>7</comment_count>
    <who name="Martin Klapetek">mklapetek</who>
    <bug_when>2012-02-23 12:38:02 +0000</bug_when>
    <thetext>Git commit aa94b03e763a8e8aabc771bbb2bc4ea58f835f2e by Martin Klapetek, on behalf of Dominik Cermak.
Committed on 31/01/2012 at 12:15.
Pushed by mklapetek into branch &apos;kde-telepathy-0.3&apos;.

Add support for showing available rooms in join chat room dialog

This adds support for showing available rooms. You can query the default
server of the selected account or specify a server yourself.
The list shows if the room is password protected, how many persons are
there, the name and the description.
REVIEW: 103825

M  +1    -0    CMakeLists.txt
M  +145  -1    dialogs/join-chat-room-dialog.cpp
M  +16   -0    dialogs/join-chat-room-dialog.h
M  +87   -2    dialogs/join-chat-room-dialog.ui
A  +146  -0    rooms-model.cpp     [License: LGPL (v2.1+)]
A  +65   -0    rooms-model.h     [License: LGPL (v2.1+)]

http://commits.kde.org/telepathy-contact-list/aa94b03e763a8e8aabc771bbb2bc4ea58f835f2e</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1236369</commentid>
    <comment_count>8</comment_count>
    <who name="Dominik Cermak">d.cermak</who>
    <bug_when>2012-03-14 09:27:49 +0000</bug_when>
    <thetext>Git commit caa4e4e53b7074a15936f97730fc875033604f01 by Dominik Cermak.
Committed on 14/03/2012 at 10:17.
Pushed by cermak into branch &apos;master&apos;.

Handle favorites in JoinChatroomDialog

Now one can maintain a list of favorite chatrooms.
Each account has it&apos;s own favorites.
REVIEW: 104173

M  +121  -5    dialogs/join-chat-room-dialog.cpp
M  +10   -0    dialogs/join-chat-room-dialog.h
M  +149  -70   dialogs/join-chat-room-dialog.ui
M  +95   -0    rooms-model.cpp
M  +55   -0    rooms-model.h

http://commits.kde.org/telepathy-contact-list/caa4e4e53b7074a15936f97730fc875033604f01</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1238992</commentid>
    <comment_count>9</comment_count>
    <who name="Dominik Cermak">d.cermak</who>
    <bug_when>2012-03-22 13:08:55 +0000</bug_when>
    <thetext>Git commit 2984af041b56accb484dba0bc89f741473c315aa by Dominik Cermak.
Committed on 22/03/2012 at 14:04.
Pushed by cermak into branch &apos;master&apos;.

Maintain a list of recently used rooms in JoinChatroomDialog

Upon joining a room (more exact upon clicking &quot;Ok&quot;) the room is saved in
the recently used list for this account.
ATM it remembers up to 8 rooms and single rooms can be removed as well
as the whole list can be cleared.

The complete list is shown in a new tab and the rooms are used for
completion in the lineEdit.
REVIEW: 104269

M  +125  -9    dialogs/join-chat-room-dialog.cpp
M  +8    -0    dialogs/join-chat-room-dialog.h
M  +47   -0    dialogs/join-chat-room-dialog.ui

http://commits.kde.org/telepathy-contact-list/2984af041b56accb484dba0bc89f741473c315aa</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1279144</commentid>
    <comment_count>10</comment_count>
    <who name="David Edmundson">kde</who>
    <bug_when>2012-07-26 14:52:40 +0000</bug_when>
    <thetext>Closing. If anything still exists, open a new bug.

Make sure to only stick to one bug/request per report otherwise it&apos;s a nightmare to manage/close</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>