<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>290491</bug_id>
          
          <creation_ts>2012-01-03 12:45:59 +0000</creation_ts>
          <short_desc>Shortcut collisions for selection tools&apos; modes</short_desc>
          <delta_ts>2012-03-03 07:30:50 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Usability</component>
          <version>git master (please specify the git hash!)</version>
          <rep_platform>Compiled Sources</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>minor</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Hirato">billy65bob</reporter>
          <assigned_to name="Krita Bugs">krita-bugs-null</assigned_to>
          <cc>dimula73</cc>
    
    <cc>halla</cc>
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1208572</commentid>
    <comment_count>0</comment_count>
    <who name="Hirato">billy65bob</who>
    <bug_when>2012-01-03 12:45:59 +0000</bug_when>
    <thetext>Version:           svn trunk (using KDE 4.7.4) 
OS:                Linux

The selection tools define the shortcuts, R, T, A and S for changing the selection mode. Respectively they are meant to change the mode to replace, intersect, add and subtract.
It is possible that similar collisions exist for the other tools as well.

Reproducible: Always

Steps to Reproduce:
Select one of the selection tools, and press either R, T or S

Actual Results:  
R - Changes the current tool to the rectangle selection tool
T - no discernible effect
A - changes the selection mode to &quot;add&quot; 
S - summons a colour wheel (useless for this mode)

Expected Results:  
R - Changes the selection mode to &quot;replace&quot;
T - Changes the selection mode to &quot;intersect&quot;
A - Changes the selection mode to &quot;add&quot; 
S - Changes the selection mode to &quot;subtract&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1217140</commentid>
    <comment_count>1</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2012-01-21 11:00:27 +0000</bug_when>
    <thetext>Hi,

Thanks for the report. I&apos;ve upgraded the severity of the report. We really should try to fix this in time for the 2.4 release.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1217834</commentid>
    <comment_count>2</comment_count>
    <who name="Sven Langkamp">sven.langkamp</who>
    <bug_when>2012-01-23 17:03:45 +0000</bug_when>
    <thetext>Git commit 36a055f447b0d909503be091161862337ef96db8 by Sven Langkamp.
Committed on 23/01/2012 at 18:01.
Pushed by langkamp into branch &apos;master&apos;.

use different shortcut as that is already used as shortcut for subtract

M  +1    -1    krita/plugins/tools/selectiontools/kis_tool_select_rectangular.h

http://commits.kde.org/calligra/36a055f447b0d909503be091161862337ef96db8</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1218134</commentid>
    <comment_count>3</comment_count>
    <who name="Sven Langkamp">sven.langkamp</who>
    <bug_when>2012-01-24 16:29:44 +0000</bug_when>
    <thetext>Git commit f90ba002fc6ca7fc096cb802baa74d9fe6e8755b by Sven Langkamp.
Committed on 24/01/2012 at 17:26.
Pushed by langkamp into branch &apos;master&apos;.

cleanup shortcuts, avoid collision with selection tools

M  +3    -3    krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_container.cpp

http://commits.kde.org/calligra/f90ba002fc6ca7fc096cb802baa74d9fe6e8755b</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1232483</commentid>
    <comment_count>4</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2012-03-03 07:30:50 +0000</bug_when>
    <thetext>Fixed in 2.4 RC1</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>