<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>290307</bug_id>
          
          <creation_ts>2012-01-01 11:15:20 +0000</creation_ts>
          <short_desc>Dolphin fails to remove network folder through the &apos;Delete&apos; action in the context menu</short_desc>
          <delta_ts>2013-09-12 13:21:33 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>dolphin</product>
          <component>general</component>
          <version>2.0</version>
          <rep_platform>Compiled Sources</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jekyll Wu">adaptee</reporter>
          <assigned_to name="Dolphin Bug Assignee">dolphin-bugs-null</assigned_to>
          <cc>nickhobart</cc>
    
    <cc>vendion</cc>
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin>4.8.0</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1207391</commentid>
    <comment_count>0</comment_count>
    <who name="Jekyll Wu">adaptee</who>
    <bug_when>2012-01-01 11:15:20 +0000</bug_when>
    <thetext>Version:           1.99 (using Devel) 
OS:                Linux

When trying to remove network folder in this way, it complains: &quot;Access denied to trash://&lt;NETWORK-FOLDER&gt;&quot;

&apos;Del&apos; key and &apos;Shift+Del&apos; shortcut work fine. 

No problem when doing this in konqueror, so I think it is something wrong with dolphin.


Reproducible: Always

Steps to Reproduce:
1. go to &apos;Network&apos; in the Places panel
2. add a network folder
3. open the context menu on the just added network folder, choose the &apos;Delete&apos; action


Actual Results:  
dolphin complains : &quot;Access denied to trash://&lt;NETWORK-FOLDER&gt;&quot;



Expected Results:  
the network folder should be removed successfully

I&apos;m using dolphin built from the master code, so the actual version is 2.0.95</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1207762</commentid>
    <comment_count>1</comment_count>
    <who name="Jekyll Wu">adaptee</who>
    <bug_when>2012-01-02 09:20:14 +0000</bug_when>
    <thetext>Well, I just realized something quite confusing to me.  

When I found the problem and succeeded in reproducing it, the &quot;Show Delete command&quot; option was disabled in dolphin. However, the context menu of network folder contained the &apos;Delete&apos; action and that action failed. 

Now after I enable the &quot;Show Delete Command&quot; option, the context menu of network folder contains the &quot;Move to Trash&quot; action, which is disabled, in addition to the &quot;Delete&quot; action. And now the &apos;Delete&apos; action works without problem, as in konqueror.

The working case and not-working case are both reproducible.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1207812</commentid>
    <comment_count>2</comment_count>
    <who name="Jekyll Wu">adaptee</who>
    <bug_when>2012-01-02 11:16:31 +0000</bug_when>
    <thetext>Bug 282848 and bug 260906 are probably related to this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1210289</commentid>
    <comment_count>3</comment_count>
    <who name="Jekyll Wu">adaptee</who>
    <bug_when>2012-01-06 01:38:12 +0000</bug_when>
    <thetext>(In reply to comment #2)

Typo: bug 269096</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1211484</commentid>
    <comment_count>4</comment_count>
    <who name="Jekyll Wu">adaptee</who>
    <bug_when>2012-01-08 15:20:07 +0000</bug_when>
    <thetext>Well, after poking around dolphincontextmenu.cpp for a while, I guess I have found where the thing goes wrong.

When &quot;Show &apos;Delete&apos; command &quot; option is disabled, the &apos;Delete&apos; entry in the context menu is provided by m_removeAction, which triggers slotRemoveActionTriggered(). However, the code within slotRemoveActionTriggered() makes the decision of trashing or deleting only based upon whether &apos;Shift&apos; key is pressed. So it tries to trash the selected items in this case, which is unexpected and destined to fail.

When &quot;Show &apos;Delete&apos; command &quot; option is enabled, the &apos;Delete&apos; entry in the context menu is provided by the &apos;delete&apos; action. So it really deletes the selected items as expected.

I think bug 290954 and bug 264583 are also caused by this issue.

@Peter, I hope that helps.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1211489</commentid>
    <comment_count>5</comment_count>
    <who name="Peter Penz">peter.penz19</who>
    <bug_when>2012-01-08 15:25:20 +0000</bug_when>
    <thetext>@Jekyll: Thanks for the good analyses, hopefully I have the time to fix this soon...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1214488</commentid>
    <comment_count>6</comment_count>
    <who name="Peter Penz">peter.penz19</who>
    <bug_when>2012-01-14 19:05:54 +0000</bug_when>
    <thetext>Git commit db03ca88fa8634e6da1773213cac05207ac3627b by Peter Penz.
Committed on 14/01/2012 at 20:02.
Pushed by ppenz into branch &apos;KDE/4.8&apos;.

Fix issue when deleting items with the context menu

Thanks to Jekyll Wu for the analyses of the issue!
Related: bug 269096, bug 290954, bug 264583
FIXED-IN: 4.8.0

M  +10   -6    dolphin/src/dolphincontextmenu.cpp
M  +11   -3    dolphin/src/dolphincontextmenu.h

http://commits.kde.org/kde-baseapps/db03ca88fa8634e6da1773213cac05207ac3627b</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1214492</commentid>
    <comment_count>7</comment_count>
    <who name="Peter Penz">peter.penz19</who>
    <bug_when>2012-01-14 19:06:25 +0000</bug_when>
    <thetext>Git commit 41c2957f9b17bfa6d9394329800c8d4ed7e20749 by Peter Penz.
Committed on 14/01/2012 at 20:02.
Pushed by ppenz into branch &apos;master&apos;.

Fix issue when deleting items with the context menu

Thanks to Jekyll Wu for the analyses of the issue!
Related: bug 269096, bug 290954, bug 264583
FIXED-IN: 4.8.0

M  +10   -6    dolphin/src/dolphincontextmenu.cpp
M  +11   -3    dolphin/src/dolphincontextmenu.h

http://commits.kde.org/kde-baseapps/41c2957f9b17bfa6d9394329800c8d4ed7e20749</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1214597</commentid>
    <comment_count>8</comment_count>
    <who name="Jekyll Wu">adaptee</who>
    <bug_when>2012-01-15 02:56:05 +0000</bug_when>
    <thetext>*** Bug 282848 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1392688</commentid>
    <comment_count>9</comment_count>
    <who name="Nick Hobart">nickhobart</who>
    <bug_when>2013-08-26 13:59:25 +0000</bug_when>
    <thetext>Sorry to dredge up an old error but I&apos;m continuing to have a similar problem. For example when I simply right-click and choose to delete the folder I get the error:

&quot;Access denied to trash://&lt;NETWORK-FOLDER&gt;&quot;

However, holding the shift key results in the &quot;Move to trash&quot; to change to &quot;Delete&quot; and I am able to delete the network share.

KDE 4.10.5
Fedora 19
Let me know if I can be of any more help.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>