287411 2011-11-23 22:58:27 +0000 KMahjongg after shuffle no information about "no moves left" 2011-12-14 11:43:55 +0000 1 1 2 Applications kmahjongg general 0.8 Arch Linux Linux RESOLVED FIXED NOR normal --- 0 CerebrosuS piacentini CerebrosuS kde-games-bugs-null 0 oldest_to_newest 1189733 0 66005 CerebrosuS 2011-11-23 22:58:27 +0000 Created attachment 66005 Solves the bug. Version: 0.8 (using KDE 4.7.3) OS: Linux After running in a non solveable combination i get informated by KMahjongg, that no moves left. After shuffle and the game is not solveable too, i don't get any information about not solveable game. Reproducible: Always Steps to Reproduce: Uncheck creation of solveable games. Play a game until it is unsolveable and then shuffle until an unsolveable game will be created. Actual Results: I won't get any information after shuffle and not solveable, that no moves left. Expected Results: A information dialog about no moves left. I add a patch which solved this bug (i feel like this is a bug). Simple extract the moving left tests and the dialog output in a separate method. This method gets called from the shuffle and the mouseEvent methods. 1199507 1 CerebrosuS 2011-12-14 11:43:55 +0000 SVN commit 1268724 by krippendorf: BUG: 287411 FIXED-IN: KDE SC 4.8 REVIEW: 6837 After shuffle the stones because no moves left, you will now get a dialog about "No moves left" if the game isn't solvable. M +16 -2 boardwidget.cpp M +5 -0 boardwidget.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1268724 66005 2011-11-23 22:58:27 +0000 2011-11-23 22:58:27 +0000 Solves the bug. NoMovesLeftAfterShuffle.diff text/plain 1789 CerebrosuS SW5kZXg6IGttYWhqb25nZy9ib2FyZHdpZGdldC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGttYWhqb25nZy9i b2FyZHdpZGdldC5oCShSZXZpc2lvbiAxMjY1NjA0KQorKysga21haGpvbmdnL2JvYXJkd2lkZ2V0 LmgJKEFyYmVpdHNrb3BpZSkKQEAgLTI4OSw2ICsyODksMTEgQEAKICAgICAgKi8KIAlpbnQgcmVx dWlyZWRWZXJ0aWNhbENlbGxzKCk7CiAKKyAgICAvKioKKyAgICAgKiBUaGlzIG1ldGhvZCB0ZXN0 IGlmIGFueSB2YWxpZCBtb3ZlcyBhcmUgYXZhaWxhYmxlLgorICAgICAqIAorICAgICAqIEByZXR1 cm4gRmFsc2UgaWYgbm8gdmFsaWQgbW92ZSBhdmFpbGFibGUsIGVsc2UgdHJ1ZS4gKi8KKyAgICBi b29sIHZhbGlkTW92ZXNBdmFpbGFibGUoKTsKIAogICAgIFBPU0lUSU9OIE1vdXNlQ2xpY2tQb3Mx OyAvKio8IE1lbWJlciBEZXNjcmlwdGlvbiBAcmVmIHBvcyAqLwogICAgIFBPU0lUSU9OIE1vdXNl Q2xpY2tQb3MyOyAvKio8IE1lbWJlciBEZXNjcmlwdGlvbiBAcmVmIHBvcyAqLwpJbmRleDoga21h aGpvbmdnL2JvYXJkd2lkZ2V0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBrbWFoam9uZ2cvYm9hcmR3aWRn ZXQuY3BwCShSZXZpc2lvbiAxMjY1NjA0KQorKysga21haGpvbmdnL2JvYXJkd2lkZ2V0LmNwcAko QXJiZWl0c2tvcGllKQpAQCAtODQ4LDkgKzg0OCw5IEBACiAgICAgICAgICAgICAgICAgICAgICAg ICBnYW1lT3ZlcihHYW1lLT5NYXhUaWxlTnVtLGNoZWF0c1VzZWQpOwogICAgICAgICAgICAgICAg ICAgICB9CiAgICAgICAgICAgICAgICAgICAgIC8vIGVsc2UgaWYgbm8gbW9yZSBtb3ZlcyBhcmUg cG9zc2libGUsIGRpc3BsYXkgdGhlIHNvdXIgZ3JhcGVzIGRpYWxvZwotICAgICAgICAgICAgICAg ICAgICBlbHNlIGlmKCAhIEdhbWUtPmZpbmRNb3ZlKCBUaW1lclBvczEsIFRpbWVyUG9zMiApICkK KyAgICAgICAgICAgICAgICAgICAgZWxzZSAKICAgICAgICAgICAgICAgICAgICAgewotICAgICAg ICAgICAgICAgICAgICAgICAgS01lc3NhZ2VCb3g6OmluZm9ybWF0aW9uKHRoaXMsIGkxOG4oIkdh bWUgb3ZlcjogWW91IGhhdmUgbm8gbW92ZXMgbGVmdC4iKSk7CisgICAgICAgICAgICAgICAgICAg ICAgdmFsaWRNb3Zlc0F2YWlsYWJsZSgpOwogICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAg ICAgICAgICAgfQogICAgICAgICAgICAgICAgIGVsc2UKQEAgLTExMDgsOCArMTEwOCwyMiBAQAog ICAvLyAzMDAgcG9pbnRzIHBlciB1c2UKICAgY2hlYXRzVXNlZCArPSAxNTsKICAgZHJhd1RpbGVO dW1iZXIoKTsKKyAgCisgIC8vIFRlc3QgaWYgYW55IG1vdmVzIGFyZSBhdmFpbGFibGUKKyAgdmFs aWRNb3Zlc0F2YWlsYWJsZSgpOwogfQogCitib29sIEJvYXJkV2lkZ2V0Ojp2YWxpZE1vdmVzQXZh aWxhYmxlKCkKK3sKKyAgaWYoIUdhbWUtPmZpbmRNb3ZlKFRpbWVyUG9zMSwgVGltZXJQb3MyKSkK KyAgeworICAgIEtNZXNzYWdlQm94OjppbmZvcm1hdGlvbih0aGlzLCBpMThuKCJHYW1lIG92ZXI6 IFlvdSBoYXZlIG5vIG1vdmVzIGxlZnQuIikpOworICAgIHJldHVybiBmYWxzZTsKKyAgfQorICAK KyAgcmV0dXJuIHRydWU7Cit9CisKIFFTdHJpbmcgIEJvYXJkV2lkZ2V0OjpnZXRMYXlvdXROYW1l KCkgewogICAgIFFTdHJpbmcga2V5KCJOYW1lIik7CiAgICAgcmV0dXJuIHRoZUJvYXJkTGF5b3V0 LmF1dGhvclByb3BlcnR5KGtleSk7Cg==