286683 2011-11-15 12:42:41 +0000 Make common-internals look like library code 2012-07-06 12:47:18 +0000 1 1 10 Unmaintained telepathy common-internals unspecified Unlisted Binaries Linux RESOLVED FIXED NOR normal 0.4.0 285413 1 kde drf drf 0 oldest_to_newest 1185634 0 kde 2011-11-15 12:42:41 +0000 This means every header file needs reviewing for: - sane, simple API - documentation - use of Q_SLOTS vs slots (etc.) - check for d pointers + other library like stuff - Put everything in KTelepathy namespace(?) circular-countdown.h error-dictionary.h global-presence.h kpresence.h service-availability-checker.h telepathy-handler-application.h text-parser.h wallet-interface.h models/ accounts-filter-model.cpp accounts-filter-model.h accounts-model.cpp accounts-model.h accounts-model-item.cpp accounts-model-item.h contact-model-item.cpp contact-model-item.h groups-model.cpp groups-model.h groups-model-item.cpp groups-model-item.h proxy-tree-node.cpp proxy-tree-node.h tree-node.cpp tree-node.h Please comment if you've edited a file that you're happy for it to be reviewed - or that you think a file is ok. 1186938 1 drf 2011-11-18 22:01:43 +0000 I'm taking care of this 1189694 2 drf 2011-11-23 21:27:14 +0000 Oh, damn you bugzilla for not recognizing my "other" address. Whatevz, committed. Further reference here if needed: https://git.reviewboard.kde.org/r/103183/