280445 2011-08-19 21:09:03 +0000 left/right padding not applied to input text 2012-05-09 10:25:32 +0000 1 1 2 Applications konqueror khtml forms 4.7.3 Unlisted Binaries Linux RESOLVED FIXED NOR normal --- 1 aiacovitti konqueror-bugs-null http://commits.kde.org/kdelibs/658759cb7c436af133b770bc50c99219dff10814 4.8.3 0 oldest_to_newest 1155393 0 62987 aiacovitti 2011-08-19 21:09:03 +0000 Created attachment 62987 testcase Version: 4.7.0 OS: Linux khtml doesn't render input text with specified left/right padding Reproducible: Always Steps to Reproduce: Load the testcase Expected Results: :) It seems KHTMLProxyStyle is broken here (patch): +++ render_form.cpp @@ -101,7 +101,7 @@ SubElement element, const QStyleOption *option, const QWidget *widget ) const { - QRect r = proxy()->subElementRect(element, option, widget); + QRect r = style()->subElementRect(element, option, widget); switch (element) { case QStyle::SE_PushButtonContents: case QStyle::SE_LineEditContents: 1247775 1 aiacovitti 2012-04-20 06:20:36 +0000 Git commit dee2801c0a86fec1c642da9710b17b0a7bec3ecd by Andrea Iacovitti. Committed on 20/04/2012 at 08:18. Pushed by aiacovitti into branch 'KDE/4.8'. Fix rendering of text input elements having padding by removing the use of cached parent's proxy style, that end up to return a wrong content rect size, and using ad-hoc style() function instead. Actually only KLineEdit inherits KdeUiProxyStyle (since kde 4.5) so the behavior of our internal proxy is unchanged for the other form elements (i.e m_proxy was always 0 for them). Also the crash reported in #197270 is no longer reproducible after this change, likely it has been fixed elsewhere... Related: bug 280226 FIXED-IN: 4.8.3 M +7 -11 khtml/rendering/render_form.cpp http://commits.kde.org/kdelibs/dee2801c0a86fec1c642da9710b17b0a7bec3ecd 1253427 2 ivan.cukic 2012-05-09 10:25:32 +0000 Git commit 658759cb7c436af133b770bc50c99219dff10814 by Ivan Čukić, on behalf of Andrea Iacovitti. Committed on 20/04/2012 at 08:18. Pushed by ivan into branch 'ivan/plasma-active-patches'. Fix rendering of text input elements having padding by removing the use of cached parent's proxy style, that end up to return a wrong content rect size, and using ad-hoc style() function instead. Actually only KLineEdit inherits KdeUiProxyStyle (since kde 4.5) so the behavior of our internal proxy is unchanged for the other form elements (i.e m_proxy was always 0 for them). Also the crash reported in #197270 is no longer reproducible after this change, likely it has been fixed elsewhere... Related: bug 280226 FIXED-IN: 4.8.3 M +7 -11 khtml/rendering/render_form.cpp http://commits.kde.org/kdelibs/658759cb7c436af133b770bc50c99219dff10814 62987 2011-08-19 21:09:03 +0000 2011-08-19 21:09:03 +0000 testcase inppad_tc.html text/html 162 aiacovitti PGh0bWw+CiAgPGJvZHk+CiAgKGxlZnQvcmlnaHQgcGFkZGluZyBub3QgYXBwbGllZCk8YnIgLz4K ICBpbnB1dCB0ZXh0IHdpdGggPGk+cGFkZGluZzoyMHB4PC9pPgogIDxwPgogIDxpbnB1dCB0eXBl PSJ0ZXh0IiBzdHlsZT0icGFkZGluZzoyMHB4Ii8+CiAgPC9ib2R5Pgo8L2h0bWw+