278790 2011-07-29 15:03:12 +0000 Telepathy chat handler places emoticons in URLs 2012-07-06 12:47:21 +0000 1 1 10 Unmaintained telepathy text-ui git-latest Gentoo Packages Linux RESOLVED FIXED NOR minor 0.4.0 1 bugs.kde kde-telepathy-bugs-null kde 0 oldest_to_newest 1146929 0 62306 bugs.kde 2011-07-29 15:03:12 +0000 Created attachment 62306 Patch to fix wrongly parsed urls containing emoticons. Version: git-latest (using KDE 4.7.0) OS: Linux When a chat partner sends a URL, the chat handler replaces emoticons before the message is parsed for links. Any URL containing an emoticon is then no longer recognised as URL and thus not converted to link. In my case, the ':/' part of the protocol is replaced, rendering 90% of all links received unclickable. Reproducible: Always Steps to Reproduce: Send (or receive) a URL containing a character sequence that is supposed to be replaced by an emoticon (for example, a URL prefixed with the protocol, where ':/' may be replaced by an emoticon (depends on emoticon theme)). Actual Results: A funny face appears in the middle of the URL, link cannot be clicked. Expected Results: No funny face, clickable link. I've added a patch that reverses the order (parse for links first, then for emoticons) that seems to fix it. 1148225 1 kde 2011-08-01 11:53:00 +0000 Patch looks good. Do you have a KDE git account? If so, please merge it! Otherwise write back, and one of us will merge for you. (sorry for the late reply) Thanks a lot. 1148229 2 bugs.kde 2011-08-01 12:06:10 +0000 I don't have a git account, go ahead and merge it. Glad to help :) 1148577 3 kde 2011-08-01 23:45:16 +0000 Git commit d59d56ab545192fef0c0961fdc8d0760f86b99a0 by David Edmundson, on behalf of Geert Lamers. Committed on 02/08/2011 at 01:44. Pushed by davidedmundson into branch 'master'. Fix a bug in which emoticons can appear in URLs in messages, by swapping the order of processing BUG: 278790 Reviewed by: David Edmundson M +6 -3 lib/adium-theme-view.cpp http://commits.kde.org/telepathy-chat-handler/d59d56ab545192fef0c0961fdc8d0760f86b99a0 1224167 4 bugs.kde 2012-02-07 18:15:41 +0000 It seems this issue has reappeared. 1224182 5 kde 2012-02-07 18:56:26 +0000 Git commit ff89d55f6df486ad8ccf6c7a85e43dd2584b733c by David Edmundson. Committed on 07/02/2012 at 19:54. Pushed by davidedmundson into branch 'master'. Fix emoticons appearing in URLs (and breaking everything) M +1 -1 lib/message-processor.cpp http://commits.kde.org/telepathy-text-ui/ff89d55f6df486ad8ccf6c7a85e43dd2584b733c 1224184 6 kde 2012-02-07 18:57:37 +0000 We recently redid all the message processing, and in the process reversed some ordering. That was really quickly spotted, thanks again! 62306 2011-07-29 15:03:12 +0000 2011-07-29 15:03:12 +0000 Patch to fix wrongly parsed urls containing emoticons. emoticons-in-url-fix.diff text/plain 1711 bugs.kde ZGlmZiAtLWdpdCBhL2xpYi9hZGl1bS10aGVtZS12aWV3LmNwcCBiL2xpYi9hZGl1bS10aGVtZS12 aWV3LmNwcAppbmRleCAwZWIxMDkwLi42ZDMwZDI3IDEwMDY0NAotLS0gYS9saWIvYWRpdW0tdGhl bWUtdmlldy5jcHAKKysrIGIvbGliL2FkaXVtLXRoZW1lLXZpZXcuY3BwCkBAIC0zOTAsMTMgKzM5 MCwxMyBAQCBRU3RyaW5nIEFkaXVtVGhlbWVWaWV3OjpyZXBsYWNlU3RhdHVzS2V5d29yZHMoUVN0 cmluZyAmaHRtbFRlbXBsYXRlLCBjb25zdCBBZGl1bQogUVN0cmluZyBBZGl1bVRoZW1lVmlldzo6 cmVwbGFjZU1lc3NhZ2VLZXl3b3JkcyhRU3RyaW5nICZodG1sVGVtcGxhdGUsIGNvbnN0IEFkaXVt VGhlbWVNZXNzYWdlSW5mbyYgaW5mbykKIHsKICAgICAvL21lc3NhZ2UKLSAgICBodG1sVGVtcGxh dGUucmVwbGFjZSgiJW1lc3NhZ2UlIiwgbV9lbW90aWNvbnMudGhlbWUoKS5wYXJzZUVtb3RpY29u cyhpbmZvLm1lc3NhZ2UoKSkpOworICAgIFFTdHJpbmcgbWVzc2FnZSA9IGluZm8ubWVzc2FnZSgp OwogCiAgICAgLy8gbGluayBkZXRlY3Rpb24KICAgICBRUmVnRXhwIGxpbmtSZWdFeHAoIlxcYig/ OihcXHcrKTovL3wod3d3XFwuKSkoW15cXHNdKykiKTsKICAgICBpbnQgaW5kZXggPSAwOwogCi0g ICAgd2hpbGUgKChpbmRleCA9IGxpbmtSZWdFeHAuaW5kZXhJbihodG1sVGVtcGxhdGUsIGluZGV4 KSkgIT0gLTEpIHsKKyAgICB3aGlsZSAoKGluZGV4ID0gbGlua1JlZ0V4cC5pbmRleEluKG1lc3Nh Z2UsIGluZGV4KSkgIT0gLTEpIHsKICAgICAgICAgUVN0cmluZyByZWFsVXJsID0gbGlua1JlZ0V4 cC5jYXAoMCk7CiAgICAgICAgIFFTdHJpbmcgcHJvdG9jb2wgPSBsaW5rUmVnRXhwLmNhcCgxKTsK IApAQCAtNDMwLDcgKzQzMCw3IEBAIFFTdHJpbmcgQWRpdW1UaGVtZVZpZXc6OnJlcGxhY2VNZXNz YWdlS2V5d29yZHMoUVN0cmluZyAmaHRtbFRlbXBsYXRlLCBjb25zdCBBZGl1CiAKICAgICAgICAg ICAgICAgICAvLyBpZiB0aGUgdXJsIGlzIGNoYW5nZWQsIHNob3cgaW4gY2hhdCB3aGF0IHRoZSB1 c2VyIHR5cGVkIGluCiAgICAgICAgICAgICAgICAgUVN0cmluZyBsaW5rID0gIjxhIGhyZWY9JyIg KyByZWFsVXJsICsgIic+IiArIHNob3duVXJsICsgIjwvYT4iOwotICAgICAgICAgICAgICAgIGh0 bWxUZW1wbGF0ZS5yZXBsYWNlKGluZGV4LCBzaG93blVybC5sZW5ndGgoKSwgbGluayk7CisgICAg ICAgICAgICAgICAgbWVzc2FnZS5yZXBsYWNlKGluZGV4LCBzaG93blVybC5sZW5ndGgoKSwgbGlu ayk7CiAgICAgICAgICAgICAgICAgLy8gYWR2YW5jZSBwb3NpdGlvbiBvdGhlcndpc2UgSSBlbmQg dXAgcGFyc2luZyB0aGUgc2FtZSBsaW5rCiAgICAgICAgICAgICAgICAgaW5kZXggKz0gbGluay5s ZW5ndGgoKTsKICAgICAgICAgICAgIH0gZWxzZSB7CkBAIC00NDEsNiArNDQxLDkgQEAgUVN0cmlu ZyBBZGl1bVRoZW1lVmlldzo6cmVwbGFjZU1lc3NhZ2VLZXl3b3JkcyhRU3RyaW5nICZodG1sVGVt cGxhdGUsIGNvbnN0IEFkaXUKICAgICAgICAgfQogICAgIH0KIAorICAgIG1lc3NhZ2UgPSBtX2Vt b3RpY29ucy50aGVtZSgpLnBhcnNlRW1vdGljb25zKG1lc3NhZ2UpOworCWh0bWxUZW1wbGF0ZS5y ZXBsYWNlKCIlbWVzc2FnZSUiLCBtZXNzYWdlKTsKKwogICAgIC8vc2VydmljZQogICAgIGh0bWxU ZW1wbGF0ZS5yZXBsYWNlKCIlc2VydmljZSUiLCBpbmZvLnNlcnZpY2UoKSk7CiAgICAgLy90aW1l Cg==