276872 2011-07-01 07:51:45 +0000 New tab should be placed right after current tab, not at the end. 2011-09-27 21:15:13 +0000 1 1 2 Applications konsole general 2.7.999 Arch Linux Linux RESOLVED FIXED NOR wishlist --- 0 adaptee konsole-bugs-null ivo 4.8 0 oldest_to_newest 1137301 0 61521 adaptee 2011-07-01 07:51:45 +0000 Created attachment 61521 put the new tab right after current tab Version: 2.7.999 (using KDE 4.6.4) OS: Linux Konsole provides the option of 'start in same directory as current tab'. This is nice, but konsole always put new tab at the end of tab list, which make this nice option not as useful as it appears. For example, I have 5 tabs open. In tab #2 I am compiling some code and I suddenly have a nice idea and want to grep something, So I open a new tab. The 'grep' tab start at the same directory as the 'compilation' tab , but is placed at the end(#6). After I finish greping and want to switch back to the 'compilation' tab(#2), I have 3 choices: a). Use mouse to click tab #2, which is slow compared with keyboard. b). Press 'Shift+Left' 4 times c). Press 'Ctr+Shift+Alt' 3 times to move the 'grep' tab to place #3, then press 'Shift+left' Has the 'grep' tab been placed right after the 'compilation' tab, at #3, I would only need to press 'Shift+left' one time to switch the focus . So this example shows that placing new tab right after current tab can make (some) users' life much easier. And I think that's the natural result following the 'start in same directory' option: users expect tabs doing related work to be placed near each other. The attached patch is a quick hack. It always puts new tab right after current tab, regardless of whether 'start in same directory' is enabled or not. Reproducible: Always Steps to Reproduce: 1. open 5 tabs in konsole 2. change their title to #1,#2,#3,#4,#5 3. switch focus to #2 4. open a new tab Actual Results: the new tab is placed after #5 Expected Results: the new tab is placed after #2 1147530 1 khindenburg 2011-07-31 02:38:47 +0000 Git commit 676df0c26e5c01652da64690756b74fbe180a080 by Kurt Hindenburg. Committed on 31/07/2011 at 04:17. Pushed by hindenburg into branch 'master'. New tabs will be placed to the right of the current tab. Currently new tabs are placed at the end which is not very convenient. Patch by Jekyll Wu <adaptee@gmail.com> FEATURE: 276872 FIXED-IN: 4.8 M +11 -1 src/ViewManager.cpp http://commits.kde.org/konsole/676df0c26e5c01652da64690756b74fbe180a080 1153532 2 ivo 2011-08-13 15:06:20 +0000 Can this at least be configurable? All KDE applications I've tried do not do this (dolphin, konqueror, kate, k3b, ktorrent), nor does gnome-terminal. Firefox does it, but offers an option to disable (which I use). Please consider that this is quite a big change, and lots of users (like me) have used the old behavior for years. Thanks. 1153853 3 adaptee 2011-08-15 04:05:27 +0000 (In reply to comment #2) > Can this at least be configurable?  I will try to make it configurable before it is shipped in 4.8. 1167363 4 adaptee 2011-09-26 22:46:57 +0000 Git commit acd37f7a739ffac0863b2580c775b0956c45baa8 by Jekyll Wu. Committed on 27/09/2011 at 00:43. Pushed by jekyllwu into branch 'master'. Allow users to control where the newly created tab should be placed. CCBUG:276872 REVIEW:102685 M +13 -1 src/EditProfileDialog.cpp M +1 -0 src/EditProfileDialog.h M +21 -1 src/EditProfileDialog.ui M +2 -0 src/Profile.cpp M +13 -0 src/Profile.h M +15 -6 src/ViewManager.cpp http://commits.kde.org/konsole/acd37f7a739ffac0863b2580c775b0956c45baa8 1167702 5 ivo 2011-09-27 21:15:13 +0000 Thanks a lot for looking into this! Cheers :) 61521 2011-07-01 07:51:45 +0000 2011-07-01 07:51:45 +0000 put the new tab right after current tab 0001-put-new-tab-after-current-tab.patch text/plain 983 adaptee RnJvbSBhMjJkM2UyZmM2NGY2ZDU5MzllY2M2YjAyOGIwZTk3YzM1NDY3MTliIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWt5bGwgV3UgPGFkYXB0ZWVAZ21haWwuY29tPgpEYXRlOiBG cmksIDEgSnVsIDIwMTEgMTU6Mzk6MDcgKzA4MDAKU3ViamVjdDogW1BBVENIXSBwdXQgbmV3IHRh YiBhZnRlciBjdXJyZW50IHRhYgoKLS0tCiBzcmMvVmlld01hbmFnZXIuY3BwIHwgICAxMyArKysr KysrKysrKystCiAxIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvc3JjL1ZpZXdNYW5hZ2VyLmNwcCBiL3NyYy9WaWV3TWFuYWdlci5j cHAKaW5kZXggMGFhMjRkNS4uNzVhNWY2NyAxMDA2NDQKLS0tIGEvc3JjL1ZpZXdNYW5hZ2VyLmNw cAorKysgYi9zcmMvVmlld01hbmFnZXIuY3BwCkBAIC02MTAsNyArNjEwLDE4IEBAIHZvaWQgVmll d01hbmFnZXI6OmNyZWF0ZVZpZXcoU2Vzc2lvbiogc2Vzc2lvbikKICAgICB3aGlsZSAoIGNvbnRh aW5lckl0ZXIuaGFzTmV4dCgpICkKICAgICB7CiAgICAgICAgIFZpZXdDb250YWluZXIqIGNvbnRh aW5lciA9IGNvbnRhaW5lckl0ZXIubmV4dCgpOwotICAgICAgICBjcmVhdGVWaWV3KHNlc3Npb24s Y29udGFpbmVyLC0xKTsKKworICAgICAgICBpbnQgaW5kZXggICAgID0gLTE7CisgICAgICAgIFFX aWRnZXQqIHZpZXcgPSBhY3RpdmVWaWV3KCk7CisKKyAgICAgICAgaWYgKHZpZXcpCisgICAgICAg IHsKKyAgICAgICAgICAgIFFMaXN0PFFXaWRnZXQqPiB2aWV3cyA9IGNvbnRhaW5lci0+dmlld3Mo KSA7CisgICAgICAgICAgICBjb25zdCBpbnQgY3VycmVudEluZGV4ID0gdmlld3MuaW5kZXhPZih2 aWV3KSA7CisgICAgICAgICAgICBpbmRleCA9IGN1cnJlbnRJbmRleCArMSA7CisgICAgICAgIH0K KworICAgICAgICBjcmVhdGVWaWV3KHNlc3Npb24sY29udGFpbmVyLGluZGV4KTsKICAgICB9CiAK IH0KLS0gCjEuNy42Cgo=