274972 2011-06-05 12:03:15 +0000 Clean up Equalizer API 2013-01-22 19:04:14 +0000 1 1 2 Applications amarok Playback 2.6.0 unspecified Linux RESOLVED FIXED NOR minor 2.7 1 kfunk amarok-bugs-null kamikazow matej http://commits.kde.org/amarok/97c5144faf608b8fca0522cff4f9590fe09896bf 2.8 0 oldest_to_newest 1127666 0 kfunk 2011-06-05 12:03:15 +0000 Version: 2.4-GIT (using KDE 4.6.0) OS: Linux The Equalizer API in Amarok needs polishing. It is not modular at all and clutters EngineController API. Also the EqualizerDialog frontend is not properly coded. We need a cleanup for this. Report back if you need guidance with this. Reproducible: Didn't try 1128001 1 kfunk 2011-06-06 00:18:01 +0000 Not a wish. 1307885 2 myriam 2012-10-21 12:08:18 +0000 Bump version. Added to Extra Mile. 1322044 3 kamikazow 2012-12-08 02:30:27 +0000 Why is an API-related request an Extramile bug? IIRC Extramile is for user-visible bugs. 1322160 4 myriam 2012-12-08 14:26:21 +0000 (In reply to comment #3) > Why is an API-related request an Extramile bug? IIRC Extramile is for > user-visible bugs. You are right, removed. 1330896 5 matej 2013-01-11 01:09:28 +0000 API designing isn't a junior job, don't scare newcomers. ;) 1334401 6 ralf-engels 2013-01-22 19:04:14 +0000 Git commit 97c5144faf608b8fca0522cff4f9590fe09896bf by Ralf Engels. Committed on 22/01/2013 at 14:40. Pushed by rengels into branch 'master'. Refactoring for Equalizer dialog Add comments Improve saving of pre-defined presets Fix Can't edit & save an existing equalizer preset Cleanup of the Equalizer stuff a bit, expecially the Equalizer Dialog Related: bug 241874 FIXED-IN: 2.8 M +0 -1 src/App.cpp M +168 -181 src/dialogs/EqualizerDialog.cpp M +38 -19 src/dialogs/EqualizerDialog.h M +17 -47 src/dialogs/EqualizerDialog.ui M +32 -27 src/equalizer/EqualizerPresets.cpp M +29 -12 src/equalizer/EqualizerPresets.h http://commits.kde.org/amarok/97c5144faf608b8fca0522cff4f9590fe09896bf