271251 2011-04-18 23:27:16 +0000 XOR function has been implemented wrongly 2011-06-03 16:50:23 +0000 1 1 2 Applications calligrasheets general 2.2 openSUSE Linux RESOLVED FIXED NOR major --- 0 freekdekruijf calligra-sheets-bugs-null inge 0 oldest_to_newest 1109303 0 freekdekruijf 2011-04-18 23:27:16 +0000 Version: 2.2 (using KDE 4.5.5) OS: Linux The description of the XOR function in messages/calligra/tables.pot is: The XOR() function returns False if the number of True values is even. Otherwise it returns True. It returns an error if any argument is an error. A better description would be: The XOR() function executes per two Boolean parameters, starting at the left, an XOR, reducing these two parameters to one and repeats that until there is only one result. The function XOR(True;True) = XOR (False;False) = False; XOR(True;False) = XOR(False;True) = True. It returns an error if any argument is an error. The implementation is wrong. Entering =XOR(False;True;True;True) in a cell should return True, however it returns False. According to the above description the result should be True if the number of True parameters is uneven. This number is 3, so it should be True. Also the suggested description has True as the outcome of the function. Reproducible: Always Steps to Reproduce: See above. Actual Results: False Expected Results: True The suggested description is more close to a mathematical oriented user. 1110706 1 59250 cfeck 2011-04-23 19:15:52 +0000 Created attachment 59250 XOR fix This should fix it (but untested). 1110753 2 freekdekruijf 2011-04-23 21:40:52 +0000 Are you serious to produce and release code that you did not test on proper functioning? 1111039 3 cfeck 2011-04-24 18:54:58 +0000 The change is a no-brainer, why don't you verify the fix? You reported the bug, so you should know how to trigger it. I have never used calligra-tables, so I don't even know how I can test the XOR function. 1111527 4 freekdekruijf 2011-04-26 09:24:38 +0000 I don't know when the new version with the patch arrives in an update to my distribution, openSUSE. It is only at that moment that I can test the change. Tables is just the new name for KSpread, and it works as a spreadsheet application. To test you only need to enter "=XOR(False;True;True;True)" without the quotes in a cell and observe the outcome; should be True. Add another True as argument and the result should be False, etc. 1126723 5 inge 2011-06-03 16:48:12 +0000 Git commit e6c0736543820b1fe4a73c89eb1f85284103f8ef by Inge Wallin. Committed on 03/06/2011 at 16:44. Pushed by ingwa into branch 'master'. Fix bug 271251: XOR function has been implemented wrongly BUG:271251 The analysis By Christoph Feck in commnet #1 is spot on, and so was the attached patch. I just changed it a tiny amount. Thank you very much. It's a bit embarrassing that we let this fundamental bug through. M +2 -2 tables/functions/logic.cpp http://commits.kde.org/calligra/e6c0736543820b1fe4a73c89eb1f85284103f8ef 1126724 6 inge 2011-06-03 16:50:23 +0000 I forgot to write: This fix will be in 2.4 snapshot 2, which is released on June 14th according to http://community.kde.org/Calligra/Schedules/2.4/Release_Plan . 59250 2011-04-23 19:15:52 +0000 2011-04-23 19:15:52 +0000 XOR fix tables.diff text/plain 812 cfeck ZGlmZiAtLWdpdCBhL3RhYmxlcy9mdW5jdGlvbnMvbG9naWMuY3BwIGIvdGFibGVzL2Z1bmN0aW9u cy9sb2dpYy5jcHAKaW5kZXggY2U0N2E4NC4uY2EyZDBhZiAxMDA2NDQKLS0tIGEvdGFibGVzL2Z1 bmN0aW9ucy9sb2dpYy5jcHAKKysrIGIvdGFibGVzL2Z1bmN0aW9ucy9sb2dpYy5jcHAKQEAgLTI2 MCw3ICsyNjAsNyBAQCBWYWx1ZSBmdW5jX3RydWUodmFsVmVjdG9yLCBWYWx1ZUNhbGMgKiwgRnVu Y0V4dHJhICopCiAvLwogVmFsdWUgZnVuY194b3IodmFsVmVjdG9yIGFyZ3MsIFZhbHVlQ2FsYyAq Y2FsYywgRnVuY0V4dHJhICopCiB7Ci0gICAgLy8gZXhjbHVzaXZlIE9SIC0gZXhhY3RseSBvbmUg dmFsdWUgbXVzdCBiZSB0cnVlCisgICAgLy8gZXhjbHVzaXZlIE9SIC0gb2RkIG51bWJlciBvZiB2 YWx1ZXMgbXVzdCBiZSB0cnVlCiAgICAgaW50IGNudCA9IGFyZ3MuY291bnQoKTsKICAgICBWYWx1 ZSBjb3VudCgwKTsKICAgICBmb3IgKGludCBpID0gMDsgaSA8IGNudDsgKytpKSB7CkBAIC0yNjks NyArMjY5LDcgQEAgVmFsdWUgZnVuY194b3IodmFsVmVjdG9yIGFyZ3MsIFZhbHVlQ2FsYyAqY2Fs YywgRnVuY0V4dHJhICopCiAgICAgfQogICAgIGZvciAoaW50IGkgPSAwOyBpIDwgY250OyArK2kp CiAgICAgICAgIGNhbGMtPmFycmF5V2FsayhhcmdzW2ldLCBjb3VudCwgYXdYb3IsIFZhbHVlKDAp KTsKLSAgICByZXR1cm4gVmFsdWUoY291bnQuYXNJbnRlZ2VyKCkgPT0gMSk7CisgICAgcmV0dXJu IFZhbHVlKChjb3VudC5hc0ludGVnZXIoKSAmIDEpICE9IDApOwogfQogCiAjaW5jbHVkZSAiTG9n aWNNb2R1bGUubW9jIgo=