265654 2011-02-06 23:43:34 +0000 Score decreases incorrectly for songs when "Stop playing after this track" is on 2011-02-10 12:48:00 +0000 1 1 2 Applications amarok Playlist 2.4-GIT Compiled Sources Linux RESOLVED FIXED HI normal 2.4.1 1 mail amarok-bugs-null 123kash nhn teo 2.4.1 0 oldest_to_newest 1084773 0 mail 2011-02-06 23:43:34 +0000 Version: 2.4-GIT (using KDE 4.6.0) OS: Linux If "Stop playing after this track" is selected, then the scores are updated incorrectly. This happens because in this case, both slotAboutToFinish() and (shortly after) slotFinished() are called in EngineController. Each of them calls m_currentTrack->finishedPlaying causing the score to get updated twice (which shouldn't happen because of the incremental way the score is computed). Moreover, the second time around the playedFraction is incorrectly determined to be zero which causes the overall decrease in score. Reproducible: Always Steps to Reproduce: Play a song, select "Stop playing after this track", and wait until it is completely played (or skip to the end). Let's assume the track has a playcount of 9 and a score of 96. Actual Results: The song now has a score of 87. (In the first step it gets a score of (9*96+100)/10 = 96 as it should, but then this is decreased to (10*96+0)/11 = 87.) Expected Results: The song should get a score of (9*96+100)/10 = 96.4. OS: Linux (x86_64) release 2.6.35-25-generic Compiler: cc 1085649 1 myriam 2011-02-09 10:01:28 +0000 Ouch, confirmed in current git 1085735 2 123kash 2011-02-09 13:37:52 +0000 Git commit ee4cb2b3c72880a9a4da83756770fcd0298bedc8 by Sergey Ivanov. Committed on 09/02/11 at 13:32. Pushed by ivanov into branch 'master'. Fixed track's statistics update in case of StopAfterCurrent playback mode (prevent double statistics change). BUG: 265654 M +2 -0 ChangeLog M +0 -4 src/EngineController.cpp http://commits.kde.org/amarok/ee4cb2b3c72880a9a4da83756770fcd0298bedc8 1085790 3 mail 2011-02-09 15:45:03 +0000 Many thanks for the quick attention! I haven't had time to actually test the proposed fix, but it seems to me that it has a troublesome side effect: in case, a song is manually stopped by the user (so that slotAboutToFinish isn't called) the score is not going to be updated at all. Or am I missing something? 1086240 4 123kash 2011-02-10 12:45:02 +0000 When you stop track manually, Amarok calls stop() method which updates track statistics.