<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>262939</bug_id>
          
          <creation_ts>2011-01-12 12:52:48 +0000</creation_ts>
          <short_desc>Kateviewinternal does not check for availability of Qt accessibility module.</short_desc>
          <delta_ts>2011-05-02 19:41:37 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>kate</product>
          <component>part</component>
          <version>unspecified</version>
          <rep_platform>Compiled Sources</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Artem Anisimov">aanisimov</reporter>
          <assigned_to name="KWrite Developers">kwrite-bugs-null</assigned_to>
          <cc>thiago</cc>
    
    <cc>vapier</cc>
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin>4.7.0</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1072211</commentid>
    <comment_count>0</comment_count>
    <who name="Artem Anisimov">aanisimov</who>
    <bug_when>2011-01-12 12:52:48 +0000</bug_when>
    <thetext>Version:           4.6 (using KDE 4.5.95) 
OS:                All

Subj.

I have attached a patch that makes kateviewinternal disable its support for accessibility on systems that do not use it.

Reproducible: Always

Steps to Reproduce:
Compile Qt with -no-accessibility and then compile kdelibs.

Actual Results:  
Compilation of kdelibs fails.

Expected Results:  
Kateviewinternal should disable its support for accessibility.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1072212</commentid>
    <comment_count>1</comment_count>
      <attachid>55906</attachid>
    <who name="Artem Anisimov">aanisimov</who>
    <bug_when>2011-01-12 12:54:44 +0000</bug_when>
    <thetext>Created attachment 55906
Patch that disables kateviewinternal&apos;s support for accessibility on systems that do not use it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1090228</commentid>
    <comment_count>2</comment_count>
    <who name="Mike Frysinger">vapier</who>
    <bug_when>2011-02-22 05:42:29 +0000</bug_when>
    <thetext>blah, i just wrote the same patch.  wish i searched first ;).

i wonder if the QT_NO_ACCESSIBILITY check should be after the local includes though ... that way the QT headers are included to provide the define.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1107266</commentid>
    <comment_count>3</comment_count>
    <who name="Artem Anisimov">aanisimov</who>
    <bug_when>2011-04-12 19:03:46 +0000</bug_when>
    <thetext>Hi again!

Guys, you already have a patch for this bug. Why not fix it?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1113760</commentid>
    <comment_count>4</comment_count>
    <who name="Thiago Macieira">thiago</who>
    <bug_when>2011-05-01 23:59:08 +0000</bug_when>
    <thetext>Less-than-full Qt is not supported. Simply enable accessibility support in Qt and the problem is gone.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1113773</commentid>
    <comment_count>5</comment_count>
    <who name="Mike Frysinger">vapier</who>
    <bug_when>2011-05-02 00:23:40 +0000</bug_when>
    <thetext>the code already has proper #ifdef checks in places, and everything else in KDE that ive used builds fine.  and someone already has posted a trivial patch.  all you have to do is merge it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1114135</commentid>
    <comment_count>6</comment_count>
    <who name="Dominik Haumann">dhaumann</who>
    <bug_when>2011-05-02 19:41:37 +0000</bug_when>
    <thetext>Git commit cb20a83c3806698a35a0ec7a9d24f4dfebe1736b by Dominik Haumann.
Committed on 02/05/2011 at 19:50.
Pushed by dhaumann into branch &apos;master&apos;.

check for availability of Qt accessibility module

Thanks to Artem Anisimov for the patch &amp; sorry for the delay!
BUG: 262939
FIXED-IN: 4.7.0

M  +2    -0    part/view/kateviewaccessible.h     
M  +6    -0    part/view/kateviewinternal.cpp     

http://commits.kde.org/kate/cb20a83c3806698a35a0ec7a9d24f4dfebe1736b</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>55906</attachid>
            <date>2011-01-12 12:54:44 +0000</date>
            <delta_ts>2011-01-12 12:54:44 +0000</delta_ts>
            <desc>Patch that disables kateviewinternal&apos;s support for accessibility on systems that do not use it.</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>1639</size>
            <attacher name="Artem Anisimov">aanisimov</attacher>
            
              <data encoding="base64">ZGlmZiAtdXIga2RlbGlicy00LjUuOTYub3JpZy9rYXRlL3ZpZXcva2F0ZXZpZXdhY2Nlc3NpYmxl
Lmgga2RlbGlicy00LjUuOTUva2F0ZS92aWV3L2thdGV2aWV3YWNjZXNzaWJsZS5oCi0tLSBrZGVs
aWJzLTQuNS45Ni5vcmlnL2thdGUvdmlldy9rYXRldmlld2FjY2Vzc2libGUuaAkyMDEwLTExLTEx
IDE3OjQxOjI4LjAwMDAwMDAwMCArMDMwMAorKysga2RlbGlicy00LjUuOTUva2F0ZS92aWV3L2th
dGV2aWV3YWNjZXNzaWJsZS5oCTIwMTEtMDEtMTEgMTE6Mzc6MTUuMjg4ODEwNTA1ICswMzAwCkBA
IC0xOSw2ICsxOSw3IEBACiAKICNpZm5kZWYgX0tBVEVfVklFV19BQ0NFU1NJQkxFXwogI2RlZmlu
ZSBfS0FURV9WSUVXX0FDQ0VTU0lCTEVfCisjaWZuZGVmIFFUX05PX0FDQ0VTU0lCSUxJVFkKIAog
I2luY2x1ZGUgImthdGV2aWV3aW50ZXJuYWwuaCIKICNpbmNsdWRlICJrYXRldGV4dGN1cnNvci5o
IgpAQCAtMzE4LDMgKzMxOSw0IEBACiB9CiAKICNlbmRpZgorI2VuZGlmCmRpZmYgLXVyIGtkZWxp
YnMtNC41Ljk2Lm9yaWcva2F0ZS92aWV3L2thdGV2aWV3aW50ZXJuYWwuY3BwIGtkZWxpYnMtNC41
Ljk1L2thdGUvdmlldy9rYXRldmlld2ludGVybmFsLmNwcAotLS0ga2RlbGlicy00LjUuOTYub3Jp
Zy9rYXRlL3ZpZXcva2F0ZXZpZXdpbnRlcm5hbC5jcHAJMjAxMC0xMi0wMyAxNzo1NzowNS4wMDAw
MDAwMDAgKzAzMDAKKysrIGtkZWxpYnMtNC41Ljk1L2thdGUvdmlldy9rYXRldmlld2ludGVybmFs
LmNwcAkyMDExLTAxLTExIDExOjM2OjUxLjk2ODgxMTQ4MSArMDMwMApAQCAtMjE2LDcgKzIxNiw5
IEBACiAgIGNvbm5lY3QoIG1fdmlldywgU0lHTkFMKCBzZWxlY3Rpb25DaGFuZ2VkKEtUZXh0RWRp
dG9yOjpWaWV3KikgKSwKICAgICAgICAgICAgICB0aGlzLCBTTE9UKCB2aWV3U2VsZWN0aW9uQ2hh
bmdlZCgpICkgKTsKIAorI2lmbmRlZiBRVF9OT19BQ0NFU1NJQklMSVRZCiAgIFFBY2Nlc3NpYmxl
OjppbnN0YWxsRmFjdG9yeShhY2Nlc3NpYmxlSW50ZXJmYWNlRmFjdG9yeSk7CisjZW5kaWYKIAog
ICAvLyB1cGRhdGUgaXMgY2FsbGVkIGluIEthdGVWaWV3LCBhZnRlciBjb25zdHJ1Y3Rpb24gYW5k
IGxheW91dCBpcyBvdmVyCiAgIC8vIGJ1dCBiZWZvcmUgYW55IG90aGVyIGthdGV2aWV3aW50ZXJu
YWwgY2FsbApAQCAtMjI0LDcgKzIyNiw5IEBACiAKIEthdGVWaWV3SW50ZXJuYWw6On5LYXRlVmll
d0ludGVybmFsICgpCiB7CisjaWZuZGVmIFFUX05PX0FDQ0VTU0lCSUxJVFkKICAgUUFjY2Vzc2li
bGU6OnJlbW92ZUZhY3RvcnkoYWNjZXNzaWJsZUludGVyZmFjZUZhY3RvcnkpOworI2VuZGlmCiAK
ICAgLy8ga2lsbCBwcmVlZGl0IHJhbmdlcwogICBkZWxldGUgbV9pbVByZWVkaXRSYW5nZTsKQEAg
LTY0Niw3ICs2NTAsOSBAQAogCiAgIG1fbWFkZVZpc2libGUgPSAhZm9yY2U7CiAKKyNpZm5kZWYg
UVRfTk9fQUNDRVNTSUJJTElUWQogICBRQWNjZXNzaWJsZTo6dXBkYXRlQWNjZXNzaWJpbGl0eSgg
dGhpcywgS2F0ZUN1cnNvckFjY2Vzc2libGU6OkNoaWxkSWQsIFFBY2Nlc3NpYmxlOjpGb2N1cyAp
OworI2VuZGlmCiB9CiAKIHZvaWQgS2F0ZVZpZXdJbnRlcm5hbDo6c2xvdFJlZ2lvblZpc2liaWxp
dHlDaGFuZ2VkQXQodW5zaWduZWQgaW50LGJvb2wgY2xlYXJfY2FjaGUpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>