251920 2010-09-21 13:11:30 +0000 Digikam should match lenses on Exif.CanonCs.LensType, not ExifCanonCs.Lens 2017-08-06 21:08:47 +0000 1 1 2 Applications digikam Plugin-Editor-LensCorrection 1.4.0 Mandriva RPMs Linux RESOLVED FIXED NOR normal --- 0 bgmilne digikam-bugs-null caulier.gilles 1.5.0 0 oldest_to_newest 1022245 0 bgmilne 2010-09-21 13:11:30 +0000 Version: 1.4.0 (using KDE 4.4.3) OS: Linux Digikam Lens correction wasn't automatically choosing the correct lens from the lensfun database. Canon cameras return different information for the Lens and LensType tags: $ exiv2 -pa IMG_2775.JPG |grep Lens Exif.CanonCs.LensType Short 1 Canon EF 70-300mm f/4-5.6 IS USM Exif.CanonCs.Lens Short 3 70.0 - 300.0 mm While the Lens tag has valid information, the actual Lens model is only correct in LensType. With the attached patch (only, no other patches), digikam automatically matches the correct lens. Reproducible: Always Steps to Reproduce: Find an image taken on a Canon DSLR (I used Canon EOS 500D) with a lens listed in the lensfun database (I used "Canon EF-S 17-85mm f/4-5.6 IS USM", which is in lensfun 0.2.5, and and "Canon EF 70-300mm f/4-5.6 IS USM" for which I have created a lens profile). Enter the editor, Enhance->Lens->Auto-correction Actual Results: See that you need to select the lens manually. Expected Results: The lens should be selected automatically. With the attached patch, images taken with both lenses I have resulted in automatic selection of the correct lens profile. 1022247 1 51856 bgmilne 2010-09-21 13:20:29 +0000 Created attachment 51856 Trivial patch to use LensType tag on Canon 1022249 2 51857 bgmilne 2010-09-21 13:23:00 +0000 Created attachment 51857 Patch formatted better to retain comment alignment 1022250 3 caulier.gilles 2010-09-21 13:24:05 +0000 digiKam 1.5.0 has already a similar patch applied. http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp#968 Gilles Caulier 1022457 4 bgmilne 2010-09-21 21:19:58 +0000 I applied the fix in http://websvn.kde.org/branches/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp?r1=1165407&r2=1172473 to 1.4.0, and it did not work as expected. Instead of automatically matching the exact lens, it matched a different lens which had a focal length range that covered the shortest focal length. In the quick test I did, instead of matching EF-S 17-85mm f/4-5.6 IS USM, it matched EF-S 10-22mm f/3.5-4.5 USM. If I instead place the append call with Exif.CanonCs.LensType before Exif.CanonCs.Lens, then it works as expected. I should probably build from svn, but assuming no other major changes were made, I think this is not fixed. I can supply a sample image if that would help test (I assume some other Canon DSLRs, such as 40D, work with the Exif.CanonCs.Lens tag, and we actually would prefer both types to work, not one or the other). 1022470 5 caulier.gilles 2010-09-21 22:10:32 +0000 yes send me by mail a test image, or give me a web link to download it Gilles Caulier 1023068 6 bgmilne 2010-09-23 11:53:55 +0000 Looks like it is fixed in trunk in r1178204 1035766 7 mklapetek 2010-10-22 23:13:50 +0000 In 2.0 branch it still detects the wrong lens for "Canon EF-S 18-55mm f/3.5-5.6 IS" as "Canon EF-S 10-22mm f/3.5-4.5 USM". Although the database has only "Canon EF-S 18-55mm f/3.5-5.6" (without the IS), so that may be the problem. I'd propose to do a regular expression match (if it isn't already, not sure). 1035824 8 caulier.gilles 2010-10-23 09:32:09 +0000 Martin, There is 2 way to fix this problem: the regex is done in liblensfun using GLib2. I suspect that code is not perfect at this place. This can be fixed in lensfun code of course and reported to lensfun project to backport patch. This is done by this stage 1 : http://lxr.kde.org/source/extragear/graphics/digikam/libs/dimg/filters/lens/lensfuniface.cpp#275 Another way is to patch the digiKam lenfun interface to process a regex based on Qt4::QString. Stage 2 is specific to Nikon camera/lens: http://lxr.kde.org/source/extragear/graphics/digikam/libs/dimg/filters/lens/lensfuniface.cpp#280 There is the last stage : http://lxr.kde.org/source/extragear/graphics/digikam/libs/dimg/filters/lens/lensfuniface.cpp#294 I recommend to add a new stage for Canon camera before last stage, if you choose to patch digiKam lensfun interface source code. Please patch trunk, i will backport later GSoC 2010 branch. Gilles Caulier 1037963 9 mklapetek 2010-10-28 13:51:27 +0000 By looking at that, I think that just doing a "reverse search" could be enough. Because now it takes the exiv data and looks into the database. But if this string is just longer by the "IS" or something, it won't match. But if it would be done the other way round - by matching the database to the exiv string, this would work. Consider a use case, when the manufacturer creates just new lenses and adds stuff to the string (like "IS" or something else) but the actual lenses stays the same, this would still get matched with my proposed way. Okay, I'll play with it a little and see what I can come up with. 51856 2010-09-21 13:20:29 +0000 2010-09-21 13:23:00 +0000 Trivial patch to use LensType tag on Canon digikam-1.4.0-canon-use-lenstype-tag.patch text/plain 690 bgmilne LS0tIGRpZ2lrYW0tMS40LjAvbGlicy9kbWV0YWRhdGEvZG1ldGFkYXRhLmNwcH4JMjAxMC0wOC0y MiAwOTo1MzoyNi4wMDAwMDAwMDAgKzAxMDAKKysrIGRpZ2lrYW0tMS40LjAvbGlicy9kbWV0YWRh dGEvZG1ldGFkYXRhLmNwcAkyMDEwLTA5LTIxIDExOjAzOjI5LjAwMDAwMDAwMCArMDEwMApAQCAt OTY0LDcgKzk2NCw3IEBACiAKICAgICAvLyBJbiBmaXJzdCwgdHJ5IHRvIGdldCBMZW5zIGluZm9y bWF0aW9uIGZyb20gbWFrZXJub3Rlcy4KIAotICAgIGxlbnNFeGlmVGFncy5hcHBlbmQoIkV4aWYu Q2Fub25Dcy5MZW5zIik7ICAgICAgICAgIC8vIENhbm9uIENhbWVyYXMgTWFrZXJub3RlLgorICAg IGxlbnNFeGlmVGFncy5hcHBlbmQoIkV4aWYuQ2Fub25Dcy5MZW5zVHlwZSIpOyAgICAgICAgICAv LyBDYW5vbiBDYW1lcmFzIE1ha2Vybm90ZS4KICAgICBsZW5zRXhpZlRhZ3MuYXBwZW5kKCJFeGlm LkNhbm9uLjB4MDA5NSIpOyAgICAgICAgICAvLyBBbHRlcm5hdGl2ZSBDYW5vbiBDYW1lcmFzIE1h a2Vybm90ZS4KICAgICBsZW5zRXhpZlRhZ3MuYXBwZW5kKCJFeGlmLk5pa29uTGQxLkxlbnNJRE51 bWJlciIpOyAvLyBOaWtvbiBDYW1lcmFzIE1ha2Vybm90ZS4KICAgICBsZW5zRXhpZlRhZ3MuYXBw ZW5kKCJFeGlmLk5pa29uTGQyLkxlbnNJRE51bWJlciIpOyAvLyBOaWtvbiBDYW1lcmFzIE1ha2Vy bm90ZS4K 51857 2010-09-21 13:23:00 +0000 2010-09-21 13:23:00 +0000 Patch formatted better to retain comment alignment digikam-1.4.0-canon-use-lenstype-tag.patch text/plain 686 bgmilne LS0tIGRpZ2lrYW0tMS40LjAvbGlicy9kbWV0YWRhdGEvZG1ldGFkYXRhLmNwcH4JMjAxMC0wOC0y MiAwOTo1MzoyNi4wMDAwMDAwMDAgKzAxMDAKKysrIGRpZ2lrYW0tMS40LjAvbGlicy9kbWV0YWRh dGEvZG1ldGFkYXRhLmNwcAkyMDEwLTA5LTIxIDExOjAzOjI5LjAwMDAwMDAwMCArMDEwMApAQCAt OTY0LDcgKzk2NCw3IEBACiAKICAgICAvLyBJbiBmaXJzdCwgdHJ5IHRvIGdldCBMZW5zIGluZm9y bWF0aW9uIGZyb20gbWFrZXJub3Rlcy4KIAotICAgIGxlbnNFeGlmVGFncy5hcHBlbmQoIkV4aWYu Q2Fub25Dcy5MZW5zIik7ICAgICAgICAgIC8vIENhbm9uIENhbWVyYXMgTWFrZXJub3RlLgorICAg IGxlbnNFeGlmVGFncy5hcHBlbmQoIkV4aWYuQ2Fub25Dcy5MZW5zVHlwZSIpOyAgICAgIC8vIENh bm9uIENhbWVyYXMgTWFrZXJub3RlLgogICAgIGxlbnNFeGlmVGFncy5hcHBlbmQoIkV4aWYuQ2Fu b24uMHgwMDk1Iik7ICAgICAgICAgIC8vIEFsdGVybmF0aXZlIENhbm9uIENhbWVyYXMgTWFrZXJu b3RlLgogICAgIGxlbnNFeGlmVGFncy5hcHBlbmQoIkV4aWYuTmlrb25MZDEuTGVuc0lETnVtYmVy Iik7IC8vIE5pa29uIENhbWVyYXMgTWFrZXJub3RlLgogICAgIGxlbnNFeGlmVGFncy5hcHBlbmQo IkV4aWYuTmlrb25MZDIuTGVuc0lETnVtYmVyIik7IC8vIE5pa29uIENhbWVyYXMgTWFrZXJub3Rl Lgo=