243513 2010-07-03 17:33:20 +0000 KCharsets does not support CP949 encoding. 2015-01-22 00:44:22 +0000 1 1 3 Frameworks and Libraries frameworks-kcodecs general 5.1.0 Arch Linux Linux RESOLVED FIXED NOR wishlist --- 1 darklin20 kdelibs-bugs-null hein kde simonandric5 http://commits.kde.org/kcodecs/3f3e074237c52b49e06083a38ab6624a541e63d1 0 oldest_to_newest 985881 0 darklin20 2010-07-03 17:33:20 +0000 Version: 4.4 (using KDE 4.4.4) OS: Linux I reported this problem to konversation team. https://bugs.kde.org/show_bug.cgi?id=243495 But they said this is kdelib's problem, and with my short look into kcharsets.cpp, I think they're right. It looks like KCharsets is a wrapper class to use functions of QTextCodec easily. There's two encoding for Korean, EUC-KR and CP949, and QTextCodec of Qt4 supports both of them. See the list in "Detailed Description" of next page. http://doc.qt.nokia.com/4.6/qtextcodec.html CP949 is superset of EUC-KR so, some characters are only included in CP949. Tha lack of CP949 support in KDE4 is especially crucial problem when transport some texts over network or read text file etc... If KCharsets is a wrapper for QTextCodec, I think that it's possible for KDE to support CP949 encoding just by adding some strings for cp949 to the arrays contains the full list of supporting encodings like language_for_encoding_string or builtin_string. Reproducible: Didn't try 985922 1 hein 2010-07-03 19:28:26 +0000 *** Bug 243495 has been marked as a duplicate of this bug. *** 986007 2 48574 darklin20 2010-07-04 02:17:33 +0000 Created attachment 48574 patch for KCharsets to support CP949 986008 3 darklin20 2010-07-04 02:18:57 +0000 I wrote a patch for this issue.(See attached file.) What I did is just add "cp 949" to input data for language_for_encoding_string and builtin_string, and generate codes with generate_string_table.pl. I tested within konversation and Kate, and it looks working fine. 986252 4 kde 2010-07-04 22:56:16 +0000 Right, CP949 is superset of EUC-KR, covering every 11172 composable characters. EUC-KR only covers 2350, just 1/5 of what we need. This bug affects everywhere CP949 decoding is needed, including webpages in Konqueror. Judging from changelog, CP949 support is included since Qt 4.3.0. It looks too late to be included in KDE 4.5, I hope this will be included as soon as possible. 986318 5 cfeck 2010-07-05 04:09:24 +0000 If the patch in comment #2 is all there is to close this bug, then I am all for getting it into the KDE SC 4.5 branch. 986364 6 darklin20 2010-07-05 11:07:30 +0000 (In reply to comment #5) > If the patch in comment #2 is all there is to close this bug, then I am all for > getting it into the KDE SC 4.5 branch. The patch is only for KCharsets, and there might be other related parts which should be corrected also. I'm not sure that the patch is enough to add an encoding support because I'm not a KDE developer (even not a KDE app. developer). I think the kdelibs developers need to glimpse the patch at least, before they apply it. 986618 7 48613 kde 2010-07-05 23:01:31 +0000 Created attachment 48613 Improvement of patch in comment #2 I checked for patch #2, and made some improvement. As I think just appending new encoding at the end of list is not so good, I moved CP949 to the next of EUC-KR in both string tables. No strings are added/modified, no need to break message freeze. I tested it with myself, at least it works for me. 986621 8 48614 kde 2010-07-05 23:05:46 +0000 Created attachment 48614 Test for the patch This test program checks for "cp 949" in the KCharsets' encoding list, and try to create QTextCodec with all possible aliases, en/decode string in CP949 encoeding. Without patch in comment #5, the test will fail in step 1. With the patch, all steps wiil be passed. 1042335 9 kde 2010-11-09 18:16:43 +0000 Any updates since KDE SC 4.5? 1415477 10 darklin20 2013-12-01 06:17:28 +0000 Nobody cares? KDE still lacks CP949 support. 1491471 11 hein 2015-01-15 19:05:24 +0000 Well, I care now (you guessed it, HanIRC). I'll investigate a bit. 1491472 12 hein 2015-01-15 19:14:20 +0000 Looks like this patch never made it in, indeed. 박신조씨, do you want to resurrect your patch and resubmit it via http://git.reviewboard.kde.org/? I'll make sure we get it on the way. 1491877 13 hein 2015-01-17 17:33:48 +0000 Git commit 7d4ca9a42be6f4361bef31a3f32644be7bdbf8c3 by Eike Hein, on behalf of Park Shinjo. Committed on 17/01/2015 at 17:32. Pushed by hein into branch 'KDE/4.14'. Add support for CP949 to KCharsets. M +21 -14 kdecore/localization/kcharsets.cpp http://commits.kde.org/kdelibs/7d4ca9a42be6f4361bef31a3f32644be7bdbf8c3 1491878 14 hein 2015-01-17 17:34:47 +0000 After testing, I've now pushed attachment #2 to kdelibs, with attribution to Park Shinjo. I've also created a new patch for the kcodecs framework with included test coverage that I will follow next. 1491879 15 hein 2015-01-17 17:36:46 +0000 Git commit 3f3e074237c52b49e06083a38ab6624a541e63d1 by Eike Hein. Committed on 17/01/2015 at 17:34. Pushed by hein into branch 'master'. Add support for CP949 to KCharsets. This is a recreation of a patch written originally for kdelibs by Park Shinjo, which entered kdelibs.git as 7d4ca9a4 prior to this. The tables in this version were regenerated clean and test coverage was added and tests done with both ICU and non-ICU builds of Qt. M +2 -0 autotests/kcharsetstest.cpp M +21 -14 src/kcharsets.cpp http://commits.kde.org/kcodecs/3f3e074237c52b49e06083a38ab6624a541e63d1 1491943 16 hein 2015-01-17 22:52:37 +0000 Git commit f9a5d5cb8577d7afd013f6f345224bf8658941c4 by Eike Hein. Committed on 17/01/2015 at 22:45. Pushed by hein into branch 'master'. Improve the mapping to Qt 5's codec names. This fixes the test failure in the ICU build on CI. M +0 -1 autotests/kcharsetstest.cpp M +10 -10 src/kcharsets.cpp http://commits.kde.org/kcodecs/f9a5d5cb8577d7afd013f6f345224bf8658941c4 1491976 17 kde 2015-01-18 07:00:46 +0000 I was about to check out both KDE4 and KF5, 감사합니다 ;) Please also indicate original author of the patch if possible, as my role was revising it. 1492039 18 hein 2015-01-18 15:10:16 +0000 Probably good for completeness' sake: Basically I tested the KF5 version of Konversation against both ICU-enabled and ICU-disabled builds of Qt 5 to verify, with the testcase of sending and receiving "잌" which isn't covered by EUC-KR. With an ICU build, this becomes mostly a GUI improvement - even just selecting EUC-KR will cause Qt to use QIcuCodec for encode/decode, which will transparently use ICU's windows-949 implementation. With ICU disabled, Qt's own CP949 implementation needs to be used and has to be specifically requested, that's when this addition is the biggest win. "windows-949" is the name it understands in both modes, that's why it's the best alias. In Qt 4 on the other hand it's just known as "cp949" and QTextCodec::codecForName() actually understands both "cp949" and "cp 949" (and so does the KCharsets wrapper now). Testing the KDE 4 version of Konversation worked, too. As for attribution ... darklin20 not setting a real name here made this a bit tricky due to our real name policy for contributions. But the commits all reference this ticket, and since the code is generated and the input data differs in your versions I think it's OK to call this two different patches. Nonetheless, many thanks to darklin20 for getting the ball rolling and I'm truly sorry it took so long for us to respond. 1492050 19 darklin20 2015-01-18 15:29:21 +0000 I don't really care about credit. I just want to use Konversation as my default IRC client. Thank you so much. 48574 2010-07-04 02:17:33 +0000 2010-07-04 02:17:33 +0000 patch for KCharsets to support CP949 kcharsets-cp949.patch text/plain 1289 darklin20 LS0tIGtkZWxpYnMtNC40LjUva2RlY29yZS9sb2NhbGl6YXRpb24va2NoYXJzZXRzLmNwcC5vcmln CTIwMTAtMDctMDQgMDU6NTY6NTEuMTA0MDk2NTE2ICswOTAwCisrKyBrZGVsaWJzLTQuNC41L2tk ZWNvcmUvbG9jYWxpemF0aW9uL2tjaGFyc2V0cy5jcHAJMjAxMC0wNy0wNCAwNzo1OTo0MC42ODY4 ODIxMDggKzA5MDAKQEAgLTEzMyw2ICsxMzMsOCBAQAogaTE4bjpPdGhlcgogVFNDSUkKIGkxOG46 T3RoZXIKK2NwIDk0OQoraTE4bjpLb3JlYW4KICAqLwogLyoKICAqIE5vdGVzIGFib3V0IHRoZSB0 YWJsZToKQEAgLTIxNCw2ICsyMTYsNyBAQAogICAgIEkxOE5fTk9PUDIoIkBpdGVtIFRleHQgY2hh cmFjdGVyIHNldCIsICJPdGhlciIpIlwwIgogICAgICJJQk04NzRcMCIKICAgICAiVFNDSUlcMCIK KyAgICAiY3AgOTQ5XDAiCiAgICAgIlwwIjsKIAogc3RhdGljIGNvbnN0IGludCBsYW5ndWFnZV9m b3JfZW5jb2RpbmdfaW5kaWNlc1tdID0gewpAQCAtMjI4LDcgKzIzMSw3IEBACiAgICAgIDQzMywg IDQyNiwgIDQ0NiwgIDQyNiwgIDQ1NCwgIDE4NSwgIDQ2NSwgIDQ3MiwKICAgICAgNDc3LCAgNDcy LCAgNDg5LCAgNDk1LCAgNTAzLCAgNDk1LCAgNTEwLCAgNDk1LAogICAgICA1MTUsICA0OTUsICA1 MjAsICA0OTUsICA1MzYsICA1NDUsICA1NjAsICA1NzMsCi0gICAgIDU3OSwgIDU3MywgIDU4Niwg IDU3MywgICAtMQorICAgICA1NzksICA1NzMsICA1ODYsICA1NzMsICA1OTIsICAzMzEsICAgLTEK IH07CiAKIC8qCkBAIC0zMTksNiArMzIyLDggQEAKIGFwcGxlIHJvbWFuCiBjc2lzbzIwMjJqcAog aXNvLTIwMjItanAKK2NwOTQ5CitjcCA5NDkKICovCiAvKgogICogTm90ZXMgYWJvdXQgdGhlIHRh YmxlOgpAQCAtMzg5LDYgKzM5NCw4IEBACiAgICAgIm1hY2ludG9zaFwwIgogICAgICJtYWNcMCIK ICAgICAiY3Npc28yMDIyanBcMCIKKyAgICAiY3A5NDlcMCIKKyAgICAiY3AgOTQ5XDAiCiAgICAg IlwwIjsKIAogc3RhdGljIGNvbnN0IGludCBidWlsdGluX2luZGljZXNbXSA9IHsKQEAgLTQwMiw3 ICs0MDksNyBAQAogICAgICAzOTksICA0MTAsICA0MTcsICAzOTIsICA0MjksICA0MTAsICA0NDEs ICA0NTAsCiAgICAgIDQ2MiwgIDQ3NCwgIDQ4NiwgIDQ5OCwgIDUwNSwgIDQ5OCwgIDUxNiwgIDQ5 OCwKICAgICAgNTIzLCAgMjA4LCAgNTM4LCAgMjA4LCAgNTUzLCAgNDUwLCAgNTYzLCAgNDUwLAot ICAgICA1NzMsICA0NTAsICA1NzcsICAzNjQsICAgLTEKKyAgICAgNTczLCAgNDUwLCAgNTc3LCAg MzY0LCAgNTg5LCAgNTk1LCAgIC0xCiB9OwogCiAjaWYgMAo= 48613 2010-07-05 23:01:31 +0000 2010-07-05 23:01:31 +0000 Improvement of patch in comment #2 kcharsets_cp949.patch text/plain 2496 kde LS0tIGtjaGFyc2V0cy5jcHAub3JpZwkyMDA5LTEyLTExIDA4OjE0OjQzLjAwMDAwMDAwMCArMDkw MAorKysga2NoYXJzZXRzLmNwcAkyMDEwLTA3LTA2IDA1OjUwOjIxLjAwMDAwMDAwMCArMDkwMApA QCAtODksNiArODksOCBAQAogaTE4bjpDaGluZXNlIFNpbXBsaWZpZWQKIEVVQy1LUgogaTE4bjpL b3JlYW4KK2NwIDk0OQoraTE4bjpLb3JlYW4KIHNqaXMKIGkxOG46SmFwYW5lc2UKIGppczcKQEAg LTE4NCw2ICsxODYsNyBAQAogICAgICJHQjIzMTJcMCIKICAgICAiRVVDLUtSXDAiCiAgICAgSTE4 Tl9OT09QMigiQGl0ZW0gVGV4dCBjaGFyYWN0ZXIgc2V0IiwgIktvcmVhbiIpIlwwIgorICAgICJj cCA5NDlcMCIKICAgICAic2ppc1wwIgogICAgIEkxOE5fTk9PUDIoIkBpdGVtIFRleHQgY2hhcmFj dGVyIHNldCIsICJKYXBhbmVzZSIpIlwwIgogICAgICJqaXM3XDAiCkBAIC0yMjMsMTIgKzIyNiwx MiBAQAogICAgICAxOTMsICAxMTcsICAyMDEsICAyMDgsICAyMTcsICAyMDgsICAyMjgsICAyMDgs CiAgICAgIDIzNiwgIDIwOCwgIDI0MywgIDIwOCwgIDI1MCwgIDI1NSwgIDI3NSwgIDI1NSwKICAg ICAgMjg2LCAgMjk0LCAgMzEzLCAgMjk0LCAgMzE3LCAgMjk0LCAgMzI0LCAgMzMxLAotICAgICAz MzgsICAzNDMsICAzNTIsICAzNDMsICAzNTcsICAzNDMsICAzNjQsICAzNzUsCi0gICAgIDM4MSwg IDM3NSwgIDM4OSwgIDQwMCwgIDQwNywgIDQwMCwgIDQxNSwgIDQyNiwKLSAgICAgNDMzLCAgNDI2 LCAgNDQ2LCAgNDI2LCAgNDU0LCAgMTg1LCAgNDY1LCAgNDcyLAotICAgICA0NzcsICA0NzIsICA0 ODksICA0OTUsICA1MDMsICA0OTUsICA1MTAsICA0OTUsCi0gICAgIDUxNSwgIDQ5NSwgIDUyMCwg IDQ5NSwgIDUzNiwgIDU0NSwgIDU2MCwgIDU3MywKLSAgICAgNTc5LCAgNTczLCAgNTg2LCAgNTcz LCAgIC0xCisgICAgIDMzOCwgIDMzMSwgIDM0NSwgIDM1MCwgIDM1OSwgIDM1MCwgIDM2NCwgIDM1 MCwKKyAgICAgMzcxLCAgMzgyLCAgMzg4LCAgMzgyLCAgMzk2LCAgNDA3LCAgNDE0LCAgNDA3LAor ICAgICA0MjIsICA0MzMsICA0NDAsICA0MzMsICA0NTMsICA0MzMsICA0NjEsICAxODUsCisgICAg IDQ3MiwgIDQ3OSwgIDQ4NCwgIDQ3OSwgIDQ5NiwgIDUwMiwgIDUxMCwgIDUwMiwKKyAgICAgNTE3 LCAgNTAyLCAgNTIyLCAgNTAyLCAgNTI3LCAgNTAyLCAgNTQzLCAgNTUyLAorICAgICA1NjcsICA1 ODAsICA1ODYsICA1ODAsICA1OTMsICA1ODAsICAgLTEKIH07CiAKIC8qCkBAIC0yNjUsNiArMjY4 LDggQEAKIGJpZzUKIGV1Yy1rcgogZXVja3IKK2NwOTQ5CitjcCA5NDkKIGV1Yy1qcAogZXVjanAK IGppc3gwMjAxLjE5NzYtMApAQCAtMzU1LDYgKzM2MCw4IEBACiAgICAgImJpZzVcMCIKICAgICAi ZXVjLWtyXDAiCiAgICAgImV1Y2tyXDAiCisgICAgImNwOTQ5XDAiCisgICAgImNwIDk0OVwwIgog ICAgICJldWMtanBcMCIKICAgICAiZXVjanBcMCIKICAgICAiamlzeDAyMDEuMTk3Ni0wXDAiCkBA IC0zOTUsMTQgKzQwMiwxNCBAQAogICAgICAgIDAsICAgMTEsICAgMTgsICAgMTEsICAgMzAsICAg MzksICAgNTAsICAgMzksCiAgICAgICA1OCwgICAzOSwgICA2NCwgICA4MiwgICA4OCwgICA5Mywg IDEwOSwgICA5MywKICAgICAgMTIwLCAgMTM1LCAgMTQzLCAgMTM1LCAgMTU4LCAgMTY0LCAgMTY4 LCAgMTY0LAotICAgICAxNzUsICAxNjQsICAxODksICAxOTYsICAyMDEsICAyMDgsICAyMTQsICAy MjEsCi0gICAgIDIyNywgIDIyMSwgIDI0MywgIDIyMSwgIDI1OSwgIDIyMSwgIDI3NSwgIDIyMSwK LSAgICAgMjkxLCAgMjIxLCAgMzA3LCAgMjIxLCAgMzIzLCAgMjIxLCAgMzM5LCAgMzQ5LAotICAg ICAzNTQsICAzNDksICAzNDksICAzNDksICAzNjQsICAzNzYsICAzODEsICAzOTIsCi0gICAgIDM5 OSwgIDQxMCwgIDQxNywgIDM5MiwgIDQyOSwgIDQxMCwgIDQ0MSwgIDQ1MCwKLSAgICAgNDYyLCAg NDc0LCAgNDg2LCAgNDk4LCAgNTA1LCAgNDk4LCAgNTE2LCAgNDk4LAotICAgICA1MjMsICAyMDgs ICA1MzgsICAyMDgsICA1NTMsICA0NTAsICA1NjMsICA0NTAsCi0gICAgIDU3MywgIDQ1MCwgIDU3 NywgIDM2NCwgICAtMQorICAgICAxNzUsICAxNjQsICAxODksICAxOTYsICAyMDEsICAyMDgsICAy MTQsICAyMjAsCisgICAgIDIyNywgIDIzNCwgIDI0MCwgIDIzNCwgIDI1NiwgIDIzNCwgIDI3Miwg IDIzNCwKKyAgICAgMjg4LCAgMjM0LCAgMzA0LCAgMjM0LCAgMzIwLCAgMjM0LCAgMzM2LCAgMjM0 LAorICAgICAzNTIsICAzNjIsICAzNjcsICAzNjIsICAzNjIsICAzNjIsICAzNzcsICAzODksCisg ICAgIDM5NCwgIDQwNSwgIDQxMiwgIDQyMywgIDQzMCwgIDQwNSwgIDQ0MiwgIDQyMywKKyAgICAg NDU0LCAgNDYzLCAgNDc1LCAgNDg3LCAgNDk5LCAgNTExLCAgNTE4LCAgNTExLAorICAgICA1Mjks ICA1MTEsICA1MzYsICAyMDgsICA1NTEsICAyMDgsICA1NjYsICA0NjMsCisgICAgIDU3NiwgIDQ2 MywgIDU4NiwgIDQ2MywgIDU5MCwgIDM3NywgICAtMQogfTsKIAogI2lmIDAK 48614 2010-07-05 23:05:46 +0000 2010-07-05 23:05:46 +0000 Test for the patch cp949_unittest.tar.gz application/x-gzip 1008 kde H4sIANpHMkwAA+1WTW/jNhD12b9i1l20UnbttWzFTpzYgON40yBuio2ds0BRdEJHFgWSChIEOfRc oJeiwB62QK97W/Tc/qEm+x9KyZI/4uajadMiAB9siRwO34zfcCR3vkEnpEeFFCV5JnNPgrJCzbbj u1VfLc/fE6xaVs6ybMu2q3Z9tZorW1a9Xs1B+WnSWUQkJOIAuVCM7vS7b/2ZIuRsRLA0AIfr9roT BVRKIiSY+SENPCdE+AQdEQP2trs2HHTfHe4edLfVKg2wH3nE8ShX2xmnRBjw8iJ2c3b3O73D7W7/ UvlBXpAldkdwLGCMaFDCYZh4nXjEdpDnOeSM4Egi1ydLOb28+AuaSRBVwyMiHZ8GJ+ricjRJaIkg yU9dOt8edJ3e7laaIw3UKfB9Awbtg53uoH9zo9q5u98ftHs9J/Vwtrtv24e9gaOmCcn/XchHIivC U8a4p/+rq3Y97X/bqiT9X67Vy7r//wu8eQOYeTQ4akAkh8W1/BdpZ8PmXucYcdW9ojVnpExITtB4 3vYufn8sGPqSK8ol84CcyQ7zCF6wbp1L0uYcnbfyqhFl8lww4oHqafwasMoCVlbU5NSEizwoGKeM emayvnHDcDoxTHOHFXwMTdjb8ZmL/EYDp3bDnDgmuS8kDL7yx8fFFgkmyoit8z7mNJS372k0qCQc qecg0NRntjq3OJosuoz5ECIhVKQh8gWZmIeMG7Tpl1xypBQwN+gLNSGBp4avXtHsx2eeoyYttjLX 0Yt4lvmO5n1j0KExKrYwG4eIE6OAQ1CPt4IJzSaUzSwTyaM0kRiX+dlVbY995lmF9JSYLJKwuQmF viQhWA3YYcwrqQMVSFVDAWmc2CXxV/n5kwiXRP3qe+m6nDNeAo8REXwlM947aGNwIiMegJUGys8U ZydpbabncCU+/CQ9RMkwrX0yfsv4PhonesXxXiuC9ASkiiW3L6e8dxHAgxgeJnQlE7rt+4B8igQR gDAmoSRe6ZFyV6Zy7zPVeg9lvlXxWVsDWmgJSN6ozWzaaAw5Gx/K4ZpRuHr/y9Wnj398+u7zT+8/ //Dr9fcfrn//cPXzb9c/flSfgrnM4ySlucnWQ5IGllFYw7Wqu05qbhlVcB0PXbxmux6uYtvz3Nqw 6hLXir8ZM4qLFxeu2EqSCmg8M+JAi2Uz0nAGKkn2NTkzTLOUddcsrbS//k5pq1lp5+ObICJVAyGG kf/Y8lan5V1kDlSx72G/vcRzhajMpJMso0c3VEscF4R6hER2JtEszr8hkD0VaJ73n8iTGssb+cvn +u9QQ0NDQ0NDQ0NDQ0NDQ0NDQ0NDQ0NDQ0ND47nhT+OfkBsAKAAA