241874 2010-06-16 03:04:07 +0000 Can't edit & save an existing equalizer preset 2013-01-22 19:04:14 +0000 1 1 2 Applications amarok Tools/Equalizer 2.6-git Arch Linux Linux RESOLVED FIXED NOR normal --- 1 losinggeneration amarok-bugs-null illya.kovalevskyy kfunk ognyan_angelov ralf-engels zmogas http://commits.kde.org/amarok/97c5144faf608b8fca0522cff4f9590fe09896bf 2.8 0 oldest_to_newest 979093 0 losinggeneration 2010-06-16 03:04:07 +0000 Version: 2.3.1 (using KDE 4.4.3) OS: Linux Presets can be created but they cannot be overwritten when edited. Reproducible: Always Steps to Reproduce: 1) Edit an existing preset 2) Upon any changes Amarok automatically renames the preset to "Manual" 3) Try to save the edited preset with a name of an existing preset Actual Results: Upon typing an existing preset's name and clicking save, the original preset's values are reloaded losing any changes that may have been made. Expected Results: The preset of the same name is overwritten perhaps with a prompt "You're about to overwrite an existing preset, are you sure you want to do this?" The current method to overwrite a preset is as follows: 1) Save preset to a temporary name 2) Delete the old preset 3) Save temporary preset to old preset's name 4) Remove temporary preset It's not straight forward that this is the route that has to be taken in order to save the preset to an existing preset's name. Other thoughts: The actual implementation on overwriting the preset is up to your discretion. I was merely giving one possible solution in the "expected results" section. Another possibility would be like what bug 225406 said: Have a popup for a name (perhaps with type-ahead like the current drop-down has.) Another option might be to not change the name of the preset to "Manual" after an edit and when the use clicks save prompt then, or if the user doesn't save, rename it upon clicking "OK". 979094 1 losinggeneration 2010-06-16 03:07:24 +0000 I should have added equalizer to the title so it's more likely to be found if others search for reports on equalizer presets. 1052482 2 ognyan_angelov 2010-12-02 18:36:00 +0000 Setup: Amarok 2.3.2 KDE 4.4.5 Test Result: Same Bug occurs here. 1052511 3 myriam 2010-12-02 19:27:30 +0000 Setting to confirmed, updated version. 1127044 4 myriam 2011-06-04 12:10:24 +0000 This is an automated message from the triager: Amarok 2.4.1 has been released on May 8 already. Could you please upgrade and test if you can still reproduce this bug? Without feedback within a month we will close this bug as resolved. Thank you for your understanding. 1128192 5 losinggeneration 2011-06-06 16:44:45 +0000 It is indeed reproducible with 2.4.1. I can't seem to update the version myself though. 1128344 6 myriam 2011-06-07 01:41:32 +0000 Thank you for the feedback. 1131129 7 kfunk 2011-06-14 15:05:35 +0000 Just investigated, not really fixable at the moment. As soon as the combo box is left, a indexChanged signal is emitted which causes a reload of the current item (intended, actually). The Equalizer would have to be redesigned, e.g. use a modal line edit for entering the to-be-saved preset name. Just FYI. 1256791 8 zmogas 2012-05-20 18:15:21 +0000 This Bug also exists in version 2.5.0. 1324516 9 illya.kovalevskyy 2012-12-17 22:18:13 +0000 That error on: ====== Kubuntu 12.10 Qt 4.8.3 Amarok 4.7 (beta) ====== Cannot edit or save an existing equalizer preset. 1332855 10 ralf-engels 2013-01-17 10:46:06 +0000 I agree that I don't understand this preset stuff. Why does the preset always fall back to "manual"? Will have a look at the code. 1334402 11 ralf-engels 2013-01-22 19:04:14 +0000 Git commit 97c5144faf608b8fca0522cff4f9590fe09896bf by Ralf Engels. Committed on 22/01/2013 at 14:40. Pushed by rengels into branch 'master'. Refactoring for Equalizer dialog Add comments Improve saving of pre-defined presets Fix Can't edit & save an existing equalizer preset Cleanup of the Equalizer stuff a bit, expecially the Equalizer Dialog Related: bug 274972 FIXED-IN: 2.8 M +0 -1 src/App.cpp M +168 -181 src/dialogs/EqualizerDialog.cpp M +38 -19 src/dialogs/EqualizerDialog.h M +17 -47 src/dialogs/EqualizerDialog.ui M +32 -27 src/equalizer/EqualizerPresets.cpp M +29 -12 src/equalizer/EqualizerPresets.h http://commits.kde.org/amarok/97c5144faf608b8fca0522cff4f9590fe09896bf