238297 2010-05-20 14:52:33 +0000 Infinite loop in "Save diff" when compared files are on different drive letters 2013-05-11 00:36:55 +0000 1 1 2 Applications kompare general unspecified Compiled Sources Microsoft Windows RESOLVED FIXED NOR normal --- 0 krissn windows-bugs-null ps_ml http://commits.kde.org/kompare/7ca56c747dbb135ad1f632fde3ceaba54cfff3b5 4.10.4 0 oldest_to_newest 964684 0 krissn 2010-05-20 14:52:33 +0000 Version: (using KDE 4.4.3) Compiler: MSVC 9.0 OS: MS Windows Installed from: Compiled From Sources On MS Windows, when comparing two files that are residing on different drive letters, Kompare falls into an infinite loop after selecting the "Save diff" option. The reason for this problem is that Kompare tries to find a common root path for both files. On Unix there is always one common root for all files, while on MS Windows this is not the case. Kompare will try to walk up the path, but once it hits the root directory of a drive, it won't detect, that it can't go any further and will keep trying. 964687 1 43745 krissn 2010-05-20 14:59:44 +0000 Created attachment 43745 Proposed patch The patch fixes the problem, although it's not necessarily a clean solution. An ideal fix would involve adding something like KUrl::isTopLevel() and making use of it here. 964791 2 kevin.kofler 2010-05-20 19:03:49 +0000 Your diff is reversed, but otherwise looks OK. 964805 3 krissn 2010-05-20 19:29:15 +0000 It was created with the patched Kompare itself :) I've found a similar bug in KDirSelectDialog::Private::slotComboTextChanged(), but there is more mess in there and it's a subject for another PR. 964825 4 kevin.kofler 2010-05-20 19:50:34 +0000 > It was created with the patched Kompare itself :) Try File / Swap source and destination. :-) But I guess that's for next time, we can work with the reversed patch just fine (that's what patch has a -R option for). 1365848 5 ps_ml 2013-05-02 19:54:39 +0000 Git commit fd2d6e32dfa724f0b2fcffe4766d2d7faf84d437 by Patrick Spendrin. Committed on 02/05/2013 at 13:34. Pushed by sengels into branch 'kde-4.10'. fix endless loop patch taken from bugreport and will be committed asap. M +1 -0 portage/kde/kdesdk/kompare/kompare-20130225.py A +19 -0 portage/kde/kdesdk/kompare/kompare-4.10.2-20130502.diff http://commits.kde.org/emerge/fd2d6e32dfa724f0b2fcffe4766d2d7faf84d437 1367908 6 ps_ml 2013-05-10 20:54:52 +0000 Git commit d05571620258b9714cbc338c5af6f4419cf601c3 by Patrick Spendrin. Committed on 10/05/2013 at 22:53. Pushed by sengels into branch 'KDE/4.10'. fix endless loop do not go into infinite loop in "save diff" M +2 -2 komparepart/komparesaveoptionswidget.cpp http://commits.kde.org/kompare/d05571620258b9714cbc338c5af6f4419cf601c3 1367910 7 ps_ml 2013-05-10 20:58:56 +0000 Git commit 7ca56c747dbb135ad1f632fde3ceaba54cfff3b5 by Patrick Spendrin. Committed on 10/05/2013 at 22:53. Pushed by sengels into branch 'master'. fix endless loop do not go into infinite loop in "save diff" M +2 -2 komparepart/komparesaveoptionswidget.cpp http://commits.kde.org/kompare/7ca56c747dbb135ad1f632fde3ceaba54cfff3b5 43745 2010-05-20 14:59:44 +0000 2010-05-20 14:59:44 +0000 Proposed patch kompare-4.4.3-savediff-win32.patch text/plain 705 krissn LS0tIGtvbXBhcmUva29tcGFyZXBhcnQva29tcGFyZXNhdmVvcHRpb25zd2lkZ2V0LmNwcAkyMDEw LTA1LTIwIDE0OjI4OjI5LjEzODE4MTkwMCArMDIwMA0KKysrIGtvbXBhcmUva29tcGFyZXBhcnQv a29tcGFyZXNhdmVvcHRpb25zd2lkZ2V0LmNwcC5vbGQJMjAwOS0wMy0yNyAxNDo0Njo1OC4wMDAw MDAwMDAgKzAxMDANCkBAIC00OCwxMyArNDgsMTMgQEANCiANCiAJLy8gRmluZCBhIGNvbW1vbiBy b290Lg0KIAlLVXJsIHJvb3QoIHNvdXJjZVVSTCApOw0KLQl3aGlsZSggcm9vdC5pc1ZhbGlkKCkg JiYgIXJvb3QuaXNQYXJlbnRPZiggZGVzdGluYXRpb25VUkwgKSAmJiAocm9vdCAhPSByb290LnVw VXJsKCkpKSB7DQorCXdoaWxlKCByb290LmlzVmFsaWQoKSAmJiAhcm9vdC5pc1BhcmVudE9mKCBk ZXN0aW5hdGlvblVSTCApICkgew0KIAkJcm9vdCA9IHJvb3QudXBVcmwoKTsNCiAJfQ0KIA0KIAkv LyBJZiB3ZSBmb3VuZCBhIGNvbW1vbiByb290LCBjaGFuZ2UgdG8gdGhhdCBkaXJlY3RvcnkgYW5k DQogCS8vIHN0cmlwIHRoZSBjb21tb24gcGFydCBmcm9tIHNvdXJjZSBhbmQgZGVzdGluYXRpb24u DQotCWlmKCByb290LmlzVmFsaWQoKSAmJiAocm9vdCAhPSByb290LnVwVXJsKCkpKSB7DQorCWlm KCByb290LmlzVmFsaWQoKSApIHsNCiAJCW1fZGlyZWN0b3J5UmVxdWVzdGVyLT5zZXRVcmwoIHJv b3QudXJsKCkgKTsNCiAJfQ0KIA0K