227836 2010-02-20 18:36:26 +0000 kde menu editor, move item doesn't work 2010-04-01 17:58:21 +0000 1 1 2 Applications kmenuedit general unspecified openSUSE Linux RESOLVED FIXED NOR normal --- 1 rufusl2001 unassigned-bugs-null annma maris.kde nzlbob2332 opensource P.Suetterlin roland.leissa superaphke Wolfram.R.Sieber 0 oldest_to_newest 921207 0 rufusl2001 2010-02-20 18:36:26 +0000 Version: (using KDE 4.3.1) OS: Linux Installed from: openSUSE RPMs Standard user. Editor appears to work when rearranging folders and items but, after saving, items have not moved or do not appear in expected places on the Classic or KickOff menus. Same result whether starting (by context menu off system menu button at left of panel) from the Classic or the KickOff style menu. Note1: When saving after making changes the progress but goes to 15%, then starts over and gets to about 1/2 point then the menu editor window closes (it's completed). Note2: Kde4 installed with _upgrade_ from Suse 11.0 to 11.2; the Suse11.0 was an upgrade from Suse10.3; Suse10.3 was a clean install. Don't recall if the Suse11.0 system used Kde3 or Kde4. Reproduce: Always. Can't get system menu changed. Expected: System menu should match the tree shown in the menu editor, after saving. 928445 1 roland.leissa 2010-03-04 19:28:47 +0000 KDE Menu Editor still totally buggy in KDE SC 4.4.1 930394 2 nzlbob2332 2010-03-08 07:17:21 +0000 duplicate of https://bugs.kde.org/show_bug.cgi?id=99420 ? 936564 3 annma 2010-03-19 16:10:33 +0000 Confirmed but this product has no maintainer... 936570 4 maris.kde 2010-03-19 16:25:43 +0000 Possibly related bugs: #229665 #102723 #110241 #186683 #221259 #110565 #93923 #102349 #219854 #186683 936602 5 maris.kde 2010-03-19 17:39:04 +0000 I compared KMenuedit 0.7 running 3.5.10 and 0.8 running 4.4.1 output in .config/menu/applications-kmenuedit.menu after performing following steps: mv applications-kmenuedit.menu /some/other/place launch KMenuedit Move "Games" folder to "Utilities" <Move> - <Old>Games</Old> - <New>Utilities/Games</New> + <Old>Games/</Old> + <New>Utilities/Games/</New> </Move> After I removed tailing / from Games, folder got moved in Kickoff too. Workaround for all - open .config/menu/applications-kmenuedit.menu with kate and check for: 1) tailing / at end of folder names; 2) folder names ending with -2 or -1. Delete <move> blocks with "foldername-2" and fix any references to "foldername-2" to point to real name ("foldername"). 936898 6 annma 2010-03-20 14:56:39 +0000 If someone has the source and can try the following patch: it fixes the trailing / (so it fixes the moving of folders when there is not the same named folder in the moved folder) Index: menufile.cpp =================================================================== --- menufile.cpp (revision 1105524) +++ menufile.cpp (working copy) @@ -408,14 +408,14 @@ commonMenuName += '/' + oldMenuParts[i]; } QString oldMenuName; - for(int j = i; j < oldMenuParts.count(); j++) + for(int j = i; j < oldMenuParts.count()-1; j++) { if (i != j) oldMenuName += '/'; oldMenuName += oldMenuParts[j]; } QString newMenuName; - for(int j = i; j < newMenuParts.count(); j++) + for(int j = i; j < newMenuParts.count()-1; j++) { if (i != j) newMenuName += '/'; 936901 7 annma 2010-03-20 15:02:15 +0000 *** Bug 229665 has been marked as a duplicate of this bug. *** 936903 8 annma 2010-03-20 15:05:47 +0000 *** Bug 102723 has been marked as a duplicate of this bug. *** 936906 9 annma 2010-03-20 15:07:14 +0000 *** Bug 110241 has been marked as a duplicate of this bug. *** 936918 10 annma 2010-03-20 15:12:58 +0000 *** Bug 186683 has been marked as a duplicate of this bug. *** 937529 11 annma 2010-03-21 09:44:26 +0000 Anyone tried the patch? What are the other obvious bugs with KMenuEdit in KDE 4.4? 938361 12 maris.kde 2010-03-22 13:08:11 +0000 (In reply to comment #11) > Anyone tried the patch? > > What are the other obvious bugs with KMenuEdit in KDE 4.4? AFAIK no. Could You, please, reformat patch as file in form suitable to apply directly to 4.4.1 release tarball? I have no idea where this "menu.cpp" file is located, still I can define a patch to apply after unpacking application and before compiling it (Gentoo here). 938372 13 annma 2010-03-22 13:19:33 +0000 menufile.cpp is in kdebase/workspace/kmenuedit/ and the patch is to be applied in that directory against 4.4.1 sources. I'll be away for 1 week starting tomorrow until 29 March evening without internet! 939151 14 maris.kde 2010-03-23 18:01:30 +0000 (In reply to comment #11) > Anyone tried the patch? > This patch works. After recompiling with this patch, moving folders in KMenuedit works just fine and generated .menu file is correct. 942371 15 annma 2010-03-30 10:33:33 +0000 SVN commit 1108974 by annma: Move folders correctly. Thanks a lot Maris for all the investigation and the patch testing, it's very nice of you having taken the time to research this bug! BUG=227836 M +2 -2 menufile.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1108974 943484 16 annma 2010-04-01 17:58:21 +0000 SVN commit 1110017 by annma: also in trunk! CCBUG=227836 M +2 -2 menufile.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1110017