226230 2010-02-11 01:06:17 +0000 Picture of the day does not work 2010-05-07 15:55:18 +0000 1 1 10 Unmaintained plasma4 widget-frame unspecified Arch Linux Unspecified RESOLVED FIXED NOR normal --- 1 mboquien plasma-bugs-null alex_monika annma etienne.rebetez magnus.bergmark mirza.dervisevic 0 oldest_to_newest 914567 0 mboquien 2010-02-11 01:06:17 +0000 Version: (using KDE 4.4.0) Installed from: Archlinux Packages Hello, The "picture of the day" in the Frame widget does not work. Steps to reproduce: * add Frame widget * configure to "picture of the day" and set any source The result is that the picture of the day is not displayed. When trying to configure again, the setting is back to "Image", as if the configuration had not been recorded. I have this problem in 4.3 and 4.4. I think it worked in 4.2. Thanks! 929198 1 etienne.rebetez 2010-03-05 23:32:23 +0000 I can confim this. I found the source oft the setting bug. The Frame::stopPotd() is caled befor the setting is saved. In that function the "picture of the day" setting is removed. But the image will still not load... 929541 2 alex_monika 2010-03-06 17:46:29 +0000 not working too 931871 3 mirza.dervisevic 2010-03-11 12:46:52 +0000 Not working for me too :( 945522 4 42517 etienne.rebetez 2010-04-06 00:14:12 +0000 Created attachment 42517 Patch that makes potd work again. Two little things where wrong. - The potd Setting was not handlet correctly. (See Comment 1) - The datahash from the dataengine was always taken form the first position, where it obviusly not was. When it is adressed with the name, it works. Some data engine sources dont't seem to work anymore, but that's an other story. 946025 5 42548 etienne.rebetez 2010-04-06 19:49:46 +0000 Created attachment 42548 Picture of the Day Patch Didn't test it with a fresh picture frame... The default text is now removed when a potd is loaded. I had to add a setMessage function in the picture class. Sorry for my spam :/ 946223 6 annma 2010-04-07 10:57:30 +0000 SVN commit 1112069 by annma: Patch from Etienne, thanks a lot! :-) CCBUG=226230 M +1 -1 frame.cpp M +5 -0 picture.cpp M +1 -0 picture.h M +4 -3 slideshow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1112069 946287 7 annma 2010-04-07 13:45:31 +0000 SVN commit 1112110 by annma: fix Picture of the Day display, thanks to Etienne! BUG=226230 M +1 -1 frame.cpp M +5 -0 picture.cpp M +1 -0 picture.h M +3 -2 slideshow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1112110 957848 8 magnus.bergmark 2010-05-06 19:20:20 +0000 (In reply to comment #6) > SVN commit 1112069 by annma: > [...] > WebSVN link: http://websvn.kde.org/?view=rev&revision=1112069 Sorry to nitpick, but there's a spelling error in the diff for slideshow.cpp: "No Picture fot this Provider." Note "fot" instead of "for". It's still present in trunk as of this posting. 957974 9 etienne.rebetez 2010-05-07 01:38:31 +0000 Thanks. Yes, i never see typos. But, it was alredy corrected by annma. It says "No Picture from this Provider" which sounds good to me. 958039 10 magnus.bergmark 2010-05-07 08:28:38 +0000 (In reply to comment #9) > Thanks. Yes, i never see typos. > But, it was alredy corrected by annma. > It says "No Picture from this Provider" which sounds good to me. Maybe I misread it, but to me it looked like the correct spelling was in the 4.4 branch only, while the improperly spelt one was in trunk. Maybe I'm not understanding the repo structure here, but wouldn't that mean that the spelling error will be reintroduced in 4.5 and above? 958070 11 annma 2010-05-07 10:09:21 +0000 Magnus, what is your revision number for trunk? For me rev 1123638 I have m_picture->setMessage(i18n("No Picture from this Provider.")); line 203 slideshow.cpp in trunk Find out with 'svn info' in your kdeplasma-addons trunk source please. Also in the same dir please do: grep -ri 'fot this ' ./ 958118 12 magnus.bergmark 2010-05-07 12:56:26 +0000 (In reply to comment #11) > Magnus, what is your revision number for trunk? Oh, I don't have it checked out or anything. I just looked at the above websvn link. One of them were for trunk and the other for branch 4.4, and the spelling error were only present in the trunk one. > For me rev 1123638 I have > m_picture->setMessage(i18n("No Picture from this Provider.")); > line 203 slideshow.cpp in trunk Then I trust that is correct. :-) 958120 13 annma 2010-05-07 13:20:11 +0000 Actually looking at websvn would have told you http://websvn.kde.org/trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp?r1=1112069&r2=1112105 958227 14 magnus.bergmark 2010-05-07 15:55:18 +0000 (In reply to comment #13) > Actually looking at websvn would have told you > http://websvn.kde.org/trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp?r1=1112069&r2=1112105 I guess so. That diff was not linked to from here, and I'm just a user trying to help. 42517 2010-04-06 00:14:12 +0000 2010-04-06 19:49:46 +0000 Patch that makes potd work again. potd.patch text/plain 1275 etienne.rebetez SW5kZXg6IHNsaWRlc2hvdy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc2xpZGVzaG93LmNwcAkoUmV2aXNp b24gMTExMTUyMCkKKysrIHNsaWRlc2hvdy5jcHAJKEFyYmVpdHNrb3BpZSkKQEAgLTE5NiwxNiAr MTk2LDE1IEBACiAKIHZvaWQgU2xpZGVTaG93OjpkYXRhVXBkYXRlZChjb25zdCBRU3RyaW5nICZu YW1lLCBjb25zdCBQbGFzbWE6OkRhdGFFbmdpbmU6OkRhdGEgJmRhdGEpCiB7Ci0gICAgUV9VTlVT RUQobmFtZSkKICAgICBpZiAoZGF0YS5pc0VtcHR5KCkpIHsKICAgICAgICAgbV9pbWFnZSA9IFFJ bWFnZSgpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgbV9pbWFnZSA9IGRhdGFbMF0u dmFsdWU8UUltYWdlPigpOworICAgIG1faW1hZ2UgPSBkYXRhW25hbWVdLnZhbHVlPFFJbWFnZT4o KTsKICAgICAvL0NvbXBhdGliaWxpdHkgd2l0aCBvbGQgZGF0YWVuZ2luZXMKICAgICBpZiAobV9p bWFnZS5pc051bGwoKSl7Ci0gICAgICAgIFFQaXhtYXAgdG1wUGl4bWFwID0gZGF0YVswXS52YWx1 ZTxRUGl4bWFwPigpOworICAgICAgICBRUGl4bWFwIHRtcFBpeG1hcCA9IGRhdGFbbmFtZV0udmFs dWU8UVBpeG1hcD4oKTsKICAgICAgICAgaWYgKCF0bXBQaXhtYXAuaXNOdWxsKCkpewogICAgICAg ICAgICAgbV9pbWFnZSA9IHRtcFBpeG1hcC50b0ltYWdlKCk7CiAgICAgICAgIH0KSW5kZXg6IGZy YW1lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBmcmFtZS5jcHAJKFJldmlzaW9uIDExMTE1MjApCisrKyBm cmFtZS5jcHAJKEFyYmVpdHNrb3BpZSkKQEAgLTU2NCw3ICs1NjQsNiBAQAogICAgIFFEYXRlIG1D dXJyZW50RGF0ZSA9IFFEYXRlOjpjdXJyZW50RGF0ZSgpOwogICAgIGNvbnN0IFFTdHJpbmcgaWRl bnRpZmllciA9IG1fcG90ZFByb3ZpZGVyICsgJzonICsgbUN1cnJlbnREYXRlLnRvU3RyaW5nKFF0 OjpJU09EYXRlKTsKICAgICBlbmdpbmUtPmRpc2Nvbm5lY3RTb3VyY2UoaWRlbnRpZmllciwgbV9t eVNsaWRlU2hvdyk7Ci0gICAgbV9wb3RkID0gZmFsc2U7CiB9CiAKIHZvaWQgRnJhbWU6OmluaXRT bGlkZVNob3coKQpAQCAtNjI0LDYgKzYyMyw3IEBACiAgICAgfQogCiAgICAgc3RvcFBvdGQoKTsK KyAgICBtX3BvdGQgPSBmYWxzZTsKICAgICBpbml0U2xpZGVTaG93KCk7CiAKICAgICBLQ29uZmln R3JvdXAgY2cgPSBjb25maWcoKTsK 42548 2010-04-06 19:49:46 +0000 2010-04-06 19:49:46 +0000 Picture of the Day Patch potd.patch text/plain 2194 etienne.rebetez SW5kZXg6IHNsaWRlc2hvdy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc2xpZGVzaG93LmNwcAkoUmV2aXNp b24gMTExMTc5NykKKysrIHNsaWRlc2hvdy5jcHAJKEFyYmVpdHNrb3BpZSkKQEAgLTE5NiwyMCAr MTk2LDIxIEBACiAKIHZvaWQgU2xpZGVTaG93OjpkYXRhVXBkYXRlZChjb25zdCBRU3RyaW5nICZu YW1lLCBjb25zdCBQbGFzbWE6OkRhdGFFbmdpbmU6OkRhdGEgJmRhdGEpCiB7Ci0gICAgUV9VTlVT RUQobmFtZSkKICAgICBpZiAoZGF0YS5pc0VtcHR5KCkpIHsKICAgICAgICAgbV9pbWFnZSA9IFFJ bWFnZSgpOworICAgICAgICBtX3BpY3R1cmUtPnNldE1lc3NhZ2UoaTE4bigiTm8gUGljdHVyZSBm b3QgdGhpcyBQcm92aWRlci4iKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBtX2lt YWdlID0gZGF0YVswXS52YWx1ZTxRSW1hZ2U+KCk7CisgICAgbV9pbWFnZSA9IGRhdGFbbmFtZV0u dmFsdWU8UUltYWdlPigpOwogICAgIC8vQ29tcGF0aWJpbGl0eSB3aXRoIG9sZCBkYXRhZW5naW5l cwogICAgIGlmIChtX2ltYWdlLmlzTnVsbCgpKXsKLSAgICAgICAgUVBpeG1hcCB0bXBQaXhtYXAg PSBkYXRhWzBdLnZhbHVlPFFQaXhtYXA+KCk7CisgICAgICAgIFFQaXhtYXAgdG1wUGl4bWFwID0g ZGF0YVtuYW1lXS52YWx1ZTxRUGl4bWFwPigpOwogICAgICAgICBpZiAoIXRtcFBpeG1hcC5pc051 bGwoKSl7CiAgICAgICAgICAgICBtX2ltYWdlID0gdG1wUGl4bWFwLnRvSW1hZ2UoKTsKICAgICAg ICAgfQogICAgIH0KKyAgICBtX3BpY3R1cmUtPnNldE1lc3NhZ2UoUVN0cmluZygpKTsKICAgICBl bWl0IHBpY3R1cmVVcGRhdGVkKCk7CiB9CiAKSW5kZXg6IHBpY3R1cmUuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIHBpY3R1cmUuY3BwCShSZXZpc2lvbiAxMTExNzk3KQorKysgcGljdHVyZS5jcHAJKEFyYmVp dHNrb3BpZSkKQEAgLTU3LDYgKzU3LDExIEBACiAgICAgcmV0dXJuIG1fbWVzc2FnZTsKIH0KIAor dm9pZCBQaWN0dXJlOjpzZXRNZXNzYWdlKGNvbnN0IFFTdHJpbmcgJm1lc3NhZ2UpCit7CisgICAg bV9tZXNzYWdlID0gbWVzc2FnZTsKK30KKwogUUltYWdlIFBpY3R1cmU6OmRlZmF1bHRQaWN0dXJl KGNvbnN0IFFTdHJpbmcgJm1lc3NhZ2UpCiB7CiAgICAgLy8gQ3JlYXRlIGEgUUltYWdlIHdpdGgg c2FtZSBheHBlY3QgcmF0aW8gb2YgZGVmYXVsdCBzdmcgYW5kIGN1cnJlbnQgcGl4ZWxTaXplCklu ZGV4OiBwaWN0dXJlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGljdHVyZS5oCShSZXZpc2lvbiAxMTExNzk3 KQorKysgcGljdHVyZS5oCShBcmJlaXRza29waWUpCkBAIC01Myw2ICs1Myw3IEBACiAgICAgS0lP OjpTdG9yZWRUcmFuc2ZlckpvYiAqIG1fam9iOwogICAgIEtVcmwgdXJsKCk7CiAgICAgUVN0cmlu ZyBtZXNzYWdlKCk7CisgICAgdm9pZCBzZXRNZXNzYWdlKGNvbnN0IFFTdHJpbmcgJm1lc3NhZ2Up OwogCiBRX1NJR05BTFM6CiAgICAgdm9pZCBwaWN0dXJlTG9hZGVkKFFJbWFnZSBpbWFnZSk7Cklu ZGV4OiBmcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZnJhbWUuY3BwCShSZXZpc2lvbiAxMTExNzk3 KQorKysgZnJhbWUuY3BwCShBcmJlaXRza29waWUpCkBAIC01NjQsNyArNTY0LDYgQEAKICAgICBR RGF0ZSBtQ3VycmVudERhdGUgPSBRRGF0ZTo6Y3VycmVudERhdGUoKTsKICAgICBjb25zdCBRU3Ry aW5nIGlkZW50aWZpZXIgPSBtX3BvdGRQcm92aWRlciArICc6JyArIG1DdXJyZW50RGF0ZS50b1N0 cmluZyhRdDo6SVNPRGF0ZSk7CiAgICAgZW5naW5lLT5kaXNjb25uZWN0U291cmNlKGlkZW50aWZp ZXIsIG1fbXlTbGlkZVNob3cpOwotICAgIG1fcG90ZCA9IGZhbHNlOwogfQogCiB2b2lkIEZyYW1l Ojppbml0U2xpZGVTaG93KCkKQEAgLTYyNCw2ICs2MjMsNyBAQAogICAgIH0KIAogICAgIHN0b3BQ b3RkKCk7CisgICAgbV9wb3RkID0gZmFsc2U7CiAgICAgaW5pdFNsaWRlU2hvdygpOwogCiAgICAg S0NvbmZpZ0dyb3VwIGNnID0gY29uZmlnKCk7Cg==