221830 2010-01-08 18:24:31 +0000 auto mode scroollbars in form textarea 2010-03-02 10:28:10 +0000 1 1 2 Applications konqueror khtml unspecified Compiled Sources Linux RESOLVED FIXED NOR wishlist --- 0 aiacovitti konqueror-bugs-null frank78ac germain 0 oldest_to_newest 894654 0 aiacovitti 2010-01-08 18:24:31 +0000 Version: (using Devel) OS: Linux Installed from: Compiled sources Please consider to apply attached patch to enable 'ScrollBarAsNeeded' in form TextArea, to match firefox behaviour. A test page to see the differences between FF and Konq will be http://www.tizag.com/htmlT/htmltextarea.php IMO text areas will look nicer... Regard, Andrea 894657 1 39696 aiacovitti 2010-01-08 18:25:53 +0000 Created attachment 39696 patch 896129 2 frank78ac 2010-01-10 22:53:06 +0000 Thanks for the report and patch. The issue has been reported a while ago already. *** This bug has been marked as a duplicate of bug 173585 *** 911266 3 germain 2010-02-04 12:23:02 +0000 @andrea: fwiw, I agree with the patch. The idea initially was to have form widgets clearly identified in any circumstances, has an accessibility helper. This is no longer much of an issue since we have removed most of the other styling limitations on other widgets, so this is now inconsistent (until I get around introducing that accessibility option I think about) could you possibly get an svn account and commit this yourself? thanks 911392 4 aiacovitti 2010-02-04 18:21:54 +0000 > could you possibly get an svn account and commit this yourself? > thanks Thank you for the trust, but probably will not right away.... In the meantime, you can apply the patch if you want. Cheers, Andrea. 916548 5 aiacovitti 2010-02-14 13:12:33 +0000 SVN commit 1090000 by aiacovitti: Do not display scroll bars on textarea elements when not necessary. Match other browsers behaviour. Approved by Germain. BUG: 221830 CCBUG: 173585 M +7 -8 render_form.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1090000 917928 6 germain 2010-02-16 05:24:04 +0000 thanks for applying eventually and commiting the fix, sorry I didn't respond beforehand. As you might guess this isn't so much a matter of trust (KDE doesn't have much of a commit-access-is-sacred mindset ; it rather put the emphasis on responsibility for one's commits) as a matter of being really very few people to handle patches. If you haven't noticed, KHTML hacking is unpopular ; it annoys a lot of people. *Don Giovanni's Commantore theme* 920778 7 germain 2010-02-20 02:13:05 +0000 SVN commit 1093037 by ggarand: automatically merged revision 1090000: Do not display scroll bars on textarea elements when not necessary. Match other browsers behaviour. Approved by Germain. BUG: 221830 CCBUG: 173585 M +7 -8 render_form.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1093037 927076 8 germain 2010-03-02 10:28:10 +0000 SVN commit 1097847 by ggarand: got a better idea here: instead of letting the textarea be always ScrollBarAsNeeded, we may mirror the overflow-x/y property and default to overflow-y:scroll This matches MSIE7 so should be perfectly compatible with sites that want to turn the scrollbars to auto for cosmetic reasons (with overflow:auto), while retaining as default the very nice "this is a form widget" accessibility hint that the vertical scrollbar naturally provides. CCBUG: 221830 M +1 -0 css/html4.css M +13 -0 rendering/render_form.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1097847 39696 2010-01-08 18:25:53 +0000 2010-01-08 18:25:53 +0000 patch TextAreaForm_ScrollBarAsNeeded.diff text/plain 969 aiacovitti LS0tIGtodG1sL3JlbmRlcmluZy9yZW5kZXJfZm9ybS5jcHAJMjAxMC0wMS0wNyAxODozOToxNi4w MDAwMDAwMDAgKzAxMDAKKysrIGtodG1sL3JlbmRlcmluZy9yZW5kZXJfZm9ybS5jcHAJMjAxMC0w MS0wNyAxODozOToxNi4wMDAwMDAwMDAgKzAxMDAKQEAgLTE5NzcsMTYgKzE5NzcsMTUgQEAKICAg ICA6IEtUZXh0RWRpdChwYXJlbnQpCiB7CiAgICAgbV9rd3AtPnNldElzUmVkaXJlY3RlZCggdHJ1 ZSApOwotICAgIGlmKHdyYXAgIT0gRE9NOjpIVE1MVGV4dEFyZWFFbGVtZW50SW1wbDo6dGFfTm9X cmFwKSB7CisKKyAgICBpZih3cmFwICE9IERPTTo6SFRNTFRleHRBcmVhRWxlbWVudEltcGw6OnRh X05vV3JhcCkKICAgICAgICAgc2V0TGluZVdyYXBNb2RlKFFUZXh0RWRpdDo6V2lkZ2V0V2lkdGgp OwotICAgICAgICBzZXRIb3Jpem9udGFsU2Nyb2xsQmFyUG9saWN5KCBRdDo6U2Nyb2xsQmFyQWx3 YXlzT2ZmICk7Ci0gICAgICAgIHNldFZlcnRpY2FsU2Nyb2xsQmFyUG9saWN5KCBRdDo6U2Nyb2xs QmFyQWx3YXlzT24gKTsKLSAgICB9Ci0gICAgZWxzZSB7CisgICAgZWxzZQogICAgICAgICBzZXRM aW5lV3JhcE1vZGUoUVRleHRFZGl0OjpOb1dyYXApOwotICAgICAgICBzZXRIb3Jpem9udGFsU2Ny b2xsQmFyUG9saWN5KCBRdDo6U2Nyb2xsQmFyQXNOZWVkZWQgKTsKLSAgICAgICAgc2V0VmVydGlj YWxTY3JvbGxCYXJQb2xpY3koIFF0OjpTY3JvbGxCYXJBc05lZWRlZCApOwotICAgIH0KKworICAg IHNldEhvcml6b250YWxTY3JvbGxCYXJQb2xpY3koIFF0OjpTY3JvbGxCYXJBc05lZWRlZCApOwor ICAgIHNldFZlcnRpY2FsU2Nyb2xsQmFyUG9saWN5KCBRdDo6U2Nyb2xsQmFyQXNOZWVkZWQgKTsK KwogICAgIEtDdXJzb3I6OnNldEF1dG9IaWRlQ3Vyc29yKHZpZXdwb3J0KCksIHRydWUpOwogICAg IHNldEFjY2VwdFJpY2hUZXh0IChmYWxzZSk7CiAgICAgc2V0TW91c2VUcmFja2luZyh0cnVlKTsK