218353 2009-12-12 04:04:32 +0000 LDAP directory contacts cannot be modified 2009-12-13 18:12:45 +0000 1 1 2 Applications kdepimlibs kldap 4.3 Ubuntu Linux RESOLVED FIXED NOR normal --- 0 rdratlos pim-bugs-null 0 oldest_to_newest 878284 0 rdratlos 2009-12-12 04:04:32 +0000 Version: (using KDE 4.3.2) OS: Linux Installed from: Ubuntu Packages I tested kaddressbook (4.3) as front-end to manage contacts in a LDAP directory (addressbook). The server runs openldap 2.4. kaddressbook perfectly adds and deletes contacts. But it fails to modify attribute values of a contact within the LDAP directory. After changing e. g. the facsimile number of a contact, kaddressbook shows the updated number but the new number is not saved in the LDAP directory. OpenLDAP reports following failure: 'value #0 invalid per syntax'. kaddressbook uses kdepimlibs for communication with the LDAP server. kdepimlibs use the modify->replace operation of the LDAP protocol for modification of attribute values. In case of empty attributes (especially numbers) kdepimlibs does not comply to IETF RFC 2849. After the replace <attribute name> statement kdepimlibs adds an empty line before end of operation ('-'). When parsing such a request, the LDAP server reports the above mentioned error notification and denies the complete modification request. kaddressbook does not report this problem to the user. 878288 1 rdratlos 2009-12-12 04:18:02 +0000 Correction: kdepimlibs does not add an empty line but the attribute name without a value. This is not allowed by RFC 2849. 878289 2 39004 rdratlos 2009-12-12 04:27:15 +0000 Created attachment 39004 Patch for kdepimlibs proposed patch 878290 3 rdratlos 2009-12-12 04:28:12 +0000 There seems to be a simple fix for this problem. The kabc plugin ldapkio within kdepimlibs has a private addEntry method that can be changed to solve this bug. It resides in the file resourceldapkio.cpp. The addEntry method should check itself (again), if the calling function has handed over a value for a particular attribute or not. If not, the attribute name should not be added (and afterwards sent to the LDAP directory). This applies for modification (i. e. replace) operations and add operations. I've tested this solution under Ubuntu karmic and it works fine. Attribute values can be added, modified and deleted again. Attached there is the patch I've applied. I have not identified further side-effects of this patch. But I recommed some further testing. 879072 4 winter 2009-12-13 16:20:07 +0000 SVN commit 1062016 by winterz: Fix "LDAP directory contents cannot be modified" Thanks to the patch from rdratlos@yahoo.co.uk BUG: 218353 MERGE: 4.3,e4 M +3 -1 resourceldapkio.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1062016 879126 5 winter 2009-12-13 18:12:45 +0000 SVN commit 1062059 by winterz: Backport r1062016 by winterz from trunk to the 4.3 branch: Fix "LDAP directory contents cannot be modified" Thanks to the patch from rdratlos@yahoo.co.uk CCBUG: 218353 MERGE: 4.3,e4 M +3 -1 resourceldapkio.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1062059 39004 2009-12-12 04:27:15 +0000 2009-12-12 04:27:15 +0000 Patch for kdepimlibs kdepimlibs-4.3.2.patch text/plain 540 rdratlos LS0tIGtkZXBpbWxpYnMtNC4zLjIub3JpZy9rYWJjL3BsdWdpbnMvbGRhcGtpby9yZXNvdXJjZWxk YXBraW8uY3BwCTIwMDktMDItMTggMTc6Mjg6MzIuMDAwMDAwMDAwICswMTAwCisrKyBrZGVwaW1s aWJzLTQuMy4yL2thYmMvcGx1Z2lucy9sZGFwa2lvL3Jlc291cmNlbGRhcGtpby5jcHAJMjAwOS0x Mi0xMSAwOToxMDowMy4wMDAwMDAwMDAgKzAxMDAKQEAgLTIxNiw3ICsyMTYsOSBAQAogICAgIGlm ICggbW9kICkgewogICAgICAgdG1wICs9IEtMREFQOjpMZGlmOjphc3NlbWJsZUxpbmUoIFFMYXRp bjFTdHJpbmcoICJyZXBsYWNlIiApLCBhdHRyICkgKyAnXG4nOwogICAgIH0KLSAgICB0bXAgKz0g S0xEQVA6OkxkaWY6OmFzc2VtYmxlTGluZSggYXR0ciwgdmFsdWUgKSArICdcbic7CisgICAgaWYg KCAhdmFsdWUuaXNFbXB0eSgpICkgeworICAgICAgdG1wICs9IEtMREFQOjpMZGlmOjphc3NlbWJs ZUxpbmUoIGF0dHIsIHZhbHVlICkgKyAnXG4nOworICAgIH0gIAogICAgIGlmICggbW9kICkgewog ICAgICAgdG1wICs9ICItXG4iOwogICAgIH0K