217201 2009-12-03 14:36:28 +0000 green progress circle doesn't accurate work for >= 1h 2013-10-29 23:57:38 +0000 1 1 2 Applications kteatime general unspecified Debian testing Unspecified RESOLVED DUPLICATE 275598 NOR normal --- 1 schwarzer kde kde xdunlapx 20 oldest_to_newest 872802 0 schwarzer 2009-12-03 14:36:28 +0000 Version: (using KDE 4.3.2) Installed from: Debian testing/unstable Packages The green progress circle doesn't show the right proportions if you set up 2 hours anonymously. 872932 1 finex 2009-12-03 18:57:20 +0000 *** Bug 217202 has been marked as a duplicate of this bug. *** 1088935 2 xdunlapx 2011-02-18 00:58:43 +0000 The problem is with exactly 1 hour or above. It is inaccurate. For example if set for one hour, at 30 minutes it shows approximately 15 minutes left on the circle indicator. 1094775 3 57773 kde 2011-03-08 13:44:07 +0000 Created attachment 57773 Proposed patch to solve the problem Different drawPie arguments 1095317 4 kde 2011-03-09 13:47:15 +0000 The statement p.drawPie( rectangle, 90*16, -(360 * 16 * m_runningTeaTime) / m_runningTea.time() ); is not yet completely correct, because with larger values we run into overflows. The correct statement has to be p.drawPie( rectangle, 90*16, -(360L * 16L * m_runningTeaTime) / m_runningTea.time() ); Because openSUSE currently updates to 4.6.1 in the Release repos, I cannot test it using kteatime directly. But a small test program shows proper results going down (or better up) from -5758 (-359 degrees) to 0 for all selected times up to several hours (I think it's 27 hours on a 32 bit system, even more on a 64 bit system). 1098449 5 58137 kde 2011-03-18 10:32:55 +0000 Created attachment 58137 KTeaTime integer overflow fix Fixes integer overflow by casting m_runningTeaTime indirectly to long by multiplying it by 360L * 16L. 1313242 6 kde 2012-11-07 07:52:39 +0000 The bug seems to be fixed for quite some time now. Tested with different KDE versions since 4.5. Could please somebody verify this and evt. set it to RESOLVED? 1407388 7 cfeck 2013-10-29 23:57:38 +0000 *** This bug has been marked as a duplicate of bug 275598 *** 57773 2011-03-08 13:44:07 +0000 2011-03-08 13:44:07 +0000 Proposed patch to solve the problem kteatime.diff text/plain 857 kde ZGlmZiAtLWdpdCBhL2t0ZWF0aW1lL3NyYy90b3BsZXZlbC5jcHAgYi9rdGVhdGltZS9zcmMvdG9w bGV2ZWwuY3BwCmluZGV4IGNhM2I1YWUuLjRiMmM5NmUgMTAwNjQ0Ci0tLSBhL2t0ZWF0aW1lL3Ny Yy90b3BsZXZlbC5jcHAKKysrIGIva3RlYXRpbWUvc3JjL3RvcGxldmVsLmNwcApAQCAtMTYsNiAr MTYsNyBAQAogICogWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdl bmVyYWwgUHVibGljIExpY2Vuc2UKICAqIGFsb25nIHdpdGggdGhpcyBwcm9ncmFtLiAgSWYgbm90 LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+LgogICovCisKICNpbmNsdWRlICJ0 b3BsZXZlbC5oIgogI2luY2x1ZGUgInRpbWVlZGl0LmgiCiAjaW5jbHVkZSAic2V0dGluZ3MuaCIK QEAgLTI0Niw3ICsyNDcsNyBAQCB2b2lkIFRvcExldmVsOjpyZXBhaW50VHJheUljb24oKQogCiAg ICAgICAgIGlmKCBtX3J1bm5pbmdUZWFUaW1lID4gMCApIHsKICAgICAgICAgICAgIHAuc2V0QnJ1 c2goIFFDb2xvcigyNTUsIDAsIDAsIDE5MCkgKTsKLSAgICAgICAgICAgIHAuZHJhd1BpZSggcmVj dGFuZ2xlLCA5MCoxNiwgLSggMzYwKjE2IC8gbV9ydW5uaW5nVGVhLnRpbWUoKSAqIG1fcnVubmlu Z1RlYVRpbWUgKSApOworICAgICAgICAgICAgcC5kcmF3UGllKCByZWN0YW5nbGUsIDkwKjE2LCAt KDM2MCAqIDE2ICogbV9ydW5uaW5nVGVhVGltZSkgLyBtX3J1bm5pbmdUZWEudGltZSgpICk7CiAg ICAgICAgIH0KICAgICAgICAgZWxzZSBpZiggKG1fcnVubmluZ1RlYVRpbWUgKiAtMSkgJSAyID09 IDAgKSB7CiAgICAgICAgICAgIHAuc2V0QnJ1c2goIFFDb2xvciggMjU1LCAwLCAwLCAxOTAgKSAp Owo= 58137 2011-03-18 10:32:55 +0000 2011-03-18 10:32:55 +0000 KTeaTime integer overflow fix kteatime.diff text/plain 614 kde ZGlmZiAtLWdpdCBhL2t0ZWF0aW1lL3NyYy90b3BsZXZlbC5jcHAgYi9rdGVhdGltZS9zcmMvdG9w bGV2ZWwuY3BwCmluZGV4IGNhM2I1YWUuLjA4YjkyMjggMTAwNjQ0Ci0tLSBhL2t0ZWF0aW1lL3Ny Yy90b3BsZXZlbC5jcHAKKysrIGIva3RlYXRpbWUvc3JjL3RvcGxldmVsLmNwcApAQCAtMjQ2LDcg KzI0Niw3IEBAIHZvaWQgVG9wTGV2ZWw6OnJlcGFpbnRUcmF5SWNvbigpCiAKICAgICAgICAgaWYo IG1fcnVubmluZ1RlYVRpbWUgPiAwICkgewogICAgICAgICAgICAgcC5zZXRCcnVzaCggUUNvbG9y KDI1NSwgMCwgMCwgMTkwKSApOwotICAgICAgICAgICAgcC5kcmF3UGllKCByZWN0YW5nbGUsIDkw KjE2LCAtKCAzNjAqMTYgLyBtX3J1bm5pbmdUZWEudGltZSgpICogbV9ydW5uaW5nVGVhVGltZSAp ICk7CisJICAgIHAuZHJhd1BpZSggcmVjdGFuZ2xlLCA5MCoxNiwgLSgzNjBMICogMTZMICogbV9y dW5uaW5nVGVhVGltZSkgLyBtX3J1bm5pbmdUZWEudGltZSgpICk7CiAgICAgICAgIH0KICAgICAg ICAgZWxzZSBpZiggKG1fcnVubmluZ1RlYVRpbWUgKiAtMSkgJSAyID09IDAgKSB7CiAgICAgICAg ICAgIHAuc2V0QnJ1c2goIFFDb2xvciggMjU1LCAwLCAwLCAxOTAgKSApOwo=