215352 2009-11-20 00:46:36 +0000 Undo after won is allowed 2012-01-10 21:52:19 +0000 1 1 2 Applications kmahjongg general 0.8 Ubuntu Linux RESOLVED FIXED NOR normal --- 0 frg10 piacentini CerebrosuS kde-games-bugs-null KDE 4.9 0 oldest_to_newest 865223 0 frg10 2009-11-20 00:46:36 +0000 Version: 0.8 (using KDE 4.3.2) OS: Linux Installed from: Ubuntu Packages It is possible to undo move after winnig a game. Following steps to reproduce: 1) Win a game 2) Wait until the end of animation 3) Press "Undo" 4) Remove the last pair 5) Win AGAIN! New result will be placed in High Scores list. 1190550 1 66073 CerebrosuS 2011-11-25 18:53:33 +0000 Created attachment 66073 Solve the reported bug. 1212724 2 CerebrosuS 2012-01-10 21:49:50 +0000 SVN commit 1273015 by krippendorf: Undo after game won - Bug After a game is won, the application is set into "finished"-mode and no undo actions are allowed anymore. FIXED-IN: KDE 4.9 REVIEW: 6841 M +13 -1 kmahjongg.cpp M +1 -0 kmahjongg.h M +17 -0 kmahjonggui.rc WebSVN link: http://websvn.kde.org/?view=rev&revision=1273015 66073 2011-11-25 18:53:33 +0000 2011-11-25 18:53:33 +0000 Solve the reported bug. UndoAfterFinish.diff text/plain 1131 CerebrosuS SW5kZXg6IGttYWhqb25nZy9rbWFoam9uZ2cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGttYWhqb25nZy9r bWFoam9uZ2cuY3BwCShSZXZpc2lvbiAxMjY1NzY1KQorKysga21haGpvbmdnL2ttYWhqb25nZy5j cHAJKEFyYmVpdHNrb3BpZSkKQEAgLTM5Myw5ICszOTMsNyBAQAogICAgICAgICBpZihrc2RpYWxv Zy5hZGRTY29yZSggc2NvcmVJbmZvLCBLU2NvcmVEaWFsb2c6OkFza05hbWUgKSkKICAgICAgICAg ICBrc2RpYWxvZy5leGVjKCk7CiAKLQlidy0+YW5pbWF0ZU1vdmVMaXN0KCk7Ci0KLQl0aW1lclJl c2V0KCk7CisgICAgYnctPmFuaW1hdGVNb3ZlTGlzdCgpOwogfQogCiAvLyAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KSW5kZXg6IGttYWhq b25nZy9ib2FyZHdpZGdldC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga21haGpvbmdnL2JvYXJkd2lkZ2V0 LmNwcAkoUmV2aXNpb24gMTI2NTc2NSkKKysrIGttYWhqb25nZy9ib2FyZHdpZGdldC5jcHAJKEFy YmVpdHNrb3BpZSkKQEAgLTM5OSw3ICszOTksMTMgQEAKIHsKICAgICBjYW5jZWxVc2VyU2VsZWN0 ZWRUaWxlcygpOwogCi0gICAgaWYoIEdhbWUtPlRpbGVOdW0gPCBHYW1lLT5NYXhUaWxlTnVtICkK KyAgICAvLyBJZiB0aGVyZSBhcmUgbm8gdGlsZXMgb24gdGhlIGJvYXJkLiBUaGUgZ2FtZSBoYXMg ZmluaXNoZWQgYW5kIG5vIHVuZG8gaXMgYWxsb3dlZC4KKyAgICBpZiAoR2FtZS0+VGlsZU51bSA9 PSAwKSB7CisgICAgICAgIHNldFN0YXR1c1RleHQoaTE4bigiTm8gdW5kbyBhbGxvd2VkLCBjYXVz ZSB5b3VyIGdhbWUgaGFzIGZpbmlzaGVkISIpKTsKKyAgICAgICAgcmV0dXJuIDA7CisgICAgfQor CisgICAgaWYoIEdhbWUtPlRpbGVOdW0gPCBHYW1lLT5NYXhUaWxlTnVtKQogICAgIHsKIAogICAg ICAgICBHYW1lLT5jbGVhclJlbW92ZWRUaWxlUGFpcihHYW1lLT5Nb3ZlTGlzdERhdGEoR2FtZS0+ VGlsZU51bSksIEdhbWUtPk1vdmVMaXN0RGF0YShHYW1lLT5UaWxlTnVtKzEpKTsK