195555 2009-06-07 13:33:13 +0000 Add a new option to use a constant scrolling speed with Kenburns effect [patch] 2021-03-09 03:05:30 +0000 1 1 2 Applications digikam Plugin-Generic-Presentation unspecified openSUSE Linux RESOLVED FIXED NOR wishlist --- 0 sven.burmeister digikam-bugs-null caulier.gilles phuockhanhnk94 https://invent.kde.org/graphics/digikam/commit/5534eb9de615d88a9ccc6280114e72ecb9c9b0f3 7.2.0 0 oldest_to_newest 771372 0 sven.burmeister 2009-06-07 13:33:13 +0000 Version: 0.10 (using KDE 4.2.4) OS: Linux Installed from: SuSE RPMs If one uses the ken burns effect for the slideshow one gets different scrolling speeds for landscape and portrait pictures. If there was an option to have a constant speed, digikam would calculate a longer time for portrait pictures and thus have a constant speed no matter what size the picture has. I do not think it is necessary to have the exact same speed, i.e. if the pictures shown do not have the "normal" lenght-width ratios they would still have diffferent speeds. Maybe adding a drop-down to select the ratio 4:3, 16:9 etc. would already be enough to fit most users' needs. 2004811 1 caulier.gilles 2021-02-21 05:56:57 +0000 Hi Le, This Presentation tool entry sound like not to hard to implement as you start to know a little bit the plugin implementation now... Please take a look to see what's possible to do as junior job. Thanks in advance Gilles 2008094 2 136331 phuockhanhnk94 2021-03-02 23:36:49 +0000 Created attachment 136331 add option for constant speed of ken burns of presentation This patch will add an of option to make speed of ken burns equal in every image. Speed is calculated by time between two times of "swap image". By this moment, this time is same by all images. So the speed of motion is proportional with height of image. The option "Ken Burns Same Speed" will adjust the speed by ratio between height and width. By using this option, the speed of motion is same for all images. This option is implemented in widget "advanced" 2010887 3 caulier.gilles 2021-03-09 03:05:30 +0000 Git commit 5534eb9de615d88a9ccc6280114e72ecb9c9b0f3 by Gilles Caulier. Committed on 09/03/2021 at 03:02. Pushed by cgilles into branch 'master'. Apply patch #136331 for Phuoc Khanh Le to use the same visual Ken-Burns effects speed while playing Presentation on scrren. FIXED-IN: 7.2.0 M +1 -0 core/dplugins/generic/view/presentation/common/presentationcontainer.cpp M +1 -0 core/dplugins/generic/view/presentation/common/presentationcontainer.h M +2 -0 core/dplugins/generic/view/presentation/dialogs/presentation_advpage.cpp M +7 -0 core/dplugins/generic/view/presentation/dialogs/presentation_advpage.ui M +14 -4 core/dplugins/generic/view/presentation/opengl/presentationkb.cpp M +4 -0 core/dplugins/generic/view/presentation/opengl/presentationkb_p.h https://invent.kde.org/graphics/digikam/commit/5534eb9de615d88a9ccc6280114e72ecb9c9b0f3 136331 2021-03-02 23:36:49 +0000 2021-03-02 23:36:49 +0000 add option for constant speed of ken burns of presentation 195555.patch text/plain 6911 phuockhanhnk94 ZGlmZiAtLWdpdCBhL2NvcmUvZHBsdWdpbnMvZ2VuZXJpYy92aWV3L3ByZXNlbnRhdGlvbi9jb21t b24vcHJlc2VudGF0aW9uY29udGFpbmVyLmNwcCBiL2NvcmUvZHBsdWdpbnMvZ2VuZXJpYy92aWV3 L3ByZXNlbnRhdGlvbi9jb21tb24vcHJlc2VudGF0aW9uY29udGFpbmVyLmNwcAppbmRleCBmYTUz NzU4MGVhLi4zZjY4NDc5ODcxIDEwMDY0NAotLS0gYS9jb3JlL2RwbHVnaW5zL2dlbmVyaWMvdmll dy9wcmVzZW50YXRpb24vY29tbW9uL3ByZXNlbnRhdGlvbmNvbnRhaW5lci5jcHAKKysrIGIvY29y ZS9kcGx1Z2lucy9nZW5lcmljL3ZpZXcvcHJlc2VudGF0aW9uL2NvbW1vbi9wcmVzZW50YXRpb25j b250YWluZXIuY3BwCkBAIC02OSw2ICs2OSw3IEBAIFByZXNlbnRhdGlvbkNvbnRhaW5lcjo6UHJl c2VudGF0aW9uQ29udGFpbmVyKCkKICAgICAgIGVuYWJsZUNhY2hlICAgICAgICAgICAgICAgICAg IChmYWxzZSksCiAgICAgICBrYkRpc2FibGVGYWRlSW5PdXQgICAgICAgICAgICAoZmFsc2UpLAog ICAgICAga2JEaXNhYmxlQ3Jvc3NGYWRlICAgICAgICAgICAgKGZhbHNlKSwKKyAgICAgIGtiRW5h YmxlU2FtZVNwZWVkICAgICAgICAgICAgIChmYWxzZSksCiAgICAgICBjYWNoZVNpemUgICAgICAg ICAgICAgICAgICAgICAoMCksCiAKICAgICAgIGlmYWNlICAgICAgICAgICAgICAgICAgICAgICAg IChudWxscHRyKQpkaWZmIC0tZ2l0IGEvY29yZS9kcGx1Z2lucy9nZW5lcmljL3ZpZXcvcHJlc2Vu dGF0aW9uL2NvbW1vbi9wcmVzZW50YXRpb25jb250YWluZXIuaCBiL2NvcmUvZHBsdWdpbnMvZ2Vu ZXJpYy92aWV3L3ByZXNlbnRhdGlvbi9jb21tb24vcHJlc2VudGF0aW9uY29udGFpbmVyLmgKaW5k ZXggNWI0OTIwNGQ2Zi4uNjUyYzk3YTQwYyAxMDA2NDQKLS0tIGEvY29yZS9kcGx1Z2lucy9nZW5l cmljL3ZpZXcvcHJlc2VudGF0aW9uL2NvbW1vbi9wcmVzZW50YXRpb25jb250YWluZXIuaAorKysg Yi9jb3JlL2RwbHVnaW5zL2dlbmVyaWMvdmlldy9wcmVzZW50YXRpb24vY29tbW9uL3ByZXNlbnRh dGlvbmNvbnRhaW5lci5oCkBAIC0xMTAsNiArMTEwLDcgQEAgcHVibGljOgogICAgIGJvb2wgICAg ICAgICAgICAgICAgICAgICBlbmFibGVDYWNoZTsKICAgICBib29sICAgICAgICAgICAgICAgICAg ICAga2JEaXNhYmxlRmFkZUluT3V0OwogICAgIGJvb2wgICAgICAgICAgICAgICAgICAgICBrYkRp c2FibGVDcm9zc0ZhZGU7CisgICAgYm9vbCAgICAgICAgICAgICAgICAgICAgIGtiRW5hYmxlU2Ft ZVNwZWVkOwogICAgIHVpbnQgICAgICAgICAgICAgICAgICAgICBjYWNoZVNpemU7CiAKICAgICBE SW5mb0ludGVyZmFjZSogICAgICAgICAgaWZhY2U7CmRpZmYgLS1naXQgYS9jb3JlL2RwbHVnaW5z L2dlbmVyaWMvdmlldy9wcmVzZW50YXRpb24vZGlhbG9ncy9wcmVzZW50YXRpb25fYWR2cGFnZS5j cHAgYi9jb3JlL2RwbHVnaW5zL2dlbmVyaWMvdmlldy9wcmVzZW50YXRpb24vZGlhbG9ncy9wcmVz ZW50YXRpb25fYWR2cGFnZS5jcHAKaW5kZXggNGRkNTk3NWQ2OC4uMDBlYWE0ZGZlNyAxMDA2NDQK LS0tIGEvY29yZS9kcGx1Z2lucy9nZW5lcmljL3ZpZXcvcHJlc2VudGF0aW9uL2RpYWxvZ3MvcHJl c2VudGF0aW9uX2FkdnBhZ2UuY3BwCisrKyBiL2NvcmUvZHBsdWdpbnMvZ2VuZXJpYy92aWV3L3By ZXNlbnRhdGlvbi9kaWFsb2dzL3ByZXNlbnRhdGlvbl9hZHZwYWdlLmNwcApAQCAtNzEsNiArNzEs NyBAQCB2b2lkIFByZXNlbnRhdGlvbkFkdlBhZ2U6OnJlYWRTZXR0aW5ncygpCiAgICAgbV91c2VN aWxsaXNlY29uZHNDaGVja0JveC0+c2V0Q2hlY2tlZChtX3NoYXJlZERhdGEtPnVzZU1pbGxpc2Vj b25kcyk7CiAgICAgbV9rYkRpc2FibGVGYWRlQ2hlY2tCb3gtPnNldENoZWNrZWQobV9zaGFyZWRE YXRhLT5rYkRpc2FibGVGYWRlSW5PdXQpOwogICAgIG1fa2JEaXNhYmxlQ3Jvc3NmYWRlQ2hlY2tC b3gtPnNldENoZWNrZWQobV9zaGFyZWREYXRhLT5rYkRpc2FibGVDcm9zc0ZhZGUpOworICAgIG1f ZW5hYmxlS2VuQnVybnNTYW1lU3BlZWQtPnNldENoZWNrZWQobV9zaGFyZWREYXRhLT5rYkVuYWJs ZVNhbWVTcGVlZCk7CiAgICAgbV9vcGVuR2xGdWxsU2NhbGUtPnNldENoZWNrZWQobV9zaGFyZWRE YXRhLT5vcGVuR2xGdWxsU2NhbGUpOwogICAgIG1fb3BlbkdsRnVsbFNjYWxlLT5zZXRFbmFibGVk KG1fc2hhcmVkRGF0YS0+b3BlbmdsKTsKICAgICBtX3VzZU1pbGxpc2Vjb25kc0NoZWNrQm94LT5z ZXRFbmFibGVkKCFtX3NoYXJlZERhdGEtPm9mZkF1dG9EZWxheSk7ICAgICAgICAgLy8gTWlsbGlT ZWNvbmRzIENoZWNrYm94IGluIGFkdmFuY2VkIHBhZ2Ugb2ZmIHdoZW4gQXV0b0RlbGF5IGlzIE9u CkBAIC05MSw2ICs5Miw3IEBAIHZvaWQgUHJlc2VudGF0aW9uQWR2UGFnZTo6c2F2ZVNldHRpbmdz KCkKICAgICBtX3NoYXJlZERhdGEtPmVuYWJsZU1vdXNlV2hlZWwgICA9IG1fZW5hYmxlTW91c2VX aGVlbENoZWNrQm94LT5pc0NoZWNrZWQoKTsKICAgICBtX3NoYXJlZERhdGEtPmtiRGlzYWJsZUZh ZGVJbk91dCA9IG1fa2JEaXNhYmxlRmFkZUNoZWNrQm94LT5pc0NoZWNrZWQoKTsKICAgICBtX3No YXJlZERhdGEtPmtiRGlzYWJsZUNyb3NzRmFkZSA9IG1fa2JEaXNhYmxlQ3Jvc3NmYWRlQ2hlY2tC b3gtPmlzQ2hlY2tlZCgpOworICAgIG1fc2hhcmVkRGF0YS0+a2JFbmFibGVTYW1lU3BlZWQgID0g bV9lbmFibGVLZW5CdXJuc1NhbWVTcGVlZC0+aXNDaGVja2VkKCk7CiB9CiAKIHZvaWQgUHJlc2Vu dGF0aW9uQWR2UGFnZTo6c2xvdFVzZU1pbGxpc2Vjb25kc1RvZ2dsZWQoKQpkaWZmIC0tZ2l0IGEv Y29yZS9kcGx1Z2lucy9nZW5lcmljL3ZpZXcvcHJlc2VudGF0aW9uL2RpYWxvZ3MvcHJlc2VudGF0 aW9uX2FkdnBhZ2UudWkgYi9jb3JlL2RwbHVnaW5zL2dlbmVyaWMvdmlldy9wcmVzZW50YXRpb24v ZGlhbG9ncy9wcmVzZW50YXRpb25fYWR2cGFnZS51aQppbmRleCA3NmNkYTk4ZmI0Li40MGI4YzU1 MjQ1IDEwMDY0NAotLS0gYS9jb3JlL2RwbHVnaW5zL2dlbmVyaWMvdmlldy9wcmVzZW50YXRpb24v ZGlhbG9ncy9wcmVzZW50YXRpb25fYWR2cGFnZS51aQorKysgYi9jb3JlL2RwbHVnaW5zL2dlbmVy aWMvdmlldy9wcmVzZW50YXRpb24vZGlhbG9ncy9wcmVzZW50YXRpb25fYWR2cGFnZS51aQpAQCAt MTI0LDYgKzEyNCwxMyBAQAogICAgICAgICA8L3Byb3BlcnR5PgogICAgICAgIDwvd2lkZ2V0Pgog ICAgICAgPC9pdGVtPgorICAgICAgIDxpdGVtPgorICAgICAgICAgPHdpZGdldCBjbGFzcz0iUUNo ZWNrQm94IiBuYW1lPSJtX2VuYWJsZUtlbkJ1cm5zU2FtZVNwZWVkIj4KKyAgICAgICAgICA8cHJv cGVydHkgbmFtZT0idGV4dCI+CisgICAgICAgICAgIDxzdHJpbmc+JmFtcDtLZW4gQnVybnMgU2Ft ZSBTcGVlZDwvc3RyaW5nPgorICAgICAgICAgIDwvcHJvcGVydHk+CisgICAgICAgICA8L3dpZGdl dD4KKyAgICAgICAgPC9pdGVtPgogICAgICA8L2xheW91dD4KICAgICA8L3dpZGdldD4KICAgIDwv aXRlbT4KZGlmZiAtLWdpdCBhL2NvcmUvZHBsdWdpbnMvZ2VuZXJpYy92aWV3L3ByZXNlbnRhdGlv bi9vcGVuZ2wvcHJlc2VudGF0aW9ua2IuY3BwIGIvY29yZS9kcGx1Z2lucy9nZW5lcmljL3ZpZXcv cHJlc2VudGF0aW9uL29wZW5nbC9wcmVzZW50YXRpb25rYi5jcHAKaW5kZXggNDZlMDQ4OWJjNS4u NmViZTVkYjUwYyAxMDA2NDQKLS0tIGEvY29yZS9kcGx1Z2lucy9nZW5lcmljL3ZpZXcvcHJlc2Vu dGF0aW9uL29wZW5nbC9wcmVzZW50YXRpb25rYi5jcHAKKysrIGIvY29yZS9kcGx1Z2lucy9nZW5l cmljL3ZpZXcvcHJlc2VudGF0aW9uL29wZW5nbC9wcmVzZW50YXRpb25rYi5jcHAKQEAgLTI3OCw2 ICsyNzgsNyBAQCBQcmVzZW50YXRpb25LQjo6UHJlc2VudGF0aW9uS0IoUHJlc2VudGF0aW9uQ29u dGFpbmVyKiBjb25zdCBzaGFyZWREYXRhKQogICAgIGQtPmltYWdlWzBdICAgICAgICA9IG5ldyBL QkltYWdlKG51bGxwdHIpOwogICAgIGQtPmltYWdlWzFdICAgICAgICA9IG5ldyBLQkltYWdlKG51 bGxwdHIpOwogICAgIGQtPnN0ZXAgICAgICAgICAgICA9IDEuMCAvICgoZmxvYXQpKGQtPmRlbGF5 ICogZnJhbWVSYXRlKSk7CisgICAgZC0+ZW5hYmxlU2FtZVNwZWVkID0gZC0+c2hhcmVkRGF0YS0+ a2JFbmFibGVTYW1lU3BlZWQ7CiAgICAgZC0+aW1hZ2VMb2FkVGhyZWFkID0gbmV3IEtCSW1hZ2VM b2FkZXIoZC0+c2hhcmVkRGF0YSwgd2lkdGgoKSwgaGVpZ2h0KCkpOwogICAgIGQtPnRpbWVyICAg ICAgICAgICA9IG5ldyBRVGltZXIodGhpcyk7CiAKQEAgLTQxMSw4ICs0MTIsMTQgQEAgdm9pZCBQ cmVzZW50YXRpb25LQjo6bW92ZVNsb3QoKQogICAgICAgICAgICAgZC0+aW1hZ2VMb2FkVGhyZWFk LT5yZXF1ZXN0TmV3SW1hZ2UoKTsKICAgICAgICAgICAgIGQtPmVuZE9mU2hvdyA9ICFkLT5oYXZl SW1hZ2VzOwogICAgICAgICB9Ci0KLSAgICAgICAgZC0+ZWZmZWN0LT5hZHZhbmNlVGltZShkLT5z dGVwKTsKKyAgICAgICAgaWYgKGQtPmVuYWJsZVNhbWVTcGVlZCkKKyAgICAgICAgeworICAgICAg ICAgICAgZC0+ZWZmZWN0LT5hZHZhbmNlVGltZShkLT5zdGVwU2FtZVNwZWVkKTsKKyAgICAgICAg fQorICAgICAgICBlbHNlCisgICAgICAgIHsKKyAgICAgICAgICAgIGQtPmVmZmVjdC0+YWR2YW5j ZVRpbWUoZC0+c3RlcCk7CisgICAgICAgIH0KICAgICB9CiAKICAgICB1cGRhdGUoKTsKQEAgLTQ2 MSwxMiArNDY4LDE1IEBAIHZvaWQgUHJlc2VudGF0aW9uS0I6OnN0YXJ0U2xpZGVTaG93T25jZSgp CiB7CiAgICAgLy8gd2hlbiB0aGUgaW1hZ2UgbG9hZGVyIHRocmVhZCBpcyByZWFkeSwgaXQgd2ls bCBhbHJlYWR5IGhhdmUgbG9hZGVkCiAgICAgLy8gdGhlIGZpcnN0IGltYWdlCi0KICAgICBpZiAo KGQtPmluaXRpYWxpemVkID09IGZhbHNlKSAmJiBkLT5pbWFnZUxvYWRUaHJlYWQtPnJlYWR5KCkp CiAgICAgewogICAgICAgICBzZXR1cE5ld0ltYWdlKDApOyAgICAgICAgICAgICAgICAgICAgICAv LyBzZXR1cCB0aGUgZmlyc3QgaW1hZ2UgYW5kCiAgICAgICAgIGQtPmltYWdlTG9hZFRocmVhZC0+ cmVxdWVzdE5ld0ltYWdlKCk7IC8vIGxvYWQgdGhlIG5leHQgb25lIGluIGJhY2tncm91bmQKICAg ICAgICAgc2V0TmV3S0JFZmZlY3QoKTsgICAgICAgICAgICAgICAgICAgICAgLy8gc2V0IHRoZSBp bml0aWFsIGVmZmVjdAorICAgICAgICBpZiAoZC0+ZW5hYmxlU2FtZVNwZWVkKQorICAgICAgICB7 CisgICAgICAgICAgICBkLT5zdGVwU2FtZVNwZWVkID0gZC0+c3RlcCAvIGQtPmltYWdlTG9hZFRo cmVhZC0+aW1hZ2VBc3BlY3QoKTsKKyAgICAgICAgfQogCiAgICAgICAgIGQtPmluaXRpYWxpemVk ID0gdHJ1ZTsKICAgICB9CkBAIC02MTIsNyArNjIyLDcgQEAgdm9pZCBQcmVzZW50YXRpb25LQjo6 cmVhZFNldHRpbmdzKCkKICAgICBpZiAoZC0+Zm9yY2VGcmFtZVJhdGUgPiAxMjApCiAgICAgewog ICAgICAgICBkLT5mb3JjZUZyYW1lUmF0ZSA9IDEyMDsKLSAgICB9CisgICAgfSAKIH0KIAogdm9p ZCBQcmVzZW50YXRpb25LQjo6ZW5kT2ZTaG93KCkKZGlmZiAtLWdpdCBhL2NvcmUvZHBsdWdpbnMv Z2VuZXJpYy92aWV3L3ByZXNlbnRhdGlvbi9vcGVuZ2wvcHJlc2VudGF0aW9ua2JfcC5oIGIvY29y ZS9kcGx1Z2lucy9nZW5lcmljL3ZpZXcvcHJlc2VudGF0aW9uL29wZW5nbC9wcmVzZW50YXRpb25r Yl9wLmgKaW5kZXggYjlkNGI4ZGU5NS4uNTVmNGY5NjJmMSAxMDA2NDQKLS0tIGEvY29yZS9kcGx1 Z2lucy9nZW5lcmljL3ZpZXcvcHJlc2VudGF0aW9uL29wZW5nbC9wcmVzZW50YXRpb25rYl9wLmgK KysrIGIvY29yZS9kcGx1Z2lucy9nZW5lcmljL3ZpZXcvcHJlc2VudGF0aW9uL29wZW5nbC9wcmVz ZW50YXRpb25rYl9wLmgKQEAgLTc0LDExICs3NCwxMyBAQCBwdWJsaWM6CiAgICAgICAgIG51bUtC RWZmZWN0UmVwZWF0ZWQgKDApLAogICAgICAgICBpbml0aWFsaXplZCAgICAgICAgIChmYWxzZSks CiAgICAgICAgIHN0ZXAgICAgICAgICAgICAgICAgKDAuMCksCisgICAgICAgIHN0ZXBTYW1lU3Bl ZWQgICAgICAgKDAuMCksCiAgICAgICAgIGVuZE9mU2hvdyAgICAgICAgICAgKGZhbHNlKSwKICAg ICAgICAgc2hvd2luZ0VuZCAgICAgICAgICAoZmFsc2UpLAogICAgICAgICBkZWxheSAgICAgICAg ICAgICAgICgwKSwKICAgICAgICAgZGlzYWJsZUZhZGVJbk91dCAgICAoZmFsc2UpLAogICAgICAg ICBkaXNhYmxlQ3Jvc3NGYWRlICAgIChmYWxzZSksCisgICAgICAgIGVuYWJsZVNhbWVTcGVlZCAg ICAgKGZhbHNlKSwKICAgICAgICAgZm9yY2VGcmFtZVJhdGUgICAgICAoMCksCiAgICAgICAgIHNo YXJlZERhdGEgICAgICAgICAgKG51bGxwdHIpLAogICAgICAgICBwbGF5YmFja1dpZGdldCAgICAg IChudWxscHRyKQpAQCAtMTA1LDYgKzEwNyw3IEBAIHB1YmxpYzoKICAgICBib29sICAgICAgICAg ICAgICAgICAgICAgem9vbUluOwogICAgIGJvb2wgICAgICAgICAgICAgICAgICAgICBpbml0aWFs aXplZDsKICAgICBmbG9hdCAgICAgICAgICAgICAgICAgICAgc3RlcDsKKyAgICBmbG9hdCAgICAg ICAgICAgICAgICAgICAgc3RlcFNhbWVTcGVlZDsKIAogICAgIGJvb2wgICAgICAgICAgICAgICAg ICAgICBlbmRPZlNob3c7CiAgICAgYm9vbCAgICAgICAgICAgICAgICAgICAgIHNob3dpbmdFbmQ7 CkBAIC0xMTIsNiArMTE1LDcgQEAgcHVibGljOgogICAgIGludCAgICAgICAgICAgICAgICAgICAg ICBkZWxheTsKICAgICBib29sICAgICAgICAgICAgICAgICAgICAgZGlzYWJsZUZhZGVJbk91dDsK ICAgICBib29sICAgICAgICAgICAgICAgICAgICAgZGlzYWJsZUNyb3NzRmFkZTsKKyAgICBib29s ICAgICAgICAgICAgICAgICAgICAgZW5hYmxlU2FtZVNwZWVkOwogICAgIHVuc2lnbmVkICAgICAg ICAgICAgICAgICBmb3JjZUZyYW1lUmF0ZTsKIAogICAgIFByZXNlbnRhdGlvbkNvbnRhaW5lciog ICBzaGFyZWREYXRhOwo=