189751 2009-04-15 22:37:44 +0000 Default playlist layout names are not translatable 2010-01-22 23:27:46 +0000 1 1 2 Applications amarok general 2.3-GIT Compiled Sources Unspecified RESOLVED DUPLICATE 189750 HI normal 2.3.0 1 aacid amarok-bugs-null aspotashev cycoone ian.monroe kfunk lfranchi nhn yurchor 0 oldest_to_newest 743450 0 aacid 2009-04-15 22:37:44 +0000 Version: (using Devel) Installed from: Compiled sources Default layout names (like "No Grouping") are not translatable 743453 1 aacid 2009-04-15 22:39:57 +0000 See http://techbase.kde.org/Development/Tutorials/Localization/Building_KDE's_l10n_Module for how to use the x-test language for testing 743455 2 aacid 2009-04-15 22:42:41 +0000 My suggestion: * Add to the xml a attribute that is default="true" for the ones that are shipped by default * Add to Messages.sh a way to parse the XML and extract the default values and store it in rc.cpp * When showing the layout name, check if it has the default="true" tag, if it has it, you pass the layout name thorugh i18n, if it has not, you just show it * User created layouts have default="false" * If a user edits a default layout it stops being a default layout so default goes to false too. 752474 3 lydia 2009-05-05 13:19:39 +0000 Ian: I seem to remember you saying something about Plasma devs having a fix for this. Can you please comment? 802733 4 myriam 2009-08-02 16:39:49 +0000 Any news about this? 844828 5 myriam 2009-10-14 10:22:10 +0000 Bumb. This is old, could somebody comment on this, please? 846919 6 kfunk 2009-10-18 22:42:39 +0000 commit 5300a8328e1b0f9e90e95ff72e450e11b4c18447 Author: Kevin Funk <krf@electrostorm.net> Date: Sun Oct 18 22:39:43 2009 +0200 Make playlist layouts translatable BR: 189751 Just before string freeze ;) 846933 7 aacid 2009-10-18 23:21:36 +0000 That bug really doesn't fix the bug, thanks for working on it though :-) 853287 8 kretschmann 2009-10-31 09:38:50 +0000 Our ChangeLog claims that this bug was fixed. KRF, what gives? 853302 9 yurchor 2009-10-31 10:15:21 +0000 No, it is not fixed. Today's git build, Ukrainian, 100% translated. All layout names and fields are in English: http://omploader.org/vMm50dQ/amarok.png 853305 10 kretschmann 2009-10-31 10:20:29 +0000 So Kevin, what did your patch actually do then? :) Maybe it should be reverted and the ChangeLog entry removed as well. 853777 11 kfunk 2009-11-01 05:09:26 +0000 Mark, my commit made it possible to translate the strings. However, the translated strings are not used in Amarok itself. The bug is not fixed yet, yep. 853991 12 38010 kfunk 2009-11-01 16:39:46 +0000 Created attachment 38010 Patch to fix l10n for playlist layouts Try to use the translated strings in Amarok. Please test the attached diff as my l10n setup is horribly broken and cant test it locally. Please make sure the strings are already translated (check po file, etc.) 854009 13 38011 yurchor 2009-11-01 17:29:53 +0000 Created attachment 38011 Part of "amarok --debug" output on layouts 854010 14 yurchor 2009-11-01 17:30:37 +0000 Applied to the last git-version (Ukrainian translation - messages 1389-1392 (layout names) are translated). Playlist is completely gone. All layout names ("Default", "No grouping", "Verbose") are gone as well. Only my own layout ("My") can be viewed in the list. Screenshot: http://omploader.org/vMm82dw/amarok1.png Part of the debug output attached. 854589 15 kfunk 2009-11-02 20:45:41 +0000 Okay. No idea then, maybe Nikolaj has an idea how to work around this. 855328 16 myriam 2009-11-04 00:39:55 +0000 Nikolaj? 903687 17 cycoone 2010-01-22 22:36:12 +0000 Nikolaj Hald Nielsen (nhn@kde.org) see #189750 (which looks like a dupe to me, but I'm not familiar with the issue) 903707 18 myriam 2010-01-22 23:27:16 +0000 Well spotted, Stephen. 903708 19 myriam 2010-01-22 23:27:46 +0000 *** This bug has been marked as a duplicate of bug 189750 *** 38010 2009-11-01 16:39:46 +0000 2009-11-02 20:46:20 +0000 Patch to fix l10n for playlist layouts fix-l10n.diff text/plain 761 kfunk ZGlmZiAtLWdpdCBhL3NyYy9wbGF5bGlzdC9sYXlvdXRzL0xheW91dE1hbmFnZXIuY3BwIGIvc3Jj L3BsYXlsaXN0L2xheW91dHMvTGF5b3V0TWFuYWdlci5jcHAKaW5kZXggYjI5MDNlZS4uZjVmNGQ2 MSAxMDA2NDQKLS0tIGEvc3JjL3BsYXlsaXN0L2xheW91dHMvTGF5b3V0TWFuYWdlci5jcHAKKysr IGIvc3JjL3BsYXlsaXN0L2xheW91dHMvTGF5b3V0TWFuYWdlci5jcHAKQEAgLTE4OCw3ICsxODgs MTEgQEAgdm9pZCBMYXlvdXRNYW5hZ2VyOjpsb2FkTGF5b3V0cyggY29uc3QgUVN0cmluZyAmZmls ZU5hbWUsIGJvb2wgdXNlciApCiAgICAgICAgIFFEb21Ob2RlIGxheW91dCA9IGxheW91dHMuaXRl bSggaW5kZXggKTsKICAgICAgICAgaW5kZXgrKzsKIAotICAgICAgICBRU3RyaW5nIGxheW91dE5h bWUgPSBsYXlvdXQudG9FbGVtZW50KCkuYXR0cmlidXRlKCAibmFtZSIsICIiICk7CisgICAgICAg IFFTdHJpbmcgbGF5b3V0TmFtZTsKKyAgICAgICAgaWYoIHVzZXIgKQorICAgICAgICAgICAgbGF5 b3V0TmFtZSA9IGxheW91dC50b0VsZW1lbnQoKS5hdHRyaWJ1dGUoICJuYW1lIiwgIiIgKTsKKyAg ICAgICAgZWxzZQorICAgICAgICAgICAgaTE4biggbGF5b3V0LnRvRWxlbWVudCgpLmF0dHJpYnV0 ZSggIm5hbWUiLCAiIiApLnRvVXRmOCgpLmNvbnN0RGF0YSgpICk7CiAgICAgICAgIGRlYnVnKCkg PDwgImxvYWRpbmcgbGF5b3V0ICIgPDwgbGF5b3V0TmFtZTsKIAogICAgICAgICBQbGF5bGlzdExh eW91dCBjdXJyZW50TGF5b3V0Owo= 38011 2009-11-01 17:29:53 +0000 2009-11-01 17:29:53 +0000 Part of "amarok --debug" output on layouts layouts.txt text/plain 2170 yurchor YW1hcm9rOiAgICAgICAgIEJFR0lOOiBQbGF5bGlzdDo6V2lkZ2V0OjpXaWRnZXQoUVdpZGdldCop IAphbWFyb2s6ICAgICAgICAgICBCRUdJTjogUGxheWxpc3Q6OlByb2dyZXNzaXZlU2VhcmNoV2lk Z2V0OjpQcm9ncmVzc2l2ZVNlYXJjaFdpZGdldChRV2lkZ2V0KikgCmFtYXJvazogICAgICAgICAg IEVORF9fOiBQbGF5bGlzdDo6UHJvZ3Jlc3NpdmVTZWFyY2hXaWRnZXQ6OlByb2dyZXNzaXZlU2Vh cmNoV2lkZ2V0KFFXaWRnZXQqKSAtIFRvb2sgMC4wMDE1cyAKYW1hcm9rOiAgICAgICAgICAgQkVH SU46IFBsYXlsaXN0QnJvd3Nlck5TOjpEeW5hbWljTW9kZWw6OkR5bmFtaWNNb2RlbCgpIAphbWFy b2s6ICAgICAgICAgICAgIEJFR0lOOiB2b2lkIFBsYXlsaXN0QnJvd3Nlck5TOjpEeW5hbWljTW9k ZWw6OmxvYWRBdXRvU2F2ZWRQbGF5bGlzdCgpIAphbWFyb2s6ICAgICAgICAgICAgIEVORF9fOiB2 b2lkIFBsYXlsaXN0QnJvd3Nlck5TOjpEeW5hbWljTW9kZWw6OmxvYWRBdXRvU2F2ZWRQbGF5bGlz dCgpIC0gVG9vayA3LjdlLTA1cyAKYW1hcm9rOiAgICAgICAgICAgRU5EX186IFBsYXlsaXN0QnJv d3Nlck5TOjpEeW5hbWljTW9kZWw6OkR5bmFtaWNNb2RlbCgpIC0gVG9vayAwLjAwMDE2cyAKYW1h cm9rOiAgICAgICAgICAgQkVHSU46IHZvaWQgUGxheWxpc3Q6OldpZGdldDo6c2hvd0R5bmFtaWNI aW50KGJvb2wpIAphbWFyb2s6ICAgICAgICAgICBFTkRfXzogdm9pZCBQbGF5bGlzdDo6V2lkZ2V0 OjpzaG93RHluYW1pY0hpbnQoYm9vbCkgLSBUb29rIDVlLTA1cyAKYW1hcm9rOiAgICAgICAgICAg QkVHSU46IFBsYXlsaXN0OjpQcmV0dHlJdGVtRGVsZWdhdGU6OlByZXR0eUl0ZW1EZWxlZ2F0ZShR T2JqZWN0KikgCmFtYXJvazogICAgICAgICAgICAgQkVHSU46IFBsYXlsaXN0OjpMYXlvdXRNYW5h Z2VyOjpMYXlvdXRNYW5hZ2VyKCkgCmFtYXJvazogICAgICAgICAgICAgICBCRUdJTjogdm9pZCBQ bGF5bGlzdDo6TGF5b3V0TWFuYWdlcjo6bG9hZExheW91dHMoY29uc3QgUVN0cmluZyYsIGJvb2wp IAphbWFyb2s6ICAgICAgICAgICAgICAgICAgbG9hZGluZyBsYXlvdXQgICIiIAphbWFyb2s6ICAg ICAgICAgICAgICAgICAgZ3JvdXBpbmcgbW9kZSBpczogICJBbGJ1bSIgCmFtYXJvazogICAgICAg ICAgICAgICAgICBsb2FkaW5nIGxheW91dCAgIiIgCmFtYXJvazogICAgICAgICAgICAgICAgICBn cm91cGluZyBtb2RlIGlzOiAgIkFsYnVtIiAKYW1hcm9rOiAgICAgICAgICAgICAgICAgIGxvYWRp bmcgbGF5b3V0ICAiIiAKYW1hcm9rOiAgICAgICAgICAgICAgICAgIGdyb3VwaW5nIG1vZGUgaXM6 ICAiTm9uZSIgCmFtYXJvazogICAgICAgICAgICAgICAgICBsb2FkaW5nIGxheW91dCAgIiIgCmFt YXJvazogICAgICAgICAgICAgICAgICBncm91cGluZyBtb2RlIGlzOiAgIkFsYnVtIiAKYW1hcm9r OiAgICAgICAgICAgICAgIEVORF9fOiB2b2lkIFBsYXlsaXN0OjpMYXlvdXRNYW5hZ2VyOjpsb2Fk TGF5b3V0cyhjb25zdCBRU3RyaW5nJiwgYm9vbCkgLSBUb29rIDAuMDAyMXMgCmFtYXJvazogICAg ICAgICAgICAgICBCRUdJTjogdm9pZCBQbGF5bGlzdDo6TGF5b3V0TWFuYWdlcjo6bG9hZExheW91 dHMoY29uc3QgUVN0cmluZyYsIGJvb2wpIAphbWFyb2s6ICAgICAgICAgICAgICAgICAgbG9hZGlu ZyBsYXlvdXQgICJNeSIgCmFtYXJvazogICAgICAgICAgICAgICAgICBncm91cGluZyBtb2RlIGlz OiAgIkFsYnVtIiAKYW1hcm9rOiAgICAgICAgICAgICAgIEVORF9fOiB2b2lkIFBsYXlsaXN0OjpM YXlvdXRNYW5hZ2VyOjpsb2FkTGF5b3V0cyhjb25zdCBRU3RyaW5nJiwgYm9vbCkgLSBUb29rIDAu MDAwNDdzIAphbWFyb2s6ICAgICAgICAgICAgIEVORF9fOiBQbGF5bGlzdDo6TGF5b3V0TWFuYWdl cjo6TGF5b3V0TWFuYWdlcigpIC0gVG9vayAwLjAwMzFzIAphbWFyb2s6ICAgICAgICAgICBFTkRf XzogUGxheWxpc3Q6OlByZXR0eUl0ZW1EZWxlZ2F0ZTo6UHJldHR5SXRlbURlbGVnYXRlKFFPYmpl Y3QqKSAtIFRvb2sgMC4wMDMycyAKYW1hcm9rOiAgICAgICAgICAgIEFkZGluZyBwcm92aWRlcjog ICIiIAphbWFyb2s6ICAgICAgICAgICAgQWRkaW5nIHByb3ZpZGVyOiAgIiIgCmFtYXJvazogICAg ICAgICBFTkRfXzogUGxheWxpc3Q6OldpZGdldDo6V2lkZ2V0KFFXaWRnZXQqKSAtIFRvb2sgMC4w MjdzIA==