<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>188594</bug_id>
          
          <creation_ts>2009-04-01 12:10:29 +0000</creation_ts>
          <short_desc>oxygen widget style does not show default button and focused button separately</short_desc>
          <delta_ts>2021-03-09 23:58:30 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>4</classification_id>
          <classification>Plasma</classification>
          <product>Oxygen</product>
          <component>style</component>
          <version>unspecified</version>
          <rep_platform>openSUSE</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>CONFIRMED</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Will Stephenson">wstephenson</reporter>
          <assigned_to name="Hugo Pereira Da Costa">hugo.pereira.da.costa</assigned_to>
          <cc>hugo.pereira.da.costa</cc>
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>737326</commentid>
    <comment_count>0</comment_count>
    <who name="Will Stephenson">wstephenson</who>
    <bug_when>2009-04-01 12:10:29 +0000</bug_when>
    <thetext>Version:            (using KDE 4.2.2)
Installed from:    SuSE RPMs

The same indicator (blue outline) is used in Oxygen for both focussed dialog buttons and the dialog&apos;s default button (set with QPushButton::setDefault()).  Changing the focus (with Tab) removes the Default indicator from the Default button.  Since the default button is pressed with Enter, while a focussed button can be pressed with Space, a user can tab to a button, see that the indicator moves from the Default button to the focussed button, press Enter, and be surprised when the non-focussed Default button is actually clicked.

Steps to reproduce:
Paste a large block of text in kde4-konversation.  This triggers the paste warning dialog, which has the Cancel button set as default.  Tab onto Paste and press Enter - the dialog is cancelled

Expected behaviour: 
Separate indicators for Default and Focus.  In Plastique, the default button has a blue outline, and the focused button has a dashed outline around its label.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1072202</commentid>
    <comment_count>1</comment_count>
    <who name="Hugo Pereira Da Costa">hugo.pereira.da.costa</who>
    <bug_when>2011-01-12 12:34:00 +0000</bug_when>
    <thetext>This is a valid bug (which I finally understood) and the only reason it is not fixed yet is that we have no visual representation idea of default button in mind.
Will keep on thinking about it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1072210</commentid>
    <comment_count>2</comment_count>
    <who name="Camilla Boemann">cbo</who>
    <bug_when>2011-01-12 12:52:39 +0000</bug_when>
    <thetext>The idea was that it would look the same, but indeed it should not be removed when tabbing away</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418280</commentid>
    <comment_count>3</comment_count>
    <who name="Hugo Pereira Da Costa">hugo.pereira.da.costa</who>
    <bug_when>2013-12-13 12:35:29 +0000</bug_when>
    <thetext>Git commit 0444b5400970f6d01d51a0b275e04b41b3300828 by Hugo Pereira Da Costa.
Committed on 29/11/2013 at 18:10.
Pushed by hpereiradacosta into branch &apos;KDE/4.11&apos;.

tint default button

M  +8    -1    kstyles/oxygen/oxygenstyle.cpp

http://commits.kde.org/kde-workspace/0444b5400970f6d01d51a0b275e04b41b3300828</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418281</commentid>
    <comment_count>4</comment_count>
    <who name="Hugo Pereira Da Costa">hugo.pereira.da.costa</who>
    <bug_when>2013-12-13 12:36:58 +0000</bug_when>
    <thetext>Git commit 61a1a1011026c185450db75b32125dcc55941ca9 by Hugo Pereira Da Costa.
Committed on 29/11/2013 at 18:10.
Pushed by hpereiradacosta into branch &apos;master&apos;.

tint default button

M  +8    -1    kstyles/oxygen/oxygenstyle.cpp

http://commits.kde.org/kde-workspace/61a1a1011026c185450db75b32125dcc55941ca9</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2013401</commentid>
    <comment_count>5</comment_count>
    <who name="Justin Zobel">justin.zobel</who>
    <bug_when>2021-03-09 23:58:30 +0000</bug_when>
    <thetext>Thank you for the bug report.

As this report hasn&apos;t seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>