187152 2009-03-14 16:30:13 +0000 multiple selection undone when dragging files 2016-02-19 11:46:54 +0000 1 1 2 Applications ark general unspecified openSUSE Linux RESOLVED FIXED NOR normal --- 1 sven.burmeister rthomsen6 aacid alejandrocobo alessandro.ufms amrecio arthur ashl1future aspotashev bluelightning cfeck ckr.hamza cyberbeat gameforge1 greenMan18523 illumilore j kde-bugs.9ek5t kde kneczaj luminoso madura.x86 mahen mail marcello.tescari metellius mfraz74+kde mrboese msdobrescu mte90net nt1277 null olivier.delaune oracle2b ozbekanil paulo.fidalgo.pt rakuco registrofx rthomsen6 sean shimi.chen simonandric5 simplew8 skreech2 szx temporary987 tesfabpel toddrme2178 v.svetoslavov vdboor vova7890 yannanth http://commits.kde.org/ark/2072d0d49a8946b62ebb8b3cb961c512ad1f8a25 15.08.1 613 oldest_to_newest 730281 0 sven.burmeister 2009-03-14 16:30:13 +0000 Version: (using KDE 4.2.1) OS: Linux Installed from: SuSE RPMs If one opens an archive and selects all files, e.g. by drawing a frame with the mouse, one would expect that clicking and holding on any of those would allow drag+drop to some place outside ark. Currently however, ark de-selects all but the file one clicked on. 750868 1 sergio.pe.facebook+kde 2009-05-01 20:51:42 +0000 Same problem here. By the way, you can vote your own bug and give it 20 votes, just like I'll do :) 750869 2 sergio.pe.facebook+kde 2009-05-01 20:52:56 +0000 (In reply to comment #1) > Same problem here. > > By the way, you can vote your own bug and give it 20 votes, just like I'll do > :) I'm sorry, I didn't say anything about my system. ArchLinux i686, KDE 4.2.2 from KDEMod, Ark 2.12 763383 3 sergio.pe.facebook+kde 2009-05-24 00:12:50 +0000 This bug is still present in KDE 4.3 Beta 1 773724 4 sergio.pe.facebook+kde 2009-06-11 19:35:54 +0000 This bug is still present in KDE 4.3 Beta 2 :( Tested from: http://home.kde.org/~binner/kde-four-live/ 780842 5 sergio.pe.facebook+kde 2009-06-23 23:56:39 +0000 I think this problem is origined by: void ArchiveView::slotClicked(const QModelIndex& index) { if (KGlobalSettings::singleClick()) { if (m_mouseButtons != Qt::LeftButton) // FIXME: see Qt-issue 176832 return; // If the user is pressing shift or control, more than one item is being selected const Qt::KeyboardModifiers modifier = QApplication::keyboardModifiers(); if ((modifier & Qt::ShiftModifier) || (modifier & Qt::ControlModifier)) return; emit itemTriggered(index); } } I couldn't try it, but I think this slot is called when you try to drag, so it causes that only one file is selected, unselecting everything else. Could anyone check that? 780857 6 rakuco 2009-06-24 00:30:11 +0000 Nope, that code is related to a different issue. The unselection is done at ArchiveView::startDrag. It currently works that way due to the issue related to dragging and dropping multiple files from different folders with no common root node or no common direct ancestor. In this case, it's difficult to determine which files to extract and you might end up extracting all folders above the items you've selected, which isn't what you usually want when you're dragging your items to a folder or your desktop. According to Harald, it was implemented this way in order to have any support for drag'n'drop for KDE 4.2 at all, and later neither of us have had the time to properly fix it. As always, patches are welcome ;) 784289 7 rakuco 2009-06-30 07:43:07 +0000 *** Bug 188205 has been marked as a duplicate of this bug. *** 797424 8 rakuco 2009-07-23 17:46:29 +0000 *** Bug 201221 has been marked as a duplicate of this bug. *** 800134 9 rakuco 2009-07-28 18:54:07 +0000 *** Bug 201775 has been marked as a duplicate of this bug. *** 841424 10 rakuco 2009-10-07 14:15:55 +0000 *** Bug 209752 has been marked as a duplicate of this bug. *** 868328 11 alejandrocobo 2009-11-25 16:55:33 +0000 Same problem in KDE 4.3.2 under Mandriva One 2010. 874834 12 rakuco 2009-12-06 20:45:45 +0000 *** Bug 217626 has been marked as a duplicate of this bug. *** 876909 13 rakuco 2009-12-10 03:03:24 +0000 *** Bug 218042 has been marked as a duplicate of this bug. *** 927846 14 sergio.pe.facebook+kde 2010-03-03 19:35:41 +0000 This bug persists on KDE 4.4.1 956026 15 sergio.pe.facebook+kde 2010-05-02 23:59:51 +0000 This bug persists on KDE 4.4.3 967171 16 rakuco 2010-05-25 22:40:06 +0000 *** Bug 238780 has been marked as a duplicate of this bug. *** 1012447 17 ashl1future 2010-09-01 07:14:14 +0000 The bug exist in KDE 4.5.0 1040165 18 cyberbeat 2010-11-04 09:16:36 +0000 still present in kde-4.5.2 1055169 19 rakuco 2010-12-08 02:18:48 +0000 Changing the default assignee in the currently open Ark bug reports to me. 1107000 20 gameforge1 2011-04-11 23:56:51 +0000 This persists in 4.6.2, in fact this bug just had its two year anniversary. 1119971 21 mail 2011-05-16 14:24:29 +0000 Still present in 4.6.3 1161366 22 rakuco 2011-09-10 01:11:39 +0000 *** Bug 281711 has been marked as a duplicate of this bug. *** 1188694 23 kde 2011-11-22 12:03:45 +0000 I think even the developers themselves now stopped using Ark … you know why. 1188701 24 rakuco 2011-11-22 12:21:57 +0000 I think we can all agree that your trollish behavior and lack of constructive suggestions or patches whatsoever clearly indicate you should be spending your time elsewhere. Please refrain from wasting everyone's time next time you feel like acting like a spoiled child. 1244983 25 rakuco 2012-04-11 14:52:52 +0000 *** Bug 297886 has been marked as a duplicate of this bug. *** 1256960 26 skreech2 2012-05-21 14:44:46 +0000 Raphael Kubo da Costa: Just checking. The logic behind not allowing multiple individual files to be extracted through drag and drop is that if files are extracted from multiple folders in the archive it would be difficult to determine how to extract the files so that they come out in multiple directories. The issue comes from drag and drop being designed around having a single destination directory instead of multiple ones. If that is correct would it be possible to detect that there are multiple directories from the paths and simulate multiple Drag and Drop events to have multiple destinations? 1257256 27 ashl1future 2012-05-22 10:26:36 +0000 I think its pretty simple. We have several selections in archive (it is possible to have selected folder and one file in it in addition). We should unpack all selected in one destination. Just unpack sequentially. One selected after another. Unpack folders and save structure from the selected folder (not the path to that folder in archive). Example: Archive: /folderA/fileA1 /folderA/fileA2 /file1 /folderB/folderC/fileBC1 /folderB/folderC/fileBC2 /folderB/fileB1 Selected to drag-n-drop: folderA fileA2 folderC fileB1 Should be unpacked in ONE destination folder as: folderA/fileA1 folderA/fileA2 fileA2 folderC/fileBC1 folderC/fileBC2 fileB1 It's simple, isn't it? 1257553 28 skreech2 2012-05-22 21:10:58 +0000 Of course it is. Really simple. How would you handle the scenario of Archive: /folderA/fileA1 /folderA/fileA2 /fileB1 /folderB/folderC/fileBC1 /folderB/folderC/fileBC2 /folderB/fileB1 /folderD/FolderA/FileA3 /FolderD/FolderA/FileA4 FolderD/FolderA/FileA5 Selected to drag-n-drop: folderA fileB1 folderC fileB1 FolderA ? 1257620 29 ashl1future 2012-05-23 04:00:34 +0000 after or before (this depend on how the Ark is unpacking: directly to destination or in temporary folder, then coping to destination) second fileB is unpacked the standard KDE dialog should be shown: the fileB already exist - change the name, skip or replace the file. This behavior also applied in case of folderA already exists in destination folder. 1257633 30 skreech2 2012-05-23 05:57:19 +0000 That feels pretty ugly for most people esp as the number of files needed increases. Just occurred to me to see if the archive kio tries to handle this scenario. 1257636 31 ashl1future 2012-05-23 06:07:41 +0000 I think this scenario is the user problem. User should understand that filenames are the same. If he need to unpack these files - just unpack as many times as needed in any destination, but not for one time. My solution apply user to change the name, for example, if he forgot about same filenames in the archive. Don't understand what you mean sad "the number of files needed increases". What is "needed files"? 1257640 32 skreech2 2012-05-23 06:47:49 +0000 I meant as the user selects more and more files that they expect in a hierarchy. I would expect that as a user I would think without any other information that drag and drop would work the same way as selecting the files and clicking the extract button. having them be so radically different would be jarring everytime. What would be the logic behind having them do that? 1257742 33 ashl1future 2012-05-23 11:42:07 +0000 Because this is standard behavior in other archive programs. If I need only one file from many-level structure in destination, I don't need the whole structure with folder, folder inside first folder, folder inside second folder is inside first folder and so on. I just need the one file. This scenario (when many file with the same name will be unpacked in one directory) is rare, I think. When you extract files from Extract button you can change the behavior by clicking checkbox "Preserve paths when extracting". Because this could be changed I couldn't expect the one of these 2 behaviors, cause I don't remember which state I use at the last time. Just only we - 2 people said the opinion. 25 users are CC'ed to this bug. I think we need their voice about this problem. If you want, it might be more complicated. For example, after drag-n-drop Ark may show additional menu to user (like dolphin's drag-n-drop produce) with 2 values: - Make the whole paths structure - Don't make additional paths (the text should be another) 1258172 34 rakuco 2012-05-24 20:16:48 +0000 (In reply to comment #26) > Raphael Kubo da Costa: Just checking. The logic behind not allowing multiple > individual files to be extracted through drag and drop is that if files are > extracted from multiple folders in the archive it would be difficult to > determine how to extract the files so that they come out in multiple > directories. The issue comes from drag and drop being designed around having > a single destination directory instead of multiple ones. If that is correct > would it be possible to detect that there are multiple directories from the > paths and simulate multiple Drag and Drop events to have multiple > destinations? I might have started to forget things, but IIRC your explanation is correct, and your solution might work. In the end, this and bug 208384 have pretty much the same cause (and possibly the same solution). 1262882 35 oracle2b 2012-06-06 18:18:48 +0000 Until i found this bug report, I was wondering why I couldn't drag and drop multiple files into a folder. Please make this a priority, I can't believe this has to be requested in 2012. 1312475 36 rakuco 2012-11-04 20:13:19 +0000 *** Bug 309534 has been marked as a duplicate of this bug. *** 1314529 37 madura.x86 2012-11-11 14:28:02 +0000 This is the only *bug* that I see in stable KDE versions 4.8 and 4.9 please fix and make KDE the ultimate! 1344970 38 77556 vova7890 2013-02-24 21:43:06 +0000 Created attachment 77556 dnd multiply extract 1344971 39 77557 vova7890 2013-02-24 21:44:23 +0000 Created attachment 77557 KXMLGUIFactory 1344973 40 vova7890 2013-02-24 21:45:40 +0000 It`s not a bug, it`s seems deliberate restriction. I don`t know why developer doing that, but that patch(^^^ se above message) remove restriction and make it usefull. No have problem allmost, work propertly. Second patch remove message about KXMLGUIFactory ololo, bla bla bla. and avoid(?) leaks, crashs and other terrible problems described in the debug message :) 1344998 41 mail 2013-02-24 22:57:58 +0000 (In reply to comment #40) > It`s not a bug, it`s seems deliberate restriction. I don`t know why > developer doing that, but that patch(^^^ se above message) remove > restriction and make it usefull. No have problem allmost, work propertly. > Second patch remove message about KXMLGUIFactory ololo, bla bla bla. and > avoid(?) leaks, crashs and other terrible problems described in the debug > message :) Please create a review on https://git.reviewboard.kde.org where the responsible developer (and others) can comment on details of the patches until they're ready to get their "Ship it". 1368163 42 rakuco 2013-05-12 08:44:21 +0000 *** Bug 319698 has been marked as a duplicate of this bug. *** 1368356 43 yannanth 2013-05-12 20:57:16 +0000 This is literally one of the very few weak links of the standard distribution of KDE SC. I can't believe Ark doesn't do this and it's unbelievably infuriating for me who often works with large archives. 1372030 44 rakuco 2013-05-29 08:29:28 +0000 *** Bug 320405 has been marked as a duplicate of this bug. *** 1373139 45 illumilore 2013-06-02 01:37:02 +0000 Who is the main developer/maintainer of ark? 1373177 46 vova7890 2013-06-02 09:43:07 +0000 (In reply to comment #45) > Who is the main developer/maintainer of ark? See about in ark. Also, I`m pushed patches on review board. Still awaiting... Already tired always patching myself package when upgrading. 1373488 47 sven.burmeister 2013-06-03 14:53:25 +0000 (In reply to comment #46) > See about in ark. Also, I`m pushed patches on review board. Still > awaiting... Already tired always patching myself package when upgrading. You should ask on the kde-devel mailinglist for somebody to review your patches and to change the maintainer. 1378558 48 szx 2013-06-21 16:31:01 +0000 Even GNOME's archive manager can do this... 1414319 49 cfeck 2013-11-25 21:21:27 +0000 *** Bug 328058 has been marked as a duplicate of this bug. *** 1417699 50 kde-bugs.9ek5t 2013-12-11 02:37:02 +0000 Vova, if you patch works, it would be great to have it integrated in ark. Have you submitted it to https://git.reviewboard.kde.org ? 1420610 51 v.svetoslavov 2013-12-25 21:16:33 +0000 When using drag-n-drop the last selected settings from the extract dialog could be used. Thus you'll have consistent behaviour (the drag-n-drop would work the same as the extract button) and better usability - the user will be able to do drag-n-drop for multiple files). Also, I guess this could also be achieved by making the drag-n-drop as clicking the "Extract" button while passing a path as parameter. 1420612 52 v.svetoslavov 2013-12-25 21:22:50 +0000 (In reply to comment #51) > When using drag-n-drop the last selected settings from the extract dialog > could be used. Thus you'll have consistent behaviour (the drag-n-drop would > work the same as the extract button) and better usability - the user will be > able to do drag-n-drop for multiple files). Also, I guess this could also be > achieved by making the drag-n-drop as clicking the "Extract" button while > passing a path as parameter. While not the best or most elegant solution in the world, this will be usable. Then later on this can be changed to something like having an option whether to show some UI when dropping multiple files, similar to the "extract" dialog, but adapted for the case of drag-n-drop. Actually, as a user, I will accept and get used to anything that does the trick. I guess most users will also do. 1424548 53 j 2014-01-13 19:40:27 +0000 As for the specification how this should be done to me, it is very simple: Ark should use the exact same logic as in dolphin, the problem is solved there and works as expected (what I refer to is dolphins ability to show the contents of folders 'inline', allowing multiple selections). Is this what the suggested patches do? Could Ark reuse the code from Dolphin? 1447371 54 mrboese 2014-05-10 13:38:38 +0000 Still in KDE 4.13 - EXTREMLY+++ annoying! 1449431 55 mte90net 2014-05-18 20:29:40 +0000 very annoying :-( 1460308 56 luminoso 2014-07-09 12:35:22 +0000 Vova, any news about the patch being accepted? 1460338 57 aacid 2014-07-09 17:29:39 +0000 Vova, can we have a link to your reviewboard request? 1460380 58 cfeck 2014-07-09 20:39:55 +0000 He posted comment #38 as https://git.reviewboard.kde.org/r/110672/ 1461055 59 mrboese 2014-07-14 22:48:29 +0000 (In reply to comment #58) > He posted comment #38 as https://git.reviewboard.kde.org/r/110672/ Cool. Finally (?) ... wait ... "by removing the code that singles the selection." ... who had this _great_ idea of making the selection single ... ? o_o 1464464 60 aacid 2014-08-06 22:24:21 +0000 Git commit 52ac4aea6f391cfe43dec0994891095d39364bd2 by Albert Astals Cid, on behalf of Alim Gokkaya. Committed on 06/08/2014 at 22:22. Pushed by aacid into branch 'KDE/4.14'. Allow multiple selection in archiveview REVIEW: 110672 FIXED-IN: 4.14.0 M +0 -2 part/archiveview.cpp M +0 -7 part/part.cpp http://commits.kde.org/ark/52ac4aea6f391cfe43dec0994891095d39364bd2 1464612 61 rakuco 2014-08-07 21:37:48 +0000 Git commit 4429a4ebbb58f44e4c96603f6bc519da8c0ce5da by Raphael Kubo da Costa. Committed on 07/08/2014 at 21:29. Pushed by rkcosta into branch 'KDE/4.14'. Revert "Allow multiple selection in archiveview" The commit being reverted seems to work fine for the ZIP and LHA backends, but for libarchive and RAR it can extract files with the wrong name, a varying hierarchy depending on which of the selected entries is being dragged or sometimes even leave selected entries out. While it is certainly bad to go back to the previous state, it is worse to have this working at varying degrees in each backend, the worst case including partial extraction with wrong names. This reverts commit 52ac4aea6f391cfe43dec0994891095d39364bd2. M +2 -0 part/archiveview.cpp M +7 -0 part/part.cpp http://commits.kde.org/ark/4429a4ebbb58f44e4c96603f6bc519da8c0ce5da 1479508 62 rakuco 2014-11-04 12:29:28 +0000 *** Bug 340626 has been marked as a duplicate of this bug. *** 1533050 63 metellius 2015-07-23 21:25:33 +0000 I'm the guy who originally intentionally made it like that (as former Ark maintainer) for technical reasons like Roger Pixley describes here: https://bugs.kde.org/show_bug.cgi?id=187152#c26 . Before those commits, I don't think dnd was even supported. I eventually realized how complex multiple selections are to support with regards to destination directories and just made it force it into a single selection in order to even support dnd at all. The timeline after this is unfortunately a pretty common one in FOSS: you either lose interest or other life events keep you from spending time on the project. I'm sorry I'm not able to be of any help. 1533159 64 rthomsen6 2015-07-24 13:03:09 +0000 Multiple drag'n'drop selection has actually been implemented and is currently undergoing review: https://git.reviewboard.kde.org/r/124018/ Hopefully, we can merge it before 15.08 final release :) 1543080 65 rthomsen6 2015-09-10 11:56:58 +0000 Git commit 2072d0d49a8946b62ebb8b3cb961c512ad1f8a25 by Ragnar Thomsen. Committed on 10/09/2015 at 11:55. Pushed by rthomsen into branch 'Applications/15.08'. Fix drag'n'drop extraction of multiple selected archive entries This commit implements multi-selection drag'n'drop extraction. This is used when dragging multiple files from Ark to e.g. Dolphin for extraction. It's based partially on work done by Raphael in the multiple-dnd-selection git branch. Dragged files are extracted without path. Dragged folders are extracted without path, but with all folders/files beneath them extracted with relative path (i.e. path beneath the selected folder). A struct called FileRootNodePair is added to Kerfuffle::Archive, which contains two strings (the filename with path and a root node). A FileRootNodePair is passed for each entry to be extracted in a QVariantList to ArchiveModel::extractFiles(), which creates the ExtractJob. All children of folders are added to the QVariantList. The QVariantList is in turn passed to CliPlugin::copyFiles and hence LibArchiveInterface::copyFiles(). The latter is modified to remove the specific rootnode from each file when extracting. The CLI plugins, e.g. clizip and clirar, still extract with full path, due to not supporting individual RootNodes. However, this is a separate issue and should be fixed separately. FIXED-IN: 15.08.1 REVIEW: 124018 M +9 -0 kerfuffle/archive_kerfuffle.cpp M +39 -0 kerfuffle/archive_kerfuffle.h M +1 -1 kerfuffle/cliinterface.cpp M +1 -1 kerfuffle/jobs.cpp M +1 -1 part/archivemodel.cpp M +0 -2 part/archiveview.cpp M +48 -65 part/part.cpp M +3 -2 part/part.h M +44 -13 plugins/libarchive/libarchivehandler.cpp http://commits.kde.org/ark/2072d0d49a8946b62ebb8b3cb961c512ad1f8a25 1577458 66 elvis.angelaccio 2016-02-19 11:46:54 +0000 *** Bug 359564 has been marked as a duplicate of this bug. *** 77556 2013-02-24 21:43:06 +0000 2013-02-24 21:43:06 +0000 dnd multiply extract multiple_dnd_extract.patch text/plain 1276 vova7890 ZGlmZiAtVSAzIC1IIC1kIC1yIC1OIC0tIGEvcGFydC9hcmNoaXZldmlldy5jcHAgYi9wYXJ0L2Fy Y2hpdmV2aWV3LmNwcAotLS0gYS9wYXJ0L2FyY2hpdmV2aWV3LmNwcAkyMDEyLTA5LTI4IDAzOjQw OjE0LjAwMDAwMDAwMCArMDMwMAorKysgYi9wYXJ0L2FyY2hpdmV2aWV3LmNwcAkyMDEyLTEwLTIz IDAwOjA1OjE2LjA3NDc0MTczMiArMDMwMApAQCAtOTgsNyArOTgsNyBAQAogICAgIH0KIAogICAg IGtEZWJ1ZygpIDw8ICJTaW5nbGluZyBvdXQgdGhlIGN1cnJlbnQgc2VsZWN0aW9uLi4uIjsKLSAg ICBzZWxlY3Rpb25Nb2RlbCgpLT5zZXRDdXJyZW50SW5kZXgoY3VycmVudEluZGV4KCksIFFJdGVt U2VsZWN0aW9uTW9kZWw6OkNsZWFyQW5kU2VsZWN0IHwgUUl0ZW1TZWxlY3Rpb25Nb2RlbDo6Um93 cyk7CisgICAgLy9zZWxlY3Rpb25Nb2RlbCgpLT5zZXRDdXJyZW50SW5kZXgoY3VycmVudEluZGV4 KCksIFFJdGVtU2VsZWN0aW9uTW9kZWw6OkNsZWFyQW5kU2VsZWN0IHwgUUl0ZW1TZWxlY3Rpb25N b2RlbDo6Um93cyk7CiAgICAgUVRyZWVWaWV3OjpzdGFydERyYWcoc3VwcG9ydGVkQWN0aW9ucyk7 CiB9CiAKZGlmZiAtVSAzIC1IIC1kIC1yIC1OIC0tIGEvcGFydC9wYXJ0LmNwcCBiL3BhcnQvcGFy dC5jcHAKLS0tIGEvcGFydC9wYXJ0LmNwcAkyMDEyLTA5LTI4IDAzOjQwOjE0LjAwMDAwMDAwMCAr MDMwMAorKysgYi9wYXJ0L3BhcnQuY3BwCTIwMTItMTAtMjMgMDA6MDU6MTYuMDc4MDc1MDUzICsw MzAwCkBAIC0xNjUsMTIgKzE2NSwxMiBAQAogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAg aWYgKG1fdmlldy0+c2VsZWN0aW9uTW9kZWwoKS0+c2VsZWN0ZWRSb3dzKCkuY291bnQoKSAhPSAx KSB7CisgICAgLyppZiAobV92aWV3LT5zZWxlY3Rpb25Nb2RlbCgpLT5zZWxlY3RlZFJvd3MoKS5j b3VudCgpICE9IDEpIHsKICAgICAgICAgbV92aWV3LT5zZWxlY3Rpb25Nb2RlbCgpLT5zZXRDdXJy ZW50SW5kZXgobV92aWV3LT5jdXJyZW50SW5kZXgoKSwgUUl0ZW1TZWxlY3Rpb25Nb2RlbDo6Q2xl YXJBbmRTZWxlY3QgfCBRSXRlbVNlbGVjdGlvbk1vZGVsOjpSb3dzKTsKICAgICB9CiAgICAgaWYg KG1fdmlldy0+c2VsZWN0aW9uTW9kZWwoKS0+c2VsZWN0ZWRSb3dzKCkuY291bnQoKSAhPSAxKSB7 CiAgICAgICAgIHJldHVybjsKLSAgICB9CisgICAgfSovCiAKICAgICBRVmFyaWFudCBpbnRlcm5h bFJvb3Q7CiAgICAga0RlYnVnKCkgPDwgInZhbGlkICIgPDwgbV92aWV3LT5jdXJyZW50SW5kZXgo KS5wYXJlbnQoKS5pc1ZhbGlkKCk7Cg== 77557 2013-02-24 21:44:23 +0000 2013-02-24 21:44:23 +0000 KXMLGUIFactory remove_from_xmlguifactory.patch text/plain 552 vova7890 ZGlmZiAtVSAzIC1IIC1kIC1yIC1OIC0tIGEvYXBwL21haW53aW5kb3cuY3BwIGIvYXBwL21haW53 aW5kb3cuY3BwCi0tLSBhL2FwcC9tYWlud2luZG93LmNwcAkyMDEyLTEwLTIzIDAwOjI1OjEzLjAw MDAwMDAwMCArMDMwMAorKysgYi9hcHAvbWFpbndpbmRvdy5jcHAJMjAxMi0xMC0yMyAwMDoyNDox NS4wMDAwMDAwMDAgKzAzMDAKQEAgLTM4LDYgKzM4LDcgQEAKICNpbmNsdWRlIDxLRGVidWc+CiAj aW5jbHVkZSA8S0VkaXRUb29sQmFyPgogI2luY2x1ZGUgPEtTaG9ydGN1dHNEaWFsb2c+CisjaW5j bHVkZSA8S1hNTEdVSUZhY3Rvcnk+CiAKICNpbmNsdWRlIDxRRHJhZ0VudGVyRXZlbnQ+CiAjaW5j bHVkZSA8UURyYWdNb3ZlRXZlbnQ+CkBAIC03MCw2ICs3MSw3IEBACiAgICAgICAgIG1fcmVjZW50 RmlsZXNBY3Rpb24tPnNhdmVFbnRyaWVzKEtHbG9iYWw6OmNvbmZpZygpLT5ncm91cCgiUmVjZW50 IEZpbGVzIikpOwogICAgIH0KKyAgICBmYWN0b3J5KCktPnJlbW92ZUNsaWVudChtX3BhcnQpOwog ICAgIGRlbGV0ZSBtX3BhcnQ7CiAgICAgbV9wYXJ0ID0gMDsKIH0K