183483 2009-02-06 22:52:06 +0000 Changes to wrong tab on tab close 2009-07-13 22:16:44 +0000 1 1 2 Applications konsole general 2.2 unspecified Linux RESOLVED FIXED NOR normal --- 1 aacid konsole-bugs-null robertknight 0 oldest_to_newest 712940 0 aacid 2009-02-06 22:52:06 +0000 Version: 2.2 (using 4.2.00 (KDE 4.2.0), Kubuntu packages) Compiler: cc OS: Linux (x86_64) release 2.6.27-11-generic How to reproduce: * Open three tabs * Write a 1 in the first tab * Write a 3 in the third tab * Go to the second tab * Close it * The user ends up in the first tab which is weird in my opinion and not what happened in KDE 3 version 787060 1 khindenburg 2009-07-05 21:07:43 +0000 It looks like it goes to shell-1; it loops to last shell if you quit the first shell. 790833 2 aacid 2009-07-12 15:42:17 +0000 Exactly what i'm saying, would you accept a patch that fixes this unstandard behaviour? 790838 3 khindenburg 2009-07-12 15:55:32 +0000 Patches are always welcomed; you are going to use the previous session? 790867 4 aacid 2009-07-12 16:39:36 +0000 What i want to do is make it do what all programs with tabs in KDE do (konsole would do it too if it was using KDE tab classes) that is; if i have three tabs and close the second i'm still at second (the third before closing) 790889 5 robertknight 2009-07-12 17:16:28 +0000 Please post patches to reviewboard.kde.org Thank-you in advance. 790931 6 khindenburg 2009-07-12 18:30:34 +0000 Bad choice of words: previous = last tab visited 790943 7 aacid 2009-07-12 18:56:36 +0000 no, not last visited tab. Now it goes to shell-1 i'll go to shell (was shell+1 before closing) like all KDE does 790970 8 aacid 2009-07-12 19:24:12 +0000 http://reviewboard.kde.org/r/999/ 791548 9 aacid 2009-07-13 20:07:00 +0000 SVN commit 996026 by aacid: switch to next tab and not previous on tab close like all other kde apps do Approved by Robert Knight BUGS: 183483 M +3 -3 ViewManager.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=996026 791550 10 aacid 2009-07-13 20:07:38 +0000 Can i backport the fix to the 4.3 branch? 791598 11 robertknight 2009-07-13 21:54:20 +0000 > Can i backport the fix to the 4.3 branch? Please do. 791614 12 aacid 2009-07-13 22:16:44 +0000 SVN commit 996082 by aacid: switch to next tab and not previous on tab close like all other kde apps do Approved by Robert Knight BUGS: 183483 M +3 -3 ViewManager.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=996082