<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>177925</bug_id>
          
          <creation_ts>2008-12-16 21:04:00 +0000</creation_ts>
          <short_desc>[regression] KHTML part does not accept drop events</short_desc>
          <delta_ts>2009-12-09 19:50:05 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>konqueror</product>
          <component>khtml part</component>
          <version>SVN</version>
          <rep_platform>Compiled Sources</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>regression</keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Palacio">dpalacio</reporter>
          <assigned_to name="Konqueror Bugs">konqueror-bugs-null</assigned_to>
          <cc>faure</cc>
    
    <cc>finex</cc>
    
    <cc>frank78ac</cc>
    
    <cc>germain</cc>
    
    <cc>squan</cc>
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>682155</commentid>
    <comment_count>0</comment_count>
    <who name="David Palacio">dpalacio</who>
    <bug_when>2008-12-16 21:04:00 +0000</bug_when>
    <thetext>Version:            (using Devel)
Installed from:    Compiled sources

I used to drop an url from another window to the view in Konqueror and it would open. Now it only works on when I drop it on the tab.

Testcase:
1. Open http://kde.org/ on a new window
2. Drop a link to this report view
3. A not-allowed-drop cursor appears</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682680</commentid>
    <comment_count>1</comment_count>
    <who name="Frank Reininghaus">frank78ac</who>
    <bug_when>2008-12-17 23:59:37 +0000</bug_when>
    <thetext>Thanks for the bug report. Confirmed in trunk rev. 898284. Dropping things still works in file management mode, so I think the error is probably in the KHTML part.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682843</commentid>
    <comment_count>2</comment_count>
    <who name="FiNeX">finex</who>
    <bug_when>2008-12-18 13:47:52 +0000</bug_when>
    <thetext>And this could be related to bug #152126</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>683924</commentid>
    <comment_count>3</comment_count>
    <who name="">squan</who>
    <bug_when>2008-12-20 13:22:41 +0000</bug_when>
    <thetext>Hint: dropping things on tabs or works.
And dropping right behind a tab opens a new tab!
This is a nice additional feature.
But of of course the main window should also accept drops.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>684931</commentid>
    <comment_count>4</comment_count>
    <who name="Frank Reininghaus">frank78ac</who>
    <bug_when>2008-12-22 01:46:51 +0000</bug_when>
    <thetext>I think that the commit which added the new find bar caused this regression:

http://websvn.kde.org/?view=rev&amp;revision=884889

At least dropping URLs works for me in 884888 while it doesn&apos;t in 884889. I&apos;m CC&apos;ing Germain because he committed it.

Since then, KHTMLPart::init( KHTMLView *view,...) does not set the &apos;view&apos; as its main widget with setWidget(), but a layout consisting of the KHTMLView and the find bar. It appears that the mouse drop event is not forwarded from the layout to the view for some reason.

I&apos;ve verified that calling &apos;setWidget(view)&apos; makes dropping URLs work again in rev. 900020, but of course, that destroys the find functionality.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>721561</commentid>
    <comment_count>5</comment_count>
    <who name="David Faure">faure</who>
    <bug_when>2009-02-23 20:18:32 +0000</bug_when>
    <thetext>SVN commit 930536 by dfaure:

Repair DND-onto-khtmlview -- the part&apos;s widget isn&apos;t a qscrollarea anymore since the findbar redesign,
so we need to call setAcceptDrops explicitely on the part&apos;s widget.
BUG: 177925


 M  +2 -0      konqview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&amp;revision=930536</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>