173814 2008-10-29 10:08:45 +0000 JJ: add keyboard shortcut for "Edit Track Information..." 2012-02-15 09:35:39 +0000 1 1 2 Applications amarok Shortcuts unspecified unspecified Linux RESOLVED FIXED junior-jobs NOR wishlist 2.6 0 glen amarok-bugs-null bart.cerneels gregor spectrumdt 2.6 10 oldest_to_newest 658441 0 glen 2008-10-29 10:08:45 +0000 Version: 1.4.10 (using 3.5.10, PLD Linux Distribution) Compiler: gcc version 3.3.6 (PLD Linux) OS: Linux (x86_64) release 2.6.24.7_desktop-2 currently the item is not listed neither in Configure Shortcuts, nor Configure Global shortcuts... actually there are more items that can be bind to keyboard shortcut, available by mouse by clicking... 919827 1 kfunk 2010-02-18 19:30:53 +0000 *** Bug 226325 has been marked as a duplicate of this bug. *** 919843 2 kfunk 2010-02-18 19:47:43 +0000 *** Bug 200897 has been marked as a duplicate of this bug. *** 1226130 3 68735 jazneetbhatti 2012-02-12 19:09:55 +0000 Created attachment 68735 This is a patch that adds a keyboard shortcut for opening the Edit Track Details dialog I've basically added a slot in MainWindow.cpp that is called when the shortcut key combination is pressed. In this slot, a call is made to a function that I've defined in playlist/PlaylistDock.cpp. This function, in turn, calls the edit track details function in playlist/view/listview/PrettyListView.cpp to open up the dialog. 1227150 4 bart.cerneels 2012-02-15 09:35:39 +0000 Git commit c167a8661d25bca35bbf5f6154d7fdf926b1df69 by Bart Cerneels. Committed on 15/02/2012 at 10:32. Pushed by shanachie into branch 'master'. Add keyboard shortcut for Edit Track Patch by: Jasneet Bhatti FIXED-IN:2.6 REVIEW: 103960 M +2 -0 ChangeLog M +11 -0 src/MainWindow.cpp M +1 -0 src/MainWindow.h M +6 -0 src/playlist/PlaylistDock.cpp M +1 -0 src/playlist/PlaylistDock.h http://commits.kde.org/amarok/c167a8661d25bca35bbf5f6154d7fdf926b1df69 68735 2012-02-12 19:09:55 +0000 2012-02-12 19:09:55 +0000 This is a patch that adds a keyboard shortcut for opening the Edit Track Details dialog editTrackInfoShortcut_jasneet.patch text/plain 2256 jazneetbhatti ZGlmZiAtLWdpdCBhL3NyYy9NYWluV2luZG93LmNwcCBiL3NyYy9NYWluV2luZG93LmNwcAppbmRl eCBlYTk5NjU5Li4wYmFkMzIxIDEwMDY0NAotLS0gYS9zcmMvTWFpbldpbmRvdy5jcHAKKysrIGIv c3JjL01haW5XaW5kb3cuY3BwCkBAIC01MjIsNiArNTIyLDEyIEBAIE1haW5XaW5kb3c6OnNsb3RT aG93QWN0aXZlVHJhY2soKSBjb25zdAogfQogCiB2b2lkCitNYWluV2luZG93OjpzbG90RWRpdFRy YWNrSW5mbygpIGNvbnN0Cit7CisgICAgbV9wbGF5bGlzdERvY2suZGF0YSgpLT5lZGl0VHJhY2tJ bmZvKCk7Cit9CisKK3ZvaWQKIE1haW5XaW5kb3c6OnNsb3RTaG93Q292ZXJNYW5hZ2VyKCkgY29u c3QgLy9TTE9UCiB7CiAgICAgQ292ZXJNYW5hZ2VyOjpzaG93T25jZSgpOwpAQCAtNzY1LDYgKzc3 MSwxMSBAQCBNYWluV2luZG93OjpjcmVhdGVBY3Rpb25zKCkKICAgICBhY3Rpb24tPnNldFNob3J0 Y3V0KCBRdDo6Q1RSTCArIFF0OjpLZXlfTyApOwogICAgIGNvbm5lY3QoIGFjdGlvbiwgU0lHTkFM KCB0cmlnZ2VyZWQoIGJvb2wgKSApLCBTTE9UKCBzbG90UGxheU1lZGlhKCkgKSApOwogCisgICAg YWN0aW9uID0gbmV3IEtBY3Rpb24oIEtJY29uKCJtZWRpYS10cmFjay1lZGl0LWFtYXJvayIpLCBp MThuKCJFZGl0IFRyYWNrIERldGFpbHMiKSwgdGhpcyApOworICAgIGFjLT5hZGRBY3Rpb24oICJ0 cmFja2RldGFpbHNfZWRpdCIsIGFjdGlvbiApOworICAgIGFjdGlvbi0+c2V0U2hvcnRjdXQoIFF0 OjpDVFJMICsgUXQ6OktleV9FICk7CisgICAgY29ubmVjdCggYWN0aW9uLCBTSUdOQUwoIHRyaWdn ZXJlZCggYm9vbCApICksIFNMT1QoIHNsb3RFZGl0VHJhY2tJbmZvKCkgKSApOworCiAgICAgYWN0 aW9uID0gbmV3IEtBY3Rpb24oIEtJY29uKCAibWVkaWEtc2Vlay1mb3J3YXJkLWFtYXJvayIgKSwg aTE4bigiJlNlZWsgRm9yd2FyZCIpLCB0aGlzICk7CiAgICAgYWMtPmFkZEFjdGlvbiggInNlZWtf Zm9yd2FyZCIsIGFjdGlvbiApOwogICAgIGFjdGlvbi0+c2V0U2hvcnRjdXQoIFF0OjpLZXlfUmln aHQgKTsKZGlmZiAtLWdpdCBhL3NyYy9NYWluV2luZG93LmggYi9zcmMvTWFpbldpbmRvdy5oCmlu ZGV4IDk4NGFhMjguLmIxNDljYjkgMTAwNjQ0Ci0tLSBhL3NyYy9NYWluV2luZG93LmgKKysrIGIv c3JjL01haW5XaW5kb3cuaApAQCAtMTM2LDYgKzEzNiw3IEBAIGNsYXNzIEFNQVJPS19FWFBPUlQg TWFpbldpbmRvdyA6IHB1YmxpYyBLTWFpbldpbmRvdwogCiAgICAgICAgIHZvaWQgZXhwb3J0UGxh eWxpc3QoKSBjb25zdDsKICAgICAgICAgdm9pZCBzbG90U2hvd0FjdGl2ZVRyYWNrKCkgY29uc3Q7 CisgICAgICAgIHZvaWQgc2xvdEVkaXRUcmFja0luZm8oKSBjb25zdDsKICAgICAgICAgdm9pZCBz bG90U2hvd0Jvb2ttYXJrTWFuYWdlcigpIGNvbnN0OwogICAgICAgICB2b2lkIHNsb3RTaG93RXF1 YWxpemVyKCkgY29uc3Q7CiAgICAgICAgIHZvaWQgc2xvdFNob3dDb3Zlck1hbmFnZXIoKSBjb25z dDsKZGlmZiAtLWdpdCBhL3NyYy9wbGF5bGlzdC9QbGF5bGlzdERvY2suY3BwIGIvc3JjL3BsYXls aXN0L1BsYXlsaXN0RG9jay5jcHAKaW5kZXggYjIxN2UzYy4uYTBlM2NjNSAxMDA2NDQKLS0tIGEv c3JjL3BsYXlsaXN0L1BsYXlsaXN0RG9jay5jcHAKKysrIGIvc3JjL3BsYXlsaXN0L1BsYXlsaXN0 RG9jay5jcHAKQEAgLTMyMiw2ICszMjIsMTMgQEAgUGxheWxpc3Q6OkRvY2s6OnNob3dBY3RpdmVU cmFjaygpCiB9CiAKIHZvaWQKK1BsYXlsaXN0OjpEb2NrOjplZGl0VHJhY2tJbmZvKCkKK3sKKyAg ICBlbnN1cmVQb2xpc2goKTsKKyAgICBtX3BsYXlsaXN0Vmlldy0+ZWRpdFRyYWNrSW5mb3JtYXRp b24oKTsKK30KKwordm9pZAogUGxheWxpc3Q6OkRvY2s6OnNob3dEeW5hbWljSGludCgpIC8vIHNs b3QKIHsKICAgICBERUJVR19CTE9DSwpkaWZmIC0tZ2l0IGEvc3JjL3BsYXlsaXN0L1BsYXlsaXN0 RG9jay5oIGIvc3JjL3BsYXlsaXN0L1BsYXlsaXN0RG9jay5oCmluZGV4IDg5N2JlMWQuLjkzNTRh ZTEgMTAwNjQ0Ci0tLSBhL3NyYy9wbGF5bGlzdC9QbGF5bGlzdERvY2suaAorKysgYi9zcmMvcGxh eWxpc3QvUGxheWxpc3REb2NrLmgKQEAgLTUyLDYgKzUyLDcgQEAgcHVibGljOgogICAgIFNvcnRX aWRnZXQgKnNvcnRXaWRnZXQoKTsKICAgICBQcm9ncmVzc2l2ZVNlYXJjaFdpZGdldCAqc2VhcmNo V2lkZ2V0KCk7CiAgICAgdm9pZCBzaG93QWN0aXZlVHJhY2soKTsKKyAgICB2b2lkIGVkaXRUcmFj a0luZm8oKTsKIAogICAgIHZvaWQgcG9saXNoKCk7CiAK