173264 2008-10-22 00:52:54 +0000 Add hotkey for "Change colors" 2019-05-05 13:46:50 +0000 1 1 2 Applications okular general 0.7.2 Fedora RPMs Linux RESOLVED FIXED https://bugs.kde.org/show_bug.cgi?id=407217 NOR wishlist --- 0 spectrumdt okular-devel a.skembris aacid ciro.santilli Reinhard.Thies tclwarrior tomasz http://commits.kde.org/okular/afc74e76ef70abf70d993d4099000742080a8a85 4.12.0 0 oldest_to_newest 655880 0 spectrumdt 2008-10-22 00:52:54 +0000 Version: 0.7.2 (using KDE 4.1.2) OS: Linux Installed from: Fedora RPMs Please add the option to set up a hotkey to turn the "Change colors" switch on and off (currently reachable via Settings -> Configure Okular -> Accessibility -> Change colors"). 1335902 1 tomasz 2013-01-28 08:34:57 +0000 Lack of fast way to switch off/on change color option makes this option useless. There are some pdfs that look terrible with change color switched on - the ones with photos are good example. 1406154 2 83100 ciro.santilli 2013-10-25 08:11:06 +0000 Created attachment 83100 pacth fix 1406159 3 ciro.santilli 2013-10-25 08:34:15 +0000 Sorry for double post, first patch and I have just figured that the patch comment goes to the devel list... Added default shortcut Ctrl + I for change colors. This should have the exact same of clicking the toolbox Settigs > Configure Okular > Accessibility > Change colors and then Ok, therefore changing the saved configs. I am not sure if: - viewport()->update() is the right way to update the screen after this config change? Where is the `update()` method defined? If I tracked well, viewport() returns a DocumentViewport, which does not seem to have such a method. - did I put things in the right place but it seems to work. 1406289 4 aacid 2013-10-25 14:48:43 +0000 please post the patch to reviewboard.kde.org 1406291 5 aacid 2013-10-25 14:49:25 +0000 *** Bug 266157 has been marked as a duplicate of this bug. *** 1406449 6 aacid 2013-10-26 09:43:34 +0000 Git commit afc74e76ef70abf70d993d4099000742080a8a85 by Albert Astals Cid, on behalf of Ciro Santilli. Committed on 26/10/2013 at 09:40. Pushed by aacid into branch 'master'. Add an action to toggle Change Colors This has the exact same behaviour of clicking the toolbox Settigs > Configure Okular > Accessibility > Change colors and then clicking Ok, therefore changing the saved configs. FIXED-IN: 4.12.0 M +11 -0 ui/pageview.cpp M +1 -0 ui/pageview.h http://commits.kde.org/okular/afc74e76ef70abf70d993d4099000742080a8a85 1442069 7 tclwarrior 2014-04-18 23:26:20 +0000 the coments here seem to suggest that the ctrl-i shortcut is added in kde version 4.12.0 i am now running kubuntu 14.04 which run kde 4.13 and okular 0.19 and this patch still did not make it to it this is really a key feature, to be able to easily invert color i hope it gets more attentions and be re-opened actually unless its an issue in kubuntu, not pulling this in 1442071 8 aacid 2014-04-18 23:32:31 +0000 The feauture is implemented. It just doesn't have a default shortcut, you can just assign the one you prefer for this really key feature 1442263 9 ciro.santilli 2014-04-20 08:48:18 +0000 @Albert I propose Okular reconsiders the decision not to assign a default key and assigns one for the following reasons: - when new users want the feature, which is really way better with a shortcut, they have to do the work of setting it up. - users have to think themselves about a good way to dispose their many shourtcuts without conflict, while keeping them as mnemonic as possible. Just imagine if, say, Vim had no default shortcuts =) Okular devs are the ones who can make the best choice. If we add the shortcut by default we remove both of those burdens from new users. This is is specially important to attract new users who are not likely to search a lot for how to do things when using a new program. And if more advanced users want to change that shortcut, they can always do so. 1442335 10 aacid 2014-04-20 14:48:08 +0000 If we add a shortcut to each action we run of of shortcuts. So no. 1442337 11 ciro.santilli 2014-04-20 14:50:56 +0000 @Albert we could select the most useful ones until we run out =) 1442344 12 aacid 2014-04-20 15:32:45 +0000 Yes, you can, there's a configure dialog for that. 83100 2013-10-25 08:11:06 +0000 2013-10-25 08:11:06 +0000 pacth fix patch.diff text/plain 1527 ciro.santilli ZGlmZiAtLWdpdCBhL3VpL3BhZ2V2aWV3LmNwcCBiL3VpL3BhZ2V2aWV3LmNwcAppbmRleCBhMWFi NWJkLi44ZDUyZmI5IDEwMDY0NAotLS0gYS91aS9wYWdldmlldy5jcHAKKysrIGIvdWkvcGFnZXZp ZXcuY3BwCkBAIC01MzIsNiArNTMyLDExIEBAIGRvIHsgXAogICAgIG16LT5zZXRTaG9ydGN1dCgg UXQ6OkNUUkwgKyBRdDo6S2V5XzIgKTsKICAgICBtei0+c2V0QWN0aW9uR3JvdXAoIGQtPm1vdXNl TW9kZUFjdGlvbkdyb3VwICk7CiAgICAgbXotPnNldENoZWNrZWQoIE9rdWxhcjo6U2V0dGluZ3M6 Om1vdXNlTW9kZSgpID09IE9rdWxhcjo6U2V0dGluZ3M6OkVudW1Nb3VzZU1vZGU6Olpvb20gKTsK KworICAgIEtBY3Rpb24gKiBhVG9vZ2xlQ2hhbmdlQ29sb3JzICA9IG5ldyBLQWN0aW9uKGkxOG4o IiZUb29nbGUgQ2hhbmdlIENvbG9ycyIpLCB0aGlzKTsKKyAgICBhYy0+YWRkQWN0aW9uKCJ0b29n bGVfY2hhbmdlX2NvbG9ycyIsIGFUb29nbGVDaGFuZ2VDb2xvcnMgKTsKKyAgICBjb25uZWN0KCBh VG9vZ2xlQ2hhbmdlQ29sb3JzLCBTSUdOQUwodHJpZ2dlcmVkKCkpLCB0aGlzLCBTTE9UKHNsb3RU b29nbGVDaGFuZ2VDb2xvcnMoKSkgKTsKKyAgICBhVG9vZ2xlQ2hhbmdlQ29sb3JzLT5zZXRTaG9y dGN1dCggUXQ6OkNUUkwgKyBRdDo6S2V5X0kgKTsKIH0KIAogLy8gV0FSTklORzogJ3NldHVwVmll d2VyQWN0aW9ucycgbXVzdCBoYXZlIGJlZW4gY2FsbGVkIGJlZm9yZSB0aGlzIG1ldGhvZApAQCAt NDg3Myw2ICs0ODc4LDEzIEBAIHZvaWQgUGFnZVZpZXc6OnNsb3RQcm9jZXNzUmVuZGl0aW9uQWN0 aW9uKCBjb25zdCBPa3VsYXI6OlJlbmRpdGlvbkFjdGlvbiAqYWN0aW9uCiAgICAgfTsKIH0KIAor dm9pZCBQYWdlVmlldzo6c2xvdFRvb2dsZUNoYW5nZUNvbG9ycygpCit7CisgICAgT2t1bGFyOjpT ZXR0aW5nc0NvcmU6OnNldENoYW5nZUNvbG9ycyggIU9rdWxhcjo6U2V0dGluZ3NDb3JlOjpjaGFu Z2VDb2xvcnMoKSApOworICAgIE9rdWxhcjo6U2V0dGluZ3M6OnNlbGYoKS0+d3JpdGVDb25maWco KTsKKyAgICB2aWV3cG9ydCgpLT51cGRhdGUoKTsKK30KKwogLy9FTkQgcHJpdmF0ZSBTTE9UUwog CiAjaW5jbHVkZSAicGFnZXZpZXcubW9jIgpkaWZmIC0tZ2l0IGEvdWkvcGFnZXZpZXcuaCBiL3Vp L3BhZ2V2aWV3LmgKaW5kZXggZmQ0ZTNhYy4uMmYyNTcyNyAxMDA2NDQKLS0tIGEvdWkvcGFnZXZp ZXcuaAorKysgYi91aS9wYWdldmlldy5oCkBAIC0yNjIsNiArMjYyLDcgQEAgUV9PQkpFQ1QKICAg ICAgICAgdm9pZCBzbG90QW5ub3RhdGlvbldpbmRvd0Rlc3Ryb3llZCggUU9iamVjdCAqd2luZG93 ICk7CiAgICAgICAgIHZvaWQgc2xvdFByb2Nlc3NNb3ZpZUFjdGlvbiggY29uc3QgT2t1bGFyOjpN b3ZpZUFjdGlvbiAqYWN0aW9uICk7CiAgICAgICAgIHZvaWQgc2xvdFByb2Nlc3NSZW5kaXRpb25B Y3Rpb24oIGNvbnN0IE9rdWxhcjo6UmVuZGl0aW9uQWN0aW9uICphY3Rpb24gKTsKKyAgICAgICAg dm9pZCBzbG90VG9vZ2xlQ2hhbmdlQ29sb3JzKCk7CiB9OwogCiAjZW5kaWYK