171642 2008-09-25 10:32:24 +0000 Clicking on systray icon does not show/hide the main window 2009-05-31 00:43:21 +0000 1 1 2 Applications akregator general SVN Unlisted Binaries Linux RESOLVED FIXED NOR normal --- 1 amantia pim-bugs-null alex.merry droebuck gekylafas krishna.ggk mattia.milleri rasasi78 schwarzer uwolfer wrar zeratul 5 oldest_to_newest 648773 0 amantia 2008-09-25 10:32:24 +0000 Summary tells it all. Happens since a few days in trunk. 650563 1 uwolfer 2008-10-02 20:24:56 +0000 *** Bug 172039 has been marked as a duplicate of this bug. *** 652259 2 27761 krishna.ggk 2008-10-09 16:58:23 +0000 Created attachment 27761 Toggles the Akregator::Part visibility between hide and show when system tray icon is clicked. This is my first ever patch to akregator, so please correct me if something is wrong. This patch adds a new slot called slotToggleVisibility to MainWindow and is invoked on signal toggleShowPart from Akregator::Part. Note: showPart is refactored to toggleShowPart everywhere to reflect this change. 652266 3 27764 krishna.ggk 2008-10-09 17:02:42 +0000 Created attachment 27764 Toggles the Akregator::Part visibility between hide and show when system tray icon is clicked. Also renamed TrayIcon showPart signal as toggleShowPart. This patch is btw, wrt to the trunk (revision #869633) 652270 4 krishna.ggk 2008-10-09 17:14:43 +0000 Added me to cc list (sorry for 3 separate mails) 652306 5 uwolfer 2008-10-09 20:02:47 +0000 Patch looks good to me. 652981 6 uwolfer 2008-10-12 12:12:07 +0000 SVN commit 870288 by uwolfer: Fix: Clicking on systray icon does not show/hide the main window. Patch by Gopala Krishna A. (Not needed to backport to 4.1, as it is not broken there IIRC.) BUG:171642 M +1 -1 akregator_part.cpp M +1 -1 akregator_part.h M +7 -2 mainwindow.cpp M +1 -0 mainwindow.h M +2 -2 trayicon.cpp M +1 -1 trayicon.h 652982 7 wrar 2008-10-12 12:14:36 +0000 It IS broken in 4.1.2 because of r864309 652990 8 uwolfer 2008-10-12 12:43:10 +0000 I do not feel comfortable to backport, because the patch does not cleanly apply to 4.1 branch and I cannot try build. Alex: you have committed r864309 which broke things according to comment above. Could you please check? 652994 9 alex.merry 2008-10-12 12:54:24 +0000 winterz backported my fix (r860909) from trunk (which was really only half a fix - it makes the tray icon show the window, but not hide it, and this is what Gopala Krishna A changed). So I can't really comment on what it does to the branch, other than that it will probably prevent Akregator from being hidden by clicking the tray icon if it worked before. 652996 10 wrar 2008-10-12 12:58:23 +0000 Akregator from 4.1.2 shows the window when clicking, but doesn't hide it. I thought this bug is entirely about this behavior. 653401 11 alex.merry 2008-10-13 20:23:51 +0000 It's not obvious from the title, and the report is no help (hint to submitter: please include "what it does" and "what you expect it to do" in the report). If it worked properly before r864309, it should be reverted. If not, r870288 (ie: the patch attached to this bug) should be backported. I don't have any way of testing which scenario is true. 655617 12 gekylafas 2008-10-21 00:12:32 +0000 There is relevant report in Kubuntu about the branch bug: https://bugs.launchpad.net/ubuntu/+source/kdepim/+bug/276880 656057 13 uwolfer 2008-10-22 19:37:24 +0000 SVN commit 874882 by uwolfer: Revert r864309, which was not necessary to backport (breaks things as confirmed multiple times; please retest now) CCBUG:171642 M +0 -2 mainwindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=874882 663457 14 wrar 2008-11-11 21:21:58 +0000 Verified for 4.1.3. 664691 15 droebuck 2008-11-14 08:42:07 +0000 I'm using 4.1.3, clicking on the icon still doesn't show or hide, but I can right click and I can fetch, configure or quit. I read that it's fixed for kubuntu (https://bugs.launchpad.net/ubuntu/+source/kdepim/+bug/276880), but I'm currently using opensuse. 744795 16 msp 2009-04-19 12:30:47 +0000 Also seen in Debian http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=513323 746315 17 mattia.milleri 2009-04-23 18:16:05 +0000 KDE Version 1.4.2 (KDE 4.2.2 (KDE 4.2.2), Kubuntu packages) Application KDE feed aggregator Operating System Linux (i686) release 2.6.28-11-generic Compiler cc I can still report this happening with the new Kubuntu 9.04 release. 27761 2008-10-09 16:58:23 +0000 2008-10-09 17:02:42 +0000 Toggles the Akregator::Part visibility between hide and show when system tray icon is clicked. trayShowHide.diff text/plain 2137 krishna.ggk SW5kZXg6IHNyYy9ha3JlZ2F0b3JfcGFydC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHNyYy9ha3JlZ2F0b3Jf cGFydC5oCShyZXZpc2lvbiA4Njk2MzMpCisrKyBzcmMvYWtyZWdhdG9yX3BhcnQuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTMzLDcgKzEzMyw3IEBACiAgICAgICAgIHZvaWQgc2hvd0tOb3RpZnlPcHRp b25zKCk7CiAKICAgICBzaWduYWxzOgotICAgICAgICB2b2lkIHNob3dQYXJ0KCk7CisgICAgICAg IHZvaWQgdG9nZ2xlU2hvd1BhcnQoKTsKICAgICAgICAgdm9pZCBzaWduYWxTZXR0aW5nc0NoYW5n ZWQoKTsKIAogCkluZGV4OiBzcmMvbWFpbndpbmRvdy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3JjL21h aW53aW5kb3cuY3BwCShyZXZpc2lvbiA4Njk2MzMpCisrKyBzcmMvbWFpbndpbmRvdy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTExMCw3ICsxMTAsNyBAQAogCiAgICAgY29ubmVjdChtX3BhcnQsIFNJ R05BTChzZXRXaW5kb3dDYXB0aW9uKFFTdHJpbmcpKSwgdGhpcywgU0xPVChzZXRDYXB0aW9uKFFT dHJpbmcpKSApOwogICAgIGNvbm5lY3QoVHJheUljb246OmdldEluc3RhbmNlKCksIFNJR05BTChx dWl0U2VsZWN0ZWQoKSksIHRoaXMsIFNMT1Qoc2xvdFF1aXQoKSkpOwotICAgIGNvbm5lY3QobV9w YXJ0LCBTSUdOQUwoc2hvd1BhcnQoKSksIHRoaXMsIFNMT1Qoc2hvdygpKSApOworICAgIGNvbm5l Y3QobV9wYXJ0LCBTSUdOQUwodG9nZ2xlU2hvd1BhcnQoKSksIHRoaXMsIFNMT1Qoc2xvdFRvZ2ds ZVZpc2liaWxpdHkoKSkgKTsKIAogICAgIGNyZWF0ZUdVSShtX3BhcnQpOwogICAgIGJyb3dzZXJF eHRlbnNpb24obV9wYXJ0KS0+c2V0QnJvd3NlckludGVyZmFjZShtX2Jyb3dzZXJJZmFjZSk7CkBA IC0yMzYsOCArMjM2LDEzIEBACiAgICAgbV9zdGF0dXNMYWJlbC0+c2V0VGV4dCh0ZXh0KTsKIH0K IAotIHZvaWQgTWFpbldpbmRvdzo6YXV0b1NhdmVQcm9wZXJ0aWVzKCkKK3ZvaWQgTWFpbldpbmRv dzo6c2xvdFRvZ2dsZVZpc2liaWxpdHkoKQogeworICBzZXRWaXNpYmxlKCFpc1Zpc2libGUoKSk7 Cit9CisKK3ZvaWQgTWFpbldpbmRvdzo6YXV0b1NhdmVQcm9wZXJ0aWVzKCkKK3sKICAgICBLQ29u ZmlnIGNvbmZpZygiYXV0b3NhdmVkIiwgS0NvbmZpZzo6U2ltcGxlQ29uZmlnLAogICAgICAgICAi YXBwZGF0YSIpOwogICAgIEtDb25maWdHcm91cCBjb25maWdHcm91cCgmY29uZmlnLCAiTWFpbldp bmRvdyIpOwpJbmRleDogc3JjL2FrcmVnYXRvcl9wYXJ0LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzcmMv YWtyZWdhdG9yX3BhcnQuY3BwCShyZXZpc2lvbiA4Njk2MzMpCisrKyBzcmMvYWtyZWdhdG9yX3Bh cnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTYsNyArMTU2LDcgQEAKICAgICBUcmF5SWNvbjo6 c2V0SW5zdGFuY2UodHJheUljb24pOwogICAgIG1fYWN0aW9uTWFuYWdlci0+aW5pdFRyYXlJY29u KHRyYXlJY29uKTsKIAotICAgIGNvbm5lY3QodHJheUljb24sIFNJR05BTChzaG93UGFydCgpKSwg dGhpcywgU0lHTkFMKHNob3dQYXJ0KCkpKTsKKyAgICBjb25uZWN0KHRyYXlJY29uLCBTSUdOQUwo c2hvd1BhcnQoKSksIHRoaXMsIFNJR05BTCh0b2dnbGVTaG93UGFydCgpKSk7CiAKICAgICBpZiAo IGlzVHJheUljb25FbmFibGVkKCkgKQogICAgIHsKSW5kZXg6IHNyYy9tYWlud2luZG93LmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gc3JjL21haW53aW5kb3cuaAkocmV2aXNpb24gODY5NjMzKQorKysgc3JjL21h aW53aW5kb3cuaAkod29ya2luZyBjb3B5KQpAQCAtODgsNiArODgsNyBAQAogcHVibGljIHNsb3Rz OgogICAgIHZvaWQgc2xvdENsZWFyU3RhdHVzVGV4dCgpOwogICAgIHZvaWQgc2xvdFNldFN0YXR1 c0JhclRleHQoY29uc3QgUVN0cmluZyAmYyk7CisgICAgdm9pZCBzbG90VG9nZ2xlVmlzaWJpbGl0 eSgpOwogCiBwcm90ZWN0ZWQ6CiAgICAgLyoqCg== 27764 2008-10-09 17:02:42 +0000 2008-10-09 17:02:42 +0000 Toggles the Akregator::Part visibility between hide and show when system tray icon is clicked. trayShowHide2.diff text/plain 3149 krishna.ggk SW5kZXg6IHNyYy90cmF5aWNvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHNyYy90cmF5aWNvbi5oCShyZXZp c2lvbiA4Njk2MzMpCisrKyBzcmMvdHJheWljb24uaAkod29ya2luZyBjb3B5KQpAQCAtNTMsNyAr NTMsNyBAQAogICAgICAgICB2b2lkIHNsb3RBY3RpdmF0ZWQoUVN5c3RlbVRyYXlJY29uOjpBY3Rp dmF0aW9uUmVhc29uIHJlYXNvbik7CiAKICAgICBzaWduYWxzOgotICAgICAgICB2b2lkIHNob3dQ YXJ0KCk7CisgICAgICAgIHZvaWQgdG9nZ2xlU2hvd1BhcnQoKTsKIAogICAgIHByaXZhdGU6CiAg ICAgICAgIHN0YXRpYyBUcmF5SWNvbiogbV9pbnN0YW5jZTsKSW5kZXg6IHNyYy9ha3JlZ2F0b3Jf cGFydC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIHNyYy9ha3JlZ2F0b3JfcGFydC5oCShyZXZpc2lvbiA4Njk2 MzMpCisrKyBzcmMvYWtyZWdhdG9yX3BhcnQuaAkod29ya2luZyBjb3B5KQpAQCAtMTMzLDcgKzEz Myw3IEBACiAgICAgICAgIHZvaWQgc2hvd0tOb3RpZnlPcHRpb25zKCk7CiAKICAgICBzaWduYWxz OgotICAgICAgICB2b2lkIHNob3dQYXJ0KCk7CisgICAgICAgIHZvaWQgdG9nZ2xlU2hvd1BhcnQo KTsKICAgICAgICAgdm9pZCBzaWduYWxTZXR0aW5nc0NoYW5nZWQoKTsKIAogCkluZGV4OiBzcmMv bWFpbndpbmRvdy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3JjL21haW53aW5kb3cuY3BwCShyZXZpc2lv biA4Njk2MzMpCisrKyBzcmMvbWFpbndpbmRvdy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMCw3 ICsxMTAsNyBAQAogCiAgICAgY29ubmVjdChtX3BhcnQsIFNJR05BTChzZXRXaW5kb3dDYXB0aW9u KFFTdHJpbmcpKSwgdGhpcywgU0xPVChzZXRDYXB0aW9uKFFTdHJpbmcpKSApOwogICAgIGNvbm5l Y3QoVHJheUljb246OmdldEluc3RhbmNlKCksIFNJR05BTChxdWl0U2VsZWN0ZWQoKSksIHRoaXMs IFNMT1Qoc2xvdFF1aXQoKSkpOwotICAgIGNvbm5lY3QobV9wYXJ0LCBTSUdOQUwoc2hvd1BhcnQo KSksIHRoaXMsIFNMT1Qoc2hvdygpKSApOworICAgIGNvbm5lY3QobV9wYXJ0LCBTSUdOQUwodG9n Z2xlU2hvd1BhcnQoKSksIHRoaXMsIFNMT1Qoc2xvdFRvZ2dsZVZpc2liaWxpdHkoKSkgKTsKIAog ICAgIGNyZWF0ZUdVSShtX3BhcnQpOwogICAgIGJyb3dzZXJFeHRlbnNpb24obV9wYXJ0KS0+c2V0 QnJvd3NlckludGVyZmFjZShtX2Jyb3dzZXJJZmFjZSk7CkBAIC0yMzYsOCArMjM2LDEzIEBACiAg ICAgbV9zdGF0dXNMYWJlbC0+c2V0VGV4dCh0ZXh0KTsKIH0KIAotIHZvaWQgTWFpbldpbmRvdzo6 YXV0b1NhdmVQcm9wZXJ0aWVzKCkKK3ZvaWQgTWFpbldpbmRvdzo6c2xvdFRvZ2dsZVZpc2liaWxp dHkoKQogeworICBzZXRWaXNpYmxlKCFpc1Zpc2libGUoKSk7Cit9CisKK3ZvaWQgTWFpbldpbmRv dzo6YXV0b1NhdmVQcm9wZXJ0aWVzKCkKK3sKICAgICBLQ29uZmlnIGNvbmZpZygiYXV0b3NhdmVk IiwgS0NvbmZpZzo6U2ltcGxlQ29uZmlnLAogICAgICAgICAiYXBwZGF0YSIpOwogICAgIEtDb25m aWdHcm91cCBjb25maWdHcm91cCgmY29uZmlnLCAiTWFpbldpbmRvdyIpOwpJbmRleDogc3JjL2Fr cmVnYXRvcl9wYXJ0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzcmMvYWtyZWdhdG9yX3BhcnQuY3BwCShy ZXZpc2lvbiA4Njk2MzMpCisrKyBzcmMvYWtyZWdhdG9yX3BhcnQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xNTYsNyArMTU2LDcgQEAKICAgICBUcmF5SWNvbjo6c2V0SW5zdGFuY2UodHJheUljb24p OwogICAgIG1fYWN0aW9uTWFuYWdlci0+aW5pdFRyYXlJY29uKHRyYXlJY29uKTsKIAotICAgIGNv bm5lY3QodHJheUljb24sIFNJR05BTChzaG93UGFydCgpKSwgdGhpcywgU0lHTkFMKHNob3dQYXJ0 KCkpKTsKKyAgICBjb25uZWN0KHRyYXlJY29uLCBTSUdOQUwodG9nZ2xlU2hvd1BhcnQoKSksIHRo aXMsIFNJR05BTCh0b2dnbGVTaG93UGFydCgpKSk7CiAKICAgICBpZiAoIGlzVHJheUljb25FbmFi bGVkKCkgKQogICAgIHsKSW5kZXg6IHNyYy9tYWlud2luZG93LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3Jj L21haW53aW5kb3cuaAkocmV2aXNpb24gODY5NjMzKQorKysgc3JjL21haW53aW5kb3cuaAkod29y a2luZyBjb3B5KQpAQCAtODgsNiArODgsNyBAQAogcHVibGljIHNsb3RzOgogICAgIHZvaWQgc2xv dENsZWFyU3RhdHVzVGV4dCgpOwogICAgIHZvaWQgc2xvdFNldFN0YXR1c0JhclRleHQoY29uc3Qg UVN0cmluZyAmYyk7CisgICAgdm9pZCBzbG90VG9nZ2xlVmlzaWJpbGl0eSgpOwogCiBwcm90ZWN0 ZWQ6CiAgICAgLyoqCkluZGV4OiBzcmMvdHJheWljb24uY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHNyYy90 cmF5aWNvbi5jcHAJKHJldmlzaW9uIDg2OTYzMykKKysrIHNyYy90cmF5aWNvbi5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTc1LDcgKzc1LDcgQEAKIAogdm9pZCBUcmF5SWNvbjo6c2xvdEFjdGl2YXRl ZChRU3lzdGVtVHJheUljb246OkFjdGl2YXRpb25SZWFzb24gcmVhc29uKSB7CiAgIGlmIChyZWFz b24gPT0gUVN5c3RlbVRyYXlJY29uOjpUcmlnZ2VyICkKLSAgICBlbWl0IHNob3dQYXJ0KCk7Cisg ICAgZW1pdCB0b2dnbGVTaG93UGFydCgpOwogfQogCiAKQEAgLTE1MCw3ICsxNTAsNyBAQAogICAg ICAgICBRU3RyaW5nIGNvdW50U3RyID0gUVN0cmluZzo6bnVtYmVyKCB1bnJlYWQgKTsKICAgICAg ICAgUUZvbnQgZiA9IEtHbG9iYWxTZXR0aW5nczo6Z2VuZXJhbEZvbnQoKTsKICAgICAgICAgZi5z ZXRCb2xkKHRydWUpOwotCQorCiAgICAgICAgIGZsb2F0IHBvaW50U2l6ZSA9IGYucG9pbnRTaXpl RigpOwogICAgICAgICBRRm9udE1ldHJpY3MgZm0oZik7CiAgICAgICAgIGludCB3ID0gZm0ud2lk dGgoY291bnRTdHIpOwo=