170411 2008-09-04 20:17:56 +0000 problem with empty cssRules in styleSheets 2008-10-20 00:28:07 +0000 1 1 2 Applications konqueror khtml unspecified Microsoft Windows Microsoft Windows RESOLVED FIXED NOR normal --- 0 lunter konqueror-bugs-null germain maksim WojciechK 0 oldest_to_newest 643688 0 lunter 2008-09-04 20:17:56 +0000 Version: Konqueror 4.1.1 (Windows XP) (using KDE 4.1.1) Compiler: n/a n/a OS: MS Windows Installed from: MS Windows http://pc44.one.pl/goorol/bugs/kde_002.html KHTML JS ignores empty rules in styleSheets! 643689 1 27244 lunter 2008-09-04 20:18:22 +0000 Created attachment 27244 source 645526 2 WojciechK 2008-09-11 15:15:26 +0000 Confirmed on konqueror 4.0 650640 3 germain 2008-10-03 04:27:54 +0000 SVN commit 867194 by ggarand: do not skip empty CSS rules - they must appear in the cssRules array. digg.com, for instance, needs this to perform some unspeakable CSS hacks. BUG: 170411, 165734 M +1 -1 parser.cpp M +1 -1 parser.y --- trunk/KDE/kdelibs/khtml/css/parser.cpp #867193:867194 @@ -2427,7 +2427,7 @@ kDebug( 6080 ) << "got ruleset" << endl << " selector:"; #endif CSSParser *p = static_cast<CSSParser *>(parser); - if ( (yyvsp[(1) - (2)].selectorList) && (yyvsp[(2) - (2)].ok) && p->numParsedProperties ) { + if ( (yyvsp[(1) - (2)].selectorList) ) { CSSStyleRuleImpl *rule = new CSSStyleRuleImpl( p->styleElement ); CSSStyleDeclarationImpl *decl = p->createStyleDeclaration( rule ); rule->setSelector( (yyvsp[(1) - (2)].selectorList) ); --- trunk/KDE/kdelibs/khtml/css/parser.y #867193:867194 @@ -648,7 +648,7 @@ kDebug( 6080 ) << "got ruleset" << endl << " selector:"; #endif CSSParser *p = static_cast<CSSParser *>(parser); - if ( $1 && $2 && p->numParsedProperties ) { + if ( $1 ) { CSSStyleRuleImpl *rule = new CSSStyleRuleImpl( p->styleElement ); CSSStyleDeclarationImpl *decl = p->createStyleDeclaration( rule ); rule->setSelector( $1 ); 655453 4 germain 2008-10-20 00:28:07 +0000 SVN commit 873668 by ggarand: automatically merged revision 867194: do not skip empty CSS rules - they must appear in the cssRules array. digg.com, for instance, needs this to perform some unspeakable CSS hacks. BUG: 170411, 165734 M +1 -1 parser.cpp M +1 -1 parser.y WebSVN link: http://websvn.kde.org/?view=rev&revision=873668 27244 2008-09-04 20:18:22 +0000 2008-09-04 20:18:22 +0000 source kde_002.html text/html 245 lunter PGRpdj5GRiwgT3BlcmEsIFNhZmFyaSAoYW5kIElFKSBhbGVydCAnLmF7fSc8L2Rpdj4NCjxkaXY+ S0hUTUwgYWxlcnRzICcuYntjb2xvcjpibHVlfScgYmVjYXVzZSB3cm9uZ2x5IGlnbm9yZXMgZW1w dHkgcnVsZSE8L2Rpdj4NCjxzdHlsZT4NCiAuYXt9DQogLmJ7Y29sb3I6Ymx1ZX0NCjwvc3R5bGU+ DQo8c2NyaXB0Pg0KIGFsZXJ0KGRvY3VtZW50LnN0eWxlU2hlZXRzWzBdLmNzc1J1bGVzWzBdLmNz c1RleHQpDQo8L3NjcmlwdD4=