<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>167955</bug_id>
          
          <creation_ts>2008-08-01 10:06:21 +0000</creation_ts>
          <short_desc>Can not exit krfb</short_desc>
          <delta_ts>2008-10-29 14:36:50 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krfb</product>
          <component>general</component>
          <version>unspecified</version>
          <rep_platform>Ubuntu</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ronny Standtke">Ronny.Standtke</reporter>
          <assigned_to name="Alessandro Praduroux">pradu</assigned_to>
          <cc>mail</cc>
    
    <cc>miwi</cc>
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>5</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>631838</commentid>
    <comment_count>0</comment_count>
    <who name="Ronny Standtke">Ronny.Standtke</who>
    <bug_when>2008-08-01 10:06:21 +0000</bug_when>
    <thetext>Version:            (using KDE 4.1.0)
Installed from:    Ubuntu Packages

When krfb sits in the systray and I select &quot;Quit&quot; in the right mouse button menu, a small window pops up for a tenth of a second and just disappears. Krfb just keeps on running. It is not possible to exit krfb this way.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>633504</commentid>
    <comment_count>1</comment_count>
    <who name="Martin Wilke">miwi</who>
    <bug_when>2008-08-04 12:49:38 +0000</bug_when>
    <thetext>I can confim this problem with qt 4.4.1 and 4.1 under FreeBSD.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>633518</commentid>
    <comment_count>2</comment_count>
    <who name="Ronny Standtke">Ronny.Standtke</who>
    <bug_when>2008-08-04 13:46:40 +0000</bug_when>
    <thetext>*** This bug has been confirmed by popular vote. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>643573</commentid>
    <comment_count>3</comment_count>
    <who name="George Kiagiadakis">mail</who>
    <bug_when>2008-09-04 15:20:52 +0000</bug_when>
    <thetext>This bug is still present on KDE 4.1.1. I wonder why and how the confirmation dialog closes so quickly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>656977</commentid>
    <comment_count>4</comment_count>
    <who name="Terry">t.lewis</who>
    <bug_when>2008-10-26 02:14:51 +0000</bug_when>
    <thetext>Also present in KDE 4.1.2 and reported at https://bugs.launchpad.net/ubuntu/+source/kdenetwork/+bug/271928. 

As mentioned in the bug report above, the bug can be reproduced by choosing &quot;Restore&quot;, close the window again and then choose &quot;Quit&quot;. Starting krfb and choosing &quot;Quit&quot; without any other program interaction behaves normally.

I&apos;m certainly no expert on KDE development but it seems krfb uses standard actions (KStandardActions?) as I can&apos;t find anything relating to the actual quit event in the source code, perhaps there is a conflict here? But like I said, I&apos;m far from an expert on C++ let alone KDE development.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>658224</commentid>
    <comment_count>5</comment_count>
    <who name="George Kiagiadakis">mail</who>
    <bug_when>2008-10-28 20:50:26 +0000</bug_when>
    <thetext>The issue seems to be quite complex here... The problem seems to originate on the fact that krfb maintains its own main loop which calls QApplication::processEvents() on every run to ensure that events from the qt event loop are delivered. However, the quit confirmation dialog is a KMessageBox, which in turn runs its own event loop on top of qt&apos;s and krfb&apos;s main loop doesn&apos;t take that into account. As it seems, the code was the same in kde3, but apparently it worked (I didn&apos;t test it though!), so the port from qt3 to qt4 might be the cause that revealed this bug. I&apos;ll try to think of a workaround...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>658318</commentid>
    <comment_count>6</comment_count>
    <who name="George Kiagiadakis">mail</who>
    <bug_when>2008-10-29 00:58:37 +0000</bug_when>
    <thetext>SVN commit 877254 by gkiagia:

Integrate the rfb event system with qt&apos;s event loop instead of running a custom event loop in KrfbServer.
This fixes the major problem that modal dialogs were closing immediately after they were shown,
which caused huge usability issues.
BUG: 167955



 M  +25 -17    krfbserver.cpp  
 M  +2 -2      krfbserver.h  
 M  +1 -4      main.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&amp;revision=877254
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>658328</commentid>
    <comment_count>7</comment_count>
    <who name="George Kiagiadakis">mail</who>
    <bug_when>2008-10-29 01:21:33 +0000</bug_when>
    <thetext>SVN commit 877255 by gkiagia:

Backport r877254.
Integrate the rfb event system with qt&apos;s event loop instead of running a custom event loop in KrfbServer.
This fixes the major problem that modal dialogs were closing immediately after they were shown,
which caused huge usability issues.
CCBUG: 167955



 M  +25 -17    krfbserver.cpp  
 M  +2 -2      krfbserver.h  
 M  +1 -4      main.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&amp;revision=877255
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>658335</commentid>
    <comment_count>8</comment_count>
    <who name="Terry">t.lewis</who>
    <bug_when>2008-10-29 01:50:31 +0000</bug_when>
    <thetext>I&apos;ve tested your fixes against the Ubuntu sources and I can confirm it is working for me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>658531</commentid>
    <comment_count>9</comment_count>
    <who name="George Kiagiadakis">mail</who>
    <bug_when>2008-10-29 14:14:04 +0000</bug_when>
    <thetext>*** Bug 167954 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>