164301 2008-06-17 15:50:45 +0000 Filter Albums sub-tree names too, when using quickfilter on icon view 2012-08-06 09:04:14 +0000 1 1 2 Applications digikam Albums-Filters unspecified Mandriva RPMs Linux RESOLVED FIXED NOR wishlist --- 1 friiduh digikam-bugs-null 0.9.4 0 oldest_to_newest 612838 0 friiduh 2008-06-17 15:50:45 +0000 Version: (using KDE 3.5.9) Installed from: Mandriva RPMs OS: Linux Currently when "View > Include Albums Sub-Tree" is ON and user has main album open what includes multiple sub-albums, the icon view filter does not filter search results from album names, only from photos and tags etc. Expand this functionality so when typing to filter path, it is going to be searched from photos and sub-albums names too. 612843 1 25407 andi.clemens 2008-06-17 15:55:03 +0000 Created attachment 25407 patch #1 Gilles, what do you think? Can we add this to the final release...? This is really a little patch that doesn't break anything. 612844 2 25408 andi.clemens 2008-06-17 15:55:04 +0000 Created attachment 25408 patch #1 Gilles, what do you think? Can we add this to the final release...? This is really a little patch that doesn't break anything. 612846 3 caulier.gilles 2008-06-17 16:00:31 +0000 Andi, Agree. Go ahead. Gilles 612848 4 andi.clemens 2008-06-17 16:05:09 +0000 Yes Sir... :-) 612850 5 andi.clemens 2008-06-17 16:10:10 +0000 SVN commit 821448 by aclemens: Album names are searched as well now when using the quickfilter. BUG:164301 M +1 -0 NEWS M +4 -1 digikam/albumlister.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=821448 612872 6 caulier.gilles 2008-06-17 16:36:06 +0000 SVN commit 821456 by cgilles: backport commit #821448 from KDE3 branch CCBUGS: 164301 M +6 -1 albumlister.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=821456 613509 7 caulier.gilles 2008-06-19 14:01:03 +0000 Andi, I have found a little problem with your patch : the album titles will be filtered only if this condition is true : if (settings->getIconShowName()) { } ... getIconShowName() is return true if icon item name is displayed on iconview (file name in fact). This is not related to album title. This is want mean than album titles will be filtered only when file names are displayed on icon-view. To solve this problem you just need to move album titles filtering code outside this conditional section. Gilles 613522 8 andi.clemens 2008-06-19 14:42:01 +0000 So the quickfilter for text search only works when the filename, caption or tags are displayed in the thumbnail item? Maybe this should be mentioned somewhere, because if you don't display those fields, the search will always fail and some users might be confused. I don't know but do we really need to check on those special cases? Like only filter for filename if filename is also displayed? But as for the specific problem you are right of course, I need to move this line somewhere else. 613525 9 andi.clemens 2008-06-19 14:54:17 +0000 SVN commit 822181 by aclemens: fixed searching for folder names CCBUGS:164301 M +6 -2 albumlister.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=822181 613529 10 caulier.gilles 2008-06-19 15:15:04 +0000 SVN commit 822187 by cgilles: backport commit #822181 from KDE3 branch CCBUGS: 164301 M +7 -4 albumlister.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=822187 613535 11 arnd.baecker 2008-06-19 15:25:30 +0000 > So the quickfilter for text search only works when the filename, caption or tags are displayed in the thumbnail item? Maybe this should be mentioned somewhere, because if you don't display those fields, the search will always fail and some users might be confused. > I don't know but do we really need to check on those special cases? Like only filter for filename if filename is also displayed? I am also not sure about this. I.e. the quick filter could always work, even if filename/caption or tag are not displayed. Conceptually this is the difference between filtering according to the "properties" of an image, or according to what is displayed. Maybe the first is more natural? (For example for more than a few tags, they are not visible anyway due to lack of space....) Best, Arnd 613540 12 andi.clemens 2008-06-19 15:34:15 +0000 Also if displaying tags, filenames and tags all together is turned off, the quick filter for text search becomes disabled (visually). But if you don't know why this is happening, some might think this is a bug. 25407 2008-06-17 15:55:03 +0000 2008-06-17 15:55:03 +0000 patch #1 albumlister.patch text/plain 648 andi.clemens SW5kZXg6IGRpZ2lrYW0vYWxidW1saXN0ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGRpZ2lrYW0vYWxi dW1saXN0ZXIuY3BwCShyZXZpc2lvbiA4MjEzOTUpCisrKyBkaWdpa2FtL2FsYnVtbGlzdGVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDMwLDggKzQzMCwxMSBAQAogICAgICAgICBmb3VuZFRleHQg PSBmYWxzZTsKICAgICAgICAgaWYgKHNldHRpbmdzLT5nZXRJY29uU2hvd05hbWUoKSkKICAgICAg ICAgewotICAgICAgICAgICAgaWYgKGluZm8tPm5hbWUoKS5sb3dlcigpLmNvbnRhaW5zKGQtPnRl eHRGaWx0ZXIubG93ZXIoKSkpCisgICAgICAgICAgICBpZiAoaW5mby0+bmFtZSgpLmxvd2VyKCku Y29udGFpbnMoZC0+dGV4dEZpbHRlci5sb3dlcigpKSB8fAorICAgICAgICAgICAgICAgIGluZm8t PmFsYnVtKCktPnRpdGxlKCkubG93ZXIoKS5jb250YWlucyhkLT50ZXh0RmlsdGVyLmxvd2VyKCkp KQorICAgICAgICAgICAgewogICAgICAgICAgICAgICAgIGZvdW5kVGV4dCA9IHRydWU7CisgICAg ICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgaWYgKHNldHRpbmdzLT5nZXRJY29uU2hvd0Nv bW1lbnRzKCkpCiAgICAgICAgIHsK 25408 2008-06-17 15:55:04 +0000 2008-06-17 15:55:04 +0000 patch #1 albumlister.patch text/plain 648 andi.clemens SW5kZXg6IGRpZ2lrYW0vYWxidW1saXN0ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGRpZ2lrYW0vYWxi dW1saXN0ZXIuY3BwCShyZXZpc2lvbiA4MjEzOTUpCisrKyBkaWdpa2FtL2FsYnVtbGlzdGVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDMwLDggKzQzMCwxMSBAQAogICAgICAgICBmb3VuZFRleHQg PSBmYWxzZTsKICAgICAgICAgaWYgKHNldHRpbmdzLT5nZXRJY29uU2hvd05hbWUoKSkKICAgICAg ICAgewotICAgICAgICAgICAgaWYgKGluZm8tPm5hbWUoKS5sb3dlcigpLmNvbnRhaW5zKGQtPnRl eHRGaWx0ZXIubG93ZXIoKSkpCisgICAgICAgICAgICBpZiAoaW5mby0+bmFtZSgpLmxvd2VyKCku Y29udGFpbnMoZC0+dGV4dEZpbHRlci5sb3dlcigpKSB8fAorICAgICAgICAgICAgICAgIGluZm8t PmFsYnVtKCktPnRpdGxlKCkubG93ZXIoKS5jb250YWlucyhkLT50ZXh0RmlsdGVyLmxvd2VyKCkp KQorICAgICAgICAgICAgewogICAgICAgICAgICAgICAgIGZvdW5kVGV4dCA9IHRydWU7CisgICAg ICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgaWYgKHNldHRpbmdzLT5nZXRJY29uU2hvd0Nv bW1lbnRzKCkpCiAgICAgICAgIHsK