157850 2008-02-15 05:20:40 +0000 KStandardDirs picks kde3 application data instead of kde4's when both are installed (affects khtml) 2009-10-14 03:45:44 +0000 1 1 10 Unmaintained kdelibs general 4.0 unspecified Linux RESOLVED FIXED NOR major --- 1 tkaitchuck kdelibs-bugs-null a.m.p.boelens bh.inbox debian exabyte fabo faure finex georg.wittenburg hkBst jachymb jlp list lists-kdedevel mail me mefoster mpapet ndbecker2 r-kde rasasi78 rdieter seufert tiposchi torquil west.wallaby zahl 66 oldest_to_newest 580432 0 tkaitchuck 2008-02-15 05:20:41 +0000 Version: unknown (using 4.0.1 (KDE 4.0.1), Debian packages) Compiler: cc OS: Linux (x86_64) release 2.6.22-3-amd64 Using the default 'Oxygen' schema, Konqueror will make input boxes borderless until the mouse clicks on them. This makes sites like bugs.kde.org virtually unusable as they have the same background color inside the input box as for the page, so one cannot tell the box is even there until you click on it. 584722 1 xavier 2008-03-06 12:39:21 +0000 I confirm this bug. It makes quite impossible to fill forms on web page with black background as text in form is in black too. See a sample here: http://pacte.blogs.apf.asso.fr/sign.html note that this page is for impaired users... 584815 2 maksim 2008-03-06 20:21:06 +0000 Can't confirm. 584883 3 cbo 2008-03-07 00:05:49 +0000 I couldn't confirm when i compiled from sources. But then i installed 4.0.1 packages from debian and then I see it. I don't think it's a distribution thing as such, but something must be different. 584985 4 xavier 2008-03-07 11:37:30 +0000 Well, I forgot to say I am in Debian Sid, AMD64. 584988 5 cbo 2008-03-07 11:43:16 +0000 hmm that is 3 times debian - a pattern is emerging :( 584989 6 xavier 2008-03-07 11:46:59 +0000 I can try in Kubuntu if you need. Do you know if the packages are the same ? 584993 7 cbo 2008-03-07 11:50:04 +0000 i have no idea, but please try as many distributions as you can well you can stop when you find a distribution that doesn't show the bug 585384 8 maksim 2008-03-08 21:47:48 +0000 *** Bug 158981 has been marked as a duplicate of this bug. *** 586113 9 xavier 2008-03-11 11:31:45 +0000 The bug doesn't happened with kubuntu on AMD64 (I confirmed the bug with Debian on the same computer). So, it's a Debian bug... 586114 10 cbo 2008-03-11 11:40:04 +0000 Great, thanks for examining this. I'll get hold of some debian dev and discuss this 586152 11 modax.reg 2008-03-11 14:10:24 +0000 Irronically, quirks mode is OK. Strict & transitional are not. 586158 12 xavier 2008-03-11 14:29:07 +0000 I have the bug on pages with and without doctype settings 586177 13 modax.reg 2008-03-11 15:54:40 +0000 "background-color: transparent" is causing this problem. transparent is default for standards compliant mode whereas other value is probably default for quirks mode. Setting e.g. "background-color: white" for input elements make borders reappear. Can you confirm? 586205 14 xavier 2008-03-11 18:09:00 +0000 Confirmed with background-color:white for an input field. 586302 15 modax.reg 2008-03-12 00:14:33 +0000 In QLineEdit case, Oxygen uses QPalette::Window color to draw QLineEdit frame. If that color is set to QColor(0,0,0,0) (what khtml does in case of background-color: transparent), QLineEdit ends up with non-visible frame. The problem can be reproduced by writing a simple Qt-only Gui application with a QLineEdit using palette which QPalette::Window & QPalette::Base are set to QColor(0,0,0,0). Example attached below. My setBgColor() is essentially the same to what khtml does to set background color. There are similar problems with QComboBox, QPushButton (and maybe something else) too. What's more, there's another very annoying problem that QComboBox item scrollbox is completely broken with transparent color (try to scroll it and you should see), but that seems to be generic Qt problem (because other styles suffer from it too). So this problem does not look like Debian-specific at all. However, I did all these tests on Debian sid/amd64 Qt 4.3.4/kde 3.5.9. Please test on other distros. 586303 16 modax.reg 2008-03-12 00:15:05 +0000 I meant kde 4.0.2. Sorry 586304 17 23870 modax.reg 2008-03-12 00:17:47 +0000 Created attachment 23870 Short test case (Qt only) Compile with: g++ transtest.cpp -o transtest -I/usr/include/qt4 -lQtCore -lQtGui 586305 18 cbo 2008-03-12 00:25:11 +0000 I've gone through the debian patches and couldn't find anything to explain why it happens on some distributions and not others. Thanks Modestas, it sounds like you have cracked it. Yay for the power of opensource :) I'll try to work on a fix 587090 19 multescugeorge 2008-03-15 14:36:02 +0000 Tested on Fedora 9 rawhide, Using Oxygen schema. kde 4.0.2. Bug is alive Any input fields or click-to-check buttons on web pages are invisible until you click on them. It even happens on http://bugs.kde.org . Hilarious to go hunting for check boxes with you mouse. 588993 20 maksim 2008-03-23 17:33:23 +0000 *** Bug 156152 has been marked as a duplicate of this bug. *** 588995 21 maksim 2008-03-23 17:33:46 +0000 *** Bug 159590 has been marked as a duplicate of this bug. *** 589378 22 mwoehlke.floss 2008-03-25 22:29:45 +0000 transtest.cpp is a horrible example... you asked us to make everything transparent, so we did. Don't do that :-). I'm looking at improving things when only Window is transparent... 589384 23 modax.reg 2008-03-25 22:51:42 +0000 transtest.cpp is a shortened version of *what khtml does* (background-color defaults to transparent as per CSS). 589413 24 mwoehlke.floss 2008-03-26 01:03:50 +0000 Does khtml *also set button and base transparent*? What exactly are you expecting? You asked us to use transparent for all our drawing (except text) so we did. I've no intention of fixing that and I don't think boemann does either. I'm investigating making lineedits more clever when only window color is "missing", but if the palette is "empty" there's nothing we can do about it (and if it is, I'd point the finger at khtml, which shouldn't be doing such things). 589421 25 modax.reg 2008-03-26 01:37:14 +0000 > Does khtml *also set button and base transparent*? As far as I can tell, yes, it does. Are you using konqueror 4? If you do, you should see this problem when you look at the "Commit" button below in this page. Offending code is in kdelibs/khtml/rendering/render_replaced.cpp at RenderWidget::updateFromElement() If you believe khtml is doing something wrong (and you know more about styles than I do), reassign the bug to khtml. I'm not a kde developer, simply this bug is my 'pet' bug so I invested some time into tracking it. 589423 26 24055 mwoehlke.floss 2008-03-26 01:38:32 +0000 Created attachment 24055 patch to use Base for 3d effects if Window is invalid Here's a patch to use Base instead of Window for the 3d-effects drawing (the shadow in particular) if Window is invalid (i.e. alpha=0). Since I don't seem to have the problem, can someone please let me know if this works for them? I can't test with transtest, as for some reason I seem to be getting Window==Qt::black for that, which results (correctly) in a white shadow color. 589459 27 xavier 2008-03-26 09:50:23 +0000 I've tested with other styles (Debian sid/amd64, KDE 4.02). - Phase: same problem - Motif: same problem - CDE: same problem - MS Windows 9x: right and bottom border of fields are invisibles; upper and left border of submit and cancel buttons are invisibles; left and bottom border of select fields are invisibles. - Cleanlooks: right border of Checkbox and Radio buttons are invisibles, other fields are ok. - Plastique: everything works. Is it related to shadow and 3D effects on fields? 595030 28 mefoster 2008-04-19 10:41:26 +0000 Still definitely an issue with Fedora 9 (KDE 4.0.3). I also find that pulldown lists get corrupted display -- is this the same issue? 595034 29 mefoster 2008-04-19 10:54:25 +0000 No, the pulldown lists are bug 157850 ... 595035 30 mefoster 2008-04-19 10:55:27 +0000 Oops, I meant bug 155573 597129 31 modax.reg 2008-04-26 02:41:48 +0000 The patch does not fix the problem. 599013 32 finex 2008-05-05 15:31:54 +0000 I've tried the URL on the comment #1. The input fields use a clear background. Even bugs.kde.org input fields are ok: them show a border. This bug seems fixed to me (trunk, r802881). 599091 33 modax.reg 2008-05-05 21:02:01 +0000 I'm using trunk too (804262) and I can confirm that the issue is NOT fixed. Maybe this is video driver issue? I'm using nvidia (proprietary) driver on this machine. 599139 34 finex 2008-05-06 01:25:32 +0000 I'm using nvidia drivers too. I've tested on a clean user directory with the default KDE settings. @Modestas: What version of Qt are you using? 599453 35 modax.reg 2008-05-07 11:27:04 +0000 Qt 4.4.0~rc1 for the moment. 599461 36 finex 2008-05-07 11:58:11 +0000 Me too. Anyway I'm recompiling trunk with the new 4.4 final. Let see how it will works. 601636 37 voker57 2008-05-16 17:02:54 +0000 *** This bug has been confirmed by popular vote. *** 602458 38 24840 thelich 2008-05-19 03:53:07 +0000 Created attachment 24840 Transparent background fix In my case Plastique style has the same issue. As mentioned above - the problem is in the kdelibs/khtml/rendering/render_replaced.cpp at RenderWidget::updateFromElement(). if backgroundColor is invalid (alpha is undefined) and rendering mode not inCompatible (style()->htmlHacks() is true) then backgroundColor is set to be transparent (0,0,0,0) (QColor(0,0,0,0) IS a valid color). This explains why in quirks mode rendering is ok (because in this case backgroundColor is set to backgroundRole). This patch fixes this issue for me. 602607 39 mwoehlke.floss 2008-05-19 17:48:57 +0000 If plastique has the same issue, then it is NOT an oxygen bug. Fix khtml to not give us riddiculous palettes; we're just doing what we were told. 603137 40 germain 2008-05-21 19:03:30 +0000 hmm, there is a mix of isues here, so lets try to clear things up... It is perfectly legitimate for KHTML widgets to be as transparent as possible when specifically asked by CSS. e.g. "background-color: transparent", or "background-color: inherit" when the parent has no color. But of course this is in no way our default settings. As you can see in css/html4.css, our widgets have default CSS colours which are mapped to 'sensible' system colours in misc/helper.cpp. So there is obviously something wrong with the colour setup of vendors for which normal form widget appear transparent. For instance, a lineedit default background is 'background-color: window' which should map to qApp's QPalette::Base @Sergey: what your patch says is that you are getting an invalid background-color. And this should not happen with default CSS style.. Could you please investigate what the CSS-to-system colours mappings are on your system? (See khtml::colorForCSSValue( int css_value ) in misc/helper.cpp that's the place where wrong things are happening as far as I can tell) 603282 41 thelich 2008-05-22 05:52:54 +0000 Well, *if* "background-color" was set for element - then everything works ok. In my case "html4.css" didn't contain such definitions (I think it's Debian issue, because in svn version "html4.css" do contain proper "background-color" for every form element). But I think that there should be some kind of protection against not properly written css files, i.e. KHTML should not make widget to be transparent if no background-color was set for it. 603305 42 modax.reg 2008-05-22 10:06:26 +0000 It is not Debian issue (or it's not due to modified html4.css) and Debian does not patch khtml at all: $ md5sum src/kde/kdesvn/kdelibs/khtml/css/html4.css /usr/share/kde4/apps/khtml/css/html4.css 61e83bf7e502092f486f428d10616209 src/kde/kdesvn/kdelibs/khtml/css/html4.css 61e83bf7e502092f486f428d10616209 /usr/share/kde4/apps/khtml/css/html4.css 603319 43 thelich 2008-05-22 11:37:47 +0000 There is 2 packages installed in my system: kdelibs-data (3.5.8) to support kde3 programms kdelibs5-data (4.0.72) first places it's files into /usr/share/apps second places into /usr/share/kde4/apps /usr/share/kde4/apps/khtml/css/html4.css (61e83bf7e502092f486f428d10616209) - has all definitions /usr/share/apps/khtml/css/html4.css (a8249376d53cd223880fa3e2d6dbc810) - don't have "background-color" in form fields definitions. The main problem is, that KStandardDirs look for html4.css in this order: /home/user/.kde4/share/apps /usr/share/apps /usr/share/kde4/apps So, the first file which it finds will be html4.css from the kde3. That's why I'm insist that khtml should properly handle backgroundColor *even* if it is not set in default css file. Setting background to QColor(0,0,0,0) is evil. 603325 44 modax.reg 2008-05-22 12:04:40 +0000 Thanks a lot Sergey, you've just pointed to the solution of 2 bugs! (i.e. we need to patch KStandardDirs) 603351 45 germain 2008-05-22 14:48:50 +0000 re:#43 > That's why I'm insist that khtml should properly handle backgroundColor > *even* if it is not set in default css file. Setting background to > QColor(0,0,0,0) is evil. Certainly, but we don't have such choice because we are not the ones who abused the CSS specification by applying random CSS properties to form widgets. We just go out of our way to provide the best compatibility we can with the web as it is - and the proprietary features of other engines. For instance, try to paste this in the address bar of a Mozilla browser, then in that of Konqueror: data:text/html,<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd"><body style='background:url(http://kde.org/img/kde40.png) no-repeat'><input type=button value=Lorem style=background-color:transparent;font-size:35px> OTOH, there is indeed room for improvement when using the Oxygen style - we should let the borders be visible when non-focused. Also #155573 is valid - we shouldn't let transparency be inherited by the drop-down widget. Patches making progress on that fence are very welcome. 603353 46 germain 2008-05-22 15:00:42 +0000 Reassigning/retitling in light of Serguey's findings. Not sure if this is a vendor problem or KDE bug though.. 603512 47 thelich 2008-05-23 04:13:59 +0000 @Germain I'm not arguing with you against CSS validity, I'm talking about updateFromElement behaviour. *IF* there was "background-color:transparent", then there should be QColor(0,0,0,0), but I don't understand why backgroundColor have to be set to QColor(0,0,0,0) when no "background-color" was set at all! 603764 48 mwoehlke.floss 2008-05-24 00:13:18 +0000 > we should let the borders be visible when non-focused We should not ask for invisible widgets unless the CSS genuinely did that. If you (khtml) ask for an invisible widget, and Oxygen obliges you by giving you an invisible widget, that's not a bug. As the joke goes, "don't do that" ("doctor, it hurts when I do this..."). 604468 49 mpyne 2008-05-27 05:47:58 +0000 Sergey: How does Debian setup the KDEDIRS (and XDG_DATA_DIRS for that matter) on your system? I have the suspicion that /usr is a valid search dir for KStandardDirs but I wasn't aware that KStandardDirs could use paths like /usr/share/kde4. (KStandardDirs normally appends /share/$type which would lead to paths like /usr/kde4/share/apps, and I don't see any code which would make it /usr/share/kde4/apps). You want to make sure it has more specific entries before less specific ones. i.e. export XDG_DATA_DIRS=/usr/kde4/share:/usr/share My interpretation of the code is that XDG_DATA_DIRS if set precedes KDEDIRS but you may want to try just settings XDG_DATA_DIRS right and leaving KDEDIRS alone. I figure Debian patched KDE to search per Debian's guidelines but they need to make sure to search KDE 4 directories before system directories in that case. (Or in many many less words, I'm not sure that KStandardDirs is really buggy). For part 2, I don't see what the reason is for making the color transparent when there is no background-color entry set at all, which seems to be the case here? Is there a way to make the default white (or Background) and only change it if it's actually set in the CSS somewhere? 604471 50 thelich 2008-05-27 06:02:33 +0000 On Debian there is no /usr/kde4/share folder, there is /usr/share/kde4 (apps,config, e.t.c. all in there). Debian does not set any environment variables like KDEDIRS or XDG_DATA_DIRS also. (At leas my default-configured user doesn't have any). For part 2, I've proposed a patch ("transparent background fix"). It does everything you wrote about. 604696 51 mpyne 2008-05-28 05:34:51 +0000 Sergey: Your patch works fine for me and on a strict HTML 4.01 document I constructed seemed to work fine in the cases of: * No background specified (some solid color was picked up) * Transparent background chosen (background was transparent) * Background color specified (the color was used). This doesn't fix no border being drawn around "invisible" input widgets though, but that's a less pressing issue I think. I would recommend applying this patch (attachment 24840) so that Debian users can still get a sane default background color if their system misconfigures the KStandardDirs search path (which I think is the case here, I don't think KStandardDirs is buggy). 604717 52 germain 2008-05-28 08:49:28 +0000 SVN commit 813566 by ggarand: correct default stylesheet is mandatory for proper KHTML operation. --> versionize, check on start up, abort on mismatch. Will catch botched setups where kde3 application data dirs are used instead of kde4's (#157850.) CCBUG: 157850 M +12 -0 cssstyleselector.cpp M +2 -0 html4.css WebSVN link: http://websvn.kde.org/?view=rev&revision=813566 604723 53 germain 2008-05-28 09:09:03 +0000 > I don't understand why backgroundColor have to be set to QColor(0,0,0,0) when > no "background-color" was set at all! because that's how CSS work! There is no such thing as an unset CSS property. Properties have initial values. The background-color property's initial value *is* 'transparent'. 604762 54 thelich 2008-05-28 12:17:46 +0000 > because that's how CSS work! There is no such thing as an unset CSS property. Properties have initial values. The background-color property's initial value *is* 'transparent'. Well, I thought that *if* element doesn't have background-color set, then it uses parent's background, *if* parent doesn't have this property set then it uses property of its parent and so on. I.e. it should end up with main window background (body), but it will be real color, not transparent. I didn't find in CSS specifications that background-color (or any other color) should have 'transparent' initial value. It said to be UA dependent. But if you say that it should be transparent - then let it be transparent... I agree that there should be borders around elements in case of transparency, but what color have to be set for drop-down lists? transparent color make them look very wierd. 604865 55 mwoehlke.floss 2008-05-28 22:06:30 +0000 Firefox makes form widgets use system widget colors unless otherwise specified, which IMO is The Right Thing To Do. What's odd is that Konqueror, at least my build, seems to do the same? I guess because this box is KDE3-free I don't have the "affects khtml" problem? And when did invisible widgets become "loss of data or system crashes"? I'm adjusting this bug's severity accordingly. (I'm fine leaving it at "major", but seriously, "grave"?) 605005 56 germain 2008-05-29 14:12:16 +0000 *** Bug 162804 has been marked as a duplicate of this bug. *** 605007 57 germain 2008-05-29 14:13:32 +0000 *** Bug 162806 has been marked as a duplicate of this bug. *** 605024 58 rdieter 2008-05-29 15:14:22 +0000 Discussed on #kde-devel a couple days ago, the consensus from distro packagers present anyway (Trigger7 and myself mostly, but thiago wasn't convinced yet...) was that kde4-config --path data should have the value of DATA_INSTALL_DIR (/usr/share/kde4/apps here) come before CMAKE_INSTALL_PREFIX/share/apps (/usr/share/apps) I took a look at the kstandarddirs.cpp code, and unfortunately to my non-coder eyes, this would be non-trivial to fix cleanly. 605056 59 kretz 2008-05-29 17:54:54 +0000 I agree that DATA_INSTALL_DIR must be preferred over CMAKE_INSTALL_PREFIX/share/apps. The latter is not used by the installation so there should be no files from the KDE4 installation anyway. All the relevant files should be in DATA_INSTALL_DIR only. AFAICS removing CMAKE_INSTALL_PREFIX/share/apps from the list completely should be correct if all KDE application installs use DATA_INSTALL_DIR. But I imagine that would break apps that don't set DATA_INSTALL_DIR, especially self compiled KDE applications. So the best fix IMO is to make sure DATA_INSTALL_DIR comes before CMAKE_INSTALL_PREFIX/share/apps. 605211 60 fabo 2008-05-30 07:57:09 +0000 In case you are not subscribed to kde-core-devel mailing list, A patch was proposed by Sune (thread subject is "kstandarddirs"). Feel free to comments. 605361 61 germain 2008-05-30 18:06:52 +0000 *** Bug 162904 has been marked as a duplicate of this bug. *** 605365 62 germain 2008-05-30 18:14:58 +0000 *** Bug 162807 has been marked as a duplicate of this bug. *** 606001 63 maksim 2008-06-01 18:56:07 +0000 *** Bug 162999 has been marked as a duplicate of this bug. *** 607080 64 tommi.tervo 2008-06-04 08:59:23 +0000 *** Bug 163185 has been marked as a duplicate of this bug. *** 608199 65 maksim 2008-06-06 18:02:58 +0000 *** Bug 163362 has been marked as a duplicate of this bug. *** 608555 66 armin 2008-06-07 15:49:10 +0000 *** Bug 163338 has been marked as a duplicate of this bug. *** 609304 67 cbo 2008-06-09 17:38:30 +0000 *** Bug 157243 has been marked as a duplicate of this bug. *** 613565 68 maksim 2008-06-19 17:29:01 +0000 *** Bug 164327 has been marked as a duplicate of this bug. *** 622664 69 germain 2008-07-09 17:03:41 +0000 Hi Sune - what happened with your k-c-d patch eventually? I seem to recall reading there were some complications? Is this bug solved now? 622668 70 debian 2008-07-09 17:09:54 +0000 Hi Germain. It was committed some time ago in a quite different form after some discussions with especially dfaure. http://websvn.kde.org/trunk/KDE/kdelibs/kdecore/kernel/kstandarddirs.cpp?r1=819551&r2=819560 I don't know if it is solved in all cases though. 626812 71 maksim 2008-07-19 17:43:14 +0000 *** Bug 166981 has been marked as a duplicate of this bug. *** 640126 72 maksim 2008-08-23 00:34:28 +0000 *** Bug 161659 has been marked as a duplicate of this bug. *** 702977 73 andresbajotierra 2009-01-20 00:08:36 +0000 *** Bug 173604 has been marked as a duplicate of this bug. *** 702985 74 faure 2009-01-20 00:31:46 +0000 Seems my patch fixed it, since there's no post-4.1 duplicate of this issue (apart from gentoo where the kde3 prefix is allegedly put first in $KDEDIRS, which doesn't make sense for kde4 apps). 704957 75 andresbajotierra 2009-01-24 15:58:55 +0000 *** Bug 175069 has been marked as a duplicate of this bug. *** 705031 76 andresbajotierra 2009-01-24 18:34:24 +0000 *** Bug 176686 has been marked as a duplicate of this bug. *** 755963 77 tommi.tervo 2009-05-12 11:53:47 +0000 *** Bug 192419 has been marked as a duplicate of this bug. *** 755965 78 lists-kdedevel 2009-05-12 12:02:09 +0000 To Tommi Tervo: This is an honest question: how exactly is https://bugs.kde.org/show_bug.cgi?id=192419 a duplicate of this (157850) bug? 844773 79 andresbajotierra 2009-10-14 03:45:44 +0000 *** Bug 210440 has been marked as a duplicate of this bug. *** 23870 2008-03-12 00:17:47 +0000 2008-03-12 00:17:47 +0000 Short test case (Qt only) transtest.cpp text/x-c++src 2308 modax.reg I2luY2x1ZGUgPFF0Q29yZS9RVmFyaWFudD4KI2luY2x1ZGUgPFF0R3VpL1FBY3Rpb24+CiNpbmNs dWRlIDxRdEd1aS9RQXBwbGljYXRpb24+CiNpbmNsdWRlIDxRdEd1aS9RQnV0dG9uR3JvdXA+CiNp bmNsdWRlIDxRdEd1aS9RTGluZUVkaXQ+CiNpbmNsdWRlIDxRdEd1aS9RQ29tYm9Cb3g+CiNpbmNs dWRlIDxRdEd1aS9RUHVzaEJ1dHRvbj4KI2luY2x1ZGUgPFF0R3VpL1FNYWluV2luZG93PgoKY2xh c3MgTWFpbldpbmRvdyA6IHB1YmxpYyBRTWFpbldpbmRvdwp7CnB1YmxpYzoKICAgIFFMaW5lRWRp dCAqbG4xOwogICAgUUxpbmVFZGl0ICpsbjI7CiAgICBRQ29tYm9Cb3ggKmNvbWJvOwogICAgUVB1 c2hCdXR0b24gKmJ0bjsKICAgIAogICAgdm9pZCBzZXRCZ0NvbG9yKFFXaWRnZXQmIHdpZGdldCwg Y29uc3QgUUNvbG9yJiBjb2xvcjEsIGNvbnN0IFFDb2xvciYgY29sb3IyID0gUUNvbG9yKCksIGNv bnN0IFFDb2xvciYgY29sb3IzID0gUUNvbG9yKCkpIHsKICAgICAgICBRUGFsZXR0ZSBwYWwgPSBR QXBwbGljYXRpb246OnBhbGV0dGUoJndpZGdldCk7CiAgICAgICAgcGFsLnNldENvbG9yKFFQYWxl dHRlOjpXaW5kb3csIGNvbG9yMSk7CiAgICAgICAgcGFsLnNldENvbG9yKFFQYWxldHRlOjpCYXNl LCAoY29sb3IyLmlzVmFsaWQoKSkgPyBjb2xvcjIgOiBjb2xvcjEpOwogICAgICAgIHBhbC5zZXRD b2xvcihRUGFsZXR0ZTo6QnV0dG9uLCAoY29sb3IzLmlzVmFsaWQoKSkgPyBjb2xvcjMgOiBjb2xv cjEpOwogICAgICAgIHdpZGdldC5zZXRQYWxldHRlKHBhbCk7CgovKiAgICAgICAgZm9yICggaW50 IGkgPSAwOyBpIDwgUVBhbGV0dGU6Ok5Db2xvckdyb3VwczsgKytpICkgewogICAgICAgICAgICBw YWwuc2V0Q29sb3IoIChRUGFsZXR0ZTo6Q29sb3JHcm91cClpLCBRUGFsZXR0ZTo6V2luZG93LCBj b2xvciApOwogICAgICAgICAgICBwYWwuc2V0Q29sb3IoIChRUGFsZXR0ZTo6Q29sb3JHcm91cClp LCBRUGFsZXR0ZTo6TGlnaHQsIGNvbG9yICk7CiAgICAgICAgICAgIHBhbC5zZXRDb2xvciggKFFQ YWxldHRlOjpDb2xvckdyb3VwKWksIFFQYWxldHRlOjpEYXJrLCBjb2xvciApOwogICAgICAgICAg ICBwYWwuc2V0Q29sb3IoIChRUGFsZXR0ZTo6Q29sb3JHcm91cClpLCBRUGFsZXR0ZTo6TWlkLCBj b2xvciApOwogICAgICAgICAgICBwYWwuc2V0Q29sb3IoIChRUGFsZXR0ZTo6Q29sb3JHcm91cClp LCBRUGFsZXR0ZTo6TWlkbGlnaHQsIGNvbG9yICk7CiAgICAgICAgICAgIHBhbC5zZXRDb2xvcigg KFFQYWxldHRlOjpDb2xvckdyb3VwKWksIFFQYWxldHRlOjpCdXR0b24sIGNvbG9yICk7CiAgICAg ICAgICAgIHBhbC5zZXRDb2xvciggKFFQYWxldHRlOjpDb2xvckdyb3VwKWksIFFQYWxldHRlOjpC YXNlLCBjb2xvciApOwogICAgICAgIH0qLwogICAgfQoKICAgIE1haW5XaW5kb3coKQogICAgewog ICAgICAgIHJlc2l6ZSg2MDAsIDQwMCk7CgogICAgICAgIGxuMSA9IG5ldyBRTGluZUVkaXQodGhp cyk7CiAgICAgICAgbG4xLT5tb3ZlKDAsIDIwMCk7CgogICAgICAgIGxuMiA9IG5ldyBRTGluZUVk aXQodGhpcyk7CiAgICAgICAgbG4yLT5tb3ZlKDE1MCwgMjAwKTsKCiAgICAgICAgY29tYm8gPSBu ZXcgUUNvbWJvQm94KHRoaXMpOwogICAgICAgIGNvbWJvLT5tb3ZlKDMwMCwgMjAwKTsKICAgICAg ICBmb3IgKCBpbnQgaSA9IDA7IGkgPCA1MDsgaSsrKSB7CiAgICAgICAgICAgIGNvbWJvLT5hZGRJ dGVtKFFTdHJpbmcoIkl0ZW0gJTEiKS5hcmcoaSkpOwogICAgICAgIH0KICAgICAgICBjb21iby0+ c2V0TWF4VmlzaWJsZUl0ZW1zKDgpOwoKICAgICAgICBidG4gPSBuZXcgUVB1c2hCdXR0b24odGhp cyk7CiAgICAgICAgYnRuLT5tb3ZlKDQ1MCwgMjAwKTsKICAgICAgICBidG4tPnNldFRleHQoIkJ1 dHRvbiIpOwoKICAgICAgICAvLyBTZXQgYmFja2dyb3VuZCBjb2xvcnMKICAgICAgICBzZXRCZ0Nv bG9yKCp0aGlzLCBRdDo6d2hpdGUpOwogICAgICAgIGNvbnN0IFFDb2xvciYgY29sb3IgPSBRQ29s b3IoMCwwLDAsMCk7IC8vIFF0Ojp3aGl0ZTsKICAgICAgICBzZXRCZ0NvbG9yKCpsbjEsIGNvbG9y KTsKICAgICAgICBzZXRCZ0NvbG9yKCpsbjIsIGNvbG9yKTsKICAgICAgICBzZXRCZ0NvbG9yKCpj b21ibywgY29sb3IpOwogICAgICAgIHNldEJnQ29sb3IoKmJ0biwgY29sb3IpOwogICAgfTsKCn07 CgppbnQgbWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3YpCnsKICAgIFFBcHBsaWNhdGlvbiBhcHAo YXJnYywgYXJndik7CiAgICAKICAgIE1haW5XaW5kb3cgd2luOwogICAgd2luLnNob3coKTsKICAg IAogICAgcmV0dXJuIGFwcC5leGVjKCk7Cn07Cg== 24055 2008-03-26 01:38:32 +0000 2008-03-26 01:38:32 +0000 patch to use Base for 3d effects if Window is invalid inputcolor.patch text/plain 3175 mwoehlke.floss SW5kZXg6IG94eWdlbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gb3h5Z2VuLmNwcAkocmV2aXNpb24gNzkw MTU2KQorKysgb3h5Z2VuLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQzNSwxMCArMTQzNSwxMSBA QAogICAgICAgICAgICAgICAgICAgICAvLyBidXQgdGhlIHNoYWRvdyBuZWVkcyB0byBiZSBjb2xv cmVkIGFzIHRoZSBpbm5lciB3aWRnZXQ7IG5lZWRzCiAgICAgICAgICAgICAgICAgICAgIC8vIGNo YW5nZXMgaW4gaGVscGVyLgogI2lmZGVmIEhPTEVfQ09MT1JfT1VUU0lERQotICAgICAgICAgICAg ICAgICAgICByZW5kZXJIb2xlKHAsIHBhbC5jb2xvcihRUGFsZXR0ZTo6V2luZG93KSwgZnIsIGhh c0ZvY3VzLCBtb3VzZU92ZXIpOwotI2Vsc2UKLSAgICAgICAgICAgICAgICAgICAgcmVuZGVySG9s ZShwLCBpbnB1dENvbG9yLCBmciwgaGFzRm9jdXMsIG1vdXNlT3Zlcik7CisgICAgICAgICAgICAg ICAgICAgIGlmIChwYWwuY29sb3IoUVBhbGV0dGU6OldpbmRvdykuaXNWYWxpZCgpKQorICAgICAg ICAgICAgICAgICAgICAgICAgcmVuZGVySG9sZShwLCBwYWwuY29sb3IoUVBhbGV0dGU6OldpbmRv dyksIGZyLCBoYXNGb2N1cywgbW91c2VPdmVyKTsKKyAgICAgICAgICAgICAgICAgICAgZWxzZQog I2VuZGlmCisgICAgICAgICAgICAgICAgICAgICAgICByZW5kZXJIb2xlKHAsIGlucHV0Q29sb3Is IGZyLCBoYXNGb2N1cywgbW91c2VPdmVyKTsKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwog ICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBjYXNlIFNwaW5Cb3g6OkVkaXRGaWVs ZDoKQEAgLTE0OTIsMjQgKzE0OTMsMjkgQEAKICAgICAgICAgICAgICAgICAgICAgICAgIHAtPnJl c3RvcmUoKTsKIAogI2lmZGVmIEhPTEVfQ09MT1JfT1VUU0lERQotICAgICAgICAgICAgICAgICAg ICAgICAgaWYgKGhhc0ZvY3VzICYmIGVuYWJsZWQpCisgICAgICAgICAgICAgICAgICAgICAgICBp ZiAocGFsLmNvbG9yKFFQYWxldHRlOjpXaW5kb3cpLmlzVmFsaWQoKSkKICAgICAgICAgICAgICAg ICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICByZW5kZXJIb2xlKHAsIHBh bC5jb2xvcihRUGFsZXR0ZTo6V2luZG93KSwgZnIsIHRydWUsIG1vdXNlT3Zlcik7CisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgaWYgKGhhc0ZvY3VzICYmIGVuYWJsZWQpCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgeworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZW5k ZXJIb2xlKHAsIHBhbC5jb2xvcihRUGFsZXR0ZTo6V2luZG93KSwgZnIsIHRydWUsIG1vdXNlT3Zl cik7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB7CisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHJlbmRlckhvbGUocCwgcGFsLmNvbG9yKFFQYWxldHRlOjpXaW5k b3cpLCBmciwgZmFsc2UsIG1vdXNlT3Zlcik7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgICAgICAgZWxz ZQorI2VuZGlmCiAgICAgICAgICAgICAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgcmVuZGVySG9sZShwLCBwYWwuY29sb3IoUVBhbGV0dGU6OldpbmRvdyksIGZyLCBm YWxzZSwgbW91c2VPdmVyKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoaGFzRm9j dXMgJiYgZW5hYmxlZCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB7CisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHJlbmRlckhvbGUocCwgaW5wdXRDb2xvciwgZnIsIHRydWUs IG1vdXNlT3Zlcik7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB7CisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlbmRlckhvbGUocCwgaW5wdXRDb2xvciwgZnIs IGZhbHNlLCBtb3VzZU92ZXIpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgICAgICAgICAgICAgIH0KLSNlbHNlCi0gICAgICAgICAgICAgICAgICAgICAgICBpZiAo aGFzRm9jdXMgJiYgZW5hYmxlZCkKLSAgICAgICAgICAgICAgICAgICAgICAgIHsKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICByZW5kZXJIb2xlKHAsIGlucHV0Q29sb3IsIGZyLCB0cnVlLCBt b3VzZU92ZXIpOwotICAgICAgICAgICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgICAgICAg ICAgICAgZWxzZQotICAgICAgICAgICAgICAgICAgICAgICAgewotICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHJlbmRlckhvbGUocCwgaW5wdXRDb2xvciwgZnIsIGZhbHNlLCBtb3VzZU92ZXIp OwotICAgICAgICAgICAgICAgICAgICAgICAgfQotI2VuZGlmCiAgICAgICAgICAgICAgICAgICAg IH0KIAogICAgICAgICAgICAgICAgICAgICByZXR1cm47CkBAIC0xNjE0LDcgKzE2MjAsOCBAQAog ICAgICAgICAgICAgICAgICAgICBjb25zdCBib29sIGlzRW5hYmxlZCA9IGZsYWdzICYgU3RhdGVf RW5hYmxlZDsKICAgICAgICAgICAgICAgICAgICAgY29uc3QgYm9vbCBoYXNGb2N1cyA9IGZsYWdz ICYgU3RhdGVfSGFzRm9jdXM7CiAjaWZkZWYgSE9MRV9DT0xPUl9PVVRTSURFCi0gICAgICAgICAg ICAgICAgICAgIGNvbnN0IFFDb2xvciBpbnB1dENvbG9yID0gIHBhbC5jb2xvcihRUGFsZXR0ZTo6 V2luZG93KTsKKyAgICAgICAgICAgICAgICAgICAgY29uc3QgUUNvbG9yIGlucHV0Q29sb3IgPSBw YWwuY29sb3IoUVBhbGV0dGU6OldpbmRvdykuaXNWYWxpZCgpCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgPyBwYWwuY29sb3IoUVBhbGV0dGU6OldpbmRvdykg OiBwYWwuY29sb3IoUVBhbGV0dGU6OkJhc2UpOwogI2Vsc2UKICAgICAgICAgICAgICAgICAgICAg Y29uc3QgUUNvbG9yIGlucHV0Q29sb3IgPSBlbmFibGVkP3BhbC5jb2xvcihRUGFsZXR0ZTo6QmFz ZSk6cGFsLmNvbG9yKFFQYWxldHRlOjpXaW5kb3cpOwogI2VuZGlmCg== 24840 2008-05-19 03:53:07 +0000 2008-05-19 03:53:07 +0000 Transparent background fix khtml_render.diff text/plain 1787 thelich LS0tIGtodG1sL3JlbmRlcmluZy9yZW5kZXJfcmVwbGFjZWQuY3BwLm9yaWcJMjAwOC0wNS0xMiAx MToyMDozNy4wMDAwMDAwMDAgKzA3MDAKKysrIGtodG1sL3JlbmRlcmluZy9yZW5kZXJfcmVwbGFj ZWQuY3BwCTIwMDgtMDUtMTkgMDg6NDc6MjEuMDAwMDAwMDAwICswNzAwCkBAIC0zNjAsMjUgKzM2 MCwyNCBAQAogICAgICAgICBRQ29sb3IgY29sb3IgPSBzdHlsZSgpLT5jb2xvcigpOwogICAgICAg ICBRQ29sb3IgYmFja2dyb3VuZENvbG9yID0gc3R5bGUoKS0+YmFja2dyb3VuZENvbG9yKCk7CiAK LSAgICAgICAgaWYgKCFiYWNrZ3JvdW5kQ29sb3IuaXNWYWxpZCgpICYmICFzdHlsZSgpLT5odG1s SGFja3MoKSkKLSAgICAgICAgICAgIGJhY2tncm91bmRDb2xvciA9IFFDb2xvcigwLDAsMCwwKTsK KyAgICAgICAgUVBhbGV0dGUgcGFsKFFBcHBsaWNhdGlvbjo6cGFsZXR0ZShtX3dpZGdldCkpOwor ICAgICAgICBpZiAoIWJhY2tncm91bmRDb2xvci5pc1ZhbGlkKCkpCisgICAgICAgICAgICBiYWNr Z3JvdW5kQ29sb3IgPSBwYWwuY29sb3IoIHdpZGdldCgpLT5iYWNrZ3JvdW5kUm9sZSgpICk7CiAK ICAgICAgICAgLy8gY2hlY2sgaWYgd2UgaGF2ZSB0byBwYWludCBvdXIgYmFja2dyb3VuZCBhbmQg bGV0IGl0IHNob3cgdGhyb3VnaAogICAgICAgICBib29sIHRyYW5zID0gKCBpc1JlZGlyZWN0ZWRX aWRnZXQoKSAmJiBzdHlsZSgpLT5iYWNrZ3JvdW5kTGF5ZXJzKCkgJiYgCiAgICAgICAgICAgICAg ICAgICAgICAgIHN0eWxlKCktPmJhY2tncm91bmRMYXllcnMoKS0+aGFzSW1hZ2UoKSAmJiAhcW9i amVjdF9jYXN0PEtVcmxSZXF1ZXN0ZXIqPihtX3dpZGdldCkgKTsKIAotICAgICAgICBRUGFsZXR0 ZSBwYWwoUUFwcGxpY2F0aW9uOjpwYWxldHRlKG1fd2lkZ2V0KSk7CiAgICAgICAgIGlmIChjb2xv ci5pc1ZhbGlkKCkgfHwgYmFja2dyb3VuZENvbG9yLmlzVmFsaWQoKSB8fCB0cmFucykgewogICAg ICAgICAgICAgaW50IGNvbnRyYXN0XyA9IEtHbG9iYWxTZXR0aW5nczo6Y29udHJhc3QoKTsKICAg ICAgICAgICAgIGludCBoaWdobGlnaHRWYWwgPSAxMDAgKyAoMipjb250cmFzdF8rNCkqMTYvMTA7 CiAgICAgICAgICAgICBpbnQgbG93bGlnaHRWYWwgPSAxMDAgKyAoMipjb250cmFzdF8rNCkqMTA7 CiAgICAgICAgICAgICBib29sIHNob3VsZENoYW5nZUJnUGFsID0gdHJ1ZTsKIAotICAgICAgICAg ICAgaWYgKCFiYWNrZ3JvdW5kQ29sb3IuaXNWYWxpZCgpKSAKLSAgICAgICAgICAgICAgICBiYWNr Z3JvdW5kQ29sb3IgPSBwYWwuY29sb3IoIHdpZGdldCgpLT5iYWNrZ3JvdW5kUm9sZSgpICk7Ci0g ICAgICAgICAgICBlbHNlCisgICAgICAgICAgICBpZiAoIXN0eWxlKCktPmh0bWxIYWNrcygpKSAK ICAgICAgICAgICAgICAgICBzaG91bGRDaGFuZ2VCZ1BhbCA9ICEoIChiYWNrZ3JvdW5kQ29sb3Ig PT0gY29sb3JGb3JDU1NWYWx1ZShDU1NfVkFMX1dJTkRPVykpIHx8CiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAoYmFja2dyb3VuZENvbG9yID09IGNvbG9yRm9yQ1NTVmFs dWUoQ1NTX1ZBTF9CVVRUT05GQUNFKSkgKTsKKwogICAgICAgICAgICAgaWYgKHNob3VsZENoYW5n ZUJnUGFsIHx8IHRyYW5zKSB7CiAgICAgICAgICAgICAgICAgcGFsLnNldENvbG9yKHdpZGdldCgp LT5iYWNrZ3JvdW5kUm9sZSgpLCB0cmFucyA/IFFDb2xvcigwLDAsMCwwKSA6IGJhY2tncm91bmRD b2xvcik7CiAgICAgICAgICAgICAgICAgZm9yICggaW50IGkgPSAwOyBpIDwgUVBhbGV0dGU6Ok5D b2xvckdyb3VwczsgKytpICkgewo=