153785 2007-12-10 17:04:38 +0000 terminal doesnt start in current directory 2007-12-16 20:14:00 +0000 1 1 2 Applications dolphin general 16.12.2 Compiled Sources Linux RESOLVED FIXED NOR normal --- 1 morten peter.penz19 0 oldest_to_newest 561840 0 morten 2007-12-10 17:04:39 +0000 Version: 0.9.5 (from svn) (using KDE Devel) Installed from: Compiled sources Compiler: gcc version 4.2.3 20071123 (prerelease) (Debian 4.2.2-4) OS: Linux the embedded terminal doesnt always start in the correct directory (which ofcourse should be the current one). 561907 1 morten 2007-12-10 20:51:51 +0000 after some checking, i have found a way to reproduce this every time: 1) start dolphin 2) enter a directory e.g. ~/kde/src 3) press f4 (terminal now opens and shows ~/kde/src) 4) f4 again (it is now gone) 5) enter ~/kde/bin 6) press f4 (current directory will now be ~/kde/src) it seems that url().path() is correct, so maybe theres something wrong with showShellInDir() ? sendInput("cd " + url().path() + "; clear\n") on line 77 of terminalsidebarpage.cpp seems to work. but its not really a good fix! 561928 2 22464 morten 2007-12-10 21:41:16 +0000 Created attachment 22464 patches bug Enclosed is a patch that should fix the problem. showShellInDir only changes directory when the shell-process is created (so when it is first, created it wont do anything on successive calls). I moved the showShellInDir-call to right after the terminal is created, and added a sendInput instead. 563772 3 peter.penz19 2007-12-16 12:28:07 +0000 Thanks a lot for the detailed analyzes + the patch. Even if sendInput("cd" + ...) might not be the nicest approach, the time until KDE 4.0 is quite short and I applied your patch :-) 563773 4 peter.penz19 2007-12-16 12:29:03 +0000 SVN commit 749039 by ppenz: fixes for the terminal panel: * assure that the correct directory is entered when reopening the terminal * let the terminal be focused also when reopening it BUG: 153785 BUG: 153756 M +7 -3 terminalsidebarpage.cpp M +2 -0 terminalsidebarpage.h WebSVN link: http://websvn.kde.org/?view=rev&revision=749039 563872 5 morten 2007-12-16 20:04:22 +0000 Yeah, sendInput isnt very clean.. (you can see the cd commands being sent to the console). But not sure if there is another way. Btw, there is also a patch in bug #153697 :-) 563879 6 peter.penz19 2007-12-16 20:14:00 +0000 > Btw, there is also a patch in bug #153697 :-) Wow, great! I just had a look and I'll apply it. I'm also not sure for 153697 whether there might be nicer approaches (I think in Qt4.4 there are easier ways for disabling global shortcuts), but like said: 4.0 is approaching... Thanks a lot! 22464 2007-12-10 21:41:16 +0000 2007-12-10 21:41:16 +0000 patches bug dolphin-term-curdir-bug153785.patch text/plain 625 morten SW5kZXg6IHRlcm1pbmFsc2lkZWJhcnBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHRlcm1pbmFsc2lk ZWJhcnBhZ2UuY3BwCShyZXZpc2lvbiA3NDY5NjMpCisrKyB0ZXJtaW5hbHNpZGViYXJwYWdlLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNzAsMTAgKzcwLDExIEBACiAgICAgICAgIGlmIChwYXJ0ICE9 IDApIHsKICAgICAgICAgICAgIG1fbGF5b3V0LT5hZGRXaWRnZXQocGFydC0+d2lkZ2V0KCkpOwog ICAgICAgICAgICAgbV90ZXJtaW5hbCA9IHFvYmplY3RfY2FzdDxUZXJtaW5hbEludGVyZmFjZSAq PihwYXJ0KTsKKwkJCW1fdGVybWluYWwtPnNob3dTaGVsbEluRGlyKHVybCgpLnBhdGgoKSk7CiAg ICAgICAgIH0KICAgICB9CiAgICAgaWYgKG1fdGVybWluYWwgIT0gMCkgewotICAgICAgICBtX3Rl cm1pbmFsLT5zaG93U2hlbGxJbkRpcih1cmwoKS5wYXRoKCkpOworICAgICAgICBtX3Rlcm1pbmFs LT5zZW5kSW5wdXQoImNkICIgKyBLU2hlbGw6OnF1b3RlQXJnKHVybCgpLnBhdGgoKSkgKyAnXG4n KTsKICAgICAgICAgbV90ZXJtaW5hbC0+c2VuZElucHV0KCJjbGVhclxuIik7CiAgICAgfQogCg==