153580 2007-12-06 19:58:25 +0000 Tower of Babel-like confusion around the meaning of the +q and +a user modes 2013-06-17 03:58:19 +0000 1 1 2 Applications konversation protocol 1.5-rc1 openSUSE Linux CONFIRMED NOR normal --- 1 ollie.jl konversation-bugs-null cathy edwardfredriks error.syntax0 hein johu m.niggli mailomaysara OldShatterhand rdieter shentino 0 oldest_to_newest 560900 0 ollie.jl 2007-12-06 19:58:25 +0000 Version: (using KDE KDE 3.5.7) Installed from: SuSE RPMs OS: Linux Whichever set of icons I use for the Nicklist in Konversation, it shows users with Admin status (mode +a) with the Owner icon (mode +q), thus making them indistinguishable from those users who are actually meant to be Owners. This bug is in effect most, but not all, of the time. 594905 1 argonel 2008-04-18 16:40:08 +0000 What network is this happening on? 626898 2 marc 2008-07-19 22:21:57 +0000 I've the same problem on my IRC Networks. I send that I've when I connect to my IRC Network : [09:02] [Bienvenue] Your host is Kolosse.MoonScoop-Fan.com, running version Unreal3.2.7 [09:02] [Bienvenue] This server was created samedi 31 mai (UTC+0200) at 2008, 00:10:37 [09:02] [Bienvenue] Serveur Kolosse.MoonScoop-Fan.com (Version Unreal3.2.7), Modes utilisateur : iowghraAsORTVSxNCWqBzvdHtGp, Modes canal : lvhopsmntikrRcaqOALQbSeIKVfMCuzNTGj [09:02] [Gérer] Neurones67 CMDS=KNOCK,MAP,DCCALLOW,USERIP NAMESX SAFELIST HCN MAXCHANNELS=25 CHANLIMIT=#:25 MAXLIST=b:60,e:60,I:60 NICKLEN=30 CHANNELLEN=32 TOPICLEN=307 KICKLEN=307 AWAYLEN=307 MAXTARGETS=20 [09:02] [Gérer] Neurones67 WALLCHOPS WATCH=128 SILENCE=15 MODES=12 CHANTYPES=# PREFIX=(qaohv)~&@%+ CHANMODES=beI,kfL,lj,psmntirRcOAQKVCuzNSMTG NETWORK=MoonScoop-Fan.com CASEMAPPING=ascii EXTBAN=~,cqnr ELIST=MNUCT STATUSMSG=~&@%+ EXCEPTS If you need further informations, tell me :) and sorry for my bad english, I'm french :) 696274 3 m.niggli 2009-01-08 19:11:35 +0000 I can reproduce this with Konversation 1.1 and KDE 3.5.10 on Gentoo in euIRC (irc.euirc.net) 696292 4 m.niggli 2009-01-08 20:00:37 +0000 Just now I found that it's not just the wrong state for admin, but that owner/admin status appear to be interchanged.. 756425 5 hein 2009-05-13 01:21:04 +0000 Likely related to bug #139591 and #148437. 769387 6 error.syntax0 2009-06-03 14:21:40 +0000 I have firsthand experience with this bug, the icon changes when mode +a is granted on a user, not (for example) when you join the channel and there are admins already there. This would be a very nice fix for the final release of 1.2 887625 7 hein 2009-12-27 17:20:34 +0000 *** Bug 220285 has been marked as a duplicate of this bug. *** 887633 8 schwarzer 2009-12-27 17:27:38 +0000 *** Bug 220285 has been marked as a duplicate of this bug. *** 1186262 9 shentino 2011-11-17 04:52:12 +0000 I would like to confirm this bug as still present in 1.3.1 on Gentoo Linux. 1343150 10 cathy 2013-02-19 00:07:59 +0000 *** Bug 315424 has been marked as a duplicate of this bug. *** 1343151 11 77417 cathy 2013-02-19 00:08:23 +0000 Created attachment 77417 Patch that fixes the issue Please find attached a patch that fixes this bug. 1343180 12 argonel 2013-02-19 03:54:12 +0000 Thanks for the patch. On what network and IRCd are you seeing this issue? On Mon, Feb 18, 2013 at 7:08 PM, Cathy J. Fitzpatrick <cathy@cathyjf.com>wrote: > https://bugs.kde.org/show_bug.cgi?id=153580 > > --- Comment #11 from Cathy J. Fitzpatrick <cathy@cathyjf.com> --- > Created attachment 77417 > --> https://bugs.kde.org/attachment.cgi?id=77417&action=edit > Patch that fixes the issue > > Please find attached a patch that fixes this bug. > > -- > You are receiving this mail because: > You are the assignee for the bug. > _______________________________________________ > Konversation-devel mailing list > Konversation-devel@kde.org > https://mail.kde.org/mailman/listinfo/konversation-devel > 1343181 13 cathy 2013-02-19 04:07:04 +0000 [16:44:18] [Welcome] Welcome to the synIRC IRC Network Cathy!~Cathy@... [16:44:18] [Welcome] Your host is moonlight.se.eu.synirc.net, running version Unreal3.2.9 [16:44:18] [Welcome] This server was created Tue Jun 19 2012 at 21:04:53 CEST [16:44:18] [Welcome] Server moonlight.se.eu.synirc.net (Version Unreal3.2.9), User modes: iowghraAsORTVSxNCWqBzvdHtGp, Channel modes: lvhopsmntikrRcaqOALQbSeIKVfMCuzNTGjZ [16:44:18] [Support] Cathy CMDS=KNOCK,MAP,DCCALLOW,USERIP UHNAMES NAMESX SAFELIST HCN MAXCHANNELS=40 CHANLIMIT=#:40 MAXLIST=b:60,e:60,I:60 NICKLEN=30 CHANNELLEN=32 TOPICLEN=307 KICKLEN=307 AWAYLEN=307 are supported by this server [16:44:18] [Support] Cathy MAXTARGETS=20 WALLCHOPS WATCH=128 WATCHOPTS=A SILENCE=15 MODES=12 CHANTYPES=# PREFIX=(qaohv)~&@%+ CHANMODES=beI,kfL,lj,psmntirRcOAQKVCuzNSMTGZ NETWORK=synIRC CASEMAPPING=ascii EXTBAN=~,qjncrR ELIST=MNUCT are supported by this server [16:44:18] [Support] Cathy STATUSMSG=~&@%+ EXCEPTS INVEX are supported by this server [16:44:18] [Notice] -moonlight.se.eu.synirc.net- *** You are connected to moonlight.se.eu.synirc.net with TLSv1-AES256-SHA-256bits That said, I don't think my proposed patch will have side effects on other networks. The code in the region I changed already assumes that mode +a is admin (not owner). The call to setOwner() appears to just be a typo. 1360854 14 hein 2013-04-15 02:56:51 +0000 *** Bug 308016 has been marked as a duplicate of this bug. *** 1360857 15 hein 2013-04-15 03:09:21 +0000 *** Bug 148437 has been marked as a duplicate of this bug. *** 1360858 16 hein 2013-04-15 03:09:56 +0000 Note that bug 148437 introduces an additional meaning of "super OPs" for +q. 1371174 17 shentino 2013-05-25 22:27:36 +0000 I've tested Fitzpatrick's patch and it works. I think we should go ahead and apply it to the mainline. It fixes an obvious bug and it doesn't appear to conflict with the mode rework. Furthermore, the mode rework may yet take a long while. 1371371 18 hein 2013-05-26 19:21:52 +0000 I'd like to hear Eli's opinion on that since he's the domain expert. 1371426 19 shentino 2013-05-26 23:36:32 +0000 I had a nice chat with argonel on irc's #konversation and the consensus is that this is indeed a typo being fixed. Said that there was a good chance of it popping into 1.5. 1377260 20 hein 2013-06-17 03:58:19 +0000 Git commit 5b79cf8cad9781f37f52f77a71353ea4caf64698 by Eike Hein, on behalf of Cathy J. Fitzpatrick. Committed on 19/02/2013 at 00:46. Pushed by hein into branch '1.5'. Fix for setting mode +a or -a Previously, setting or removing mode +a on a nick in a channel called ChannelNick::setOwner(), so setting +a on a nick made the nick appear as an owner of the channel, rather than as an admin. This commit fixes the problem by correctly calling ChannelNick::setAdmin() instead. M +1 -1 src/irc/channel.cpp http://commits.kde.org/konversation/5b79cf8cad9781f37f52f77a71353ea4caf64698 77417 2013-02-19 00:08:23 +0000 2013-02-19 00:08:23 +0000 Patch that fixes the issue 0001-Fix-for-setting-mode-a-or-a.patch text/plain 1062 cathy RnJvbSBkYzUxZjQ4ODU0Y2U0NTk3Y2Y5ZjlmOThhNWQ1NWVkMDE0OGFkM2E0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiQ2F0aHkgSi4gRml0enBhdHJpY2siIDxjYXRoeUBjYXRoeWpm LmNvbT4KRGF0ZTogTW9uLCAxOCBGZWIgMjAxMyAxNjo0Njo1MyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIEZpeCBmb3Igc2V0dGluZyBtb2RlICthIG9yIC1hCgpQcmV2aW91c2x5LCBzZXR0aW5nIG9y IHJlbW92aW5nIG1vZGUgK2Egb24gYSBuaWNrIGluIGEgY2hhbm5lbCBjYWxsZWQKQ2hhbm5lbE5p Y2s6OnNldE93bmVyKCksIHNvIHNldHRpbmcgK2Egb24gYSBuaWNrIG1hZGUgdGhlIG5pY2sgYXBw ZWFyCmFzIGFuIG93bmVyIG9mIHRoZSBjaGFubmVsLCByYXRoZXIgdGhhbiBhcyBhbiBhZG1pbi4g VGhpcyBjb21taXQKZml4ZXMgdGhlIHByb2JsZW0gYnkgY29ycmVjdGx5IGNhbGxpbmcgQ2hhbm5l bE5pY2s6OnNldEFkbWluKCkgaW5zdGVhZC4KLS0tCiBzcmMvaXJjL2NoYW5uZWwuY3BwIHwgMiAr LQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvc3JjL2lyYy9jaGFubmVsLmNwcCBiL3NyYy9pcmMvY2hhbm5lbC5jcHAKaW5kZXggZjA1 NTIxMy4uNTNlMDJhNyAxMDA2NDQKLS0tIGEvc3JjL2lyYy9jaGFubmVsLmNwcAorKysgYi9zcmMv aXJjL2NoYW5uZWwuY3BwCkBAIC0xNDkzLDcgKzE0OTMsNyBAQCB2b2lkIENoYW5uZWw6OnVwZGF0 ZU1vZGUoY29uc3QgUVN0cmluZyYgc291cmNlTmljaywgY2hhciBtb2RlLCBib29sIHBsdXMsIGNv bnN0CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBpZiAocGFyYW1ldGVyQ2hhbm5lbE5pY2sp CiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgcGFyYW1ldGVyQ2hhbm5lbE5pY2stPnNl dE93bmVyKHBsdXMpOworICAgICAgICAgICAgICAgIHBhcmFtZXRlckNoYW5uZWxOaWNrLT5zZXRB ZG1pbihwbHVzKTsKICAgICAgICAgICAgICAgICBlbWl0VXBkYXRlSW5mbygpOwogICAgICAgICAg ICAgfQogICAgICAgICAgICAgYnJlYWs7Ci0tIAoxLjguMQoK