152501 2007-11-18 11:25:03 +0000 (daa) vex x86->IR: unhandled instruction bytes: 0x27 0x66 0x89 0x45 2007-11-23 23:13:17 +0000 1 1 6 Developer tools valgrind vex 3.2.3 Gentoo Packages Linux RESOLVED FIXED NOR crash --- 0 slyich jseward 0 oldest_to_newest 556317 0 slyich 2007-11-18 11:25:03 +0000 Version: 3.2.3 (using KDE KDE 3.5.7) Installed from: Gentoo Packages Compiler: gcc version 4.2.2 (Gentoo 4.2.2 p1.0) Configured with: /var/tmp/portage/sys-devel/gcc-4.2.2/work/gcc-4.2.2/configure --prefix=/usr --bindir=/usr/i686-pc-linux-gnu/gcc-bin/4.2.2 --includedir=/usr/lib/gcc/i686-pc-linux-gnu/4.2.2/include --datadir=/usr/share/gcc-data/i686-pc-linux-gnu/4.2.2 --mandir=/usr/share/gcc-data/i686-pc-linux-gnu/4.2.2/man --infodir=/usr/share/gcc-data/i686-pc-linux-gnu/4.2.2/info --with-gxx-include-dir=/usr/lib/gcc/i686-pc-linux-gnu/4.2.2/include/g++-v4 --host=i686-pc-linux-gnu --build=i686-pc-linux-gnu --disable-altivec --enable-nls --without-included-gettext --with-system-zlib --disable-checking --disable-werror --enable-secureplt --disable-libunwind-exceptions --disable-multilib --enable-libmudflap --disable-libssp --disable-libgcj --with-arch=i686 --enable-languages=c,c++,fortran --enable-shared --enable-threads=posix --enable-__cxa_atexit --enable-clocale=gnu OS: Linux I use valgrind for testing an x86 emulator. Emulator can run different x86 binaries (DOS, MS WINDOWS), checks instructions and operands validness and runs instructions on real processor. Some of binaries contain old instructions: DAA, DAS, etc. Valgrind crashes on them. 556334 1 jseward 2007-11-18 13:28:52 +0000 > instructions on real processor. Some of binaries contain > old instructions: DAA, DAS, etc. Write a program which tests DAA, DAS, etc, with all possible input values, so as to demonstrate correct behaviour of the instructions, and send it. That will make it much easier for me to implement the instructions. 556385 2 22105 slyich 2007-11-18 17:22:09 +0000 Created attachment 22105 C source for testing DAA instruction Small program loops around all significant values of AX: 0..0xFF; and EFLAGS: SF ZF AF PF CF (according to intel specs). 556430 3 slyich 2007-11-18 21:29:18 +0000 Same tests can be ran for AAS, AAD, DAS. * Should I attach 3 more files or write one test for all insns? * Does this test look good or I've chosen wrong way? 556435 4 jseward 2007-11-18 21:48:42 +0000 > * Should I attach 3 more files or write one test for all insns? One test for all 4 insns. > * Does this test look good or I've chosen wrong way? Yes, looks good. I just need to implement them now. Thanks. 556452 5 22112 slyich 2007-11-18 22:35:39 +0000 Created attachment 22112 Contains test for DAA, DAS, AAA, AAS insns New testcase, beware :) On my p4-3.0GHz: $ time { ./wr_sig > bcd_dump; } real 0m8.269s user 0m5.068s sys 0m2.654s Generates 320 MB log 557481 6 jseward 2007-11-23 03:47:48 +0000 Fixed (vex r1800). Please verify. Is it OK to include a simplified version of your test program in the Valgrind test suite? 557677 7 slyich 2007-11-23 23:13:17 +0000 > Fixed (vex r1800). Please verify. (after i've left only AF and CF) $ diff -uN orig_log vg_log | wc -l 0 Great. Seems to work! >Is it OK to include a simplified version of your test program in the >Valgrind test suite? Sure. Thanks! 22105 2007-11-18 17:22:09 +0000 2007-11-18 22:35:39 +0000 C source for testing DAA instruction main.c text/x-csrc 2383 slyich I2luY2x1ZGUgPHN0ZGlvLmg+CiNpbmNsdWRlIDxhc3NlcnQuaD4KCiNkZWZpbmUgR0VUX0JJVCh2 YXIsIGJpdF9ubykgKCh2YXIgPj4gYml0X25vKSAmIDEpCgovLyBhY2NlcHRzIFNGOlpGOkFGOlBG OkNGIGFuZCBwYWNrcyAnZW0gdG8gYnl0ZQovLyBmb3Igc2FoZi9sYWhmIGluIGZvcm1hdCAoU0Y6 WkY6MDpBRjowOlBGOjE6Q0YpCnN0YXRpYyB1bnNpZ25lZCBpbnQKXzV0bzhfZWZsYWdzKHVuc2ln bmVkIGludCBfNWJpdHMpCnsKICAgIGFzc2VydCAoXzViaXRzID49IDApOwogICAgYXNzZXJ0IChf NWJpdHMgPD0gMHgxRik7CiAgICB1bnNpZ25lZCBpbnQgU0YgPSBHRVRfQklUKF81Yml0cywgNCk7 CiAgICB1bnNpZ25lZCBpbnQgWkYgPSBHRVRfQklUKF81Yml0cywgMyk7CiAgICB1bnNpZ25lZCBp bnQgQUYgPSBHRVRfQklUKF81Yml0cywgMik7CiAgICB1bnNpZ25lZCBpbnQgUEYgPSBHRVRfQklU KF81Yml0cywgMSk7CiAgICB1bnNpZ25lZCBpbnQgQ0YgPSBHRVRfQklUKF81Yml0cywgMCk7Cgog ICAgcmV0dXJuIChTRiA8PCA3KQogICAgICAgICB8IChaRiA8PCA2KQogICAgICAgICB8ICggMCA8 PCA1KQogICAgICAgICB8IChBRiA8PCA0KQogICAgICAgICB8ICggMCA8PCAzKQogICAgICAgICB8 IChQRiA8PCAyKQogICAgICAgICB8ICggMSA8PCAxKQogICAgICAgICB8IChDRiA8PCAwKTsKfQoK c3RhdGljIGNoYXIgc3pfZWZsYWdzW10gPSAiICAgICAgICAiOyAvLyA4IHNwYWNlcyAgICAKc3Rh dGljIHZvaWQgcHBfZWZsYWdzICh1bnNpZ25lZCBpbnQgXzhiaXRzX2VmbGFncykKewogICAgYXNz ZXJ0IChfOGJpdHNfZWZsYWdzID49IDApOwogICAgYXNzZXJ0IChfOGJpdHNfZWZsYWdzIDw9IDB4 RkYpOwogICAgc3pfZWZsYWdzWzBdID0gR0VUX0JJVChfOGJpdHNfZWZsYWdzLCA3KSA/ICdTJyA6 ICcgJzsKICAgIHN6X2VmbGFnc1sxXSA9IEdFVF9CSVQoXzhiaXRzX2VmbGFncywgNikgPyAnWicg OiAnICc7CiAgICBzel9lZmxhZ3NbM10gPSBHRVRfQklUKF84Yml0c19lZmxhZ3MsIDQpID8gJ0En IDogJyAnOwogICAgc3pfZWZsYWdzWzVdID0gR0VUX0JJVChfOGJpdHNfZWZsYWdzLCAyKSA/ICdQ JyA6ICcgJzsKICAgIHN6X2VmbGFnc1s3XSA9IEdFVF9CSVQoXzhiaXRzX2VmbGFncywgMCkgPyAn QycgOiAnICc7Cn0KCmludCBtYWluICgpCnsKICAgIHVuc2lnbmVkIGludCBfNWJlZmxhZ3MsIGVm bGFnczsKICAgIHVuc2lnbmVkIGludCBlYXg7CiAgICBmb3IgKF81YmVmbGFncyA9IDA7IF81YmVm bGFncyA8PSAweDFGOyArK181YmVmbGFncykKICAgIHsKICAgICAgICBlZmxhZ3MgPSBfNXRvOF9l ZmxhZ3MgKF81YmVmbGFncykgPDwgODsKICAgICAgICBmb3IgKGVheCA9IDA7IGVheCA8PSAweEZG OyArK2VheCkKICAgICAgICB7CiAgICAgICAgICAgIHBwX2VmbGFncyAoKGVmbGFncyA+PiA4KSAm IDB4RkYpOyAvLyBzY3JhdGNoaW5nIG9mZiBBSAogICAgICAgICAgICBwcmludGYgKCJEQUEgKEVB WCA9ICUwOFgsIEVGTEFHUyA9ICVzKSA9PiAiLCBlYXgsIHN6X2VmbGFncyk7CiAgICAgICAgICAg IAogICAgICAgICAgICB1bnNpZ25lZCBpbnQgcmVzdWx0aW5nX2VmbGFnczsKICAgICAgICAgICAg dW5zaWduZWQgaW50IHJlc3VsdGluZ19lYXg7CiAgICAgICAgICAgIC8vIGluOiAgZWZsYWdzLCBl YXg7CiAgICAgICAgICAgIC8vIG91dDogcmVzdWx0aW5nX2VheCwgcmVzdWx0aW5nX2VmbGFncwoK ICAgICAgICAgICAgYXNtIHZvbGF0aWxlKAoJICAgICAgICAibW92bCAgJTIsICUlZWF4IFx0XG4i CiAgICAgICAgICAgICAgICAic2FoZiAgICAgICAgICAgIFx0XG4iCiAgICAgICAgICAgICAgICAi bW92bCAgJTMsICUlZWF4IFx0XG4iCgogICAgICAgICAgICAgICAgImRhYSAgICAgICAgICAgICBc dFxuIgoKICAgICAgICAgICAgICAgIC8vIHJldHVybiByZXN1bHQKICAgICAgICAgICAgICAgICJt b3ZsICUlZWF4LCAlMCAgXHRcbiIKICAgICAgICAgICAgICAgICJsYWhmICAgICAgICAgICAgXHRc biIKICAgICAgICAgICAgICAgICJtb3ZsICAlJWVheCwgJTEgXHRcbiIKICAgICAgICAgICAgICAg IDogIj1kIihyZXN1bHRpbmdfZWF4KSwgIj1iIihyZXN1bHRpbmdfZWZsYWdzKQogICAgICAgICAg ICAgICAgOiAiYiIoZWZsYWdzKSwgImQiKGVheCkKCQk6ICIlZWF4IiwgImNjIiAvLyB3ZSBtZXNz IHVwIEVGTEFHUwogICAgICAgICAgICAgICAgKTsKCiAgICAgICAgICAgIHBwX2VmbGFncyAoKHJl c3VsdGluZ19lZmxhZ3MgPj4gOCkgJiAweEZGKTsvLyBzY3JhdGNoaW5nIG9mZiBBSAogICAgICAg ICAgICBwcmludGYgKCIoRUFYID0gJTA4WCwgRUZMQUdTID0gJXMpXG4iLCByZXN1bHRpbmdfZWF4 LCBzel9lZmxhZ3MpOwogICAgICAgIH0KICAgIH0KICAgIHJldHVybiAwOwp9Cg== 22112 2007-11-18 22:35:39 +0000 2007-11-18 22:35:39 +0000 Contains test for DAA, DAS, AAA, AAS insns main.c text/x-csrc 3973 slyich I2luY2x1ZGUgPHN0ZGlvLmg+CiNpbmNsdWRlIDxhc3NlcnQuaD4KCiNkZWZpbmUgR0VUX0JJVCh2 YXIsIGJpdF9ubykgKCh2YXIgPj4gYml0X25vKSAmIDEpCgovLyBhY2NlcHRzIFNGOlpGOkFGOlBG OkNGIGFuZCBwYWNrcyAnZW0gdG8gYnl0ZQovLyBmb3Igc2FoZi9sYWhmIGluIGZvcm1hdCAoU0Y6 WkY6MDpBRjowOlBGOjE6Q0YpCnN0YXRpYyB1bnNpZ25lZCBpbnQKXzV0bzhfZWZsYWdzKHVuc2ln bmVkIGludCBfNWJpdHMpCnsKICAgIGFzc2VydCAoXzViaXRzID49IDApOwogICAgYXNzZXJ0IChf NWJpdHMgPD0gMHgxRik7CiAgICB1bnNpZ25lZCBpbnQgU0YgPSBHRVRfQklUKF81Yml0cywgNCk7 CiAgICB1bnNpZ25lZCBpbnQgWkYgPSBHRVRfQklUKF81Yml0cywgMyk7CiAgICB1bnNpZ25lZCBp bnQgQUYgPSBHRVRfQklUKF81Yml0cywgMik7CiAgICB1bnNpZ25lZCBpbnQgUEYgPSBHRVRfQklU KF81Yml0cywgMSk7CiAgICB1bnNpZ25lZCBpbnQgQ0YgPSBHRVRfQklUKF81Yml0cywgMCk7Cgog ICAgcmV0dXJuIChTRiA8PCA3KQogICAgICAgICB8IChaRiA8PCA2KQogICAgICAgICB8ICggMCA8 PCA1KQogICAgICAgICB8IChBRiA8PCA0KQogICAgICAgICB8ICggMCA8PCAzKQogICAgICAgICB8 IChQRiA8PCAyKQogICAgICAgICB8ICggMSA8PCAxKQogICAgICAgICB8IChDRiA8PCAwKTsKfQoK c3RhdGljIGNoYXIgc3pfZWZsYWdzW10gPSAiICAgICAgICAiOyAvLyA4IHNwYWNlcyAgICAKc3Rh dGljIHZvaWQgcHBfZWZsYWdzICh1bnNpZ25lZCBpbnQgXzhiaXRzX2VmbGFncykKewogICAgYXNz ZXJ0IChfOGJpdHNfZWZsYWdzID49IDApOwogICAgYXNzZXJ0IChfOGJpdHNfZWZsYWdzIDw9IDB4 RkYpOwogICAgc3pfZWZsYWdzWzBdID0gR0VUX0JJVChfOGJpdHNfZWZsYWdzLCA3KSA/ICdTJyA6 ICcgJzsKICAgIHN6X2VmbGFnc1sxXSA9IEdFVF9CSVQoXzhiaXRzX2VmbGFncywgNikgPyAnWicg OiAnICc7CiAgICBzel9lZmxhZ3NbM10gPSBHRVRfQklUKF84Yml0c19lZmxhZ3MsIDQpID8gJ0En IDogJyAnOwogICAgc3pfZWZsYWdzWzVdID0gR0VUX0JJVChfOGJpdHNfZWZsYWdzLCAyKSA/ICdQ JyA6ICcgJzsKICAgIHN6X2VmbGFnc1s3XSA9IEdFVF9CSVQoXzhiaXRzX2VmbGFncywgMCkgPyAn QycgOiAnICc7Cn0KCnN0YXRpYyBjb25zdCBzdHJ1Y3QgQkNEX0lOU05TIHsKICAgIGNvbnN0IGNo YXIgbmFtZVs0XTsKICAgIHVuc2lnbmVkIGludCBlYXhfbGltaXQ7Cn0gYmNkX2luc25zW10gPSB7 CiAgICB7IC5uYW1lID0gIkRBQSIsIC5lYXhfbGltaXQgPSAweEZGIH0sICAgLy8gb3BlcmF0ZXMg b25seSBvbiBBTAogICAgeyAubmFtZSA9ICJEQVMiLCAuZWF4X2xpbWl0ID0gMHhGRiB9LCAgIC8v IG9wZXJhdGVzIG9ubHkgb24gQUwKICAgIHsgLm5hbWUgPSAiQUFBIiwgLmVheF9saW1pdCA9IDB4 RkZGRiB9LCAvLyBvcGVyYXRlcyBvbiBBTCwgQUgKICAgIHsgLm5hbWUgPSAiQUFTIiwgLmVheF9s aW1pdCA9IDB4RkZGRiB9ICAvLyBvcGVyYXRlcyBvbiBBTCwgQUgKfTsKc3RhdGljIGNvbnN0IHVu c2lnbmVkIGludCBiY2RfaW5zbnNfY291bnQgPSBzaXplb2YgKGJjZF9pbnNucykgLyBzaXplb2Yg KGJjZF9pbnNuc1swXSk7CgojZGVmaW5lIEVNSVRfQkNEX0NBTEwoaW5zbiwgaW5fZWF4LCBpbl9l ZmxhZ3MsIG91dF9lYXgsIG91dF9lZmxhZ3MpIFwKICAgIGFzbSB2b2xhdGlsZSggICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAgICAgICAgIm1vdmwg JTIsICUlZWF4IFx0XG4iICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAog ICAgICAgICJzYWhmICAgICAgICAgICBcdFxuIiAvKiBsb2FkaW5nIG91ciBlZmxhZ3MgKi8gICAg ICAgICAgICAgIFwKICAgICAgICAibW92bCAlMywgJSVlYXggXHRcbiIgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBcCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgICAgIGluc24gIlx0XG4i ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBcCiAgICAgICAgLyogcmV0dXJuIHJlc3VsdCAqLyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXAogICAgICAgICJtb3ZsICUlZWF4LCAlMCBcdFxuIiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKICAgICAgICAibGFoZiAgICAg ICAgICAgXHRcbiIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAg ICAgICAgIm1vdmwgJSVlYXgsICUxIFx0XG4iICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgXAogICAgICAgIDogIj1kIihvdXRfZWF4KSwgIj1iIihvdXRfZWZsYWdzKSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKICAgICAgICA6ICJiIihpbl9lZmxhZ3MpLCAi ZCIoaW5fZWF4KSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAgICAgICAgOiAi JWVheCIsICJjYyIgLyogd2UgbWVzcyB1cCBFRkxBR1MgKi8pOwoKCmludCBtYWluICgpCnsKICAg IHVuc2lnbmVkIGludCBpOwoKICAgIGZvciAoaSA9IDA7IGkgPCBiY2RfaW5zbnNfY291bnQ7ICsr aSkKICAgIHsKICAgICAgICB1bnNpZ25lZCBpbnQgXzViZWZsYWdzLCBlZmxhZ3M7CiAgICAgICAg dW5zaWduZWQgaW50IGVheDsKCiAgICAgICAgZm9yIChfNWJlZmxhZ3MgPSAwOyBfNWJlZmxhZ3Mg PD0gMHgxRjsgKytfNWJlZmxhZ3MpCiAgICAgICAgewogICAgICAgICAgICBlZmxhZ3MgPSBfNXRv OF9lZmxhZ3MgKF81YmVmbGFncykgPDwgODsKICAgICAgICAgICAgZm9yIChlYXggPSAwOyBlYXgg PD0gYmNkX2luc25zW2ldLmVheF9saW1pdDsgKytlYXgpCiAgICAgICAgICAgIHsKICAgICAgICAg ICAgICAgIHBwX2VmbGFncyAoKGVmbGFncyA+PiA4KSAmIDB4RkYpOyAvLyBzY3JhdGNoaW5nIG9m ZiBBSAogICAgICAgICAgICAgICAgcHJpbnRmICgiJXMgKEVBWCA9ICUwOFgsIEVGTEFHUyA9ICVz KSA9PiAiLCBiY2RfaW5zbnNbaV0ubmFtZSwgZWF4LCBzel9lZmxhZ3MpOwogICAgICAgICAgICAg ICAgCiAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgcmVzdWx0aW5nX2VmbGFnczsKICAgICAg ICAgICAgICAgIHVuc2lnbmVkIGludCByZXN1bHRpbmdfZWF4OwoKICAgICAgICAgICAgICAgIHN3 aXRjaCAoaSkgewogICAgICAgICAgICAgICAgICAgIGNhc2UgMDogRU1JVF9CQ0RfQ0FMTCgiZGFh IiwgZWF4LCBlZmxhZ3MsIHJlc3VsdGluZ19lYXgsIHJlc3VsdGluZ19lZmxhZ3MpOyBicmVhazsK ICAgICAgICAgICAgICAgICAgICBjYXNlIDE6IEVNSVRfQkNEX0NBTEwoImRhcyIsIGVheCwgZWZs YWdzLCByZXN1bHRpbmdfZWF4LCByZXN1bHRpbmdfZWZsYWdzKTsgYnJlYWs7CiAgICAgICAgICAg ICAgICAgICAgY2FzZSAyOiBFTUlUX0JDRF9DQUxMKCJhYWEiLCBlYXgsIGVmbGFncywgcmVzdWx0 aW5nX2VheCwgcmVzdWx0aW5nX2VmbGFncyk7IGJyZWFrOwogICAgICAgICAgICAgICAgICAgIGNh c2UgMzogRU1JVF9CQ0RfQ0FMTCgiYWFzIiwgZWF4LCBlZmxhZ3MsIHJlc3VsdGluZ19lYXgsIHJl c3VsdGluZ19lZmxhZ3MpOyBicmVhazsKICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAg IAogICAgICAgICAgICAgICAgcHBfZWZsYWdzICgocmVzdWx0aW5nX2VmbGFncyA+PiA4KSAmIDB4 RkYpOyAvLyBzY3JhdGNoaW5nIG9mZiBBSAogICAgICAgICAgICAgICAgcHJpbnRmICgiKEVBWCA9 ICUwOFgsIEVGTEFHUyA9ICVzKVxuIiwgcmVzdWx0aW5nX2VheCwgc3pfZWZsYWdzKTsKICAgICAg ICAgICAgfQogICAgICAgIH0KICAgIH0KICAgIHJldHVybiAwOwp9Cg==