146679 2007-06-11 20:51:19 +0000 Can't set negative absolute hours 2008-06-24 14:30:55 +0000 1 1 2 Applications ktimetracker general Git (master) unspecified Linux RESOLVED FIXED NOR minor --- 1 ronald dev lro smparrish 0 oldest_to_newest 531130 0 ronald 2007-06-11 20:51:19 +0000 Version: 1.6.0 (using KDE 3.5.4, compiled sources) Compiler: Target: i586-mandriva-linux-gnu OS: Linux (i686) release 2.6.17-5mdv Just a very minor bug in my opinion. (1) I like the functionality of KArm working with negative times, but besides setting the time using a negative relative value to something on the other end of the 0, it should also be possible to set it directly using a negative absolute hour value, but the hour-fields do not accept the dash. (2) Strongly related but even of less importance maybe: when you edit a task with a negative time, the dash is present (inconsistent with the behavior of above) but the hour field is not editable. Expected behaviors: (1) The application should accepts my dash in the absolute hour fields. (2) The application should let me edit the absolute hour fields when a negative value is in it. 531203 1 dev 2007-06-12 12:38:45 +0000 I confirm this bug. I would be glad if you could tell me what you need negative times for - I enabled them somehow, but I still cannot think about a usecase. And I am always happy to hear how people use karm (which is renamed to ktimetracker for KDE 4). 531207 2 dev 2007-06-12 12:58:33 +0000 SVN commit 674402 by tstaerk: allow negative times BUGS:146679 M +1 -1 edittaskdialog.cpp M +1 -1 edittaskdialog.h M +0 -4 ktimewidget.cpp --- trunk/KDE/kdepim/ktimetracker/edittaskdialog.cpp #674401:674402 @@ -1,5 +1,5 @@ /* - * karm + * ktimetracker * This file only: Copyright (C) 1999 Espen Sand, espensa@online.no * Modifications (see CVS log) Copyright (C) 2000 Klarälvdalens * Datakonsult AB <kalle@dalheimer.de>, Jesper Pedersen <blackie@kde.org> --- trunk/KDE/kdepim/ktimetracker/edittaskdialog.h #674401:674402 @@ -1,5 +1,5 @@ /* - * karm + * ktimetracker * This file only: Copyright (C) 1999 Espen Sand, espensa@online.no * * This program is free software; you can redistribute it and/or modify --- trunk/KDE/kdepim/ktimetracker/ktimewidget.cpp #674401:674402 @@ -27,7 +27,6 @@ #include <QString> #include <QValidator> #include <QWidget> -//Added by qt3to4: #include <QHBoxLayout> #include <QKeyEvent> @@ -55,9 +54,6 @@ if ( ! ok ) return Invalid; - if ( str.contains('-') != 0 ) - return Invalid; - if ( _tp==MINUTE && val >= 60 ) return Invalid; else 531217 3 ronald 2007-06-12 13:58:10 +0000 Thanks for your fast reply and fix! So what's the use of negative times? I use them to mimic the behavior of a count-down timer so I can easily see how many time is left when I'm completing a task with a time budget. Of course, it misses functionality like warnings or an alarm bell and if this functionality would have made it in a normal way to the application, there would be a seperate field for time budget or something, but it works this way. 531228 4 dev 2007-06-12 15:22:57 +0000 See https://bugs.kde.org/show_bug.cgi?id=90407 for the request for a time budget - I will not implement it. 531292 5 dev 2007-06-12 22:17:11 +0000 SVN commit 674691 by tstaerk: Backport SVN commit 674402 to KDE 3.5 series: Allow negative times for budgeting time for a task. CCBUGS:146679 M +0 -3 ktimewidget.cpp --- branches/KDE/3.5/kdepim/karm/ktimewidget.cpp #674690:674691 @@ -30,9 +30,6 @@ if ( ! ok ) return Invalid; - if ( str.contains('-') != 0 ) - return Invalid; - if ( _tp==MINUTE && val >= 60 ) return Invalid; else 531295 6 dev 2007-06-12 22:18:53 +0000 *** Bug 90407 has been marked as a duplicate of this bug. *** 586406 7 23877 modax.reg 2008-03-12 14:53:05 +0000 Created attachment 23877 Patch for inconsistencies with -0:59 <=t<=-0:01 The bug was not fully fixed. There is still a problem with display and input of "negative" time if it's in -0:59 to -0:01 range. Then it's displayed without minus. This patch fixes this issue. Applied against karm 3.5.9 586536 8 dev 2008-03-13 01:26:33 +0000 At the moment it is 1:30 am and I do not have the concentration to look at it, but the patch seems beautiful - less code partly. And I never understood the printf parameters, thanks for helping me here. 586538 9 dev 2008-03-13 01:40:08 +0000 Modestas is right: - start karm - add a task a - edit task a, subtract 59 minutes -> actual: task a shows 0:59 minutes; expected: task a shows -0:59 - edit task a, subtrack 2 hours -> actual and expected: task a shows -2:59 this is a bug 586541 10 dev 2008-03-13 02:11:40 +0000 SVN commit 785005 by tstaerk: Patch by Modestas Vainius to show negative times with an abs value below 1 hour correctly. Thanks! CCBUGS:146679 M +2 -2 edittaskdialog.cpp M +3 -1 karmutility.cpp M +13 -8 ktimewidget.cpp M +1 -1 ktimewidget.h WebSVN link: http://websvn.kde.org/?view=rev&revision=785005 586542 11 dev 2008-03-13 02:17:43 +0000 For ktimetracker 4: - add a task a, with a negative time of 59 minutes - task a shows 0:-59 => this is a bug in ktimetracker 4 as well 586544 12 dev 2008-03-13 02:27:42 +0000 WebSVN link: http://websvn.kde.org/?view=rev&revision=785006 615105 13 dev 2008-06-24 14:30:55 +0000 *** Bug 164785 has been marked as a duplicate of this bug. *** 23877 2008-03-12 14:53:05 +0000 2008-03-12 14:53:05 +0000 Patch for inconsistencies with -0:59 <=t<=-0:01 19_karm_negative_time.diff text/plain 2906 modax.reg ZGlmZiAtdU5yIGtkZS0zLjUuOS9rYXJtL2VkaXR0YXNrZGlhbG9nLmNwcCBrZGUtMy41Ljkva2Fy bS9lZGl0dGFza2RpYWxvZy5jcHAKLS0tIGtkZS0zLjUuOS9rYXJtL2VkaXR0YXNrZGlhbG9nLmNw cAkyMDA1LTA5LTEwIDExOjIzOjUzLjAwMDAwMDAwMCArMDMwMAorKysga2RlLTMuNS45L2thcm0v ZWRpdHRhc2tkaWFsb2cuY3BwCTIwMDgtMDMtMTIgMTQ6MTY6NTguMDAwMDAwMDAwICswMjAwCkBA IC0yOTgsOCArMjk4LDggQEAKIHsKICAgX25hbWUtPnNldFRleHQoIG5hbWUgKTsKICAgCi0gIF90 aW1lVFctPnNldFRpbWUoIHRpbWUgLyA2MCwgdGltZSAlIDYwICk7Ci0gIF9zZXNzaW9uVFctPnNl dFRpbWUoIHNlc3Npb24gLyA2MCwgc2Vzc2lvbiAlIDYwICk7CisgIF90aW1lVFctPnNldFRpbWUo IHRpbWUgKTsKKyAgX3Nlc3Npb25UVy0+c2V0VGltZSggc2Vzc2lvbiApOwogICBvcmlnVGltZSA9 IHRpbWU7CiAgIG9yaWdTZXNzaW9uID0gc2Vzc2lvbjsKIH0KZGlmZiAtdU5yIGtkZS0zLjUuOS9r YXJtL2thcm11dGlsaXR5LmNwcCBrZGUtMy41Ljkva2FybS9rYXJtdXRpbGl0eS5jcHAKLS0tIGtk ZS0zLjUuOS9rYXJtL2thcm11dGlsaXR5LmNwcAkyMDA4LTAzLTEyIDEzOjUxOjM4LjAwMDAwMDAw MCArMDIwMAorKysga2RlLTMuNS45L2thcm0va2FybXV0aWxpdHkuY3BwCTIwMDgtMDMtMTIgMTM6 NTg6NTkuMDAwMDAwMDAwICswMjAwCkBAIC0xNCw3ICsxNCw5IEBACiAgICAgdGltZS5zcHJpbnRm KCIlLjJmIiwgbWludXRlcyAvIDYwLjApOwogICAgIHRpbWUucmVwbGFjZSggJy4nLCBLR2xvYmFs Ojpsb2NhbGUoKS0+ZGVjaW1hbFN5bWJvbCgpICk7CiAgIH0KLSAgZWxzZSB0aW1lLnNwcmludGYo IiVsZDolMDJsZCIsIG1pbnV0ZXMgLyA2MCwgbGFicyhtaW51dGVzICUgNjApKTsKKyAgZWxzZSB0 aW1lLnNwcmludGYoIiVzJWxkOiUwMmxkIiwKKyAgICAobWludXRlcyA8IDApID8gS0dsb2JhbDo6 bG9jYWxlKCktPm5lZ2F0aXZlU2lnbigpLnV0ZjgoKS5kYXRhKCkgOiAiIiwKKyAgICBsYWJzKG1p bnV0ZXMgLyA2MCksIGxhYnMobWludXRlcyAlIDYwKSk7CiAgIHJldHVybiB0aW1lOwogfQogCmRp ZmYgLXVOciBrZGUtMy41Ljkva2FybS9rdGltZXdpZGdldC5jcHAga2RlLTMuNS45L2thcm0va3Rp bWV3aWRnZXQuY3BwCi0tLSBrZGUtMy41Ljkva2FybS9rdGltZXdpZGdldC5jcHAJMjAwNy0xMC0w OCAxMjo1MDo0MS4wMDAwMDAwMDAgKzAzMDAKKysrIGtkZS0zLjUuOS9rYXJtL2t0aW1ld2lkZ2V0 LmNwcAkyMDA4LTAzLTEyIDE0OjIyOjQwLjAwMDAwMDAwMCArMDIwMApAQCAtOCw2ICs4LDcgQEAK ICNpbmNsdWRlIDxxd2lkZ2V0Lmg+CiAKICNpbmNsdWRlIDxrbG9jYWxlLmg+ICAgICAgICAgICAg Ly8gaTE4bgorI2luY2x1ZGUgPGtnbG9iYWwuaD4KICNpbmNsdWRlICJrdGltZXdpZGdldC5oIgog CiBlbnVtIFZhbGlkYXRvclR5cGUgeyBIT1VSLCBNSU5VVEUgfTsKQEAgLTk3LDE1ICs5OCwxOSBA QAogICBzZXRGb2N1c1Byb3h5KCBfaG91ckxFICk7CiB9CiAKLXZvaWQgS0FybVRpbWVXaWRnZXQ6 OnNldFRpbWUoIGludCBob3VyLCBpbnQgbWludXRlICkKK3ZvaWQgS0FybVRpbWVXaWRnZXQ6OnNl dFRpbWUoIGxvbmcgdGltZSApCiB7CiAgIFFTdHJpbmcgZHVtbXk7CisgIGxvbmcgaG91ciA9IGxh YnModGltZSkgLyA2MDsKKyAgbG9uZyBtaW51dGUgPSBsYWJzKHRpbWUpICUgNjA7CiAKICAgZHVt bXkuc2V0TnVtKCBob3VyICk7CisgIGlmICh0aW1lIDwgMCkKKyAgICBkdW1teSA9IEtHbG9iYWw6 OmxvY2FsZSgpLT5uZWdhdGl2ZVNpZ24oKSArIGR1bW15OwogICBfaG91ckxFLT5zZXRUZXh0KCBk dW1teSApOwogCi0gIGR1bW15LnNldE51bSggYWJzKG1pbnV0ZSkgKTsKLSAgaWYgKGFicyhtaW51 dGUpIDwgMTAgKSB7CisgIGR1bW15LnNldE51bSggbWludXRlICk7CisgIGlmIChtaW51dGUgPCAx MCApIHsKICAgICBkdW1teSA9IFFTdHJpbmc6OmZyb21MYXRpbjEoICIwIiApICsgZHVtbXk7CiAg IH0KICAgX21pbnV0ZUxFLT5zZXRUZXh0KCBkdW1teSApOwpAQCAtMTEzLDEyICsxMTgsMTIgQEAK IAogbG9uZyBLQXJtVGltZVdpZGdldDo6dGltZSgpIGNvbnN0CiB7Ci0gIGJvb2wgb2s7CisgIGJv b2wgb2ssIGlzTmVnYXRpdmU7CiAgIGludCBoLCBtOwogCi0gIGggPSBfaG91ckxFLT50ZXh0KCku dG9JbnQoICZvayApOworICBoID0gYWJzKF9ob3VyTEUtPnRleHQoKS50b0ludCggJm9rICkpOwog ICBtID0gX21pbnV0ZUxFLT50ZXh0KCkudG9JbnQoICZvayApOworICBpc05lZ2F0aXZlID0gX2hv dXJMRS0+dGV4dCgpLnN0YXJ0c1dpdGgoS0dsb2JhbDo6bG9jYWxlKCktPm5lZ2F0aXZlU2lnbigp KTsKIAotICAvLyBpZiBoIGlzIG5lZ2F0aXZlLCB3ZSBoYXZlIHRvICpzdWJ0cmFjdCogbQotICBy ZXR1cm4gaCAqIDYwICsgKCAoIGggPCAwKSA/IC0xIDogMSApICogbTsKKyAgcmV0dXJuIChoICog NjAgKyBtKSAqICgoaXNOZWdhdGl2ZSkgPyAtMSA6IDEpOwogfQpkaWZmIC11TnIga2RlLTMuNS45 L2thcm0va3RpbWV3aWRnZXQuaCBrZGUtMy41Ljkva2FybS9rdGltZXdpZGdldC5oCi0tLSBrZGUt My41Ljkva2FybS9rdGltZXdpZGdldC5oCTIwMDUtMDktMTAgMTE6MjM6NTMuMDAwMDAwMDAwICsw MzAwCisrKyBrZGUtMy41Ljkva2FybS9rdGltZXdpZGdldC5oCTIwMDgtMDMtMTIgMTQ6MTY6MTQu MDAwMDAwMDAwICswMjAwCkBAIC0xNCw3ICsxNCw3IEBACiB7CiAgIHB1YmxpYzoKICAgICBLQXJt VGltZVdpZGdldCggUVdpZGdldCogcGFyZW50ID0gMCwgY29uc3QgY2hhciogbmFtZSA9IDAgKTsK LSAgICB2b2lkIHNldFRpbWUoIGludCBob3VyLCBpbnQgbWludXRlICk7CisgICAgdm9pZCBzZXRU aW1lKCBsb25nIHRpbWUgKTsKICAgICBsb25nIHRpbWUoKSBjb25zdDsKIAogICBwcml2YXRlOgo=