145451 2007-05-15 11:55:46 +0000 Patch for replacing "0 Kb/s" with empty string 2007-05-15 20:13:58 +0000 1 1 2 Applications ktorrent general unspecified Gentoo Packages Linux RESOLVED FIXED NOR wishlist --- 0 twisted.fall joris.guisson 0 oldest_to_newest 525824 0 twisted.fall 2007-05-15 11:55:46 +0000 Version: 2.1.4 (using KDE KDE 3.5.6) Installed from: Gentoo Packages OS: Linux It is quite uninformative for me to see all those 0 Kb/s in speed columns. Both BitComet and uTorrent do hide such values which results in cleaner view of torrent activity IMHO. I have made a patch that replaces all speed values that are less than 103 bytes/sec with an empty string. Patched are main ktorrent view and peer tab of info widget plugin. 525825 1 20573 twisted.fall 2007-05-15 11:56:34 +0000 Created attachment 20573 empty_string_when_zero_speed.patch 525923 2 joris.guisson 2007-05-15 20:13:57 +0000 SVN commit 665062 by guisson: Added patch from twisted_fall, which doesn't show anything in speed columns if the speed is very low or 0 BUG: 145451 M +16 -6 apps/ktorrent/ktorrentviewitem.cpp M +1 -0 apps/ktorrent/main.cpp M +9 -3 plugins/infowidget/peerview.cpp --- trunk/extragear/network/ktorrent/apps/ktorrent/ktorrentviewitem.cpp #665061:665062 @@ -191,15 +191,25 @@ if(m_parent->columnVisible(5)) { - if (s.bytes_left_to_download == 0) - setText(5,KBytesPerSecToString(0)); + if (s.download_rate >= 103) // lowest "visible" speed, all below will be 0,0 Kb/s + { + if (s.bytes_left_to_download == 0) + setText(5,KBytesPerSecToString(0)); + else + setText(5,KBytesPerSecToString(s.download_rate / 1024.0)); + } else - setText(5,KBytesPerSecToString(s.download_rate / 1024.0)); + setText(5, ""); } - + if(m_parent->columnVisible(6)) - setText(6,KBytesPerSecToString(s.upload_rate / 1024.0)); - + { + if (s.upload_rate >= 103) // lowest "visible" speed, all below will be 0,0 Kb/s + setText(6,KBytesPerSecToString(s.upload_rate / 1024.0)); + else + setText(6, ""); + } + if(m_parent->columnVisible(7)) { if (s.bytes_left_to_download == 0) --- trunk/extragear/network/ktorrent/apps/ktorrent/main.cpp #665061:665062 @@ -150,6 +150,7 @@ about.addCredit("Goten Xiao",I18N_NOOP("Patch to load silently with a save location"),0); about.addCredit("Rapsys",I18N_NOOP("Fixes in PHP code of webinterface"),0); about.addCredit("Athantor",I18N_NOOP("XFS specific disk preallocation"),0); + about.addCredit("twisted_fall",I18N_NOOP("Patch to not show very low speeds"),"twisted.fall@gmail.com"); KCmdLineArgs::init(argc, argv, &about); KCmdLineArgs::addCmdLineOptions(options); --- trunk/extragear/network/ktorrent/plugins/infowidget/peerview.cpp #665061:665062 @@ -120,9 +120,15 @@ { KLocale* loc = KGlobal::locale(); const PeerInterface::Stats & s = peer->getStats(); - - setText(3,KBytesPerSecToString(s.download_rate / 1024.0)); - setText(4,KBytesPerSecToString(s.upload_rate / 1024.0)); + + if (s.download_rate >= 103) // lowest "visible" speed, all below will be 0,0 Kb/s + setText(3,KBytesPerSecToString(s.download_rate / 1024.0)); + else + setText(3, ""); + if (s.upload_rate >= 103) // lowest "visible" speed, all below will be 0,0 Kb/s + setText(4,KBytesPerSecToString(s.upload_rate / 1024.0)); + else + setText(4, ""); //setPixmap(5,!s.choked ? yes_pix : no_pix); setText(5,s.choked ? i18n("Yes") : i18n("No")); //setPixmap(6,!s.snubbed ? yes_pix : no_pix); 20573 2007-05-15 11:56:34 +0000 2007-05-15 11:56:34 +0000 empty_string_when_zero_speed.patch empty_string_when_zero_speed.patch text/plain 1886 twisted.fall LS0tIGFwcHMva3RvcnJlbnQva3RvcnJlbnR2aWV3aXRlbS5jcHAub3JpZwkyMDA3LTA0LTIyIDE0 OjI1OjQ4LjAwMDAwMDAwMCArMDMwMAorKysgYXBwcy9rdG9ycmVudC9rdG9ycmVudHZpZXdpdGVt LmNwcAkyMDA3LTA1LTE0IDIyOjU4OjU5LjAwMDAwMDAwMCArMDMwMApAQCAtMTI0LDE1ICsxMjQs MjUgQEAKIAkKIAlpZihtX3BhcmVudC0+Y29sdW1uVmlzaWJsZSg1KSkKIAl7Ci0JCWlmIChzLmJ5 dGVzX2xlZnRfdG9fZG93bmxvYWQgPT0gMCkKLQkJCXNldFRleHQoNSxLQnl0ZXNQZXJTZWNUb1N0 cmluZygwKSk7CisJCWlmIChzLmRvd25sb2FkX3JhdGUgPj0gMTAzKSAvLyBsb3dlc3QgInZpc2li bGUiIHNwZWVkLCBhbGwgYmVsb3cgd2lsbCBiZSAwLDAgS2IvcworCQl7CisJCQlpZiAocy5ieXRl c19sZWZ0X3RvX2Rvd25sb2FkID09IDApCisJCQkJc2V0VGV4dCg1LEtCeXRlc1BlclNlY1RvU3Ry aW5nKDApKTsKKwkJCWVsc2UKKwkJCQlzZXRUZXh0KDUsS0J5dGVzUGVyU2VjVG9TdHJpbmcocy5k b3dubG9hZF9yYXRlIC8gMTAyNC4wKSk7CisJCX0KIAkJZWxzZQotCQkJc2V0VGV4dCg1LEtCeXRl c1BlclNlY1RvU3RyaW5nKHMuZG93bmxvYWRfcmF0ZSAvIDEwMjQuMCkpOworCQkJc2V0VGV4dCg1 LCAiIik7CiAJfQotCQorCiAJaWYobV9wYXJlbnQtPmNvbHVtblZpc2libGUoNikpCi0JCXNldFRl eHQoNixLQnl0ZXNQZXJTZWNUb1N0cmluZyhzLnVwbG9hZF9yYXRlIC8gMTAyNC4wKSk7Ci0gIAor CXsKKwkJaWYgKHMudXBsb2FkX3JhdGUgPj0gMTAzKSAvLyBsb3dlc3QgInZpc2libGUiIHNwZWVk LCBhbGwgYmVsb3cgd2lsbCBiZSAwLDAgS2IvcworCQkJc2V0VGV4dCg2LEtCeXRlc1BlclNlY1Rv U3RyaW5nKHMudXBsb2FkX3JhdGUgLyAxMDI0LjApKTsKKwkJZWxzZQorCQkJc2V0VGV4dCg2LCAi Iik7CisJfQorCiAJaWYobV9wYXJlbnQtPmNvbHVtblZpc2libGUoNykpCiAJewogCQlpZiAocy5i eXRlc19sZWZ0X3RvX2Rvd25sb2FkID09IDApCi0tLSBwbHVnaW5zL2luZm93aWRnZXQvcGVlcnZp ZXcuY3BwLm9yaWcJMjAwNy0wNC0yMiAxNDoyNTo0NC4wMDAwMDAwMDAgKzAzMDAKKysrIHBsdWdp bnMvaW5mb3dpZGdldC9wZWVydmlldy5jcHAJMjAwNy0wNS0xNSAxMDoxMDo1MC4wMDAwMDAwMDAg KzAzMDAKQEAgLTEyMCw5ICsxMjAsMTUgQEAKIAl7CiAJCUtMb2NhbGUqIGxvYyA9IEtHbG9iYWw6 OmxvY2FsZSgpOwogCQljb25zdCBQZWVySW50ZXJmYWNlOjpTdGF0cyAmIHMgPSBwZWVyLT5nZXRT dGF0cygpOwotCQkKLQkJc2V0VGV4dCgzLEtCeXRlc1BlclNlY1RvU3RyaW5nKHMuZG93bmxvYWRf cmF0ZSAvIDEwMjQuMCkpOwotCQlzZXRUZXh0KDQsS0J5dGVzUGVyU2VjVG9TdHJpbmcocy51cGxv YWRfcmF0ZSAvIDEwMjQuMCkpOworCisJCWlmIChzLmRvd25sb2FkX3JhdGUgPj0gMTAzKSAvLyBs b3dlc3QgInZpc2libGUiIHNwZWVkLCBhbGwgYmVsb3cgd2lsbCBiZSAwLDAgS2IvcworCQkJc2V0 VGV4dCgzLEtCeXRlc1BlclNlY1RvU3RyaW5nKHMuZG93bmxvYWRfcmF0ZSAvIDEwMjQuMCkpOwor CQllbHNlCisJCQlzZXRUZXh0KDMsICIiKTsKKwkJaWYgKHMudXBsb2FkX3JhdGUgPj0gMTAzKSAv LyBsb3dlc3QgInZpc2libGUiIHNwZWVkLCBhbGwgYmVsb3cgd2lsbCBiZSAwLDAgS2IvcworCQkJ c2V0VGV4dCg0LEtCeXRlc1BlclNlY1RvU3RyaW5nKHMudXBsb2FkX3JhdGUgLyAxMDI0LjApKTsK KwkJZWxzZQorCQkJc2V0VGV4dCg0LCAiIik7CiAJCS8vc2V0UGl4bWFwKDUsIXMuY2hva2VkID8g eWVzX3BpeCA6IG5vX3BpeCk7CiAJCXNldFRleHQoNSxzLmNob2tlZCA/IGkxOG4oIlllcyIpIDog aTE4bigiTm8iKSk7CiAJCS8vc2V0UGl4bWFwKDYsIXMuc251YmJlZCA/IHllc19waXggOiBub19w aXgpOwo=