<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>144177</bug_id>
          
          <creation_ts>2007-04-13 14:56:52 +0000</creation_ts>
          <short_desc>In Caption/Tags sidebar, new Tags inherit the image of their parents</short_desc>
          <delta_ts>2021-01-19 17:21:01 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>digikam</product>
          <component>Tags-Captions</component>
          <version>4.1.0</version>
          <rep_platform>Fedora RPMs</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dotan Cohen">kde-2011.08</reporter>
          <assigned_to name="Digikam Developers">digikam-bugs-null</assigned_to>
          <cc>caulier.gilles</cc>
    
    <cc>dch.code</cc>
    
    <cc>kde-2011.08</cc>
    
    <cc>laurakittyinka</cc>
    
    <cc>metzpinguin</cc>
    
    <cc>timetre</cc>
          
          <cf_commitlink>https://invent.kde.org/graphics/digikam/-/commit/087bdcd4c244e5acd5552c8b08e8636dc92ca31f</cf_commitlink>
          <cf_versionfixedin>7.2.0</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>1</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>520463</commentid>
    <comment_count>0</comment_count>
    <who name="Dotan Cohen">kde-2011.08</who>
    <bug_when>2007-04-13 14:56:52 +0000</bug_when>
    <thetext>Version:            (using KDE KDE 3.5.6)
Installed from:    Fedora RPMs
OS:                Linux

When creating new tags in the Comments/Tags sidebar, the new tag inherits the image of it&apos;s parent tag. I would expect the new tag to have no image, just like new tags created in other parts of Digikam have no image.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>637941</commentid>
    <comment_count>1</comment_count>
    <who name="Andi Clemens">andi.clemens</who>
    <bug_when>2008-08-16 15:47:48 +0000</bug_when>
    <thetext>Yes, I think this should be improved... I can confirm this, too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>841713</commentid>
    <comment_count>2</comment_count>
    <who name="Andi Clemens">andi.clemens</who>
    <bug_when>2009-10-08 01:05:18 +0000</bug_when>
    <thetext>I also would prefer an empty icon, but there might also be users who want to have the icon of the parent set for the child tag.

We need to discuss this. Any suggestions here?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>844439</commentid>
    <comment_count>3</comment_count>
    <who name="Dotan Cohen">kde-2011.08</who>
    <bug_when>2009-10-13 15:17:07 +0000</bug_when>
    <thetext>&gt; We need to discuss this. Any suggestions here?

An option. It could either be a general option for all of digikam, or a checkbox for each tag whether or not new child tabs get an empty icon or their parent&apos;s icon.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1200484</commentid>
    <comment_count>4</comment_count>
    <who name="">caulier.gilles</who>
    <bug_when>2011-12-16 12:27:03 +0000</bug_when>
    <thetext>Dotan,

This file still valid using digiKam 2.4 ?

Gilles Caulier</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1201067</commentid>
    <comment_count>5</comment_count>
    <who name="Dotan Cohen">kde-2011.08</who>
    <bug_when>2011-12-17 18:40:08 +0000</bug_when>
    <thetext>‏Yes, still valid.

Steps to reproduce:
1) Assign an an icon/image to a tag.
2) Right-click the tag, select New Tag.
3) Finish creating the new tag, do not assign an image.

Notice that the icon/image of the new tag is the icon/image of the parent tag.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1469081</commentid>
    <comment_count>6</comment_count>
    <who name="">caulier.gilles</who>
    <bug_when>2014-09-02 10:03:17 +0000</bug_when>
    <thetext>Dotan,

This file still valid using last digiKam 4.2.0 ?

Gilles Caulier</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1469171</commentid>
    <comment_count>7</comment_count>
    <who name="Dotan Cohen">kde-2011.08</who>
    <bug_when>2014-09-02 18:16:57 +0000</bug_when>
    <thetext>The issue is still valid in Digikam 4.1, using the steps to reproduce from Comment #5.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1605637</commentid>
    <comment_count>8</comment_count>
    <who name="">caulier.gilles</who>
    <bug_when>2016-07-06 13:59:34 +0000</bug_when>
    <thetext>This problem still valid using last digiKam 5.0.0 ?

Gilles Caulier</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1642822</commentid>
    <comment_count>9</comment_count>
    <who name="">caulier.gilles</who>
    <bug_when>2016-12-01 10:08:20 +0000</bug_when>
    <thetext>Any feedback with current AppImage bundle for Linux ?

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Gilles Caulier</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1642845</commentid>
    <comment_count>10</comment_count>
    <who name="Barbara Scheffner">laurakittyinka</who>
    <bug_when>2016-12-01 11:58:45 +0000</bug_when>
    <thetext>I support the proposal of Dotan Cohen to have an option whether the new tag should inherit the icon or not, because the first can save you the hassle of finding a particular tag in lenghty tables/lists. I even &quot;abuse&quot; this function if I want the same icon for a tag that is not a child. I first create the new tag as a child and then move it to somewhere eles in the tree.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1996095</commentid>
    <comment_count>11</comment_count>
    <who name="David Haslam">dch.code</who>
    <bug_when>2021-01-19 10:47:42 +0000</bug_when>
    <thetext>I think there may be a simple fix for this, that might allow us to
close this very old report.

At the moment, if the user wishes to use the standard icon, the tag
has to be first created with right click then &apos;New Tag&apos;. Then right
click on the new tag then either &apos;Reset Tag Icon&apos;, or &apos;Properties&apos;
then &apos;Reset&apos;.

If we put a Reset button on the &apos;New Tag&apos; popup dialog, then the user
may choose the standard icon at creation time saving a few clicks.

The &apos;New Tag&apos; popup and the &apos;Properties&apos; popup share the same dialog
code (core/libs/tags/widgets/tageditdlg.cpp), so it is a simple fix to
remove the code that disables the button.

I&apos;ll send a merge request shortly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1996191</commentid>
    <comment_count>12</comment_count>
    <who name="Maik Qualmann">metzpinguin</who>
    <bug_when>2021-01-19 17:21:01 +0000</bug_when>
    <thetext>Fixed with this commit:

https://invent.kde.org/graphics/digikam/-/commit/087bdcd4c244e5acd5552c8b08e8636dc92ca31f

Maik</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>