142579 2007-03-06 05:39:41 +0000 convert Replaygain values to iPod Soundcheck 2012-01-12 15:20:27 +0000 1 1 2 Applications amarok Collections/iPod iPhone 2.3-GIT openSUSE Linux RESOLVED FIXED NOR wishlist --- 1 superbiji amarok-bugs-null hessijames matej michael netz ralf-engels 2.6 81 oldest_to_newest 513137 0 superbiji 2007-03-06 05:39:41 +0000 Version: (using KDE KDE 3.5.1DevelKDE 1.2) Installed from: SuSE RPMsSuSE RPMs0SuSE RPMs convert Replaygain values to iPod Soundcheck I'm using mp3gain and *apply* dB change to the files (mp3 files altered) so I can play in iPod with equal volume I hope amarok can convert replaygain values (from replygain tag) to iPod iTunesDB' soundcheck value so I don't have to alter mp3 513320 1 michael 2007-03-06 22:47:54 +0000 I have hacked Amarok to do exactly this, and it works for me. The problem with my implementation is that it only reads ReplayGain tags as written by mp3gain. This is because TagLib doesn't really support ReplayGain metadata. ReplayGain support in TagLib is supposedly in development, and I've been waiting for this before submitting my patch. 513493 2 19905 michael 2007-03-07 19:36:15 +0000 Created attachment 19905 Patch to add ReplayGain metadata to iPods Here is my patch against Amarok 1.4.5 which sets the Soundcheck field in the iPod database based on the ReplayGain Track Gain. As I noted above, it can only retrieve values as written by mp3gain since TagLib doesn't support ReplayGain properly. It enters a default gain of -8dB if a track doesn't contain ReplayGain metadata. 513576 3 superbiji 2007-03-08 04:37:06 +0000 great.. I wonder what happen to files which already applied gain (mp3 files altered) amarok should set Soundcheck value to 0 for these files 513599 4 michael 2007-03-08 11:43:19 +0000 It probably should, but it's not the ideal situation since you can't enable/disable Soundcheck on the iPod. It would be better to remove the adjustment from the files. 694915 5 marc 2009-01-06 12:02:10 +0000 *** This bug has been confirmed by popular vote. *** 745900 6 netz 2009-04-22 14:56:27 +0000 Since amarok-2.1 now natively supports ReplayGain (and so I assume taglib does as well), this is perhaps not too difficult to implement anymore? 1072397 7 ralf-engels 2011-01-12 20:11:26 +0000 Very good idea. I also noticed that some other tags supported by libgpod are not set. I have started refactoring the stuff. 1175487 8 matej 2011-10-20 13:11:31 +0000 This is on my TODO list, but there are more severe Amarok iPod bugs, so this will have to wait a bit. 1202374 9 matej 2011-12-20 12:09:13 +0000 Git commit 9f0986a74551002da73d20bda6f3db414053ce75 by Matěj Laitl. Committed on 19/12/2011 at 13:58. Pushed by laitl into branch 'strohel-for-2.6'. iPod collection: convert from ReplayGain to Sound Check and vice versa By popular demand, we now convert ReplayGain values to Sound Check values when transferring tracks to iPod. We also read Sound Check from iPod and convert it to ReplayGain on-the-fly when playing a track off an iPod in Amarok. On the other hand, when transferring tracks from iPod to Amarok, Sound Check from iPod is _not_ automatically copied (current limitation of the ReplayGain implementation in Amarok), but Amarok picks up ReplayGain information from meta-data stored inside the track. (Does anyone know whether iTunes save Sound Check somewhere in song meta-data?) It is currently hard-coded that *track* ReplayGain is used (Sound Check is not able to differentiate between track and album gains), this could be configurable in future (but hey, micro-options!) or it could respect Settings -> Replay Gain Mode (tricky, the setting would be read *only when the song is being transferred to iPod*) FEATURE: 142579 FIXED-IN: 2.6 DIGEST: volume normalization now works between Amarok and iPods M +2 -0 ChangeLog M +26 -0 src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp M +2 -0 src/core-impl/collections/ipodcollection/handler/IpodHandler.h M +6 -0 src/core-impl/collections/ipodcollection/handler/capabilities/IpodReadCapability.cpp M +1 -0 src/core-impl/collections/ipodcollection/handler/capabilities/IpodReadCapability.h M +7 -1 src/core-impl/collections/ipodcollection/handler/capabilities/IpodWriteCapability.cpp M +1 -0 src/core-impl/collections/ipodcollection/handler/capabilities/IpodWriteCapability.h M +23 -0 src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp M +5 -0 src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h M +5 -0 src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp M +6 -0 src/core-impl/collections/mediadevicecollection/handler/capabilities/ReadCapability.cpp M +1 -0 src/core-impl/collections/mediadevicecollection/handler/capabilities/ReadCapability.h M +7 -0 src/core-impl/collections/mediadevicecollection/handler/capabilities/WriteCapability.cpp M +1 -0 src/core-impl/collections/mediadevicecollection/handler/capabilities/WriteCapability.h http://commits.kde.org/amarok/9f0986a74551002da73d20bda6f3db414053ce75 1213585 10 hessijames 2012-01-12 15:17:26 +0000 Git commit 717342ed4aeba0df2328b28840820919ea3d13ec by Daniel Faust. Committed on 12/01/2012 at 16:01. Pushed by dfaust into branch 'master'. Support embedded covers for ogg (read only) and flac files M +1 -0 ChangeLog M +1 -1 shared/tag_helpers/TagHelper.cpp M +208 -1 shared/tag_helpers/VorbisCommentTagHelper.cpp M +9 -0 shared/tag_helpers/VorbisCommentTagHelper.h http://commits.kde.org/amarok/717342ed4aeba0df2328b28840820919ea3d13ec 1213586 11 hessijames 2012-01-12 15:20:27 +0000 sorry, wrong bug number :) 19905 2007-03-07 19:36:15 +0000 2007-03-07 19:36:15 +0000 Patch to add ReplayGain metadata to iPods amarok-1.4.5-soundcheck.diff text/plain 2600 michael ZGlmZiAtdXJwIGFtYXJvay0xLjQuNS1vcmlnL2FtYXJvay9zcmMvbWVkaWFkZXZpY2UvaXBvZC9p cG9kbWVkaWFkZXZpY2UuY3BwIGFtYXJvay0xLjQuNS1zb3VuZGNoZWNrL2FtYXJvay9zcmMvbWVk aWFkZXZpY2UvaXBvZC9pcG9kbWVkaWFkZXZpY2UuY3BwCi0tLSBhbWFyb2stMS40LjUtb3JpZy9h bWFyb2svc3JjL21lZGlhZGV2aWNlL2lwb2QvaXBvZG1lZGlhZGV2aWNlLmNwcAkyMDA3LTAyLTAx IDIwOjE0OjE3LjAwMDAwMDAwMCArMDIwMAorKysgYW1hcm9rLTEuNC41LXNvdW5kY2hlY2svYW1h cm9rL3NyYy9tZWRpYWRldmljZS9pcG9kL2lwb2RtZWRpYWRldmljZS5jcHAJMjAwNy0wMy0wNyAx NzowOTozMy4wMDAwMDAwMDAgKzAyMDAKQEAgLTY3LDYgKzY3LDcgQEAgQU1BUk9LX0VYUE9SVF9Q TFVHSU4oIElwb2RNZWRpYURldmljZSApCiAKICNpbmNsdWRlIDxjc3RkbGliPgogI2luY2x1ZGUg PHVuaXN0ZC5oPgorI2luY2x1ZGUgPG1hdGguaD4KIAogI2lmbmRlZiBIQVZFX0lUREJfTUVESUFU WVBFCiAjZGVmaW5lIG1lZGlhdHlwZSB1bmsyMDgKQEAgLTQ5Niw2ICs0OTcsMTAgQEAgSXBvZE1l ZGlhRGV2aWNlOjp1cGRhdGVUcmFja0luREIoIElwb2RNZQogICAgICAgICB0cmFjay0+dGltZV9t b2RpZmllZCA9IGl0ZGJfdGltZV9ob3N0X3RvX21hYyggY3JlYXRlZGF0ZSApOwogICAgIH0KIAor ICAgIC8vU2V0IFNvdW5kY2hlY2sgZmllbGQgYmFzZWQgb24gUmVwbGF5R2FpbiBkYXRhCisgICAg Ly9Db252ZXJzaW9uIHRha2VuIGZyb20gZ3RrcG9kCisgICAgdHJhY2stPnNvdW5kY2hlY2sgPSAo Z3VpbnQzMikgZmxvb3IgKDEwMDAuICogZXhwMTAgKC1tZXRhQnVuZGxlLnRyYWNrUmVwbGF5R2Fp bigpICogMC4xKSArIDAuNSk7CisKICAgICBpZihwb2RjYXN0SW5mbykKICAgICB7CiAgICAgICAg IHRyYWNrLT5za2lwX3doZW5fc2h1ZmZsaW5nID0gMHgwMTsgLy8gc2tpcCAgd2hlbiBzaHVmZmxp bmcKZGlmZiAtdXJwIGFtYXJvay0xLjQuNS1vcmlnL2FtYXJvay9zcmMvbWV0YWJ1bmRsZS5jcHAg YW1hcm9rLTEuNC41LXNvdW5kY2hlY2svYW1hcm9rL3NyYy9tZXRhYnVuZGxlLmNwcAotLS0gYW1h cm9rLTEuNC41LW9yaWcvYW1hcm9rL3NyYy9tZXRhYnVuZGxlLmNwcAkyMDA3LTAyLTAxIDIwOjE0 OjE3LjAwMDAwMDAwMCArMDIwMAorKysgYW1hcm9rLTEuNC41LXNvdW5kY2hlY2svYW1hcm9rL3Ny Yy9tZXRhYnVuZGxlLmNwcAkyMDA3LTAzLTA3IDE3OjEwOjM4LjAwMDAwMDAwMCArMDIwMApAQCAt MTgyMCw2ICsxODIwLDE3IEBAIHZvaWQgTWV0YUJ1bmRsZTo6ZGV0YWNoKCkKICAgICAgICAgIHNl dExhc3RGbUJ1bmRsZSggUURlZXBDb3B5PExhc3RGbTo6QnVuZGxlPiggKm1fbGFzdEZtQnVuZGxl ICkgKTsKIH0KIAorZmxvYXQgTWV0YUJ1bmRsZTo6dHJhY2tSZXBsYXlHYWluKCBmbG9hdCBub1Jl cGxheUdhaW4gKSBjb25zdAoreworICAgIFRhZ0xpYjo6RmlsZVJlZiBmaWxlcmVmID0gVGFnTGli OjpGaWxlUmVmKCBRRmlsZTo6ZW5jb2RlTmFtZSggdXJsKCkucGF0aCgpICksIHRydWUgKTsKKwor ICAgIGlmICggVGFnTGliOjpNUEVHOjpGaWxlICpmaWxlID0gZHluYW1pY19jYXN0PFRhZ0xpYjo6 TVBFRzo6RmlsZSAqPiggZmlsZXJlZi5maWxlKCkgKSApCisgICAgICAgIGlmICggZmlsZS0+QVBF VGFnKCkgKQorICAgICAgICAgICAgaWYgKCBmaWxlLT5BUEVUYWcoKS0+aXRlbUxpc3RNYXAoKS5j b250YWlucygiUkVQTEFZR0FJTl9UUkFDS19HQUlOIikgKQorICAgICAgICAgICAgICAgIHJldHVy biBhdG9mKCBmaWxlLT5BUEVUYWcoKS0+aXRlbUxpc3RNYXAoKVsiUkVQTEFZR0FJTl9UUkFDS19H QUlOIl0udmFsdWUoKS5kYXRhKCkgKTsKKworICAgIHJldHVybiBub1JlcGxheUdhaW47Cit9CiAK IHZvaWQgUG9kY2FzdEVwaXNvZGVCdW5kbGU6OmRldGFjaCgpCiB7CmRpZmYgLXVycCBhbWFyb2st MS40LjUtb3JpZy9hbWFyb2svc3JjL21ldGFidW5kbGUuaCBhbWFyb2stMS40LjUtc291bmRjaGVj ay9hbWFyb2svc3JjL21ldGFidW5kbGUuaAotLS0gYW1hcm9rLTEuNC41LW9yaWcvYW1hcm9rL3Ny Yy9tZXRhYnVuZGxlLmgJMjAwNy0wMi0wMSAyMDoxNDoxNy4wMDAwMDAwMDAgKzAyMDAKKysrIGFt YXJvay0xLjQuNS1zb3VuZGNoZWNrL2FtYXJvay9zcmMvbWV0YWJ1bmRsZS5oCTIwMDctMDMtMDcg MTc6MDE6MjQuMDAwMDAwMDAwICswMjAwCkBAIC0yNjQsNiArMjY0LDcgQEAgcHVibGljOiAvL2Fj Y2Vzc29ycwogICAgIGludCAgICAgcmF0aW5nKCBib29sIGVuc3VyZUNhY2hlZCA9IGZhbHNlICkg ICAgIGNvbnN0OyAvL3JldHVybnMgcmF0aW5nICogMiwgdG8gYWNjb21tb2RhdGUgLjUgcmF0aW5n cwogICAgIGludCAgICAgcGxheUNvdW50KCBib29sIGVuc3VyZUNhY2hlZCA9IGZhbHNlICkgIGNv bnN0OwogICAgIHVpbnQgICAgbGFzdFBsYXkoIGJvb2wgZW5zdXJlQ2FjaGVkID0gZmFsc2UgKSAg IGNvbnN0OworICAgIGZsb2F0ICAgdHJhY2tSZXBsYXlHYWluKCBmbG9hdCBub1JlcGxheUdhaW4g PSAtOCApICAgY29uc3Q7CiAKICAgICBNb29kYmFyICAgICAgICZtb29kYmFyKCk7CiAgICAgY29u c3QgTW9vZGJhciAmbW9vZGJhcl9jb25zdCgpIGNvbnN0Owo=