140175 2007-01-16 23:43:26 +0000 mishandling of symbolic links [patch] 2022-02-03 03:35:30 +0000 1 1 2 Applications digikam ImageEditor-Save 0.9.1 Gentoo Packages Linux RESOLVED FIXED NOR normal --- 1 pjvenda digikam-bugs-null bacchus bugs.kde.org caulier.gilles jonorland lb.kdebugzilla 4.0.0 20 oldest_to_newest 502053 0 pjvenda 2007-01-16 23:43:26 +0000 Version: 0.9.1-svn (using KDE KDE 3.5.5) Installed from: Gentoo Packages Compiler: gcc (GCC) 4.1.1 (Gentoo 4.1.1-r3) CFLAGS="-march=pentium-m -mtune=pentium-m -mmmx -msse -msse2 -mfpmath=sse,387 -fomit-frame-pointer -funroll-loops -O2 -pipe" OS: Linux I'm creating sub-albums of my main albums where I symlink the files corresponding to my selected pictures to geotag and comment and later to publish on the web. So far it works well: digikam displays the pictures (symlinks) correctly in the sub-album and if I change the picture in the main album, it shows up changed in the sub album. The issue is doing it the other way around: changing pictures in the sub album (changing/adding tags) does a strange thing. The symlink is replaced by the changed file and the source file is replaced by another with the same name and with size 0. Like this: before: pjlv@archon ... $ ls -l 20061231T180626.JPG ../20061231T180626.JPG ... 3569645 Jan  2 01:34 ../20061231T180626.JPG ...      22 Jan 16 12:50 20061231T180626.JPG -> ../20061231T180626.JPG after: pjlv@archon ... $ ls -l 20061231T180626.JPG ../20061231T180626.JPG ...       0 Jan 16 13:13 ../20061231T180626.JPG ... 3569742 Jan 16 13:13 20061231T180626.JPG I understand that this technique may seem a dirty hack to "fool" digikam, but nevertheless, it should handle symlinks like symlinks. How to reproduce: 0. select an album [~/album] 1. create a sub-album (on digikam or on the shell) [~/album/subalbum] 2. symlink an image from the album into sub-album (on the shell) [~/album/subalbum/img001.jpg -> ~/album/subalbum/img001.jpg] 3. navigate into the sub-album folder and change the comment of the linked image file 4. watch the resulting files [~/album/subalbum/img001.jpg (should have 0 bytes), ~/album/subalbum/img001.jpg (shoud no longer be a symlink and is the altered image file)] Expected behaviour: 4. the symlink in ~/album/subalbum/img001.jpg remains a symlink to ~/album/img001.jpg and ~/album/img001.jpg is changed to reflect the new comment tag. 568870 1 bugzilla.kde.org 2008-01-06 23:06:03 +0000 I can confirm this strange behavior for 0.9.3 (KDE 3.5.7 "release 72.4" openSUSE 10.3). 568970 2 arnd.baecker 2008-01-07 07:56:43 +0000 It *might* be that internally the modification is done on a temporary file which is then copied over to the original one (which, in this case, would not be the file to which the symlink goes, but the symlink itself). Using symlinked directories should work ok though. Have you tried using tags to mark the selected pictures for geotagging, commenting publishing? 677525 3 bugs.kde.org 2008-12-08 01:26:35 +0000 I see this behaviour with digikam 0.9.4 in Debian Lenny (from Debian digikam package 2:0.9.4-1). Quite annoying, really, to have the symlink farm wiped out and the original files truncated to 0 bytes too. Probably an associated problem is that digikam doesn't play nicely with hardlinks either. 678473 4 bacchus 2008-12-09 16:11:36 +0000 I confirm this behaviour of symbolic links as well as hard links with digiKam 0.9.4 in Ubuntu 8.10. 681557 5 jonorland 2008-12-15 13:18:24 +0000 I can confirm this bug to on Kubuntu 8.10 with digikam 0.9.4 (0.9.4-1ubuntu1). I think that with the comments on this bug the status and specially severity should change as this can make you loose pictures. I spent several hours comparing and restoring pictures from a backup two different times before I realized that it was a bug related to some of my pictures was symlinked. 937764 6 41806 languitar 2010-03-21 18:01:42 +0000 Created attachment 41806 Let the imag editor follow symlinks This patch lets the image editor follow symlinks for saving images. Could someone please test this, especially on windows because the file name for preserving the windows file permissions now points to the symlink target and I don't know how windows reacts on this. 937772 7 41807 languitar 2010-03-21 18:30:25 +0000 Created attachment 41807 also don't remove symlinks when writing metadata This patch also includes checking symlinks when writing metadata. Nevertheless, the database will not be notified for changes on the source of the symlink. I don't know if there is a good solution to model this. 942627 8 languitar 2010-03-30 22:15:25 +0000 Could someone please review these patches before they cannot be applied to trunk anymore ;) 1026610 9 andi.clemens 2010-10-01 23:30:05 +0000 The patch still applies to trunk :-) Gilles, can you test this on Windows? Andi 1026830 10 caulier.gilles 2010-10-02 15:18:33 +0000 i will check it Gilles 1043849 11 andi.clemens 2010-11-13 12:44:19 +0000 Gilles, I can not test this under Windows or Mac OSX, I will checkout the patch, modify it (if needed) and send the patch to you, so you can try it on these operating systems? 1043863 12 andi.clemens 2010-11-13 13:15:52 +0000 SVN commit 1196422 by aclemens: Check for correct symlink handling. CCBUG: 140175 M +17 -7 kexiv2.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1196422 1043865 13 andi.clemens 2010-11-13 13:16:44 +0000 SVN commit 1196423 by aclemens: Check for correct symlink handling. CCBUG: 140175 M +14 -2 editorwindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1196423 1043866 14 andi.clemens 2010-11-13 13:17:57 +0000 Gilles, I added the patch to libkexiv2 and to digiKam, maybe you can test the other operating sytems now and close the bug if succeeded? 1053726 15 caulier.gilles 2010-12-05 11:30:14 +0000 Under MacOS X, it's sound fine. Symbolic links as like under Linux. Under windows, Symbolic links do not exist. It's replaced by the windows shortcuts concept ? Gilles Caulier 1053728 16 caulier.gilles 2010-12-05 11:35:28 +0000 Under windows windows shortcuts concept is not supported as well by digiKam kioslave. I suspect a problem in KUrl. Typically, if i install digiKam through NSIS installer on a fresh XP computer, digiKam use by default USERS/My Images as root collection. In this folder, there is a shortcuts on common samples images provided by windows. The link to this folder is visible under digiKam, but items are not displayable as thumbs/preview/edit... All operation fail as well, as metadata patch. Gilles Caulier 1095203 17 andi.clemens 2011-03-09 08:15:05 +0000 As far as I know, Windows doesn't have symbolic links, so the described error is ok in this case? I guess we can close this bug if the patch works fine under Mac and Linux. 1139911 18 lb.kdebugzilla 2011-07-09 14:39:13 +0000 SVN commit 1196422 from comment #12 is responsible for bug 275311. I really like that digikam makes an attempt to follow symlinks when editing pictures. However, this is interacting badly with the xmp sidecar code, because digikam is trying to put the sidecar next to the real file (when I think it makes more sense to put it near the symlink). Ideally, I'd like it if digikam tried to put the sidecar next to the symlink, but then checked if the sidecar was already a symlink and follow that before editing it. Also, commit 1196422 has a surprising property. It doesn't walk symlinks all the way down. It only dereferences one. It should probably resolve them farther (but not too far...avoid getting stuck in a loop). 1238252 19 marcel.wiesweg 2012-03-19 20:34:44 +0000 Symlink handling for sidecars has recently been improved, see bug 275311. Please check with current git or coming 2.6 if any issues still exist, I would like to make sidecars work for 2.6. Is any other issue pending for the original, very old, bug report or can we close? 1414104 20 caulier.gilles 2013-11-25 12:47:03 +0000 Following comment #17 from Andi, i close this file now... Gilles Caulier 41806 2010-03-21 18:01:42 +0000 2010-03-21 18:30:25 +0000 Let the imag editor follow symlinks editor-use-symlinks.patch text/plain 1467 languitar SW5kZXg6IHV0aWxpdGllcy9pbWFnZWVkaXRvci9lZGl0b3IvZWRpdG9yd2luZG93LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSB1dGlsaXRpZXMvaW1hZ2VlZGl0b3IvZWRpdG9yL2VkaXRvcndpbmRvdy5jcHAJ KHJldmlzaW9uIDExMDU4ODkpCisrKyB1dGlsaXRpZXMvaW1hZ2VlZGl0b3IvZWRpdG9yL2VkaXRv cndpbmRvdy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5NTIsNyArMTk1MiwxOSBAQAogICAgIHsK ICAgICAgICAga0RlYnVnKCkgPDwgIm1vdmluZyBhIGxvY2FsIGZpbGUiOwogCi0gICAgICAgIFFC eXRlQXJyYXkgZHN0RmlsZU5hbWUgPSBRRmlsZTo6ZW5jb2RlTmFtZShtX3NhdmluZ0NvbnRleHQt PmRlc3RpbmF0aW9uVVJMLnRvTG9jYWxGaWxlKCkpOworICAgICAgICBRU3RyaW5nIGZpbGVOYW1l ID0gbV9zYXZpbmdDb250ZXh0LT5kZXN0aW5hdGlvblVSTC50b0xvY2FsRmlsZSgpOworCisgICAg ICAgIC8vIGNoZWNrIHRoYXQgd2UncmUgbm90IHJlcGxhY2luZyBhIHN5bWxpbmsKKyAgICAgICAg UUZpbGVJbmZvIGluZm8oZmlsZU5hbWUpOworICAgICAgICBpZiAoaW5mby5pc1N5bUxpbmsoKSkK KyAgICAgICAgeworICAgICAgICAgICAgZmlsZU5hbWUgPSBpbmZvLnN5bUxpbmtUYXJnZXQoKTsK KyAgICAgICAgICAgIGtEZWJ1ZygpIDw8ICJUYXJnZXQgZmlsZVBhdGgiIDw8IG1fc2F2aW5nQ29u dGV4dC0+ZGVzdGluYXRpb25VUkwudG9Mb2NhbEZpbGUoKQorICAgICAgICAgICAgICAgICAgICAg PDwgImlzIGEgc3ltbGluayBwb2ludGluZyB0byIKKyAgICAgICAgICAgICAgICAgICAgIDw8IGZp bGVOYW1lIDw8ICIuIFN0b3JpbmcgaW1hZ2UgdGhlcmUuIjsKKyAgICAgICAgfQorCisgICAgICAg IFFCeXRlQXJyYXkgZHN0RmlsZU5hbWUgPSBRRmlsZTo6ZW5jb2RlTmFtZShmaWxlTmFtZSk7CiAj aWZuZGVmIF9XSU4zMgogICAgICAgICAvLyBTdG9yZSBvbGQgcGVybWlzc2lvbnM6CiAgICAgICAg IC8vIEp1c3QgZ2V0IHRoZSBjdXJyZW50IHVtYXNrLgpAQCAtMTk3OSw3ICsxOTkxLDcgQEAKICAg ICAgICAgLy8gS0RFIDQuMy4wCiAgICAgICAgIC8vIEtERTo6cmVuYW1lKCkgdGFrZXMgY2FyZSBv ZiBRU3RyaW5nIC0+IGJ5dGVzdHJpbmcgZW5jb2RpbmcKICAgICAgICAgcmV0ID0gS0RFOjpyZW5h bWUobV9zYXZpbmdDb250ZXh0LT5zYXZlVGVtcEZpbGVOYW1lLAotICAgICAgICAgICAgICAgICAg ICAgICAgICAgbV9zYXZpbmdDb250ZXh0LT5kZXN0aW5hdGlvblVSTC50b0xvY2FsRmlsZSgpKTsK KyAgICAgICAgICAgICAgICAgICAgICAgICAgZmlsZU5hbWUpOwogI2Vsc2UKICAgICAgICAgLy8g S0RFIDQuMi54IG9yIDQuMS54CiAgICAgICAgIHJldCA9IEtERV9yZW5hbWUoUUZpbGU6OmVuY29k ZU5hbWUobV9zYXZpbmdDb250ZXh0LT5zYXZlVGVtcEZpbGVOYW1lKSwK 41807 2010-03-21 18:30:25 +0000 2010-12-05 11:36:06 +0000 also don't remove symlinks when writing metadata digiKam-dont-destroy-symlinks.patch text/plain 2426 languitar SW5kZXg6IGxpYnMvZG1ldGFkYXRhL2RtZXRhZGF0YS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGlicy9k bWV0YWRhdGEvZG1ldGFkYXRhLmNwcAkocmV2aXNpb24gMTEwNTgwMSkKKysrIGxpYnMvZG1ldGFk YXRhL2RtZXRhZGF0YS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDcgQEAKIAogI2lu Y2x1ZGUgPFFEb21Eb2N1bWVudD4KICNpbmNsdWRlIDxRRmlsZT4KKyNpbmNsdWRlIDxRRmlsZUlu Zm8+CiAKIC8vIEtERSBpbmNsdWRlcwogCkBAIC03NSw5ICs3NiwxOCBAQAogICAgIC8vIEluIGZp cnN0LCB3ZSB0cnlpbmcgdG8gZ2V0IG1ldGFkYXRhIHVzaW5nIEV4aXYyLAogICAgIC8vIGVsc2Ug d2Ugd2lsbCB1c2UgZGNyYXcgdG8gZXh0cmFjdCBtaW5pbWFsIGluZm9ybWF0aW9uLgogCi0gICAg aWYgKCFLRXhpdjI6OmxvYWQoZmlsZVBhdGgpKQorICAgIC8vIGVuc3VyZSB0aGF0IHN5bWxpbmtz IGFyZSB1c2VkIGNvcnJlY3RseQorICAgIFFTdHJpbmcgZmlsZU5hbWUgPSBmaWxlUGF0aDsKKyAg ICBRRmlsZUluZm8gaW5mbyhmaWxlTmFtZSk7CisgICAgaWYgKGluZm8uaXNTeW1MaW5rKCkpIHsK KyAgICAgICAga0RlYnVnKCkgPDwgImZpbGVQYXRoIiA8PCBmaWxlUGF0aCA8PCAiaXMgYSBzeW1s aW5rLiIKKyAgICAgICAgICAgICAgICAgPDwgIlVzaW5nIHRhcmdldCIgPDwgaW5mby5zeW1MaW5r VGFyZ2V0KCk7CisgICAgICAgIGZpbGVOYW1lID0gaW5mby5zeW1MaW5rVGFyZ2V0KCk7CisgICAg fQorCisgICAgaWYgKCFLRXhpdjI6OmxvYWQoZmlsZU5hbWUpKQogICAgIHsKLSAgICAgICAgaWYg KCFsb2FkVXNpbmdEY3JhdyhmaWxlUGF0aCkpCisgICAgICAgIGlmICghbG9hZFVzaW5nRGNyYXco ZmlsZU5hbWUpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIApJbmRleDogdXRp bGl0aWVzL2ltYWdlZWRpdG9yL2VkaXRvci9lZGl0b3J3aW5kb3cuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IHV0aWxpdGllcy9pbWFnZWVkaXRvci9lZGl0b3IvZWRpdG9yd2luZG93LmNwcAkocmV2aXNpb24g MTEwNTg4OSkKKysrIHV0aWxpdGllcy9pbWFnZWVkaXRvci9lZGl0b3IvZWRpdG9yd2luZG93LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTk1Miw3ICsxOTUyLDE5IEBACiAgICAgewogICAgICAgICBr RGVidWcoKSA8PCAibW92aW5nIGEgbG9jYWwgZmlsZSI7CiAKLSAgICAgICAgUUJ5dGVBcnJheSBk c3RGaWxlTmFtZSA9IFFGaWxlOjplbmNvZGVOYW1lKG1fc2F2aW5nQ29udGV4dC0+ZGVzdGluYXRp b25VUkwudG9Mb2NhbEZpbGUoKSk7CisgICAgICAgIFFTdHJpbmcgZmlsZU5hbWUgPSBtX3Nhdmlu Z0NvbnRleHQtPmRlc3RpbmF0aW9uVVJMLnRvTG9jYWxGaWxlKCk7CisKKyAgICAgICAgLy8gY2hl Y2sgdGhhdCB3ZSdyZSBub3QgcmVwbGFjaW5nIGEgc3ltbGluaworICAgICAgICBRRmlsZUluZm8g aW5mbyhmaWxlTmFtZSk7CisgICAgICAgIGlmIChpbmZvLmlzU3ltTGluaygpKQorICAgICAgICB7 CisgICAgICAgICAgICBmaWxlTmFtZSA9IGluZm8uc3ltTGlua1RhcmdldCgpOworICAgICAgICAg ICAga0RlYnVnKCkgPDwgIlRhcmdldCBmaWxlUGF0aCIgPDwgbV9zYXZpbmdDb250ZXh0LT5kZXN0 aW5hdGlvblVSTC50b0xvY2FsRmlsZSgpCisgICAgICAgICAgICAgICAgICAgICA8PCAiaXMgYSBz eW1saW5rIHBvaW50aW5nIHRvIgorICAgICAgICAgICAgICAgICAgICAgPDwgZmlsZU5hbWUgPDwg Ii4gU3RvcmluZyBpbWFnZSB0aGVyZS4iOworICAgICAgICB9CisKKyAgICAgICAgUUJ5dGVBcnJh eSBkc3RGaWxlTmFtZSA9IFFGaWxlOjplbmNvZGVOYW1lKGZpbGVOYW1lKTsKICNpZm5kZWYgX1dJ TjMyCiAgICAgICAgIC8vIFN0b3JlIG9sZCBwZXJtaXNzaW9uczoKICAgICAgICAgLy8gSnVzdCBn ZXQgdGhlIGN1cnJlbnQgdW1hc2suCkBAIC0xOTc5LDcgKzE5OTEsNyBAQAogICAgICAgICAvLyBL REUgNC4zLjAKICAgICAgICAgLy8gS0RFOjpyZW5hbWUoKSB0YWtlcyBjYXJlIG9mIFFTdHJpbmcg LT4gYnl0ZXN0cmluZyBlbmNvZGluZwogICAgICAgICByZXQgPSBLREU6OnJlbmFtZShtX3Nhdmlu Z0NvbnRleHQtPnNhdmVUZW1wRmlsZU5hbWUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICBt X3NhdmluZ0NvbnRleHQtPmRlc3RpbmF0aW9uVVJMLnRvTG9jYWxGaWxlKCkpOworICAgICAgICAg ICAgICAgICAgICAgICAgICBmaWxlTmFtZSk7CiAjZWxzZQogICAgICAgICAvLyBLREUgNC4yLngg b3IgNC4xLngKICAgICAgICAgcmV0ID0gS0RFX3JlbmFtZShRRmlsZTo6ZW5jb2RlTmFtZShtX3Nh dmluZ0NvbnRleHQtPnNhdmVUZW1wRmlsZU5hbWUpLAo=