139578 2007-01-04 02:27:09 +0000 Code folding screws up highlighting 2007-05-28 04:03:54 +0000 1 1 2 Applications kate folding unspecified unspecified Linux RESOLVED FIXED NOR normal --- 1 stefl kwrite-bugs-null cyberfish fullofgrace88 redlizard thomas.friedrichsmeier 60 oldest_to_newest 498004 0 stefl 2007-01-04 02:27:10 +0000 Version: unknown (using KDE 3.5.5, Debian Package 4:3.5.5a.dfsg.1-2 (testing/unstable)) Compiler: Target: i486-linux-gnu OS: Linux (i686) release 2.6.14.rldesktop When any code is folded, the highlighting of my php syntax starts to do weird things. Curly braces matching near the cursor fails, and sometimes the cursor disappears altogether (while still being functional). A note of interest is that these problems happen only in parts of the file *after* the folded code. 498361 1 19111 thomas.friedrichsmeier 2007-01-05 15:39:13 +0000 Created attachment 19111 Testcase with instructions Attaching a testcase to show two sorts of wierd behavior after folded regions: Failure to highlight matching curly braces, and failure to clear selection markers. Instructions on reproducing the bugs are enclosed in the testcase. The testcase also contains some observations on when the bugs go away. From a lay-persons perspective, this seems like a problem in updating the view. Perhaps most interestingly, using the scroll-wheel (as described in the testcase) seems to update the view properly. 498362 2 thomas.friedrichsmeier 2007-01-05 15:44:28 +0000 Additional note: The problem(s) is/are not constrained to PHP, but also work with different hightlighting definitions, including at least C, C++, and R Script, suggesting the highlighting definition is definitely not to blame. When using the testcase, of course you will have to set C highlighting, in order to get any code-folding markers at all. 498375 3 dhaumann 2007-01-05 16:55:53 +0000 I can confirm this. It's like that since a long time already :) 500795 4 alanjprescott 2007-01-12 10:44:20 +0000 With PHP and Python - using mouse to highlight a block of text which stays highlighted/selected even when the cursor is clicked elsewhere in the text. Plus if the cursor is clicked somewhere inside the highlighted block then just that one line becomes unhighlighted. Can confirm that this appears to affect only the area after the fold. 505891 5 dhaumann 2007-02-02 09:36:41 +0000 *** Bug 141047 has been marked as a duplicate of this bug. *** 528009 6 20694 redlizard 2007-05-25 10:52:48 +0000 Created attachment 20694 This patch fixes both problems, incorrect brace-matching and not updating the selected lines. 528246 7 dhaumann 2007-05-27 00:31:46 +0000 SVN commit 668607 by dhaumann: fix bug: Code folding screws up highlighting Converting from/to virtual cursors was wrong. Patch by: Ruud Koolen - Thanks a lot! BUG: 139578 M +8 -8 kateview.cpp M +4 -4 kateviewinternal.cpp --- branches/KDE/3.5/kdelibs/kate/part/kateview.cpp #668606:668607 @@ -1521,32 +1521,32 @@ // We have to tag the whole lot if // 1) we have a selection, and: // a) it's new; or - tagLines(selectStart, selectEnd); + tagLines(selectStart, selectEnd, true); } else if (blockSelectionMode() && (oldSelectStart.col() != selectStart.col() || oldSelectEnd.col() != selectEnd.col())) { // b) we're in block selection mode and the columns have changed - tagLines(selectStart, selectEnd); - tagLines(oldSelectStart, oldSelectEnd); + tagLines(selectStart, selectEnd, true); + tagLines(oldSelectStart, oldSelectEnd, true); } else { if (oldSelectStart != selectStart) { if (oldSelectStart < selectStart) - tagLines(oldSelectStart, selectStart); + tagLines(oldSelectStart, selectStart, true); else - tagLines(selectStart, oldSelectStart); + tagLines(selectStart, oldSelectStart, true); } if (oldSelectEnd != selectEnd) { if (oldSelectEnd < selectEnd) - tagLines(oldSelectEnd, selectEnd); + tagLines(oldSelectEnd, selectEnd, true); else - tagLines(selectEnd, oldSelectEnd); + tagLines(selectEnd, oldSelectEnd, true); } } } else { // No more selection, clean up - tagLines(oldSelectStart, oldSelectEnd); + tagLines(oldSelectStart, oldSelectEnd, true); } } --- branches/KDE/3.5/kdelibs/kate/part/kateviewinternal.cpp #668606:668607 @@ -2231,11 +2231,11 @@ // @@ Do this only when cursor near start/end. if( bmStart > bmEnd ) { - tagLines(bmEnd, bmStart, true); + tagLines(bmEnd, bmStart); } else { - tagLines(bmStart, bmEnd, true); + tagLines(bmStart, bmEnd); } } else @@ -2258,11 +2258,11 @@ // @@ Do this only when cursor near start/end. if( bmStart > bmEnd ) { - tagLines(bmEnd, bmStart, true); + tagLines(bmEnd, bmStart); } else { - tagLines(bmStart, bmEnd, true); + tagLines(bmStart, bmEnd); } } else 528435 8 dhaumann 2007-05-28 04:03:54 +0000 *** Bug 137717 has been marked as a duplicate of this bug. *** 19111 2007-01-05 15:39:13 +0000 2007-01-05 15:39:13 +0000 Testcase with instructions folding_wierdness_test.c text/x-csrc 1807 thomas.friedrichsmeier LyogdGVzdCBjYXNlIHRvIHNob3cgd2llZGVybmVzcyByZWxhdGluZyB0byBjb2RlIGZvbGRpbmcK Ckluc3RydWN0aW9uczoKMSkgQ29sbGFwc2UgdGhlIGZvbyAoKSBmdW5jdGlvbgoyKSBJbiB0aGUg YmFyIGZ1bmN0aW9uIHNlbGVjdCB0aGUgY29tbWVudCByZWFkaW5nICJTRUxFQ1QgVEhJUyBDT01N RU5UIiAobGluZXMgMzQtMzgpCiAgIGFuZCBmb2xsb3cgaW5zdHJ1Y3Rpb25zIGdpdmVuIHRoZXJl LCBvYnNlcnZlIHRoZSBiZWhhdmlvcgozKSBOb3cgc2V0IHRoZSBjdXJzb3IgdG8gdGhlIGN1cmx5 IGJyYWNlIG9uIGxpbmUgMzUKCS0gbW9zdCBvZiB0aGUgdGltZSB0aGUgY29ycmVzcG9uZGluZyBi cmFjZSBvbiBsaW5lIDQyIHdpbGwgbm90IGJlIG1hcmtlZCAoYnV0IHRoaXMgaXMgbm90CgkgIDEw MCUgcmVwcm9kdWNpYmxlKQoJLSBpZiB0aGUgYnVnIGRvZXMgbm90IHNob3cgdXAsIHRyeSB1bmZv bGRpbmcgYW5kIHJlZm9sZGluZyBmb28gKCksIHRoZW4gcGxhY2UgdGhlIGN1cnNvciBhZ2FpbgoJ LSB0aGUgY3VybHkgYnJhY2UgcGFpciBvbiBsaW5lcyAzNCBhbmQgNDMgd2lsbCBnZXQgaGlnaGxp Z2h0ZWQgY29ycmVjdGx5CjQpIFJlc2l6ZSB0aGUgd2luZG93IHNvIHlvdSBjYW4gc2Nyb2xsIHNv bWUuIEZvbGxvdyBzdGVwIDIsIGFuZCBvciAzLgo1KSBTY3JvbGwgdXNpbmcgdGhlIHNjb2xsIHdo ZWVsIG9mIHlvdXIgbW91c2UuIEludmFsaWQgc2VsZWN0aW9ucyBnbyBhd2F5LCBtYXJraW5nIHVw IHRoZSBtYXRjaGluZyBjdXJseQogICBicmFjZSB3b3JrcyBhZ2FpbiwgdGVtcG9yYXJpbHkKNikg UmVwZWF0IHN0ZXAgNCwgdGhlbiBzY3JvbGwgdXNpbmcgdGhlIHNjcm9sbCBiYXIuIFRoZSBidWdz IHJlbWFpbiB2aXNpYmxlLgo3KSBVbmZvbGQgZXZlcnl0aGluZywgYW5kIHRyeSBzdGVwcyAyIGFu ZCAzLiBFdmVyeXRoaW5nIHNob3VsZCBiZSBmaW5lIGFnYWluLCBub3cuCjgpIFNpbWlsYXJpbHks IGlmIHlvdSBmb2xkIGZvb2JhciAoKSAoYW5kIG5vdGhpbmcgZWxzZSksIGkuZS4gdGhlIGZvbGRl ZCByZWdpb24gaXMgYWZ0ZXIgdGhlIHJlZ2lvbgogICB5b3UncmUgd29ya2luZyB3aXRoLCBubyBw cm9ibGVtcyBhcHBlYXIsIGVpdGhlci4KCk5vdGUgdGhhdCB0aGVzZSBidWdzIGFsc28gc2hvdyB1 cCBpbiBkaWZmZXJlbnQgZmlsZSB0eXBlcyAvIGhpZ2hsaWdodGluZyBtb2RlcwoqLwoKCnZvaWQg Zm9vICgpIHsKCWlmIChzb21ldGhpbmcpIHsKCQlkb19zb21ldGhpbmcgKCk7Cgl9CgkvKiBtb3Jl ICovCgkvKiBtb3JlICovCgkvKiBtb3JlICovCgkvKiBtb3JlICovCn0KCnZvaWQgYmFyICgpIHsK CWlmIChzb21ldGhpbmcpIHsJCS8qIDwtIHBsYWNlIGN1cnNvciBvbiB0aGlzIGN1cmx5IGJyYWNl ICovCgkJZG9fc29tZXRoaW5nICgpOwoJCWRvX3NvbWV0aGluZ19lbHNlICgpOwoJCS8qIFNFTEVD VCBUSElTIENPTU1FTlQsCgkJdGhlbiBwbGFjZSBjdXJzb3Igc29tZXdoZXJlIGVsc2UgdG8gbWFr ZSB0aGUgc2VsZWN0aW9uIGdvIGF3YXkKCQl0aGUgc2VsZWN0aW9uIHdpbGwgcmVtYWluIGhpZ2hs aWdodGVkIHBhcnRpYWxseQoJCW1vdmluZyB0aGUgY3Vyc29yIHRvIGxpbmVzIHdyb25nbHkgbWFy a2VkLCB3aWxsIG1ha2UgdGhlIHNlbGVjdGlvbiBtYXJrIGRpc2FwcGVhciBhZ2FpbiAqLwoJfQp9 Cgp2b2lkIGZvb2JhciAoKSB7CglpZiAoc29tZXRoaW5nKSB7CgkJZG9fc29tZXRoaW5nICgpOwoJ fQoJLyogbW9yZSAqLwoJLyogbW9yZSAqLwoJLyogbW9yZSAqLwoJLyogbW9yZSAqLwp9CgovKiBt b3JlICovCi8qIG1vcmUgKi8KLyogbW9yZSAqLwovKiBtb3JlICovCg== 20694 2007-05-25 10:52:48 +0000 2007-05-25 10:52:48 +0000 This patch fixes both problems, incorrect brace-matching and not updating the selected lines. bug-139578.patch text/plain 2454 redlizard SW5kZXg6IGthdGUvcGFydC9rYXRldmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2F0ZS9wYXJ0L2th dGV2aWV3LmNwcAkocmV2aXNpb24gNjY4MTQ5KQorKysga2F0ZS9wYXJ0L2thdGV2aWV3LmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTUyMSwzMiArMTUyMSwzMiBAQAogICAgICAgLy8gV2UgaGF2ZSB0 byB0YWcgdGhlIHdob2xlIGxvdCBpZgogICAgICAgLy8gMSkgd2UgaGF2ZSBhIHNlbGVjdGlvbiwg YW5kOgogICAgICAgLy8gIGEpIGl0J3MgbmV3OyBvcgotICAgICAgdGFnTGluZXMoc2VsZWN0U3Rh cnQsIHNlbGVjdEVuZCk7CisgICAgICB0YWdMaW5lcyhzZWxlY3RTdGFydCwgc2VsZWN0RW5kLCB0 cnVlKTsKIAogICAgIH0gZWxzZSBpZiAoYmxvY2tTZWxlY3Rpb25Nb2RlKCkgJiYgKG9sZFNlbGVj dFN0YXJ0LmNvbCgpICE9IHNlbGVjdFN0YXJ0LmNvbCgpIHx8IG9sZFNlbGVjdEVuZC5jb2woKSAh PSBzZWxlY3RFbmQuY29sKCkpKSB7CiAgICAgICAvLyAgYikgd2UncmUgaW4gYmxvY2sgc2VsZWN0 aW9uIG1vZGUgYW5kIHRoZSBjb2x1bW5zIGhhdmUgY2hhbmdlZAotICAgICAgdGFnTGluZXMoc2Vs ZWN0U3RhcnQsIHNlbGVjdEVuZCk7Ci0gICAgICB0YWdMaW5lcyhvbGRTZWxlY3RTdGFydCwgb2xk U2VsZWN0RW5kKTsKKyAgICAgIHRhZ0xpbmVzKHNlbGVjdFN0YXJ0LCBzZWxlY3RFbmQsIHRydWUp OworICAgICAgdGFnTGluZXMob2xkU2VsZWN0U3RhcnQsIG9sZFNlbGVjdEVuZCwgdHJ1ZSk7CiAK ICAgICB9IGVsc2UgewogICAgICAgaWYgKG9sZFNlbGVjdFN0YXJ0ICE9IHNlbGVjdFN0YXJ0KSB7 CiAgICAgICAgIGlmIChvbGRTZWxlY3RTdGFydCA8IHNlbGVjdFN0YXJ0KQotICAgICAgICAgIHRh Z0xpbmVzKG9sZFNlbGVjdFN0YXJ0LCBzZWxlY3RTdGFydCk7CisgICAgICAgICAgdGFnTGluZXMo b2xkU2VsZWN0U3RhcnQsIHNlbGVjdFN0YXJ0LCB0cnVlKTsKICAgICAgICAgZWxzZQotICAgICAg ICAgIHRhZ0xpbmVzKHNlbGVjdFN0YXJ0LCBvbGRTZWxlY3RTdGFydCk7CisgICAgICAgICAgdGFn TGluZXMoc2VsZWN0U3RhcnQsIG9sZFNlbGVjdFN0YXJ0LCB0cnVlKTsKICAgICAgIH0KIAogICAg ICAgaWYgKG9sZFNlbGVjdEVuZCAhPSBzZWxlY3RFbmQpIHsKICAgICAgICAgaWYgKG9sZFNlbGVj dEVuZCA8IHNlbGVjdEVuZCkKLSAgICAgICAgICB0YWdMaW5lcyhvbGRTZWxlY3RFbmQsIHNlbGVj dEVuZCk7CisgICAgICAgICAgdGFnTGluZXMob2xkU2VsZWN0RW5kLCBzZWxlY3RFbmQsIHRydWUp OwogICAgICAgICBlbHNlCi0gICAgICAgICAgdGFnTGluZXMoc2VsZWN0RW5kLCBvbGRTZWxlY3RF bmQpOworICAgICAgICAgIHRhZ0xpbmVzKHNlbGVjdEVuZCwgb2xkU2VsZWN0RW5kLCB0cnVlKTsK ICAgICAgIH0KICAgICB9CiAKICAgfSBlbHNlIHsKICAgICAvLyBObyBtb3JlIHNlbGVjdGlvbiwg Y2xlYW4gdXAKLSAgICB0YWdMaW5lcyhvbGRTZWxlY3RTdGFydCwgb2xkU2VsZWN0RW5kKTsKKyAg ICB0YWdMaW5lcyhvbGRTZWxlY3RTdGFydCwgb2xkU2VsZWN0RW5kLCB0cnVlKTsKICAgfQogfQog CkluZGV4OiBrYXRlL3BhcnQva2F0ZXZpZXdpbnRlcm5hbC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2F0 ZS9wYXJ0L2thdGV2aWV3aW50ZXJuYWwuY3BwCShyZXZpc2lvbiA2NjgxNDkpCisrKyBrYXRlL3Bh cnQva2F0ZXZpZXdpbnRlcm5hbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIyMzEsMTEgKzIyMzEs MTEgQEAKICAgICAgIC8vIEBAIERvIHRoaXMgb25seSB3aGVuIGN1cnNvciBuZWFyIHN0YXJ0L2Vu ZC4KICAgICAgIGlmKCBibVN0YXJ0ID4gYm1FbmQgKQogICAgICAgewotICAgICAgICB0YWdMaW5l cyhibUVuZCwgYm1TdGFydCwgdHJ1ZSk7CisgICAgICAgIHRhZ0xpbmVzKGJtRW5kLCBibVN0YXJ0 KTsKICAgICAgIH0KICAgICAgIGVsc2UKICAgICAgIHsKLSAgICAgICAgdGFnTGluZXMoYm1TdGFy dCwgYm1FbmQsIHRydWUpOworICAgICAgICB0YWdMaW5lcyhibVN0YXJ0LCBibUVuZCk7CiAgICAg ICB9CiAgICAgfQogICAgIGVsc2UKQEAgLTIyNTgsMTEgKzIyNTgsMTEgQEAKICAgICAgIC8vIEBA IERvIHRoaXMgb25seSB3aGVuIGN1cnNvciBuZWFyIHN0YXJ0L2VuZC4KICAgICAgIGlmKCBibVN0 YXJ0ID4gYm1FbmQgKQogICAgICAgewotICAgICAgICB0YWdMaW5lcyhibUVuZCwgYm1TdGFydCwg dHJ1ZSk7CisgICAgICAgIHRhZ0xpbmVzKGJtRW5kLCBibVN0YXJ0KTsKICAgICAgIH0KICAgICAg IGVsc2UKICAgICAgIHsKLSAgICAgICAgdGFnTGluZXMoYm1TdGFydCwgYm1FbmQsIHRydWUpOwor ICAgICAgICB0YWdMaW5lcyhibVN0YXJ0LCBibUVuZCk7CiAgICAgICB9CiAgICAgfQogICAgIGVs c2UK