137119 2006-11-09 20:46:28 +0000 panel in upper right corner doesnt hide correctly anymore 2006-11-17 02:22:46 +0000 1 1 4 Plasma kwin general unspecified unspecified Linux RESOLVED WORKSFORME NOR normal --- 1 mmodem00 kwin-bugs-null 0 oldest_to_newest 485517 0 mmodem00 2006-11-09 20:46:28 +0000 Version: 3.5.5 (using KDE 3.5.5, compiled sources) Compiler: Target: x86_64-mandriva-linux-gnu OS: Linux (x86_64) release 2.6.17-5mdv I have created a panel and set it as tiny in wich i put it in the upper right corner of the screen, and activated the options: "Allow other windows to cover the panel" "Show panel when changing screen" "Raise when mouse cursor reaches Upper Right Corner of the Screen" and all was working fine. Now i have updated kdebase branch_3.5 and this panel isnt working anymore as supposed, since is only hidden when clicking in the titlebar window and not just in the window like used to work. But if a windows isnt active and clicking the window it hides the panel, its only needed to click in the titlebar window when the window is activated and i remember that was never needed to click in a titlebar window (active or not) to hide the panel. So i entered websvn and saw that there where changes in kdebase/kwin/layers.cpp and are these changes that are causing the incorrect hide behaviour of the panel. In kdebase svn release 601090 the panel was working fine, so i created a patch so that some one can commit to put back the panel correct hide behaviour. 485518 1 18483 mmodem00 2006-11-09 20:48:11 +0000 Created attachment 18483 Give correct hode behaviour to panel 487282 2 l.lunak 2006-11-16 17:37:15 +0000 SVN commit 605394 by lunakl: Fix finding the most recently raised window when updating mouse grab for click raise. BUG: 137119 M +1 -1 events.cpp M +3 -0 kcmkwin/kwinoptions/windows.cpp [POSSIBLY UNSAFE: system] M +8 -4 layers.cpp M +1 -1 workspace.h --- branches/KDE/3.5/kdebase/kwin/events.cpp #605393:605394 @@ -1012,7 +1012,7 @@ // is unobscured or if the user doesn't want click raise // (it is unobscured if it the topmost in the unconstrained stacking order, i.e. it is // the most recently raised window) - bool not_obscured = workspace()->topClientOnDesktop( workspace()->currentDesktop(), true ) == this; + bool not_obscured = workspace()->topClientOnDesktop( workspace()->currentDesktop(), true, false ) == this; if( !options->clickRaise || not_obscured ) ungrabButton( None ); else --- branches/KDE/3.5/kdebase/kwin/kcmkwin/kwinoptions/windows.cpp #605393:605394 @@ -46,6 +46,7 @@ #include <kprocess.h> #include <qtabwidget.h> +#include <stdlib.h> #include <X11/X.h> #include <X11/Xlib.h> #include <X11/Xutil.h> @@ -1473,6 +1474,8 @@ movingWindowOpacity->setEnabled(movingWindowTransparency->isChecked()); dockWindowOpacity->setEnabled(dockWindowTransparency->isChecked()); + if( !QFile::exists( QDir::homeDirPath() + "/.xcompmgrrc" )) + system( "/bin/cp /etc/opt/kde3/share/config/xcompmgrrc $HOME/.xcompmgrrc" ); KConfig conf_(QDir::homeDirPath() + "/.xcompmgrrc"); conf_.setGroup("xcompmgr"); --- branches/KDE/3.5/kdebase/kwin/layers.cpp #605393:605394 @@ -194,7 +194,7 @@ doesn't accept focus it's excluded. */ // TODO misleading name for this method -Client* Workspace::topClientOnDesktop( int desktop, bool unconstrained ) const +Client* Workspace::topClientOnDesktop( int desktop, bool unconstrained, bool only_normal ) const { // TODO Q_ASSERT( block_stacking_updates == 0 ); ClientList::ConstIterator begin, end; @@ -212,9 +212,13 @@ it != end; --it ) { - if ( (*it)->isOnDesktop( desktop ) && !(*it)->isSpecialWindow() - && (*it)->isShown( false ) && (*it)->wantsTabFocus()) - return *it; + if( (*it)->isOnDesktop( desktop ) && (*it)->isShown( false )) + { + if( !only_normal ) + return *it; + if( (*it)->wantsTabFocus() && !(*it)->isSpecialWindow()) + return *it; + } } return 0; } --- branches/KDE/3.5/kdebase/kwin/workspace.h #605393:605394 @@ -181,7 +181,7 @@ ClientList ensureStackingOrder( const ClientList& clients ) const; - Client* topClientOnDesktop( int desktop, bool unconstrained = false ) const; + Client* topClientOnDesktop( int desktop, bool unconstrained = false, bool only_normal = true ) const; Client* findDesktop( bool topmost, int desktop ) const; void sendClientToDesktop( Client* c, int desktop, bool dont_activate ); void windowToPreviousDesktop( Client* c ); 487345 3 mmodem00 2006-11-16 23:28:52 +0000 This is not fixed, i do continue having to click in window titlebar to hide panel. The panel is only hidden when is the regular window when that window isnt the active window, when the window is active you still have to click in titlebar, so continues happening preciselly what was happening before. 487388 4 mmodem00 2006-11-17 02:22:46 +0000 its fixed, i did last comments because i forgot to remove the patch that was reverting changes, sorry :) 18483 2006-11-09 20:48:11 +0000 2006-11-09 20:48:11 +0000 Give correct hode behaviour to panel kdebase-3.5.5-revert-mouse-kicker-visibility.patch text/plain 5036 mmodem00 LS0tIG1udC9leHQzL2xpbnV4L3RtcC9zdm4vS0RFL2JyYW5jaF8zLjUva2RlYmFzZS0zLjUuNS9r d2luL2xheWVycy5jcHAJMjAwNi0xMS0wOCAyMzoyMzoxNi4wMDAwMDAwMDAgKzAwMDAKKysrIGtk ZWJhc2UtMy41LjUva3dpbi9sYXllcnMuY3BwCTIwMDYtMDQtMTMgMTM6MDU6NDAuMDAwMDAwMDAw ICswMTAwCkBAIC0xMTcsMTEgKzExNyw3IEBACiAgICAgICAgIH0KICNlbmRpZgogICAgIGlmKCBj aGFuZ2VkIHx8IHByb3BhZ2F0ZV9uZXdfY2xpZW50cyApCi0gICAgICAgIHsKICAgICAgICAgcHJv cGFnYXRlQ2xpZW50cyggcHJvcGFnYXRlX25ld19jbGllbnRzICk7Ci0gICAgICAgIGlmKCBhY3Rp dmVfY2xpZW50ICkKLSAgICAgICAgICAgIGFjdGl2ZV9jbGllbnQtPnVwZGF0ZU1vdXNlR3JhYigp OwotICAgICAgICB9CiAgICAgfQogCiAvKiEKQEAgLTQwOCwyNyArNDA0LDIwIEBACiAgICAgICAg IHJldHVybjsKICAgICAgICAgfQogCisgICAgLy8gcHV0IGluIHRoZSBzdGFja2luZyBvcmRlciBi ZWxvdyBfYWxsXyB3aW5kb3dzIGJlbG9uZ2luZyB0byB0aGUgYWN0aXZlIGFwcGxpY2F0aW9uCiAg ICAgYXNzZXJ0KCB1bmNvbnN0cmFpbmVkX3N0YWNraW5nX29yZGVyLmNvbnRhaW5zKCBhY3RpdmVf Y2xpZW50ICkpOwotICAgIGlmKCBDbGllbnQ6OmJlbG9uZ1RvU2FtZUFwcGxpY2F0aW9uKCBhY3Rp dmVfY2xpZW50LCBjICkpCi0gICAgICAgIHsgLy8gcHV0IGl0IGJlbG93IHRoZSBhY3RpdmUgd2lu ZG93IGlmIGl0J3MgdGhlIHNhbWUgYXBwCi0gICAgICAgIHVuY29uc3RyYWluZWRfc3RhY2tpbmdf b3JkZXIucmVtb3ZlKCBjICk7Ci0gICAgICAgIHVuY29uc3RyYWluZWRfc3RhY2tpbmdfb3JkZXIu aW5zZXJ0KCB1bmNvbnN0cmFpbmVkX3N0YWNraW5nX29yZGVyLmZpbmQoIGFjdGl2ZV9jbGllbnQg KSwgYyApOwotICAgICAgICB9Ci0gICAgZWxzZQotICAgICAgICB7IC8vIHB1dCBpbiB0aGUgc3Rh Y2tpbmcgb3JkZXIgYmVsb3cgX2FsbF8gd2luZG93cyBiZWxvbmdpbmcgdG8gdGhlIGFjdGl2ZSBh cHBsaWNhdGlvbgotICAgICAgICBmb3IoIENsaWVudExpc3Q6Okl0ZXJhdG9yIGl0ID0gdW5jb25z dHJhaW5lZF9zdGFja2luZ19vcmRlci5iZWdpbigpOwotICAgICAgICAgICAgIGl0ICE9IHVuY29u c3RyYWluZWRfc3RhY2tpbmdfb3JkZXIuZW5kKCk7Ci0gICAgICAgICAgICAgKytpdCApCi0gICAg ICAgICAgICB7IC8vIFRPRE8gaWdub3JlIHRvcG1lbnVzPwotICAgICAgICAgICAgaWYoIENsaWVu dDo6YmVsb25nVG9TYW1lQXBwbGljYXRpb24oIGFjdGl2ZV9jbGllbnQsICppdCApKQorICAgIGZv ciggQ2xpZW50TGlzdDo6SXRlcmF0b3IgaXQgPSB1bmNvbnN0cmFpbmVkX3N0YWNraW5nX29yZGVy LmJlZ2luKCk7CisgICAgICAgICBpdCAhPSB1bmNvbnN0cmFpbmVkX3N0YWNraW5nX29yZGVyLmVu ZCgpOworICAgICAgICAgKytpdCApCisgICAgICAgIHsgLy8gVE9ETyBpZ25vcmUgdG9wbWVudXM/ CisgICAgICAgIGlmKCBDbGllbnQ6OmJlbG9uZ1RvU2FtZUFwcGxpY2F0aW9uKCBhY3RpdmVfY2xp ZW50LCAqaXQgKSkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgIGlmKCAqaXQgIT0gYyApCiAg ICAgICAgICAgICAgICAgewotICAgICAgICAgICAgICAgIGlmKCAqaXQgIT0gYyApCi0gICAgICAg ICAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICAgICAgdW5jb25zdHJhaW5lZF9zdGFja2lu Z19vcmRlci5yZW1vdmUoIGMgKTsKLSAgICAgICAgICAgICAgICAgICAgdW5jb25zdHJhaW5lZF9z dGFja2luZ19vcmRlci5pbnNlcnQoIGl0LCBjICk7Ci0gICAgICAgICAgICAgICAgICAgIH0KLSAg ICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAgICB1bmNvbnN0cmFpbmVkX3N0YWNr aW5nX29yZGVyLnJlbW92ZSggYyApOworICAgICAgICAgICAgICAgIHVuY29uc3RyYWluZWRfc3Rh Y2tpbmdfb3JkZXIuaW5zZXJ0KCBpdCwgYyApOwogICAgICAgICAgICAgICAgIH0KKyAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgYXNzZXJ0KCB1bmNvbnN0 cmFpbmVkX3N0YWNraW5nX29yZGVyLmNvbnRhaW5zKCBjICkpOwpAQCAtNDM4LDIzICs0MjcsMTYg QEAKICAgICAgICAgeyAvLyBkbyBmb3IgZXZlcnkgdmlydHVhbCBkZXNrdG9wIHRvIGhhbmRsZSB0 aGUgY2FzZSBvZiBvbmFsbGRlc2t0b3Agd2luZG93cwogICAgICAgICBpZiggYy0+d2FudHNUYWJG b2N1cygpICYmIGMtPmlzT25EZXNrdG9wKCBkZXNrdG9wICkgJiYgZm9jdXNfY2hhaW5bIGRlc2t0 b3AgXS5jb250YWlucyggYWN0aXZlX2NsaWVudCApKQogICAgICAgICAgICAgewotICAgICAgICAg ICAgaWYoIENsaWVudDo6YmVsb25nVG9TYW1lQXBwbGljYXRpb24oIGFjdGl2ZV9jbGllbnQsIGMg KSkKLSAgICAgICAgICAgICAgICB7IC8vIHB1dCBpdCBhZnRlciB0aGUgYWN0aXZlIHdpbmRvdyBp ZiBpdCdzIHRoZSBzYW1lIGFwcAotICAgICAgICAgICAgICAgIGZvY3VzX2NoYWluWyBkZXNrdG9w IF0ucmVtb3ZlKCBjICk7Ci0gICAgICAgICAgICAgICAgZm9jdXNfY2hhaW5bIGRlc2t0b3AgXS5p bnNlcnQoIGZvY3VzX2NoYWluWyBkZXNrdG9wIF0uZmluZCggYWN0aXZlX2NsaWVudCApLCBjICk7 Ci0gICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgIHsg Ly8gcHV0IGl0IGluIGZvY3VzX2NoYWluW2N1cnJlbnREZXNrdG9wKCldIGFmdGVyIGFsbCB3aW5k b3dzIGJlbG9uZ2luZyB0byB0aGUgYWN0aXZlIGFwcGxpY2F0aW9uYQotICAgICAgICAgICAgICAg IGZvY3VzX2NoYWluWyBkZXNrdG9wIF0ucmVtb3ZlKCBjICk7Ci0gICAgICAgICAgICAgICAgZm9y KCBDbGllbnRMaXN0OjpJdGVyYXRvciBpdCA9IGZvY3VzX2NoYWluWyBkZXNrdG9wIF0uZnJvbUxh c3QoKTsKLSAgICAgICAgICAgICAgICAgICAgIGl0ICE9IGZvY3VzX2NoYWluWyBkZXNrdG9wIF0u ZW5kKCk7Ci0gICAgICAgICAgICAgICAgICAgICAtLWl0ICkKLSAgICAgICAgICAJICAgICAgICB7 Ci0gICAgICAgICAgICAgICAgICAgIGlmKCBDbGllbnQ6OmJlbG9uZ1RvU2FtZUFwcGxpY2F0aW9u KCBhY3RpdmVfY2xpZW50LCAqaXQgKSkKLSAgICAgICAgICAgICAgICAgICAgICAgIHsKLSAgICAg ICAgICAgICAgICAgICAgICAgIGZvY3VzX2NoYWluWyBkZXNrdG9wIF0uaW5zZXJ0KCBpdCwgYyAp OwotICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgICAgICAgICAgICAgICAg ICB9CisgICAgICAgICAgICAvLyBhbHNvIHB1dCBpbiBmb2N1c19jaGFpbltjdXJyZW50RGVza3Rv cCgpXSBhZnRlciBhbGwgd2luZG93cyBiZWxvbmdpbmcgdG8gdGhlIGFjdGl2ZSBhcHBsaWNhdGlv bmEKKyAgICAgICAgICAgIGZvY3VzX2NoYWluWyBkZXNrdG9wIF0ucmVtb3ZlKCBjICk7CisgICAg ICAgICAgICBmb3IoIENsaWVudExpc3Q6Okl0ZXJhdG9yIGl0ID0gZm9jdXNfY2hhaW5bIGRlc2t0 b3AgXS5mcm9tTGFzdCgpOworICAgICAgICAgICAgICAgICBpdCAhPSBmb2N1c19jaGFpblsgZGVz a3RvcCBdLmVuZCgpOworICAgICAgICAgICAgICAgICAtLWl0ICkKKyAgICAgIAkgICAgICAgIHsK KyAgICAgICAgICAgICAgICBpZiggQ2xpZW50OjpiZWxvbmdUb1NhbWVBcHBsaWNhdGlvbiggYWN0 aXZlX2NsaWVudCwgKml0ICkpCisgICAgICAgICAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAg ICAgICAgZm9jdXNfY2hhaW5bIGRlc2t0b3AgXS5pbnNlcnQoIGl0LCBjICk7CisgICAgICAgICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgfQpAQCAtNDYyLDIzICs0NDQsMTUgQEAKICAgICAvLyB0aGUgc2FtZSBm b3IgZ2xvYmFsX2ZvY3VzX2NoYWluCiAgICAgaWYoIGMtPndhbnRzVGFiRm9jdXMoKSAmJiBnbG9i YWxfZm9jdXNfY2hhaW4uY29udGFpbnMoIGFjdGl2ZV9jbGllbnQgKSkKICAgICAgICAgewotICAg ICAgICBpZiggQ2xpZW50OjpiZWxvbmdUb1NhbWVBcHBsaWNhdGlvbiggYWN0aXZlX2NsaWVudCwg YyApKQotICAgICAgICAgICAgewotICAgICAgICAgICAgZ2xvYmFsX2ZvY3VzX2NoYWluLnJlbW92 ZSggYyApOwotICAgICAgICAgICAgZ2xvYmFsX2ZvY3VzX2NoYWluLmluc2VydCggZ2xvYmFsX2Zv Y3VzX2NoYWluLmZpbmQoIGFjdGl2ZV9jbGllbnQgKSwgYyApOwotICAgICAgICAgICAgfQotICAg ICAgICBlbHNlCisgICAgICAgIGdsb2JhbF9mb2N1c19jaGFpbi5yZW1vdmUoIGMgKTsKKyAgICAg ICAgZm9yKCBDbGllbnRMaXN0OjpJdGVyYXRvciBpdCA9IGdsb2JhbF9mb2N1c19jaGFpbi5mcm9t TGFzdCgpOworICAgICAgICAgICAgIGl0ICE9IGdsb2JhbF9mb2N1c19jaGFpbi5lbmQoKTsKKyAg ICAgICAgICAgICAtLWl0ICkKICAgICAgICAgICAgIHsKLSAgICAgICAgICAgIGdsb2JhbF9mb2N1 c19jaGFpbi5yZW1vdmUoIGMgKTsKLSAgICAgICAgICAgIGZvciggQ2xpZW50TGlzdDo6SXRlcmF0 b3IgaXQgPSBnbG9iYWxfZm9jdXNfY2hhaW4uZnJvbUxhc3QoKTsKLSAgICAgICAgICAgICAgICAg aXQgIT0gZ2xvYmFsX2ZvY3VzX2NoYWluLmVuZCgpOwotICAgICAgICAgICAgICAgICAtLWl0ICkK KyAgICAgICAgICAgIGlmKCBDbGllbnQ6OmJlbG9uZ1RvU2FtZUFwcGxpY2F0aW9uKCBhY3RpdmVf Y2xpZW50LCAqaXQgKSkKICAgICAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgaWYoIENs aWVudDo6YmVsb25nVG9TYW1lQXBwbGljYXRpb24oIGFjdGl2ZV9jbGllbnQsICppdCApKQotICAg ICAgICAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgICAgIGdsb2JhbF9mb2N1c19jaGFp bi5pbnNlcnQoIGl0LCBjICk7Ci0gICAgICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAg ICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgZ2xvYmFsX2ZvY3VzX2NoYWluLmluc2VydCgg aXQsIGMgKTsKKyAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICB9CiAgICAg ICAgICAgICB9CiAgICAgICAJfQo=