<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>136876</bug_id>
          
          <creation_ts>2006-11-05 10:47:27 +0000</creation_ts>
          <short_desc>Symlinks in trash should show symlink size, not file size.</short_desc>
          <delta_ts>2006-11-06 12:12:30 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>10</classification_id>
          <classification>Unmaintained</classification>
          <product>kio</product>
          <component>trash</component>
          <version>unspecified</version>
          <rep_platform>Gentoo Packages</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Viesturs Zarins">viesturs.zarins</reporter>
          <assigned_to name="David Faure">faure</assigned_to>
          
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>484050</commentid>
    <comment_count>0</comment_count>
    <who name="Viesturs Zarins">viesturs.zarins</who>
    <bug_when>2006-11-05 10:47:27 +0000</bug_when>
    <thetext>Version:            (using KDE KDE 3.5.5)
Installed from:    Gentoo Packages

If i create a symlink of a large file and delete it later, the size of a symlink in trash is the size of the file the symlink links to.

I would expect the file sizes in trash to show how much space my trash takes up.

The correct behavior would be to show the symlink size which usually is about hundread bytes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>484580</commentid>
    <comment_count>1</comment_count>
    <who name="David Faure">faure</who>
    <bug_when>2006-11-06 12:12:25 +0000</bug_when>
    <thetext>SVN commit 602619 by dfaure:

[Bug 136876] Symlinks in trash should show symlink size, not file size.
BUG: 136876


 M  +4 -0      kio_trash.cpp  


--- branches/KDE/3.5/kdebase/kioslave/trash/kio_trash.cpp #602618:602619
@@ -407,6 +407,9 @@
 
         addAtom( entry, KIO::UDS_LINK_DEST, 0, QFile::decodeName( buffer2 ) );
         // Follow symlink
+        // That makes sense in kio_file, but not in the trash, especially for the size
+        // #136876
+#if 0
         if ( KDE_stat( physicalPath_c, &amp;buff ) == -1 ) {
             // It is a link pointing to nowhere
             buff.st_mode = S_IFLNK | S_IRWXU | S_IRWXG | S_IRWXO;
@@ -414,6 +417,7 @@
             buff.st_atime = 0;
             buff.st_size = 0;
         }
+#endif
     }
     mode_t type = buff.st_mode &amp; S_IFMT; // extract file type
     mode_t access = buff.st_mode &amp; 07777; // extract permissions
</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>